Re: Review Request 125662: mangonel: Initial port to Qt5/KF5
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125662/#review87736 --- Ship it! Ship It! - Martin Tobias Holmedahl Sandsmark On Oct. 16, 2015, 4:04 p.m., Jeremy Whiting wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/125662/ > --- > > (Updated Oct. 16, 2015, 4:04 p.m.) > > > Review request for Plasma and Martin Tobias Holmedahl Sandsmark. > > > Repository: mangonel > > > Description > --- > > Port of Mangonel to Qt5/KF5 > > > Diffs > - > > CMakeLists.txt fec95da > Label.cpp 136f70b > Mangonel.h 9c8a32f > Mangonel.cpp 63e10ab > main.cpp 1b0c4a3 > providers/Applications.cpp 7674a97 > providers/Paths.cpp 713aba3 > > Diff: https://git.reviewboard.kde.org/r/125662/diff/ > > > Testing > --- > > It builds and runs, but looks a bit strange since it's a plani QWidget. > (Maybe we could say it's using Material design and call it good, dunno :p) > > > File Attachments > > > screenshot > > https://git.reviewboard.kde.org/media/uploaded/files/2015/10/16/2f8f36d8-dea2-4679-8826-96ebbaa8c8e9__mangonel.png > > > Thanks, > > Jeremy Whiting > > ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 125662: mangonel: Initial port to Qt5/KF5
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125662/ --- (Updated Oct. 30, 2015, 5:53 a.m.) Status -- This change has been marked as submitted. Review request for Plasma and Martin Tobias Holmedahl Sandsmark. Repository: mangonel Description --- Port of Mangonel to Qt5/KF5 Diffs - CMakeLists.txt fec95da Label.cpp 136f70b Mangonel.h 9c8a32f Mangonel.cpp 63e10ab main.cpp 1b0c4a3 providers/Applications.cpp 7674a97 providers/Paths.cpp 713aba3 Diff: https://git.reviewboard.kde.org/r/125662/diff/ Testing --- It builds and runs, but looks a bit strange since it's a plani QWidget. (Maybe we could say it's using Material design and call it good, dunno :p) File Attachments screenshot https://git.reviewboard.kde.org/media/uploaded/files/2015/10/16/2f8f36d8-dea2-4679-8826-96ebbaa8c8e9__mangonel.png Thanks, Jeremy Whiting ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Review Request 125662: mangonel: Initial port to Qt5/KF5
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125662/ --- Review request for Plasma and Martin Tobias Holmedahl Sandsmark. Repository: mangonel Description --- Port of Mangonel to Qt5/KF5 Diffs - CMakeLists.txt fec95da Label.cpp 136f70b Mangonel.h 9c8a32f Mangonel.cpp 63e10ab main.cpp 1b0c4a3 providers/Applications.cpp 7674a97 providers/Paths.cpp 713aba3 Diff: https://git.reviewboard.kde.org/r/125662/diff/ Testing --- It builds and runs, but looks a bit strange since it's a plani QWidget. (Maybe we could say it's using Material design and call it good, dunno :p) Thanks, Jeremy Whiting ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 125662: mangonel: Initial port to Qt5/KF5
> On Oct. 16, 2015, 9:58 a.m., Martin Klapetek wrote: > > Screenshots? ;) Ok, added a screenshot with breeze dark theme, The colors look ok, but I guess Plasma::Dialog may have done some rounded corners or something iirc to make it look a bit better or added transparency or something. - Jeremy --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125662/#review86929 --- On Oct. 16, 2015, 9:42 a.m., Jeremy Whiting wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/125662/ > --- > > (Updated Oct. 16, 2015, 9:42 a.m.) > > > Review request for Plasma and Martin Tobias Holmedahl Sandsmark. > > > Repository: mangonel > > > Description > --- > > Port of Mangonel to Qt5/KF5 > > > Diffs > - > > CMakeLists.txt fec95da > Label.cpp 136f70b > Mangonel.h 9c8a32f > Mangonel.cpp 63e10ab > main.cpp 1b0c4a3 > providers/Applications.cpp 7674a97 > providers/Paths.cpp 713aba3 > > Diff: https://git.reviewboard.kde.org/r/125662/diff/ > > > Testing > --- > > It builds and runs, but looks a bit strange since it's a plani QWidget. > (Maybe we could say it's using Material design and call it good, dunno :p) > > > Thanks, > > Jeremy Whiting > > ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 125662: mangonel: Initial port to Qt5/KF5
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125662/ --- (Updated Oct. 16, 2015, 10:04 a.m.) Review request for Plasma and Martin Tobias Holmedahl Sandsmark. Repository: mangonel Description --- Port of Mangonel to Qt5/KF5 Diffs - CMakeLists.txt fec95da Label.cpp 136f70b Mangonel.h 9c8a32f Mangonel.cpp 63e10ab main.cpp 1b0c4a3 providers/Applications.cpp 7674a97 providers/Paths.cpp 713aba3 Diff: https://git.reviewboard.kde.org/r/125662/diff/ Testing --- It builds and runs, but looks a bit strange since it's a plani QWidget. (Maybe we could say it's using Material design and call it good, dunno :p) File Attachments (updated) screenshot https://git.reviewboard.kde.org/media/uploaded/files/2015/10/16/2f8f36d8-dea2-4679-8826-96ebbaa8c8e9__mangonel.png Thanks, Jeremy Whiting ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 125662: mangonel: Initial port to Qt5/KF5
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125662/#review86929 --- Screenshots? ;) - Martin Klapetek On Oct. 16, 2015, 5:42 p.m., Jeremy Whiting wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/125662/ > --- > > (Updated Oct. 16, 2015, 5:42 p.m.) > > > Review request for Plasma and Martin Tobias Holmedahl Sandsmark. > > > Repository: mangonel > > > Description > --- > > Port of Mangonel to Qt5/KF5 > > > Diffs > - > > CMakeLists.txt fec95da > Label.cpp 136f70b > Mangonel.h 9c8a32f > Mangonel.cpp 63e10ab > main.cpp 1b0c4a3 > providers/Applications.cpp 7674a97 > providers/Paths.cpp 713aba3 > > Diff: https://git.reviewboard.kde.org/r/125662/diff/ > > > Testing > --- > > It builds and runs, but looks a bit strange since it's a plani QWidget. > (Maybe we could say it's using Material design and call it good, dunno :p) > > > Thanks, > > Jeremy Whiting > > ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
