Re: Review Request 125811: detect gtk engine

[Jonathan Riddell]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125811/
---

(Updated Nov. 4, 2015, 10:29 a.m.)


Status
--

This change has been marked as submitted.


Review request for Plasma and David Edmundson.


Changes
---

Submitted with commit d4ab63518e150663f5fb13ee0eba30a00ddf0acf by Jonathan 
Riddell to branch master.


Repository: breeze-gtk


Description
---

first attempt at detecting gtk 2 pixmap engine as runtime dependency

but it doesn't work if you set cmake path to different from gtk engine

and I don't know if it works on distros that use /usr/lib64/ rather than 
/usr/lib/x86_86-linux-gnu


Diffs
-

  CMakeLists.txt 9d7b7a7 
  cmake/FindGTKEngine.cmake PRE-CREATION 

Diff: https://git.reviewboard.kde.org/r/125811/diff/


Testing
---

works for me unless I install outwith /usr/


Thanks,

Jonathan Riddell

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 125811: detect gtk engine

[Hrvoje Senjan]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125811/#review87948
---



cmake/FindGTKEngine.cmake (line 17)


KDE_INSTALL_FULL_LIBDIR rather?


- Hrvoje Senjan


On Oct. 27, 2015, 10:22 a.m., Jonathan Riddell wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/125811/
> ---
> 
> (Updated Oct. 27, 2015, 10:22 a.m.)
> 
> 
> Review request for Plasma and David Edmundson.
> 
> 
> Repository: breeze-gtk
> 
> 
> Description
> ---
> 
> first attempt at detecting gtk 2 pixmap engine as runtime dependency
> 
> but it doesn't work if you set cmake path to different from gtk engine
> 
> and I don't know if it works on distros that use /usr/lib64/ rather than 
> /usr/lib/x86_86-linux-gnu
> 
> 
> Diffs
> -
> 
>   CMakeLists.txt 9d7b7a7 
>   cmake/FindGTKEngine.cmake PRE-CREATION 
> 
> Diff: https://git.reviewboard.kde.org/r/125811/diff/
> 
> 
> Testing
> ---
> 
> works for me unless I install outwith /usr/
> 
> 
> Thanks,
> 
> Jonathan Riddell
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 125811: detect gtk engine

[Alex Merry]

> On Nov. 3, 2015, 5:38 p.m., Hrvoje Senjan wrote:
> > cmake/FindGTKEngine.cmake, line 17
> > 
> >
> > KDE_INSTALL_FULL_LIBDIR rather?

Yes, that one, please. Otherwise bad things will happen if anyone specifies an 
absolute libdir on the command line.


- Alex


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125811/#review87948
---


On Oct. 27, 2015, 9:22 a.m., Jonathan Riddell wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/125811/
> ---
> 
> (Updated Oct. 27, 2015, 9:22 a.m.)
> 
> 
> Review request for Plasma and David Edmundson.
> 
> 
> Repository: breeze-gtk
> 
> 
> Description
> ---
> 
> first attempt at detecting gtk 2 pixmap engine as runtime dependency
> 
> but it doesn't work if you set cmake path to different from gtk engine
> 
> and I don't know if it works on distros that use /usr/lib64/ rather than 
> /usr/lib/x86_86-linux-gnu
> 
> 
> Diffs
> -
> 
>   CMakeLists.txt 9d7b7a7 
>   cmake/FindGTKEngine.cmake PRE-CREATION 
> 
> Diff: https://git.reviewboard.kde.org/r/125811/diff/
> 
> 
> Testing
> ---
> 
> works for me unless I install outwith /usr/
> 
> 
> Thanks,
> 
> Jonathan Riddell
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 125811: detect gtk engine

[David Edmundson]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125811/#review87945
---

Ship it!


Ship It!

- David Edmundson


On Oct. 27, 2015, 9:22 a.m., Jonathan Riddell wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/125811/
> ---
> 
> (Updated Oct. 27, 2015, 9:22 a.m.)
> 
> 
> Review request for Plasma and David Edmundson.
> 
> 
> Repository: breeze-gtk
> 
> 
> Description
> ---
> 
> first attempt at detecting gtk 2 pixmap engine as runtime dependency
> 
> but it doesn't work if you set cmake path to different from gtk engine
> 
> and I don't know if it works on distros that use /usr/lib64/ rather than 
> /usr/lib/x86_86-linux-gnu
> 
> 
> Diffs
> -
> 
>   CMakeLists.txt 9d7b7a7 
>   cmake/FindGTKEngine.cmake PRE-CREATION 
> 
> Diff: https://git.reviewboard.kde.org/r/125811/diff/
> 
> 
> Testing
> ---
> 
> works for me unless I install outwith /usr/
> 
> 
> Thanks,
> 
> Jonathan Riddell
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 125811: detect gtk engine

[Jonathan Riddell]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125811/
---

(Updated Oct. 27, 2015, 9:22 a.m.)


Review request for Plasma and David Edmundson.


Changes
---

using _ver and merged with master


Repository: breeze-gtk


Description
---

first attempt at detecting gtk 2 pixmap engine as runtime dependency

but it doesn't work if you set cmake path to different from gtk engine

and I don't know if it works on distros that use /usr/lib64/ rather than 
/usr/lib/x86_86-linux-gnu


Diffs (updated)
-

  CMakeLists.txt 9d7b7a7 
  cmake/FindGTKEngine.cmake PRE-CREATION 

Diff: https://git.reviewboard.kde.org/r/125811/diff/


Testing
---

works for me unless I install outwith /usr/


Thanks,

Jonathan Riddell

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 125811: detect gtk engine

[David Edmundson]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125811/#review87493
---



cmake/FindGTKEngine.cmake (line 17)


what if I have 2.10.1 installed?


- David Edmundson


On Oct. 27, 2015, 9:22 a.m., Jonathan Riddell wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/125811/
> ---
> 
> (Updated Oct. 27, 2015, 9:22 a.m.)
> 
> 
> Review request for Plasma and David Edmundson.
> 
> 
> Repository: breeze-gtk
> 
> 
> Description
> ---
> 
> first attempt at detecting gtk 2 pixmap engine as runtime dependency
> 
> but it doesn't work if you set cmake path to different from gtk engine
> 
> and I don't know if it works on distros that use /usr/lib64/ rather than 
> /usr/lib/x86_86-linux-gnu
> 
> 
> Diffs
> -
> 
>   CMakeLists.txt 9d7b7a7 
>   cmake/FindGTKEngine.cmake PRE-CREATION 
> 
> Diff: https://git.reviewboard.kde.org/r/125811/diff/
> 
> 
> Testing
> ---
> 
> works for me unless I install outwith /usr/
> 
> 
> Thanks,
> 
> Jonathan Riddell
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 125811: detect gtk engine

[David Edmundson]

> On Oct. 27, 2015, 9:26 a.m., David Edmundson wrote:
> > cmake/FindGTKEngine.cmake, line 17
> > 
> >
> > what if I have 2.10.1 installed?
> 
> Jonathan Riddell wrote:
> No such bugfix ABI bumper were made and now GTK 3 is the development 
> focus so I don't think they will be made.

that raises a good question - why are we checking for the GTK2 engine, but not 
the GTK 3 one?


- David


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125811/#review87493
---


On Oct. 27, 2015, 9:22 a.m., Jonathan Riddell wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/125811/
> ---
> 
> (Updated Oct. 27, 2015, 9:22 a.m.)
> 
> 
> Review request for Plasma and David Edmundson.
> 
> 
> Repository: breeze-gtk
> 
> 
> Description
> ---
> 
> first attempt at detecting gtk 2 pixmap engine as runtime dependency
> 
> but it doesn't work if you set cmake path to different from gtk engine
> 
> and I don't know if it works on distros that use /usr/lib64/ rather than 
> /usr/lib/x86_86-linux-gnu
> 
> 
> Diffs
> -
> 
>   CMakeLists.txt 9d7b7a7 
>   cmake/FindGTKEngine.cmake PRE-CREATION 
> 
> Diff: https://git.reviewboard.kde.org/r/125811/diff/
> 
> 
> Testing
> ---
> 
> works for me unless I install outwith /usr/
> 
> 
> Thanks,
> 
> Jonathan Riddell
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 125811: detect gtk engine

[Jonathan Riddell]

> On Oct. 27, 2015, 9:26 a.m., David Edmundson wrote:
> > cmake/FindGTKEngine.cmake, line 17
> > 
> >
> > what if I have 2.10.1 installed?

No such bugfix ABI bumper were made and now GTK 3 is the development focus so I 
don't think they will be made.


- Jonathan


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125811/#review87493
---


On Oct. 27, 2015, 9:22 a.m., Jonathan Riddell wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/125811/
> ---
> 
> (Updated Oct. 27, 2015, 9:22 a.m.)
> 
> 
> Review request for Plasma and David Edmundson.
> 
> 
> Repository: breeze-gtk
> 
> 
> Description
> ---
> 
> first attempt at detecting gtk 2 pixmap engine as runtime dependency
> 
> but it doesn't work if you set cmake path to different from gtk engine
> 
> and I don't know if it works on distros that use /usr/lib64/ rather than 
> /usr/lib/x86_86-linux-gnu
> 
> 
> Diffs
> -
> 
>   CMakeLists.txt 9d7b7a7 
>   cmake/FindGTKEngine.cmake PRE-CREATION 
> 
> Diff: https://git.reviewboard.kde.org/r/125811/diff/
> 
> 
> Testing
> ---
> 
> works for me unless I install outwith /usr/
> 
> 
> Thanks,
> 
> Jonathan Riddell
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 125811: detect gtk engine

[Jonathan Riddell]

> On Oct. 27, 2015, 9:26 a.m., David Edmundson wrote:
> > cmake/FindGTKEngine.cmake, line 17
> > 
> >
> > what if I have 2.10.1 installed?
> 
> Jonathan Riddell wrote:
> No such bugfix ABI bumper were made and now GTK 3 is the development 
> focus so I don't think they will be made.
> 
> David Edmundson wrote:
> that raises a good question - why are we checking for the GTK2 engine, 
> but not the GTK 3 one?

The GTK 2 breeze theme requires with pixbuf/pixmap engine from GTK 2.  The GTK 
3 theme uses another method which as far as I can tell doesn't require a 
potentially separate package to be installed.


- Jonathan


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125811/#review87493
---


On Oct. 27, 2015, 9:22 a.m., Jonathan Riddell wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/125811/
> ---
> 
> (Updated Oct. 27, 2015, 9:22 a.m.)
> 
> 
> Review request for Plasma and David Edmundson.
> 
> 
> Repository: breeze-gtk
> 
> 
> Description
> ---
> 
> first attempt at detecting gtk 2 pixmap engine as runtime dependency
> 
> but it doesn't work if you set cmake path to different from gtk engine
> 
> and I don't know if it works on distros that use /usr/lib64/ rather than 
> /usr/lib/x86_86-linux-gnu
> 
> 
> Diffs
> -
> 
>   CMakeLists.txt 9d7b7a7 
>   cmake/FindGTKEngine.cmake PRE-CREATION 
> 
> Diff: https://git.reviewboard.kde.org/r/125811/diff/
> 
> 
> Testing
> ---
> 
> works for me unless I install outwith /usr/
> 
> 
> Thanks,
> 
> Jonathan Riddell
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Review Request 125811: detect gtk engine

[Jonathan Riddell]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125811/
---

Review request for Plasma and David Edmundson.


Repository: breeze-gtk


Description
---

first attempt at detecting gtk 2 pixmap engine as runtime dependency

but it doesn't work if you set cmake path to different from gtk engine

and I don't know if it works on distros that use /usr/lib64/ rather than 
/usr/lib/x86_86-linux-gnu


Diffs
-

  CMakeLists.txt b977da8 
  cmake/FindGTKEngine.cmake PRE-CREATION 
  cmake/FindGTKEngine.cmake~ PRE-CREATION 
  cmake/GTKEngineConfig.cmake PRE-CREATION 

Diff: https://git.reviewboard.kde.org/r/125811/diff/


Testing
---

works for me unless I install outwith /usr/


Thanks,

Jonathan Riddell

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 125811: detect gtk engine

[David Edmundson]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125811/#review87436
---



CMakeLists.txt (line 14)


remove



cmake/FindGTKEngine.cmake (line 9)


what if the GTK version isn't 2.10?



cmake/FindGTKEngine.cmake~ (line 1)


git rm this file



cmake/GTKEngineConfig.cmake (line 3)


that's not distro agnostic

I think there's a cmake var for libpath


- David Edmundson


On Oct. 26, 2015, 4:43 p.m., Jonathan Riddell wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/125811/
> ---
> 
> (Updated Oct. 26, 2015, 4:43 p.m.)
> 
> 
> Review request for Plasma and David Edmundson.
> 
> 
> Repository: breeze-gtk
> 
> 
> Description
> ---
> 
> first attempt at detecting gtk 2 pixmap engine as runtime dependency
> 
> but it doesn't work if you set cmake path to different from gtk engine
> 
> and I don't know if it works on distros that use /usr/lib64/ rather than 
> /usr/lib/x86_86-linux-gnu
> 
> 
> Diffs
> -
> 
>   CMakeLists.txt b977da8 
>   cmake/FindGTKEngine.cmake PRE-CREATION 
>   cmake/FindGTKEngine.cmake~ PRE-CREATION 
>   cmake/GTKEngineConfig.cmake PRE-CREATION 
> 
> Diff: https://git.reviewboard.kde.org/r/125811/diff/
> 
> 
> Testing
> ---
> 
> works for me unless I install outwith /usr/
> 
> 
> Thanks,
> 
> Jonathan Riddell
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel