Re: Review Request 126061: [Menu] Popup above parent if would exceed screen boundaries

[Kai Uwe Broulik]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126061/
---

(Updated Aug. 29, 2017, 8:57 nachm.)


Status
--

This change has been discarded.


Review request for Plasma.


Repository: plasma-framework


Description
---

QMenu is smart enough not to position itself outside the screen, however this 
can mean that the button the Menu originated from, could be covered. This can 
be observed with Widget Explorer's "get more widgets" buttons.


Diffs
-

  src/declarativeimports/plasmacomponents/qmenu.cpp d84f481 

Diff: https://git.reviewboard.kde.org/r/126061/diff/


Testing
---

Ran the menu.qml test and moved the window around, positioning seemed sane. 
Also Widget Explorer more menu now pops up to the top.

I subtract the Y from the position to not break the most common usecase of 
popup(0, height) to have the menu pop up below the button. Now it pops up above 
it, still glued to it as it should be.


Thanks,

Kai Uwe Broulik

Re: Review Request 126061: [Menu] Popup above parent if would exceed screen boundaries

[Albert Astals Cid]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126061/#review102365
---



Patch does not apply to git master anymore

- Albert Astals Cid


On Nov. 14, 2015, 12:11 p.m., Kai Uwe Broulik wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/126061/
> ---
> 
> (Updated Nov. 14, 2015, 12:11 p.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Repository: plasma-framework
> 
> 
> Description
> ---
> 
> QMenu is smart enough not to position itself outside the screen, however this 
> can mean that the button the Menu originated from, could be covered. This can 
> be observed with Widget Explorer's "get more widgets" buttons.
> 
> 
> Diffs
> -
> 
>   src/declarativeimports/plasmacomponents/qmenu.cpp d84f481 
> 
> Diff: https://git.reviewboard.kde.org/r/126061/diff/
> 
> 
> Testing
> ---
> 
> Ran the menu.qml test and moved the window around, positioning seemed sane. 
> Also Widget Explorer more menu now pops up to the top.
> 
> I subtract the Y from the position to not break the most common usecase of 
> popup(0, height) to have the menu pop up below the button. Now it pops up 
> above it, still glued to it as it should be.
> 
> 
> Thanks,
> 
> Kai Uwe Broulik
> 
>

Re: Review Request 126061: [Menu] Popup above parent if would exceed screen boundaries

[Sebastian Kügler]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126061/#review88808
---


pingeling, status of this? :)

- Sebastian Kügler


On Nov. 14, 2015, 12:11 p.m., Kai Uwe Broulik wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/126061/
> ---
> 
> (Updated Nov. 14, 2015, 12:11 p.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Repository: plasma-framework
> 
> 
> Description
> ---
> 
> QMenu is smart enough not to position itself outside the screen, however this 
> can mean that the button the Menu originated from, could be covered. This can 
> be observed with Widget Explorer's "get more widgets" buttons.
> 
> 
> Diffs
> -
> 
>   src/declarativeimports/plasmacomponents/qmenu.cpp d84f481 
> 
> Diff: https://git.reviewboard.kde.org/r/126061/diff/
> 
> 
> Testing
> ---
> 
> Ran the menu.qml test and moved the window around, positioning seemed sane. 
> Also Widget Explorer more menu now pops up to the top.
> 
> I subtract the Y from the position to not break the most common usecase of 
> popup(0, height) to have the menu pop up below the button. Now it pops up 
> above it, still glued to it as it should be.
> 
> 
> Thanks,
> 
> Kai Uwe Broulik
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 126061: [Menu] Popup above parent if would exceed screen boundaries

[Marco Martin]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126061/#review88414
---

Ship it!



src/declarativeimports/plasmacomponents/qmenu.cpp (line 223)


maybe instead a qMin(screen height - menu height, pos.y()) ?


- Marco Martin


On Nov. 14, 2015, 12:11 p.m., Kai Uwe Broulik wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/126061/
> ---
> 
> (Updated Nov. 14, 2015, 12:11 p.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Repository: plasma-framework
> 
> 
> Description
> ---
> 
> QMenu is smart enough not to position itself outside the screen, however this 
> can mean that the button the Menu originated from, could be covered. This can 
> be observed with Widget Explorer's "get more widgets" buttons.
> 
> 
> Diffs
> -
> 
>   src/declarativeimports/plasmacomponents/qmenu.cpp d84f481 
> 
> Diff: https://git.reviewboard.kde.org/r/126061/diff/
> 
> 
> Testing
> ---
> 
> Ran the menu.qml test and moved the window around, positioning seemed sane. 
> Also Widget Explorer more menu now pops up to the top.
> 
> I subtract the Y from the position to not break the most common usecase of 
> popup(0, height) to have the menu pop up below the button. Now it pops up 
> above it, still glued to it as it should be.
> 
> 
> Thanks,
> 
> Kai Uwe Broulik
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 126061: [Menu] Popup above parent if would exceed screen boundaries

[David Edmundson]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126061/#review88417
---


doesn't that just move the problem to buttons that are at the top of the screen?

- David Edmundson


On Nov. 14, 2015, 12:11 p.m., Kai Uwe Broulik wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/126061/
> ---
> 
> (Updated Nov. 14, 2015, 12:11 p.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Repository: plasma-framework
> 
> 
> Description
> ---
> 
> QMenu is smart enough not to position itself outside the screen, however this 
> can mean that the button the Menu originated from, could be covered. This can 
> be observed with Widget Explorer's "get more widgets" buttons.
> 
> 
> Diffs
> -
> 
>   src/declarativeimports/plasmacomponents/qmenu.cpp d84f481 
> 
> Diff: https://git.reviewboard.kde.org/r/126061/diff/
> 
> 
> Testing
> ---
> 
> Ran the menu.qml test and moved the window around, positioning seemed sane. 
> Also Widget Explorer more menu now pops up to the top.
> 
> I subtract the Y from the position to not break the most common usecase of 
> popup(0, height) to have the menu pop up below the button. Now it pops up 
> above it, still glued to it as it should be.
> 
> 
> Thanks,
> 
> Kai Uwe Broulik
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 126061: [Menu] Popup above parent if would exceed screen boundaries

[Kai Uwe Broulik]

> On Nov. 16, 2015, 12:12 nachm., David Edmundson wrote:
> > doesn't that just move the problem to buttons that are at the top of the 
> > screen?

Imho it's far less likely for someone to open a menu deliberately *above* a 
button.


- Kai Uwe


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126061/#review88417
---


On Nov. 14, 2015, 12:11 nachm., Kai Uwe Broulik wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/126061/
> ---
> 
> (Updated Nov. 14, 2015, 12:11 nachm.)
> 
> 
> Review request for Plasma.
> 
> 
> Repository: plasma-framework
> 
> 
> Description
> ---
> 
> QMenu is smart enough not to position itself outside the screen, however this 
> can mean that the button the Menu originated from, could be covered. This can 
> be observed with Widget Explorer's "get more widgets" buttons.
> 
> 
> Diffs
> -
> 
>   src/declarativeimports/plasmacomponents/qmenu.cpp d84f481 
> 
> Diff: https://git.reviewboard.kde.org/r/126061/diff/
> 
> 
> Testing
> ---
> 
> Ran the menu.qml test and moved the window around, positioning seemed sane. 
> Also Widget Explorer more menu now pops up to the top.
> 
> I subtract the Y from the position to not break the most common usecase of 
> popup(0, height) to have the menu pop up below the button. Now it pops up 
> above it, still glued to it as it should be.
> 
> 
> Thanks,
> 
> Kai Uwe Broulik
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Review Request 126061: [Menu] Popup above parent if would exceed screen boundaries

[Kai Uwe Broulik]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126061/
---

Review request for Plasma.


Repository: plasma-framework


Description
---

QMenu is smart enough not to position itself outside the screen, however this 
can mean that the button the Menu originated from, could be covered. This can 
be observed with Widget Explorer's "get more widgets" buttons.


Diffs
-

  src/declarativeimports/plasmacomponents/qmenu.cpp d84f481 

Diff: https://git.reviewboard.kde.org/r/126061/diff/


Testing
---

Ran the menu.qml test and moved the window around, positioning seemed sane. 
Also Widget Explorer more menu now pops up to the top.

I subtract the Y from the position to not break the most common usecase of 
popup(0, height) to have the menu pop up below the button. Now it pops up above 
it, still glued to it as it should be.


Thanks,

Kai Uwe Broulik

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel