Re: Review Request 126064: [DragArea] Add dragActive property
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126064/ --- (Updated Dec. 15, 2015, 10:43 a.m.) Status -- This change has been marked as submitted. Review request for Plasma. Changes --- Submitted with commit 83ac45466e817dd1973dff1e502463fea1d88921 by Kai Uwe Broulik to branch master. Repository: kdeclarative Description --- It allows to query whether a drag is currently ongoing. This eases avoiding dropping something onto itself when it has both DragArea and DropArea Diffs - src/qmlcontrols/draganddrop/DeclarativeDragArea.h 6cb682d src/qmlcontrols/draganddrop/DeclarativeDragArea.cpp 3afaa62 Diff: https://git.reviewboard.kde.org/r/126064/diff/ Testing --- Works Thanks, Kai Uwe Broulik ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 126064: [DragArea] Add dragActive property
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126064/#review88818 --- Ship it! I would be in favor of this - Marco Martin On Nov. 14, 2015, 3:59 p.m., Kai Uwe Broulik wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/126064/ > --- > > (Updated Nov. 14, 2015, 3:59 p.m.) > > > Review request for Plasma. > > > Repository: kdeclarative > > > Description > --- > > It allows to query whether a drag is currently ongoing. This eases avoiding > dropping something onto itself when it has both DragArea and DropArea > > > Diffs > - > > src/qmlcontrols/draganddrop/DeclarativeDragArea.h 6cb682d > src/qmlcontrols/draganddrop/DeclarativeDragArea.cpp 3afaa62 > > Diff: https://git.reviewboard.kde.org/r/126064/diff/ > > > Testing > --- > > Works > > > Thanks, > > Kai Uwe Broulik > > ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 126064: [DragArea] Add dragActive property
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126064/#review88807 --- ping, what's the status of this? - Sebastian Kügler On Nov. 14, 2015, 3:59 p.m., Kai Uwe Broulik wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/126064/ > --- > > (Updated Nov. 14, 2015, 3:59 p.m.) > > > Review request for Plasma. > > > Repository: kdeclarative > > > Description > --- > > It allows to query whether a drag is currently ongoing. This eases avoiding > dropping something onto itself when it has both DragArea and DropArea > > > Diffs > - > > src/qmlcontrols/draganddrop/DeclarativeDragArea.h 6cb682d > src/qmlcontrols/draganddrop/DeclarativeDragArea.cpp 3afaa62 > > Diff: https://git.reviewboard.kde.org/r/126064/diff/ > > > Testing > --- > > Works > > > Thanks, > > Kai Uwe Broulik > > ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Review Request 126064: [DragArea] Add dragActive property
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126064/ --- Review request for Plasma. Repository: kdeclarative Description --- It allows to query whether a drag is currently ongoing. This eases avoiding dropping something onto itself when it has both DragArea and DropArea Diffs - src/qmlcontrols/draganddrop/DeclarativeDragArea.h 6cb682d src/qmlcontrols/draganddrop/DeclarativeDragArea.cpp 3afaa62 Diff: https://git.reviewboard.kde.org/r/126064/diff/ Testing --- Works Thanks, Kai Uwe Broulik ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 126064: [DragArea] Add dragActive property
> On Nov. 14, 2015, 11:44 nachm., Aleix Pol Gonzalez wrote: > > How come we never needed this? (nor Qt did) Probably because we never had a Drag and Drop Area in the same location with visible side-effects if an item is dropped onto itself. Also if you're not lazy like me you could add a property bool yourself that is updated in onDragStarted and onDrop. - Kai Uwe --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126064/#review88368 --- On Nov. 14, 2015, 3:59 nachm., Kai Uwe Broulik wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/126064/ > --- > > (Updated Nov. 14, 2015, 3:59 nachm.) > > > Review request for Plasma. > > > Repository: kdeclarative > > > Description > --- > > It allows to query whether a drag is currently ongoing. This eases avoiding > dropping something onto itself when it has both DragArea and DropArea > > > Diffs > - > > src/qmlcontrols/draganddrop/DeclarativeDragArea.h 6cb682d > src/qmlcontrols/draganddrop/DeclarativeDragArea.cpp 3afaa62 > > Diff: https://git.reviewboard.kde.org/r/126064/diff/ > > > Testing > --- > > Works > > > Thanks, > > Kai Uwe Broulik > > ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
