Re: Review Request 126149: [Icon widget] Bring back properties dialog

[David Faure]

> On Dec. 29, 2015, 6:07 p.m., Kai Uwe Broulik wrote:
> > I completely screwed up my Kate desktop files :( Would it help if I set 
> > NoDisplay or Hidden on the desktop file copy so it's there for the icon 
> > widget but not shown in the Open With dialogs and so on? Or, if I copied 
> > the desktop file elsewhere (eg. not into the local share applications)?
> > 
> > Also, I should probably delete the desktop file again if the widget is 
> > removed :)

If you set NoDisplay or Hidden in ~/.local/share/applications/kate.desktop then 
this will fully hide kate from your K menu. That's a local override.

Desktop files in the panel or on the desktop should probably be copies, yes (in 
other dirs than ~/.local/share/applications/)


- David


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126149/#review90298
---


On Dec. 21, 2015, 11:31 p.m., Kai Uwe Broulik wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/126149/
> ---
> 
> (Updated Dec. 21, 2015, 11:31 p.m.)
> 
> 
> Review request for KDE Frameworks and Plasma.
> 
> 
> Bugs: 349177
> https://bugs.kde.org/show_bug.cgi?id=349177
> 
> 
> Repository: plasma-workspace
> 
> 
> Description
> ---
> 
> This brings back the KPropertiesDialog to modify an icon's appearance. This 
> has been requested at multiple occasions. This has been adapted from the 
> Plasma 4 icon code.
> 
> 
> Diffs
> -
> 
>   applets/icon/package/contents/ui/main.qml 9286b94 
>   applets/icon/plugin/icon_p.h dd7963c 
>   applets/icon/plugin/icon_p.cpp e086870 
> 
> Diff: https://git.reviewboard.kde.org/r/126149/diff/
> 
> 
> Testing
> ---
> 
> Dropped a file from my home onto the desktop -> dialog from the actual file, 
> allowing to rename it. The applet reflected the changes.
> 
> Dropped an application from kickoff to the desktop -> dialog from a copy of 
> the desktop file, allowing to change its icon and description. The applet 
> reflected the changes.
> 
> 
> Thanks,
> 
> Kai Uwe Broulik
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 126149: [Icon widget] Bring back properties dialog

[Kai Uwe Broulik]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126149/#review90298
---


I completely screwed up my Kate desktop files :( Would it help if I set 
NoDisplay or Hidden on the desktop file copy so it's there for the icon widget 
but not shown in the Open With dialogs and so on? Or, if I copied the desktop 
file elsewhere (eg. not into the local share applications)?

Also, I should probably delete the desktop file again if the widget is removed 
:)

- Kai Uwe Broulik


On Dez. 21, 2015, 11:31 nachm., Kai Uwe Broulik wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/126149/
> ---
> 
> (Updated Dez. 21, 2015, 11:31 nachm.)
> 
> 
> Review request for KDE Frameworks and Plasma.
> 
> 
> Bugs: 349177
> https://bugs.kde.org/show_bug.cgi?id=349177
> 
> 
> Repository: plasma-workspace
> 
> 
> Description
> ---
> 
> This brings back the KPropertiesDialog to modify an icon's appearance. This 
> has been requested at multiple occasions. This has been adapted from the 
> Plasma 4 icon code.
> 
> 
> Diffs
> -
> 
>   applets/icon/package/contents/ui/main.qml 9286b94 
>   applets/icon/plugin/icon_p.h dd7963c 
>   applets/icon/plugin/icon_p.cpp e086870 
> 
> Diff: https://git.reviewboard.kde.org/r/126149/diff/
> 
> 
> Testing
> ---
> 
> Dropped a file from my home onto the desktop -> dialog from the actual file, 
> allowing to rename it. The applet reflected the changes.
> 
> Dropped an application from kickoff to the desktop -> dialog from a copy of 
> the desktop file, allowing to change its icon and description. The applet 
> reflected the changes.
> 
> 
> Thanks,
> 
> Kai Uwe Broulik
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 126149: [Icon widget] Bring back properties dialog

[Kai Uwe Broulik]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126149/
---

(Updated Dez. 21, 2015, 11:31 nachm.)


Review request for KDE Frameworks and Plasma.


Bugs: 349177
https://bugs.kde.org/show_bug.cgi?id=349177


Repository: plasma-workspace


Description
---

This brings back the KPropertiesDialog to modify an icon's appearance. This has 
been requested at multiple occasions. This has been adapted from the Plasma 4 
icon code.


Diffs
-

  applets/icon/package/contents/ui/main.qml 9286b94 
  applets/icon/plugin/icon_p.h dd7963c 
  applets/icon/plugin/icon_p.cpp e086870 

Diff: https://git.reviewboard.kde.org/r/126149/diff/


Testing
---

Dropped a file from my home onto the desktop -> dialog from the actual file, 
allowing to rename it. The applet reflected the changes.

Dropped an application from kickoff to the desktop -> dialog from a copy of the 
desktop file, allowing to change its icon and description. The applet reflected 
the changes.


Thanks,

Kai Uwe Broulik

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 126149: [Icon widget] Bring back properties dialog

[David Faure]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126149/#review89023
---



applets/icon/plugin/icon_p.cpp (line 203)


PreferLocalFile is only good for displaying to the user. Otherwise you have 
something which is "a path or a URL", and most API doesn't work with that.



applets/icon/plugin/icon_p.cpp (line 205)


This only works with local files, so it should be in a if 
(m_url.isLocalFile()) block, and use m_url.toLocalFile(). The current code 
would break on Windows at least, and possibly in case of filenames with '#'.

Put the result of toLocalFile() in a temporary QString, you'll need further 
down as well.



applets/icon/plugin/icon_p.cpp (line 211)


Yes, don't ;)

Actually this is a local-to-local copy, you could just use QFile::copy if 
you want it synchronous.



applets/icon/plugin/icon_p.cpp (line 239)


why commented out?


- David Faure


On Nov. 26, 2015, 8:15 p.m., Kai Uwe Broulik wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/126149/
> ---
> 
> (Updated Nov. 26, 2015, 8:15 p.m.)
> 
> 
> Review request for KDE Frameworks and Plasma.
> 
> 
> Bugs: ?
> https://bugs.kde.org/show_bug.cgi?id=?
> 
> 
> Repository: plasma-workspace
> 
> 
> Description
> ---
> 
> This brings back the KPropertiesDialog to modify an icon's appearance. This 
> has been requested at multiple occasions. This has been adapted from the 
> Plasma 4 icon code.
> 
> 
> Diffs
> -
> 
>   applets/icon/package/contents/ui/main.qml 9286b94 
>   applets/icon/plugin/icon_p.h dd7963c 
>   applets/icon/plugin/icon_p.cpp e086870 
> 
> Diff: https://git.reviewboard.kde.org/r/126149/diff/
> 
> 
> Testing
> ---
> 
> Dropped a file from my home onto the desktop -> dialog from the actual file, 
> allowing to rename it. The applet reflected the changes.
> 
> Dropped an application from kickoff to the desktop -> dialog from a copy of 
> the desktop file, allowing to change its icon and description. The applet 
> reflected the changes.
> 
> 
> Thanks,
> 
> Kai Uwe Broulik
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 126149: [Icon widget] Bring back properties dialog

[Marco Martin]

> On Nov. 23, 2015, 10:04 p.m., Eike Hein wrote:
> > The problem with this is that the old applet had the properties widget 
> > embedded as a page into the applet config dialog. This probably replaces 
> > the latter, killing the keyboard shortcut page and making it not possible 
> > to configure a hotkey anymore ...?
> 
> Kai Uwe Broulik wrote:
> The old applet also just opened the KPropertiesDialog.
> 
> Eike Hein wrote:
> This will still make it hard for users to access config UI they might 
> have come to rely on (shortcuts) so it's a regression vs. the last stable 
> release. This needs to be addressed somehow, reverting to Plasma 4 behavior 
> is a bit of a stretch IMHO.
> 
> Kai Uwe Broulik wrote:
> Alternatively we could keep the (empty) settings dialog as is and add 
> another context menu option for the icon settings, like we do with a couple 
> of applets that can spawn a KCM.

yeah, a second context menu item would be good in this case i think


- Marco


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126149/#review88741
---


On Nov. 23, 2015, 8:54 p.m., Kai Uwe Broulik wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/126149/
> ---
> 
> (Updated Nov. 23, 2015, 8:54 p.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Bugs: ?
> https://bugs.kde.org/show_bug.cgi?id=?
> 
> 
> Repository: plasma-workspace
> 
> 
> Description
> ---
> 
> This brings back the KPropertiesDialog to modify an icon's appearance. This 
> has been requested at multiple occasions. This has been adapted from the 
> Plasma 4 icon code.
> 
> 
> Diffs
> -
> 
>   applets/icon/package/contents/ui/main.qml 9286b94 
>   applets/icon/plugin/icon_p.h dd7963c 
>   applets/icon/plugin/icon_p.cpp e086870 
> 
> Diff: https://git.reviewboard.kde.org/r/126149/diff/
> 
> 
> Testing
> ---
> 
> Dropped a file from my home onto the desktop -> dialog from the actual file, 
> allowing to rename it. The applet reflected the changes.
> 
> Dropped an application from kickoff to the desktop -> dialog from a copy of 
> the desktop file, allowing to change its icon and description. The applet 
> reflected the changes.
> 
> 
> Thanks,
> 
> Kai Uwe Broulik
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 126149: [Icon widget] Bring back properties dialog

[Kai Uwe Broulik]

> On Nov. 23, 2015, 10:04 nachm., Eike Hein wrote:
> > The problem with this is that the old applet had the properties widget 
> > embedded as a page into the applet config dialog. This probably replaces 
> > the latter, killing the keyboard shortcut page and making it not possible 
> > to configure a hotkey anymore ...?
> 
> Kai Uwe Broulik wrote:
> The old applet also just opened the KPropertiesDialog.
> 
> Eike Hein wrote:
> This will still make it hard for users to access config UI they might 
> have come to rely on (shortcuts) so it's a regression vs. the last stable 
> release. This needs to be addressed somehow, reverting to Plasma 4 behavior 
> is a bit of a stretch IMHO.
> 
> Kai Uwe Broulik wrote:
> Alternatively we could keep the (empty) settings dialog as is and add 
> another context menu option for the icon settings, like we do with a couple 
> of applets that can spawn a KCM.
> 
> Marco Martin wrote:
> yeah, a second context menu item would be good in this case i think

Okay.

One thing I noticed is that when I edit eg. Kate and apply in the dialog, it 
adds this Kate to the "open with" actions but never removes them again and now 
I have 20 Kate entries there :( Any idea how to prevent this?


- Kai Uwe


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126149/#review88741
---


On Nov. 23, 2015, 8:54 nachm., Kai Uwe Broulik wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/126149/
> ---
> 
> (Updated Nov. 23, 2015, 8:54 nachm.)
> 
> 
> Review request for Plasma.
> 
> 
> Bugs: ?
> https://bugs.kde.org/show_bug.cgi?id=?
> 
> 
> Repository: plasma-workspace
> 
> 
> Description
> ---
> 
> This brings back the KPropertiesDialog to modify an icon's appearance. This 
> has been requested at multiple occasions. This has been adapted from the 
> Plasma 4 icon code.
> 
> 
> Diffs
> -
> 
>   applets/icon/package/contents/ui/main.qml 9286b94 
>   applets/icon/plugin/icon_p.h dd7963c 
>   applets/icon/plugin/icon_p.cpp e086870 
> 
> Diff: https://git.reviewboard.kde.org/r/126149/diff/
> 
> 
> Testing
> ---
> 
> Dropped a file from my home onto the desktop -> dialog from the actual file, 
> allowing to rename it. The applet reflected the changes.
> 
> Dropped an application from kickoff to the desktop -> dialog from a copy of 
> the desktop file, allowing to change its icon and description. The applet 
> reflected the changes.
> 
> 
> Thanks,
> 
> Kai Uwe Broulik
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 126149: [Icon widget] Bring back properties dialog

[Marco Martin]

> On Nov. 23, 2015, 10:04 p.m., Eike Hein wrote:
> > The problem with this is that the old applet had the properties widget 
> > embedded as a page into the applet config dialog. This probably replaces 
> > the latter, killing the keyboard shortcut page and making it not possible 
> > to configure a hotkey anymore ...?
> 
> Kai Uwe Broulik wrote:
> The old applet also just opened the KPropertiesDialog.
> 
> Eike Hein wrote:
> This will still make it hard for users to access config UI they might 
> have come to rely on (shortcuts) so it's a regression vs. the last stable 
> release. This needs to be addressed somehow, reverting to Plasma 4 behavior 
> is a bit of a stretch IMHO.
> 
> Kai Uwe Broulik wrote:
> Alternatively we could keep the (empty) settings dialog as is and add 
> another context menu option for the icon settings, like we do with a couple 
> of applets that can spawn a KCM.
> 
> Marco Martin wrote:
> yeah, a second context menu item would be good in this case i think
> 
> Kai Uwe Broulik wrote:
> Okay.
> 
> One thing I noticed is that when I edit eg. Kate and apply in the dialog, 
> it adds this Kate to the "open with" actions but never removes them again and 
> now I have 20 Kate entries there :( Any idea how to prevent this?

perhaps when editing an icon that is installed globally, it then creates a copy 
in the home, and then disaster ensues?


- Marco


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126149/#review88741
---


On Nov. 23, 2015, 8:54 p.m., Kai Uwe Broulik wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/126149/
> ---
> 
> (Updated Nov. 23, 2015, 8:54 p.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Bugs: ?
> https://bugs.kde.org/show_bug.cgi?id=?
> 
> 
> Repository: plasma-workspace
> 
> 
> Description
> ---
> 
> This brings back the KPropertiesDialog to modify an icon's appearance. This 
> has been requested at multiple occasions. This has been adapted from the 
> Plasma 4 icon code.
> 
> 
> Diffs
> -
> 
>   applets/icon/package/contents/ui/main.qml 9286b94 
>   applets/icon/plugin/icon_p.h dd7963c 
>   applets/icon/plugin/icon_p.cpp e086870 
> 
> Diff: https://git.reviewboard.kde.org/r/126149/diff/
> 
> 
> Testing
> ---
> 
> Dropped a file from my home onto the desktop -> dialog from the actual file, 
> allowing to rename it. The applet reflected the changes.
> 
> Dropped an application from kickoff to the desktop -> dialog from a copy of 
> the desktop file, allowing to change its icon and description. The applet 
> reflected the changes.
> 
> 
> Thanks,
> 
> Kai Uwe Broulik
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 126149: [Icon widget] Bring back properties dialog

[Kai Uwe Broulik]

> On Nov. 23, 2015, 10:04 nachm., Eike Hein wrote:
> > The problem with this is that the old applet had the properties widget 
> > embedded as a page into the applet config dialog. This probably replaces 
> > the latter, killing the keyboard shortcut page and making it not possible 
> > to configure a hotkey anymore ...?
> 
> Kai Uwe Broulik wrote:
> The old applet also just opened the KPropertiesDialog.
> 
> Eike Hein wrote:
> This will still make it hard for users to access config UI they might 
> have come to rely on (shortcuts) so it's a regression vs. the last stable 
> release. This needs to be addressed somehow, reverting to Plasma 4 behavior 
> is a bit of a stretch IMHO.

Alternatively we could keep the (empty) settings dialog as is and add another 
context menu option for the icon settings, like we do with a couple of applets 
that can spawn a KCM.


- Kai Uwe


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126149/#review88741
---


On Nov. 23, 2015, 8:54 nachm., Kai Uwe Broulik wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/126149/
> ---
> 
> (Updated Nov. 23, 2015, 8:54 nachm.)
> 
> 
> Review request for Plasma.
> 
> 
> Bugs: ?
> https://bugs.kde.org/show_bug.cgi?id=?
> 
> 
> Repository: plasma-workspace
> 
> 
> Description
> ---
> 
> This brings back the KPropertiesDialog to modify an icon's appearance. This 
> has been requested at multiple occasions. This has been adapted from the 
> Plasma 4 icon code.
> 
> 
> Diffs
> -
> 
>   applets/icon/package/contents/ui/main.qml 9286b94 
>   applets/icon/plugin/icon_p.h dd7963c 
>   applets/icon/plugin/icon_p.cpp e086870 
> 
> Diff: https://git.reviewboard.kde.org/r/126149/diff/
> 
> 
> Testing
> ---
> 
> Dropped a file from my home onto the desktop -> dialog from the actual file, 
> allowing to rename it. The applet reflected the changes.
> 
> Dropped an application from kickoff to the desktop -> dialog from a copy of 
> the desktop file, allowing to change its icon and description. The applet 
> reflected the changes.
> 
> 
> Thanks,
> 
> Kai Uwe Broulik
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 126149: [Icon widget] Bring back properties dialog

[Eike Hein]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126149/#review88741
---


The problem with this is that the old applet had the properties widget embedded 
as a page into the applet config dialog. This probably replaces the latter, 
killing the keyboard shortcut page and making it not possible to configure a 
hotkey anymore ...?

- Eike Hein


On Nov. 23, 2015, 8:54 p.m., Kai Uwe Broulik wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/126149/
> ---
> 
> (Updated Nov. 23, 2015, 8:54 p.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Bugs: ?
> https://bugs.kde.org/show_bug.cgi?id=?
> 
> 
> Repository: plasma-workspace
> 
> 
> Description
> ---
> 
> This brings back the KPropertiesDialog to modify an icon's appearance. This 
> has been requested at multiple occasions. This has been adapted from the 
> Plasma 4 icon code.
> 
> 
> Diffs
> -
> 
>   applets/icon/package/contents/ui/main.qml 9286b94 
>   applets/icon/plugin/icon_p.h dd7963c 
>   applets/icon/plugin/icon_p.cpp e086870 
> 
> Diff: https://git.reviewboard.kde.org/r/126149/diff/
> 
> 
> Testing
> ---
> 
> Dropped a file from my home onto the desktop -> dialog from the actual file, 
> allowing to rename it. The applet reflected the changes.
> 
> Dropped an application from kickoff to the desktop -> dialog from a copy of 
> the desktop file, allowing to change its icon and description. The applet 
> reflected the changes.
> 
> 
> Thanks,
> 
> Kai Uwe Broulik
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 126149: [Icon widget] Bring back properties dialog

[Eike Hein]

> On Nov. 23, 2015, 10:04 p.m., Eike Hein wrote:
> > The problem with this is that the old applet had the properties widget 
> > embedded as a page into the applet config dialog. This probably replaces 
> > the latter, killing the keyboard shortcut page and making it not possible 
> > to configure a hotkey anymore ...?
> 
> Kai Uwe Broulik wrote:
> The old applet also just opened the KPropertiesDialog.

This will still make it hard for users to access config UI they might have come 
to rely on (shortcuts) so it's a regression vs. the last stable release. This 
needs to be addressed somehow, reverting to Plasma 4 behavior is a bit of a 
stretch IMHO.


- Eike


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126149/#review88741
---


On Nov. 23, 2015, 8:54 p.m., Kai Uwe Broulik wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/126149/
> ---
> 
> (Updated Nov. 23, 2015, 8:54 p.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Bugs: ?
> https://bugs.kde.org/show_bug.cgi?id=?
> 
> 
> Repository: plasma-workspace
> 
> 
> Description
> ---
> 
> This brings back the KPropertiesDialog to modify an icon's appearance. This 
> has been requested at multiple occasions. This has been adapted from the 
> Plasma 4 icon code.
> 
> 
> Diffs
> -
> 
>   applets/icon/package/contents/ui/main.qml 9286b94 
>   applets/icon/plugin/icon_p.h dd7963c 
>   applets/icon/plugin/icon_p.cpp e086870 
> 
> Diff: https://git.reviewboard.kde.org/r/126149/diff/
> 
> 
> Testing
> ---
> 
> Dropped a file from my home onto the desktop -> dialog from the actual file, 
> allowing to rename it. The applet reflected the changes.
> 
> Dropped an application from kickoff to the desktop -> dialog from a copy of 
> the desktop file, allowing to change its icon and description. The applet 
> reflected the changes.
> 
> 
> Thanks,
> 
> Kai Uwe Broulik
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 126149: [Icon widget] Bring back properties dialog

[Kai Uwe Broulik]

> On Nov. 23, 2015, 10:04 nachm., Eike Hein wrote:
> > The problem with this is that the old applet had the properties widget 
> > embedded as a page into the applet config dialog. This probably replaces 
> > the latter, killing the keyboard shortcut page and making it not possible 
> > to configure a hotkey anymore ...?

The old applet also just opened the KPropertiesDialog.


- Kai Uwe


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126149/#review88741
---


On Nov. 23, 2015, 8:54 nachm., Kai Uwe Broulik wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/126149/
> ---
> 
> (Updated Nov. 23, 2015, 8:54 nachm.)
> 
> 
> Review request for Plasma.
> 
> 
> Bugs: ?
> https://bugs.kde.org/show_bug.cgi?id=?
> 
> 
> Repository: plasma-workspace
> 
> 
> Description
> ---
> 
> This brings back the KPropertiesDialog to modify an icon's appearance. This 
> has been requested at multiple occasions. This has been adapted from the 
> Plasma 4 icon code.
> 
> 
> Diffs
> -
> 
>   applets/icon/package/contents/ui/main.qml 9286b94 
>   applets/icon/plugin/icon_p.h dd7963c 
>   applets/icon/plugin/icon_p.cpp e086870 
> 
> Diff: https://git.reviewboard.kde.org/r/126149/diff/
> 
> 
> Testing
> ---
> 
> Dropped a file from my home onto the desktop -> dialog from the actual file, 
> allowing to rename it. The applet reflected the changes.
> 
> Dropped an application from kickoff to the desktop -> dialog from a copy of 
> the desktop file, allowing to change its icon and description. The applet 
> reflected the changes.
> 
> 
> Thanks,
> 
> Kai Uwe Broulik
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Review Request 126149: [Icon widget] Bring back properties dialog

[Kai Uwe Broulik]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126149/
---

Review request for Plasma.


Bugs: ?
https://bugs.kde.org/show_bug.cgi?id=?


Repository: plasma-workspace


Description
---

This brings back the KPropertiesDialog to modify an icon's appearance. This has 
been requested at multiple occasions. This has been adapted from the Plasma 4 
icon code.


Diffs
-

  applets/icon/package/contents/ui/main.qml 9286b94 
  applets/icon/plugin/icon_p.h dd7963c 
  applets/icon/plugin/icon_p.cpp e086870 

Diff: https://git.reviewboard.kde.org/r/126149/diff/


Testing
---

Dropped a file from my home onto the desktop -> dialog from the actual file, 
allowing to rename it. The applet reflected the changes.

Dropped an application from kickoff to the desktop -> dialog from a copy of the 
desktop file, allowing to change its icon and description. The applet reflected 
the changes.


Thanks,

Kai Uwe Broulik

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel