Re: Review Request 126463: Allow applets to set full ToolTip item

2016-01-04 Thread Martin Klapetek 

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126463/
---

(Updated Jan. 4, 2016, 4:38 p.m.)


Status
--

This change has been marked as submitted.


Review request for KDE Frameworks and Plasma.


Changes
---

Submitted with commit 3992593f31681254fb5fa9bafcaa47e18fc19421 by Martin 
Klapetek to branch master.


Repository: plasma-framework


Description
---

Adds new property available as Plasmoid.toolTipItem that allows
to set a full custom item as the tooltip.

The main motivation is to have a custom Item tooltip for digital
clock to properly format the list of timezones (version of
https://git.reviewboard.kde.org/r/124047/). Adding a custom
PlasmaCore.ToolTipArea to the compact representation does not
work well because then it's a ToolTipArea nested inside another
ToolTipArea (from CompactApplet.qml), this causes a sliding effect
as it changes visual parents when hovering.

I dunno if this could perhaps be fixed, but seems redundant to have
two ToolTipAreas anyway, so instead this exposes the main applet's
ToolTipArea's mainItem property through Plasmoid.toolTipItem which
the appelts can use to set a custom item.

This has a part2 patch which goes of plasma-desktop:
https://git.reviewboard.kde.org/r/126464/


Diffs
-

  src/scriptengines/qml/plasmoid/appletinterface.h 40016b1 
  src/scriptengines/qml/plasmoid/appletinterface.cpp 60b7fa5 

Diff: https://git.reviewboard.kde.org/r/126463/diff/


Testing
---

I can have custom tooltip item in digital clock without any artifacts
while all other applets still have correct tooltips.


Thanks,

Martin Klapetek

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 126463: Allow applets to set full ToolTip item

2016-01-04 Thread Marco Martin 

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126463/#review90530
---

Ship it!


Ship It!

- Marco Martin


On Dec. 31, 2015, 6:47 p.m., Martin Klapetek wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/126463/
> ---
> 
> (Updated Dec. 31, 2015, 6:47 p.m.)
> 
> 
> Review request for KDE Frameworks and Plasma.
> 
> 
> Repository: plasma-framework
> 
> 
> Description
> ---
> 
> Adds new property available as Plasmoid.toolTipItem that allows
> to set a full custom item as the tooltip.
> 
> The main motivation is to have a custom Item tooltip for digital
> clock to properly format the list of timezones (version of
> https://git.reviewboard.kde.org/r/124047/). Adding a custom
> PlasmaCore.ToolTipArea to the compact representation does not
> work well because then it's a ToolTipArea nested inside another
> ToolTipArea (from CompactApplet.qml), this causes a sliding effect
> as it changes visual parents when hovering.
> 
> I dunno if this could perhaps be fixed, but seems redundant to have
> two ToolTipAreas anyway, so instead this exposes the main applet's
> ToolTipArea's mainItem property through Plasmoid.toolTipItem which
> the appelts can use to set a custom item.
> 
> This has a part2 patch which goes of plasma-desktop:
> https://git.reviewboard.kde.org/r/126464/
> 
> 
> Diffs
> -
> 
>   src/scriptengines/qml/plasmoid/appletinterface.h 40016b1 
>   src/scriptengines/qml/plasmoid/appletinterface.cpp 60b7fa5 
> 
> Diff: https://git.reviewboard.kde.org/r/126463/diff/
> 
> 
> Testing
> ---
> 
> I can have custom tooltip item in digital clock without any artifacts
> while all other applets still have correct tooltips.
> 
> 
> Thanks,
> 
> Martin Klapetek
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 126463: Allow applets to set full ToolTip item

2015-12-31 Thread Martin Klapetek 

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126463/
---

(Updated Dec. 31, 2015, 7:47 p.m.)


Review request for KDE Frameworks and Plasma.


Changes
---

* Use QPointer
* Emit the changed signal also on object deletion


Repository: plasma-framework


Description
---

Adds new property available as Plasmoid.toolTipItem that allows
to set a full custom item as the tooltip.

The main motivation is to have a custom Item tooltip for digital
clock to properly format the list of timezones (version of
https://git.reviewboard.kde.org/r/124047/). Adding a custom
PlasmaCore.ToolTipArea to the compact representation does not
work well because then it's a ToolTipArea nested inside another
ToolTipArea (from CompactApplet.qml), this causes a sliding effect
as it changes visual parents when hovering.

I dunno if this could perhaps be fixed, but seems redundant to have
two ToolTipAreas anyway, so instead this exposes the main applet's
ToolTipArea's mainItem property through Plasmoid.toolTipItem which
the appelts can use to set a custom item.

This has a part2 patch which goes of plasma-desktop:
https://git.reviewboard.kde.org/r/126464/


Diffs (updated)
-

  src/scriptengines/qml/plasmoid/appletinterface.h 40016b1 
  src/scriptengines/qml/plasmoid/appletinterface.cpp 60b7fa5 

Diff: https://git.reviewboard.kde.org/r/126463/diff/


Testing
---

I can have custom tooltip item in digital clock without any artifacts
while all other applets still have correct tooltips.


Thanks,

Martin Klapetek

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 126463: Allow applets to set full ToolTip item

2015-12-22 Thread Marco Martin 

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126463/#review89909
---

Ship it!



src/scriptengines/qml/plasmoid/appletinterface.h (line 109)


QQuickItem *



src/scriptengines/qml/plasmoid/appletinterface.h (line 407)


QPointer  (emit the tooltipItemChanged signal also on object 
destruction)


- Marco Martin


On Dic. 21, 2015, 10:12 p.m., Martin Klapetek wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/126463/
> ---
> 
> (Updated Dic. 21, 2015, 10:12 p.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Repository: plasma-framework
> 
> 
> Description
> ---
> 
> Adds new property available as Plasmoid.toolTipItem that allows
> to set a full custom item as the tooltip.
> 
> The main motivation is to have a custom Item tooltip for digital
> clock to properly format the list of timezones (version of
> https://git.reviewboard.kde.org/r/124047/). Adding a custom
> PlasmaCore.ToolTipArea to the compact representation does not
> work well because then it's a ToolTipArea nested inside another
> ToolTipArea (from CompactApplet.qml), this causes a sliding effect
> as it changes visual parents when hovering.
> 
> I dunno if this could perhaps be fixed, but seems redundant to have
> two ToolTipAreas anyway, so instead this exposes the main applet's
> ToolTipArea's mainItem property through Plasmoid.toolTipItem which
> the appelts can use to set a custom item.
> 
> This has a part2 patch which goes of plasma-desktop:
> https://git.reviewboard.kde.org/r/126464/
> 
> 
> Diffs
> -
> 
>   src/scriptengines/qml/plasmoid/appletinterface.h 40016b1 
>   src/scriptengines/qml/plasmoid/appletinterface.cpp 60b7fa5 
> 
> Diff: https://git.reviewboard.kde.org/r/126463/diff/
> 
> 
> Testing
> ---
> 
> I can have custom tooltip item in digital clock without any artifacts
> while all other applets still have correct tooltips.
> 
> 
> Thanks,
> 
> Martin Klapetek
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 126463: Allow applets to set full ToolTip item

2015-12-22 Thread Marco Martin 


> On Dic. 21, 2015, 10:39 p.m., David Edmundson wrote:
> > src/scriptengines/qml/plasmoid/appletinterface.h, line 407
> > 
> >
> > what would happen if the tooltipItem object gets deleted by the 
> > plasmoid after having set the object in the applet interface?
> 
> Kai Uwe Broulik wrote:
> "deleted by the plasmoid" means deleted from QML means the QML engine 
> will set the property to null, if I'm not mistaken?

you still have to use a qpointer to store the internal variable tough


- Marco


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126463/#review89868
---


On Dic. 21, 2015, 10:12 p.m., Martin Klapetek wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/126463/
> ---
> 
> (Updated Dic. 21, 2015, 10:12 p.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Repository: plasma-framework
> 
> 
> Description
> ---
> 
> Adds new property available as Plasmoid.toolTipItem that allows
> to set a full custom item as the tooltip.
> 
> The main motivation is to have a custom Item tooltip for digital
> clock to properly format the list of timezones (version of
> https://git.reviewboard.kde.org/r/124047/). Adding a custom
> PlasmaCore.ToolTipArea to the compact representation does not
> work well because then it's a ToolTipArea nested inside another
> ToolTipArea (from CompactApplet.qml), this causes a sliding effect
> as it changes visual parents when hovering.
> 
> I dunno if this could perhaps be fixed, but seems redundant to have
> two ToolTipAreas anyway, so instead this exposes the main applet's
> ToolTipArea's mainItem property through Plasmoid.toolTipItem which
> the appelts can use to set a custom item.
> 
> This has a part2 patch which goes of plasma-desktop:
> https://git.reviewboard.kde.org/r/126464/
> 
> 
> Diffs
> -
> 
>   src/scriptengines/qml/plasmoid/appletinterface.h 40016b1 
>   src/scriptengines/qml/plasmoid/appletinterface.cpp 60b7fa5 
> 
> Diff: https://git.reviewboard.kde.org/r/126463/diff/
> 
> 
> Testing
> ---
> 
> I can have custom tooltip item in digital clock without any artifacts
> while all other applets still have correct tooltips.
> 
> 
> Thanks,
> 
> Martin Klapetek
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 126463: Allow applets to set full ToolTip item

2015-12-21 Thread Kai Uwe Broulik 


> On Dez. 21, 2015, 10:39 nachm., David Edmundson wrote:
> > src/scriptengines/qml/plasmoid/appletinterface.h, line 407
> > 
> >
> > what would happen if the tooltipItem object gets deleted by the 
> > plasmoid after having set the object in the applet interface?

"deleted by the plasmoid" means deleted from QML means the QML engine will set 
the property to null, if I'm not mistaken?


- Kai Uwe


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126463/#review89868
---


On Dez. 21, 2015, 10:12 nachm., Martin Klapetek wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/126463/
> ---
> 
> (Updated Dez. 21, 2015, 10:12 nachm.)
> 
> 
> Review request for Plasma.
> 
> 
> Repository: plasma-framework
> 
> 
> Description
> ---
> 
> Adds new property available as Plasmoid.toolTipItem that allows
> to set a full custom item as the tooltip.
> 
> The main motivation is to have a custom Item tooltip for digital
> clock to properly format the list of timezones (version of
> https://git.reviewboard.kde.org/r/124047/). Adding a custom
> PlasmaCore.ToolTipArea to the compact representation does not
> work well because then it's a ToolTipArea nested inside another
> ToolTipArea (from CompactApplet.qml), this causes a sliding effect
> as it changes visual parents when hovering.
> 
> I dunno if this could perhaps be fixed, but seems redundant to have
> two ToolTipAreas anyway, so instead this exposes the main applet's
> ToolTipArea's mainItem property through Plasmoid.toolTipItem which
> the appelts can use to set a custom item.
> 
> This has a part2 patch which goes of plasma-desktop:
> https://git.reviewboard.kde.org/r/126464/
> 
> 
> Diffs
> -
> 
>   src/scriptengines/qml/plasmoid/appletinterface.h 40016b1 
>   src/scriptengines/qml/plasmoid/appletinterface.cpp 60b7fa5 
> 
> Diff: https://git.reviewboard.kde.org/r/126463/diff/
> 
> 
> Testing
> ---
> 
> I can have custom tooltip item in digital clock without any artifacts
> while all other applets still have correct tooltips.
> 
> 
> Thanks,
> 
> Martin Klapetek
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 126463: Allow applets to set full ToolTip item

2015-12-21 Thread David Edmundson 

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126463/#review89868
---



src/scriptengines/qml/plasmoid/appletinterface.h (line 407)


what would happen if the tooltipItem object gets deleted by the plasmoid 
after having set the object in the applet interface?


- David Edmundson


On Dec. 21, 2015, 10:12 p.m., Martin Klapetek wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/126463/
> ---
> 
> (Updated Dec. 21, 2015, 10:12 p.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Repository: plasma-framework
> 
> 
> Description
> ---
> 
> Adds new property available as Plasmoid.toolTipItem that allows
> to set a full custom item as the tooltip.
> 
> The main motivation is to have a custom Item tooltip for digital
> clock to properly format the list of timezones (version of
> https://git.reviewboard.kde.org/r/124047/). Adding a custom
> PlasmaCore.ToolTipArea to the compact representation does not
> work well because then it's a ToolTipArea nested inside another
> ToolTipArea (from CompactApplet.qml), this causes a sliding effect
> as it changes visual parents when hovering.
> 
> I dunno if this could perhaps be fixed, but seems redundant to have
> two ToolTipAreas anyway, so instead this exposes the main applet's
> ToolTipArea's mainItem property through Plasmoid.toolTipItem which
> the appelts can use to set a custom item.
> 
> This has a part2 patch which goes of plasma-desktop:
> https://git.reviewboard.kde.org/r/126464/
> 
> 
> Diffs
> -
> 
>   src/scriptengines/qml/plasmoid/appletinterface.h 40016b1 
>   src/scriptengines/qml/plasmoid/appletinterface.cpp 60b7fa5 
> 
> Diff: https://git.reviewboard.kde.org/r/126463/diff/
> 
> 
> Testing
> ---
> 
> I can have custom tooltip item in digital clock without any artifacts
> while all other applets still have correct tooltips.
> 
> 
> Thanks,
> 
> Martin Klapetek
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 126463: Allow applets to set full ToolTip item

2015-12-21 Thread Kai Uwe Broulik 

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126463/#review89867
---


+1


src/scriptengines/qml/plasmoid/appletinterface.h (line 109)


QQuickItem?



src/scriptengines/qml/plasmoid/appletinterface.cpp (line 354)


QObject *AppletInterface::toolTipItem() const


- Kai Uwe Broulik


On Dez. 21, 2015, 10:12 nachm., Martin Klapetek wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/126463/
> ---
> 
> (Updated Dez. 21, 2015, 10:12 nachm.)
> 
> 
> Review request for Plasma.
> 
> 
> Repository: plasma-framework
> 
> 
> Description
> ---
> 
> Adds new property available as Plasmoid.toolTipItem that allows
> to set a full custom item as the tooltip.
> 
> The main motivation is to have a custom Item tooltip for digital
> clock to properly format the list of timezones (version of
> https://git.reviewboard.kde.org/r/124047/). Adding a custom
> PlasmaCore.ToolTipArea to the compact representation does not
> work well because then it's a ToolTipArea nested inside another
> ToolTipArea (from CompactApplet.qml), this causes a sliding effect
> as it changes visual parents when hovering.
> 
> I dunno if this could perhaps be fixed, but seems redundant to have
> two ToolTipAreas anyway, so instead this exposes the main applet's
> ToolTipArea's mainItem property through Plasmoid.toolTipItem which
> the appelts can use to set a custom item.
> 
> This has a part2 patch which goes of plasma-desktop:
> https://git.reviewboard.kde.org/r/126464/
> 
> 
> Diffs
> -
> 
>   src/scriptengines/qml/plasmoid/appletinterface.h 40016b1 
>   src/scriptengines/qml/plasmoid/appletinterface.cpp 60b7fa5 
> 
> Diff: https://git.reviewboard.kde.org/r/126463/diff/
> 
> 
> Testing
> ---
> 
> I can have custom tooltip item in digital clock without any artifacts
> while all other applets still have correct tooltips.
> 
> 
> Thanks,
> 
> Martin Klapetek
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Review Request 126463: Allow applets to set full ToolTip item

2015-12-21 Thread Martin Klapetek 

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126463/
---

Review request for Plasma.


Repository: plasma-framework


Description
---

Adds new property available as Plasmoid.toolTipItem that allows
to set a full custom item as the tooltip.

The main motivation is to have a custom Item tooltip for digital
clock to properly format the list of timezones (version of
https://git.reviewboard.kde.org/r/124047/). Adding a custom
PlasmaCore.ToolTipArea to the compact representation does not
work well because then it's a ToolTipArea nested inside another
ToolTipArea (from CompactApplet.qml), this causes a sliding effect
as it changes visual parents when hovering.

I dunno if this could perhaps be fixed, but seems redundant to have
two ToolTipAreas anyway, so instead this exposes the main applet's
ToolTipArea's mainItem property through Plasmoid.toolTipItem which
the appelts can use to set a custom item.

This has a part2 patch which goes of plasma-desktop:
https://git.reviewboard.kde.org/r/126464/


Diffs
-

  src/scriptengines/qml/plasmoid/appletinterface.h 40016b1 
  src/scriptengines/qml/plasmoid/appletinterface.cpp 60b7fa5 

Diff: https://git.reviewboard.kde.org/r/126463/diff/


Testing
---

I can have custom tooltip item in digital clock without any artifacts
while all other applets still have correct tooltips.


Thanks,

Martin Klapetek

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel