Re: Review Request 126573: Don't duplicate checking content length is within user set bounds
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126573/ --- (Updated Dec. 30, 2015, 4:11 p.m.) Status -- This change has been marked as submitted. Review request for Plasma. Changes --- Submitted with commit ba733d16fb2849b2b2cc390ed89b5200dffb5c3f by David Edmundson to branch master. Repository: plasma-desktop Description --- This is done by PanelView, we should not be doing the same thing twice. Longer term means we can use length to refer to the content implicitWidth and not the current panel width and resize whilst we are dragging the min sliders. Diffs - desktoppackage/contents/views/Panel.qml a85a79ec9fda41c6ac8efd76a9fc7094d3a46537 Diff: https://git.reviewboard.kde.org/r/126573/diff/ Testing --- Thanks, David Edmundson ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Review Request 126573: Don't duplicate checking content length is within user set bounds
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126573/ --- Review request for Plasma. Repository: plasma-desktop Description --- This is done by PanelView, we should not be doing the same thing twice. Longer term means we can use length to refer to the content implicitWidth and not the current panel width and resize whilst we are dragging the min sliders. Diffs - desktoppackage/contents/views/Panel.qml a85a79ec9fda41c6ac8efd76a9fc7094d3a46537 Diff: https://git.reviewboard.kde.org/r/126573/diff/ Testing --- Thanks, David Edmundson ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 126573: Don't duplicate checking content length is within user set bounds
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126573/#review90336 --- Ship it! Ship It! - Aleix Pol Gonzalez On Dec. 30, 2015, 12:46 p.m., David Edmundson wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/126573/ > --- > > (Updated Dec. 30, 2015, 12:46 p.m.) > > > Review request for Plasma. > > > Repository: plasma-desktop > > > Description > --- > > This is done by PanelView, we should not be doing the same thing twice. > > Longer term means we can use length to refer to the content implicitWidth and > not the current panel width and resize whilst we are dragging the min sliders. > > > Diffs > - > > desktoppackage/contents/views/Panel.qml > a85a79ec9fda41c6ac8efd76a9fc7094d3a46537 > > Diff: https://git.reviewboard.kde.org/r/126573/diff/ > > > Testing > --- > > > Thanks, > > David Edmundson > > ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
