Re: Review Request 126579: [Kickoff/Kicker] Extract underlying URL from search result

2016-01-04 Thread Kai Uwe Broulik

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126579/
---

(Updated Jan. 4, 2016, 11:13 p.m.)


Status
--

This change has been marked as submitted.


Review request for Plasma and Eike Hein.


Changes
---

Submitted with commit 30ab223050d1d57b5fb81de366dbb89e6e67a21c by Kai Uwe 
Broulik to branch master.


Bugs: 355808
https://bugs.kde.org/show_bug.cgi?id=355808


Repository: plasma-desktop


Description
---

This enables drag and drop for favorites


Diffs
-

  applets/kicker/plugin/runnermatchesmodel.cpp b6b1b0f 

Diff: https://git.reviewboard.kde.org/r/126579/diff/


Testing
---

Dragged application to my desktop: got an icon widget
Dragged recent document to my desktop: got an icon widget
Dragged a random text document to my desktop: got an icon widget

Probably not optimal querying KService all the time?


Thanks,

Kai Uwe Broulik

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel


Re: Review Request 126579: [Kickoff/Kicker] Extract underlying URL from search result

2016-01-04 Thread Eike Hein

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126579/#review90603
---

Ship it!


Ship It!

- Eike Hein


On Jan. 1, 2016, 5:47 p.m., Kai Uwe Broulik wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/126579/
> ---
> 
> (Updated Jan. 1, 2016, 5:47 p.m.)
> 
> 
> Review request for Plasma and Eike Hein.
> 
> 
> Bugs: 355808
> https://bugs.kde.org/show_bug.cgi?id=355808
> 
> 
> Repository: plasma-desktop
> 
> 
> Description
> ---
> 
> This enables drag and drop for favorites
> 
> 
> Diffs
> -
> 
>   applets/kicker/plugin/runnermatchesmodel.cpp b6b1b0f 
> 
> Diff: https://git.reviewboard.kde.org/r/126579/diff/
> 
> 
> Testing
> ---
> 
> Dragged application to my desktop: got an icon widget
> Dragged recent document to my desktop: got an icon widget
> Dragged a random text document to my desktop: got an icon widget
> 
> Probably not optimal querying KService all the time?
> 
> 
> Thanks,
> 
> Kai Uwe Broulik
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel


Re: Review Request 126579: [Kickoff/Kicker] Extract underlying URL from search result

2016-01-01 Thread Kai Uwe Broulik

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126579/
---

(Updated Jan. 1, 2016, 5:47 nachm.)


Review request for Plasma and Eike Hein.


Bugs: 355808
https://bugs.kde.org/show_bug.cgi?id=355808


Repository: plasma-desktop


Description
---

This enables drag and drop for favorites


Diffs
-

  applets/kicker/plugin/runnermatchesmodel.cpp b6b1b0f 

Diff: https://git.reviewboard.kde.org/r/126579/diff/


Testing
---

Dragged application to my desktop: got an icon widget
Dragged recent document to my desktop: got an icon widget
Dragged a random text document to my desktop: got an icon widget

Probably not optimal querying KService all the time?


Thanks,

Kai Uwe Broulik

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel


Re: Review Request 126579: [Kickoff/Kicker] Extract underlying URL from search result

2015-12-30 Thread David Edmundson

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126579/#review90359
---


+1

- David Edmundson


On Dec. 30, 2015, 7:09 p.m., Kai Uwe Broulik wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/126579/
> ---
> 
> (Updated Dec. 30, 2015, 7:09 p.m.)
> 
> 
> Review request for Plasma and Eike Hein.
> 
> 
> Repository: plasma-desktop
> 
> 
> Description
> ---
> 
> This enables drag and drop for favorites
> 
> 
> Diffs
> -
> 
>   applets/kicker/plugin/runnermatchesmodel.cpp b6b1b0f 
> 
> Diff: https://git.reviewboard.kde.org/r/126579/diff/
> 
> 
> Testing
> ---
> 
> Dragged application to my desktop: got an icon widget
> Dragged recent document to my desktop: got an icon widget
> Dragged a random text document to my desktop: got an icon widget
> 
> Probably not optimal querying KService all the time?
> 
> 
> Thanks,
> 
> Kai Uwe Broulik
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel


Review Request 126579: [Kickoff/Kicker] Extract underlying URL from search result

2015-12-30 Thread Kai Uwe Broulik

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126579/
---

Review request for Plasma and Eike Hein.


Repository: plasma-desktop


Description
---

This enables drag and drop for favorites


Diffs
-

  applets/kicker/plugin/runnermatchesmodel.cpp b6b1b0f 

Diff: https://git.reviewboard.kde.org/r/126579/diff/


Testing
---

Dragged application to my desktop: got an icon widget
Dragged recent document to my desktop: got an icon widget
Dragged a random text document to my desktop: got an icon widget

Probably not optimal querying KService all the time?


Thanks,

Kai Uwe Broulik

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel