Re: Review Request 127071: ButtonStyle: Fix text alignment with minimumWidth

[David Rosca]

> On Feb. 14, 2016, 10:34 p.m., Aleix Pol Gonzalez wrote:
> > src/declarativeimports/plasmastyle/ButtonStyle.qml, line 83
> > 
> >
> > Looks bound to implode, I'd rather specify the minimumWith as a 
> > property, for every case.

That doesn't work as it creates binding loop, which makes the text alignment 
completely broken.

But maybe it would be better to add new property to Button, something like 
`resizeToContents` instead of using `implicitWidth: minimumWidth`.


- David


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127071/#review92366
---


On Feb. 13, 2016, 11:23 p.m., David Rosca wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/127071/
> ---
> 
> (Updated Feb. 13, 2016, 11:23 p.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Repository: plasma-framework
> 
> 
> Description
> ---
> 
> Fix text alignment with buttons that sets implicitWidth
> to minimumWidth.
> 
> 
> Diffs
> -
> 
>   src/declarativeimports/plasmastyle/ButtonStyle.qml a962512 
>   tests/components/button.qml a645537 
> 
> Diff: https://git.reviewboard.kde.org/r/127071/diff/
> 
> 
> Testing
> ---
> 
> Direct binding causes binding loop. I'm not really sure on the fix though as 
> it's quite ugly.
> 
> To reproduce the bug, press "-" in button test.
> 
> 
> Thanks,
> 
> David Rosca
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 127071: ButtonStyle: Fix text alignment with minimumWidth

[Aleix Pol Gonzalez]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127071/#review92366
---




src/declarativeimports/plasmastyle/ButtonStyle.qml (line 83)


Looks bound to implode, I'd rather specify the minimumWith as a property, 
for every case.


- Aleix Pol Gonzalez


On Feb. 14, 2016, 12:23 a.m., David Rosca wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/127071/
> ---
> 
> (Updated Feb. 14, 2016, 12:23 a.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Repository: plasma-framework
> 
> 
> Description
> ---
> 
> Fix text alignment with buttons that sets implicitWidth
> to minimumWidth.
> 
> 
> Diffs
> -
> 
>   src/declarativeimports/plasmastyle/ButtonStyle.qml a962512 
>   tests/components/button.qml a645537 
> 
> Diff: https://git.reviewboard.kde.org/r/127071/diff/
> 
> 
> Testing
> ---
> 
> Direct binding causes binding loop. I'm not really sure on the fix though as 
> it's quite ugly.
> 
> To reproduce the bug, press "-" in button test.
> 
> 
> Thanks,
> 
> David Rosca
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Review Request 127071: ButtonStyle: Fix text alignment with minimumWidth

[David Rosca]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127071/
---

Review request for Plasma.


Repository: plasma-framework


Description
---

Fix text alignment with buttons that sets implicitWidth
to minimumWidth.


Diffs
-

  src/declarativeimports/plasmastyle/ButtonStyle.qml a962512 
  tests/components/button.qml a645537 

Diff: https://git.reviewboard.kde.org/r/127071/diff/


Testing
---

Direct binding causes binding loop. I'm not really sure on the fix though as 
it's quite ugly.

To reproduce the bug, press "-" in button test.


Thanks,

David Rosca

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel