Re: Review Request 127079: fix uninitialised var

2016-02-23 Thread David Edmundson 

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127079/
---

(Updated Feb. 23, 2016, 2:07 p.m.)


Status
--

This change has been marked as submitted.


Review request for KDE Frameworks and Plasma.


Changes
---

Submitted with commit 73aa13b26da3a79fa861ec54509c6c0710b2e020 by David 
Edmundson to branch master.


Repository: plasma-framework


Description
---

Valgrind pointed this out whilst debugging something else.

(though I'm not sure what on the desktop creates an Application object)


Diffs
-

  src/declarativeimports/platformcomponents/application.cpp 
a3aecc4a13541d41136fd0b34e58b3107eda060f 

Diff: https://git.reviewboard.kde.org/r/127079/diff/


Testing
---


Thanks,

David Edmundson

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 127079: fix uninitialised var

2016-02-19 Thread Milian Wolff 

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127079/#review92574
---


Ship it!




Ship It!

- Milian Wolff


On Feb. 19, 2016, 11:46 a.m., David Edmundson wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/127079/
> ---
> 
> (Updated Feb. 19, 2016, 11:46 a.m.)
> 
> 
> Review request for KDE Frameworks and Plasma.
> 
> 
> Repository: plasma-framework
> 
> 
> Description
> ---
> 
> Valgrind pointed this out whilst debugging something else.
> 
> (though I'm not sure what on the desktop creates an Application object)
> 
> 
> Diffs
> -
> 
>   src/declarativeimports/platformcomponents/application.cpp 
> a3aecc4a13541d41136fd0b34e58b3107eda060f 
> 
> Diff: https://git.reviewboard.kde.org/r/127079/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> David Edmundson
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 127079: fix uninitialised var

2016-02-19 Thread David Edmundson 

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127079/
---

(Updated Feb. 19, 2016, 11:46 a.m.)


Review request for KDE Frameworks and Plasma.


Repository: plasma-framework


Description
---

Valgrind pointed this out whilst debugging something else.

(though I'm not sure what on the desktop creates an Application object)


Diffs (updated)
-

  src/declarativeimports/platformcomponents/application.cpp 
a3aecc4a13541d41136fd0b34e58b3107eda060f 

Diff: https://git.reviewboard.kde.org/r/127079/diff/


Testing
---


Thanks,

David Edmundson

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 127079: fix uninitialised var

2016-02-15 Thread Kai Uwe Broulik 

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127079/#review92411
---




src/declarativeimports/platformcomponents/application_p.h (line 35)


We can't do this in Frameworks


- Kai Uwe Broulik


On Feb. 15, 2016, 5:23 nachm., David Edmundson wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/127079/
> ---
> 
> (Updated Feb. 15, 2016, 5:23 nachm.)
> 
> 
> Review request for KDE Frameworks and Plasma.
> 
> 
> Repository: plasma-framework
> 
> 
> Description
> ---
> 
> Valgrind pointed this out whilst debugging something else.
> 
> (though I'm not sure what on the desktop creates an Application object)
> 
> 
> Diffs
> -
> 
>   src/declarativeimports/platformcomponents/application_p.h 
> 8e690928c2a4a0d3da983cb385e50e0e9e9d66e9 
> 
> Diff: https://git.reviewboard.kde.org/r/127079/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> David Edmundson
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Review Request 127079: fix uninitialised var

2016-02-15 Thread David Edmundson 

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127079/
---

Review request for KDE Frameworks and Plasma.


Repository: plasma-framework


Description
---

Valgrind pointed this out whilst debugging something else.

(though I'm not sure what on the desktop creates an Application object)


Diffs
-

  src/declarativeimports/platformcomponents/application_p.h 
8e690928c2a4a0d3da983cb385e50e0e9e9d66e9 

Diff: https://git.reviewboard.kde.org/r/127079/diff/


Testing
---


Thanks,

David Edmundson

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel