Re: Review Request 128040: [shellcorona] Containment can be nullptr

[Anthony Fieroni]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128040/
---

(Updated Юни 15, 2016, 12:49 след обяд)


Status
--

This change has been discarded.


Review request for Plasma, Aleix Pol Gonzalez and David Edmundson.


Bugs: 361548
https://bugs.kde.org/show_bug.cgi?id=361548


Repository: plasma-workspace


Description
---

I can't reproduce this tons of bug reports and i event can't undertaind how 
containment can be nullptr, when i see corona.cpp 
http://api.kde.org/frameworks/plasma-framework/html/corona_8cpp_source.html#l00447


Diffs
-

  shell/shellcorona.cpp 2a78ca9 

Diff: https://git.reviewboard.kde.org/r/128040/diff/


Testing
---

To stop crash ?!


Thanks,

Anthony Fieroni

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 128040: [shellcorona] Containment can be nullptr

[Marco Martin]

> On May 30, 2016, 11:32 a.m., Aleix Pol Gonzalez wrote:
> > Could you look a bit into why is the containment null?
> 
> Anthony Fieroni wrote:
> So i can speculate, because i have 2 Samsung TV, 1 smart, 1 LCD and i 
> can't reproduce crash, KScreen is not finish recognazing, which i write 
> above, corona.cpp:211 if (screen >= 0 && screen < numScreens()) is not 
> satisfied for some reason and returning containment is nullptr. I can't 
> figure out any other possible way.
> 
> Aleix Pol Gonzalez wrote:
> But `createContainmentForActivity` should return a containment 
> nevertheless, it's not related to KScreen after all.
> 
> Marco Martin wrote:
> so may the issue go away with the port to qscreen?
> 
> Anthony Fieroni wrote:
> createContainmentForActivity calls containmentForScreen() from corona 
> which use numScreen() overridden in shellCorona and depend on KScreen 
> configuration. So for me is KScreen related.
> 
> David Edmundson wrote:
> >so may the issue go away with the port to qscreen?
> 
> It should do.
> 
> It's a continuation of https://bugs.kde.org/show_bug.cgi?id=351777 
> 
> there I list the events which cause the crash:
> 
> >Corona.cpp checks we are requesting a containment for a valid screen if 
> (screen >= 0 && screen < numScreens()) {
> 
> >This fails as numScreens() is Qt API based, whereas the signal we're 
> adding the output for is ShellCorona::addOutput
> 
> If Qt proceses the DBus event before we get the X event. You're out of 
> sync.
> (note they weren't in Plasma 5.0,it changed in ~5.2 when the XCB backend 
> for kscreen was split into a separate process)
> 
> I fixed the case of them being out of sync at startup which was the main 
> time we got the crash, but it still apparently happens on unplugging/plugging 
> in a monitor.
> 
> As for this patch; sure you'll stop a crash, but you'll leave those 
> setups that would have crashed with a blank screen on the monitor they've 
> just plugged in.
> 
> Anthony Fieroni wrote:
> *but you'll leave those setups that would have crashed with a blank 
> screen*
> 
> Are you sure about that? So i'm not, still think KScreen has a false 
> positive signals, i.e. he will be done with screen recognazing
> 
> David Edmundson wrote:
> doesn't really matter: https://git.reviewboard.kde.org/r/125451/ is 
> submitted and fixes the root cause.

this should be discarded then


- Marco


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128040/#review96027
---


On May 30, 2016, 4:33 a.m., Anthony Fieroni wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/128040/
> ---
> 
> (Updated May 30, 2016, 4:33 a.m.)
> 
> 
> Review request for Plasma, Aleix Pol Gonzalez and David Edmundson.
> 
> 
> Bugs: 361548
> https://bugs.kde.org/show_bug.cgi?id=361548
> 
> 
> Repository: plasma-workspace
> 
> 
> Description
> ---
> 
> I can't reproduce this tons of bug reports and i event can't undertaind how 
> containment can be nullptr, when i see corona.cpp 
> http://api.kde.org/frameworks/plasma-framework/html/corona_8cpp_source.html#l00447
> 
> 
> Diffs
> -
> 
>   shell/shellcorona.cpp 2a78ca9 
> 
> Diff: https://git.reviewboard.kde.org/r/128040/diff/
> 
> 
> Testing
> ---
> 
> To stop crash ?!
> 
> 
> Thanks,
> 
> Anthony Fieroni
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 128040: [shellcorona] Containment can be nullptr

[David Edmundson]

> On May 30, 2016, 11:32 a.m., Aleix Pol Gonzalez wrote:
> > Could you look a bit into why is the containment null?
> 
> Anthony Fieroni wrote:
> So i can speculate, because i have 2 Samsung TV, 1 smart, 1 LCD and i 
> can't reproduce crash, KScreen is not finish recognazing, which i write 
> above, corona.cpp:211 if (screen >= 0 && screen < numScreens()) is not 
> satisfied for some reason and returning containment is nullptr. I can't 
> figure out any other possible way.
> 
> Aleix Pol Gonzalez wrote:
> But `createContainmentForActivity` should return a containment 
> nevertheless, it's not related to KScreen after all.
> 
> Marco Martin wrote:
> so may the issue go away with the port to qscreen?
> 
> Anthony Fieroni wrote:
> createContainmentForActivity calls containmentForScreen() from corona 
> which use numScreen() overridden in shellCorona and depend on KScreen 
> configuration. So for me is KScreen related.
> 
> David Edmundson wrote:
> >so may the issue go away with the port to qscreen?
> 
> It should do.
> 
> It's a continuation of https://bugs.kde.org/show_bug.cgi?id=351777 
> 
> there I list the events which cause the crash:
> 
> >Corona.cpp checks we are requesting a containment for a valid screen if 
> (screen >= 0 && screen < numScreens()) {
> 
> >This fails as numScreens() is Qt API based, whereas the signal we're 
> adding the output for is ShellCorona::addOutput
> 
> If Qt proceses the DBus event before we get the X event. You're out of 
> sync.
> (note they weren't in Plasma 5.0,it changed in ~5.2 when the XCB backend 
> for kscreen was split into a separate process)
> 
> I fixed the case of them being out of sync at startup which was the main 
> time we got the crash, but it still apparently happens on unplugging/plugging 
> in a monitor.
> 
> As for this patch; sure you'll stop a crash, but you'll leave those 
> setups that would have crashed with a blank screen on the monitor they've 
> just plugged in.
> 
> Anthony Fieroni wrote:
> *but you'll leave those setups that would have crashed with a blank 
> screen*
> 
> Are you sure about that? So i'm not, still think KScreen has a false 
> positive signals, i.e. he will be done with screen recognazing

doesn't really matter: https://git.reviewboard.kde.org/r/125451/ is submitted 
and fixes the root cause.


- David


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128040/#review96027
---


On May 30, 2016, 4:33 a.m., Anthony Fieroni wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/128040/
> ---
> 
> (Updated May 30, 2016, 4:33 a.m.)
> 
> 
> Review request for Plasma, Aleix Pol Gonzalez and David Edmundson.
> 
> 
> Bugs: 361548
> https://bugs.kde.org/show_bug.cgi?id=361548
> 
> 
> Repository: plasma-workspace
> 
> 
> Description
> ---
> 
> I can't reproduce this tons of bug reports and i event can't undertaind how 
> containment can be nullptr, when i see corona.cpp 
> http://api.kde.org/frameworks/plasma-framework/html/corona_8cpp_source.html#l00447
> 
> 
> Diffs
> -
> 
>   shell/shellcorona.cpp 2a78ca9 
> 
> Diff: https://git.reviewboard.kde.org/r/128040/diff/
> 
> 
> Testing
> ---
> 
> To stop crash ?!
> 
> 
> Thanks,
> 
> Anthony Fieroni
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 128040: [shellcorona] Containment can be nullptr

[Anthony Fieroni]

> On Май 30, 2016, 2:32 след обяд, Aleix Pol Gonzalez wrote:
> > Could you look a bit into why is the containment null?
> 
> Anthony Fieroni wrote:
> So i can speculate, because i have 2 Samsung TV, 1 smart, 1 LCD and i 
> can't reproduce crash, KScreen is not finish recognazing, which i write 
> above, corona.cpp:211 if (screen >= 0 && screen < numScreens()) is not 
> satisfied for some reason and returning containment is nullptr. I can't 
> figure out any other possible way.
> 
> Aleix Pol Gonzalez wrote:
> But `createContainmentForActivity` should return a containment 
> nevertheless, it's not related to KScreen after all.
> 
> Marco Martin wrote:
> so may the issue go away with the port to qscreen?
> 
> Anthony Fieroni wrote:
> createContainmentForActivity calls containmentForScreen() from corona 
> which use numScreen() overridden in shellCorona and depend on KScreen 
> configuration. So for me is KScreen related.
> 
> David Edmundson wrote:
> >so may the issue go away with the port to qscreen?
> 
> It should do.
> 
> It's a continuation of https://bugs.kde.org/show_bug.cgi?id=351777 
> 
> there I list the events which cause the crash:
> 
> >Corona.cpp checks we are requesting a containment for a valid screen if 
> (screen >= 0 && screen < numScreens()) {
> 
> >This fails as numScreens() is Qt API based, whereas the signal we're 
> adding the output for is ShellCorona::addOutput
> 
> If Qt proceses the DBus event before we get the X event. You're out of 
> sync.
> (note they weren't in Plasma 5.0,it changed in ~5.2 when the XCB backend 
> for kscreen was split into a separate process)
> 
> I fixed the case of them being out of sync at startup which was the main 
> time we got the crash, but it still apparently happens on unplugging/plugging 
> in a monitor.
> 
> As for this patch; sure you'll stop a crash, but you'll leave those 
> setups that would have crashed with a blank screen on the monitor they've 
> just plugged in.

*but you'll leave those setups that would have crashed with a blank screen*

Are you sure about that? So i'm not, still think KScreen has a false positive 
signals, i.e. he will be done with screen recognazing


- Anthony


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128040/#review96027
---


On Май 30, 2016, 7:33 преди обяд, Anthony Fieroni wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/128040/
> ---
> 
> (Updated Май 30, 2016, 7:33 преди обяд)
> 
> 
> Review request for Plasma, Aleix Pol Gonzalez and David Edmundson.
> 
> 
> Bugs: 361548
> https://bugs.kde.org/show_bug.cgi?id=361548
> 
> 
> Repository: plasma-workspace
> 
> 
> Description
> ---
> 
> I can't reproduce this tons of bug reports and i event can't undertaind how 
> containment can be nullptr, when i see corona.cpp 
> http://api.kde.org/frameworks/plasma-framework/html/corona_8cpp_source.html#l00447
> 
> 
> Diffs
> -
> 
>   shell/shellcorona.cpp 2a78ca9 
> 
> Diff: https://git.reviewboard.kde.org/r/128040/diff/
> 
> 
> Testing
> ---
> 
> To stop crash ?!
> 
> 
> Thanks,
> 
> Anthony Fieroni
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 128040: [shellcorona] Containment can be nullptr

[David Edmundson]

> On May 30, 2016, 11:32 a.m., Aleix Pol Gonzalez wrote:
> > Could you look a bit into why is the containment null?
> 
> Anthony Fieroni wrote:
> So i can speculate, because i have 2 Samsung TV, 1 smart, 1 LCD and i 
> can't reproduce crash, KScreen is not finish recognazing, which i write 
> above, corona.cpp:211 if (screen >= 0 && screen < numScreens()) is not 
> satisfied for some reason and returning containment is nullptr. I can't 
> figure out any other possible way.
> 
> Aleix Pol Gonzalez wrote:
> But `createContainmentForActivity` should return a containment 
> nevertheless, it's not related to KScreen after all.
> 
> Marco Martin wrote:
> so may the issue go away with the port to qscreen?
> 
> Anthony Fieroni wrote:
> createContainmentForActivity calls containmentForScreen() from corona 
> which use numScreen() overridden in shellCorona and depend on KScreen 
> configuration. So for me is KScreen related.

>so may the issue go away with the port to qscreen?

It should do.

It's a continuation of https://bugs.kde.org/show_bug.cgi?id=351777 

there I list the events which cause the crash:

>Corona.cpp checks we are requesting a containment for a valid screen if 
>(screen >= 0 && screen < numScreens()) {

>This fails as numScreens() is Qt API based, whereas the signal we're adding 
>the output for is ShellCorona::addOutput

If Qt proceses the DBus event before we get the X event. You're out of sync.
(note they weren't in Plasma 5.0,it changed in ~5.2 when the XCB backend for 
kscreen was split into a separate process)

I fixed the case of them being out of sync at startup which was the main time 
we got the crash, but it still apparently happens on unplugging/plugging in a 
monitor.

As for this patch; sure you'll stop a crash, but you'll leave those setups that 
would have crashed with a blank screen on the monitor they've just plugged in.


- David


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128040/#review96027
---


On May 30, 2016, 4:33 a.m., Anthony Fieroni wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/128040/
> ---
> 
> (Updated May 30, 2016, 4:33 a.m.)
> 
> 
> Review request for Plasma, Aleix Pol Gonzalez and David Edmundson.
> 
> 
> Bugs: 361548
> https://bugs.kde.org/show_bug.cgi?id=361548
> 
> 
> Repository: plasma-workspace
> 
> 
> Description
> ---
> 
> I can't reproduce this tons of bug reports and i event can't undertaind how 
> containment can be nullptr, when i see corona.cpp 
> http://api.kde.org/frameworks/plasma-framework/html/corona_8cpp_source.html#l00447
> 
> 
> Diffs
> -
> 
>   shell/shellcorona.cpp 2a78ca9 
> 
> Diff: https://git.reviewboard.kde.org/r/128040/diff/
> 
> 
> Testing
> ---
> 
> To stop crash ?!
> 
> 
> Thanks,
> 
> Anthony Fieroni
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 128040: [shellcorona] Containment can be nullptr

[Anthony Fieroni]

> On Май 30, 2016, 2:32 след обяд, Aleix Pol Gonzalez wrote:
> > Could you look a bit into why is the containment null?
> 
> Anthony Fieroni wrote:
> So i can speculate, because i have 2 Samsung TV, 1 smart, 1 LCD and i 
> can't reproduce crash, KScreen is not finish recognazing, which i write 
> above, corona.cpp:211 if (screen >= 0 && screen < numScreens()) is not 
> satisfied for some reason and returning containment is nullptr. I can't 
> figure out any other possible way.
> 
> Aleix Pol Gonzalez wrote:
> But `createContainmentForActivity` should return a containment 
> nevertheless, it's not related to KScreen after all.
> 
> Marco Martin wrote:
> so may the issue go away with the port to qscreen?

createContainmentForActivity calls containmentForScreen() from corona which use 
numScreen() overridden in shellCorona and depend on KScreen configuration. So 
for me is KScreen related.


- Anthony


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128040/#review96027
---


On Май 30, 2016, 7:33 преди обяд, Anthony Fieroni wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/128040/
> ---
> 
> (Updated Май 30, 2016, 7:33 преди обяд)
> 
> 
> Review request for Plasma, Aleix Pol Gonzalez and David Edmundson.
> 
> 
> Bugs: 361548
> https://bugs.kde.org/show_bug.cgi?id=361548
> 
> 
> Repository: plasma-workspace
> 
> 
> Description
> ---
> 
> I can't reproduce this tons of bug reports and i event can't undertaind how 
> containment can be nullptr, when i see corona.cpp 
> http://api.kde.org/frameworks/plasma-framework/html/corona_8cpp_source.html#l00447
> 
> 
> Diffs
> -
> 
>   shell/shellcorona.cpp 2a78ca9 
> 
> Diff: https://git.reviewboard.kde.org/r/128040/diff/
> 
> 
> Testing
> ---
> 
> To stop crash ?!
> 
> 
> Thanks,
> 
> Anthony Fieroni
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 128040: [shellcorona] Containment can be nullptr

[Marco Martin]

> On May 30, 2016, 11:32 a.m., Aleix Pol Gonzalez wrote:
> > Could you look a bit into why is the containment null?
> 
> Anthony Fieroni wrote:
> So i can speculate, because i have 2 Samsung TV, 1 smart, 1 LCD and i 
> can't reproduce crash, KScreen is not finish recognazing, which i write 
> above, corona.cpp:211 if (screen >= 0 && screen < numScreens()) is not 
> satisfied for some reason and returning containment is nullptr. I can't 
> figure out any other possible way.
> 
> Aleix Pol Gonzalez wrote:
> But `createContainmentForActivity` should return a containment 
> nevertheless, it's not related to KScreen after all.

so may the issue go away with the port to qscreen?


- Marco


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128040/#review96027
---


On May 30, 2016, 4:33 a.m., Anthony Fieroni wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/128040/
> ---
> 
> (Updated May 30, 2016, 4:33 a.m.)
> 
> 
> Review request for Plasma, Aleix Pol Gonzalez and David Edmundson.
> 
> 
> Bugs: 361548
> https://bugs.kde.org/show_bug.cgi?id=361548
> 
> 
> Repository: plasma-workspace
> 
> 
> Description
> ---
> 
> I can't reproduce this tons of bug reports and i event can't undertaind how 
> containment can be nullptr, when i see corona.cpp 
> http://api.kde.org/frameworks/plasma-framework/html/corona_8cpp_source.html#l00447
> 
> 
> Diffs
> -
> 
>   shell/shellcorona.cpp 2a78ca9 
> 
> Diff: https://git.reviewboard.kde.org/r/128040/diff/
> 
> 
> Testing
> ---
> 
> To stop crash ?!
> 
> 
> Thanks,
> 
> Anthony Fieroni
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 128040: [shellcorona] Containment can be nullptr

[Aleix Pol Gonzalez]

> On May 30, 2016, 1:32 p.m., Aleix Pol Gonzalez wrote:
> > Could you look a bit into why is the containment null?
> 
> Anthony Fieroni wrote:
> So i can speculate, because i have 2 Samsung TV, 1 smart, 1 LCD and i 
> can't reproduce crash, KScreen is not finish recognazing, which i write 
> above, corona.cpp:211 if (screen >= 0 && screen < numScreens()) is not 
> satisfied for some reason and returning containment is nullptr. I can't 
> figure out any other possible way.

But `createContainmentForActivity` should return a containment nevertheless, 
it's not related to KScreen after all.


- Aleix


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128040/#review96027
---


On May 30, 2016, 6:33 a.m., Anthony Fieroni wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/128040/
> ---
> 
> (Updated May 30, 2016, 6:33 a.m.)
> 
> 
> Review request for Plasma, Aleix Pol Gonzalez and David Edmundson.
> 
> 
> Bugs: 361548
> https://bugs.kde.org/show_bug.cgi?id=361548
> 
> 
> Repository: plasma-workspace
> 
> 
> Description
> ---
> 
> I can't reproduce this tons of bug reports and i event can't undertaind how 
> containment can be nullptr, when i see corona.cpp 
> http://api.kde.org/frameworks/plasma-framework/html/corona_8cpp_source.html#l00447
> 
> 
> Diffs
> -
> 
>   shell/shellcorona.cpp 2a78ca9 
> 
> Diff: https://git.reviewboard.kde.org/r/128040/diff/
> 
> 
> Testing
> ---
> 
> To stop crash ?!
> 
> 
> Thanks,
> 
> Anthony Fieroni
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 128040: [shellcorona] Containment can be nullptr

[Anthony Fieroni]

> On Май 30, 2016, 2:32 след обяд, Aleix Pol Gonzalez wrote:
> > Could you look a bit into why is the containment null?

So i can speculate, because i have 2 Samsung TV, 1 smart, 1 LCD and i can't 
reproduce crash, KScreen is not finish recognazing, which i write above, 
corona.cpp:211 if (screen >= 0 && screen < numScreens()) is not satisfied for 
some reason and returning containment is nullptr. I can't figure out any other 
possible way.


- Anthony


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128040/#review96027
---


On Май 30, 2016, 7:33 преди обяд, Anthony Fieroni wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/128040/
> ---
> 
> (Updated Май 30, 2016, 7:33 преди обяд)
> 
> 
> Review request for Plasma, Aleix Pol Gonzalez and David Edmundson.
> 
> 
> Bugs: 361548
> https://bugs.kde.org/show_bug.cgi?id=361548
> 
> 
> Repository: plasma-workspace
> 
> 
> Description
> ---
> 
> I can't reproduce this tons of bug reports and i event can't undertaind how 
> containment can be nullptr, when i see corona.cpp 
> http://api.kde.org/frameworks/plasma-framework/html/corona_8cpp_source.html#l00447
> 
> 
> Diffs
> -
> 
>   shell/shellcorona.cpp 2a78ca9 
> 
> Diff: https://git.reviewboard.kde.org/r/128040/diff/
> 
> 
> Testing
> ---
> 
> To stop crash ?!
> 
> 
> Thanks,
> 
> Anthony Fieroni
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 128040: [shellcorona] Containment can be nullptr

[Aleix Pol Gonzalez]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128040/#review96027
---



Could you look a bit into why is the containment null?

- Aleix Pol Gonzalez


On May 30, 2016, 6:33 a.m., Anthony Fieroni wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/128040/
> ---
> 
> (Updated May 30, 2016, 6:33 a.m.)
> 
> 
> Review request for Plasma, Aleix Pol Gonzalez and David Edmundson.
> 
> 
> Bugs: 361548
> https://bugs.kde.org/show_bug.cgi?id=361548
> 
> 
> Repository: plasma-workspace
> 
> 
> Description
> ---
> 
> I can't reproduce this tons of bug reports and i event can't undertaind how 
> containment can be nullptr, when i see corona.cpp 
> http://api.kde.org/frameworks/plasma-framework/html/corona_8cpp_source.html#l00447
> 
> 
> Diffs
> -
> 
>   shell/shellcorona.cpp 2a78ca9 
> 
> Diff: https://git.reviewboard.kde.org/r/128040/diff/
> 
> 
> Testing
> ---
> 
> To stop crash ?!
> 
> 
> Thanks,
> 
> Anthony Fieroni
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 128040: [shellcorona] Containment can be nullptr

[Anthony Fieroni]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128040/
---

(Updated Май 30, 2016, 7:33 преди обяд)


Review request for Plasma, Aleix Pol Gonzalez and David Edmundson.


Changes
---

Another approach, do not inser screen nor create view if containment is 
nullptr. This will not leave plasmashell in *incomplete* state and give a new 
chance for kscreen to identified the screen.


Bugs: 361548
https://bugs.kde.org/show_bug.cgi?id=361548


Repository: plasma-workspace


Description
---

I can't reproduce this tons of bug reports and i event can't undertaind how 
containment can be nullptr, when i see corona.cpp 
http://api.kde.org/frameworks/plasma-framework/html/corona_8cpp_source.html#l00447


Diffs (updated)
-

  shell/shellcorona.cpp 2a78ca9 

Diff: https://git.reviewboard.kde.org/r/128040/diff/


Testing
---

To stop crash ?!


Thanks,

Anthony Fieroni

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 128040: [shellcorona] Containment can be nullptr

[Aleix Pol Gonzalez]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128040/#review96012
---



+1, it's fair to add a failsafe for release. It's about the worst positive 
patch, but it can still be useful.
Are you sure it doesn't leave the plasmashell in a weird broken state?

- Aleix Pol Gonzalez


On May 29, 2016, 7:17 a.m., Anthony Fieroni wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/128040/
> ---
> 
> (Updated May 29, 2016, 7:17 a.m.)
> 
> 
> Review request for Plasma, Aleix Pol Gonzalez and David Edmundson.
> 
> 
> Bugs: 361548
> https://bugs.kde.org/show_bug.cgi?id=361548
> 
> 
> Repository: plasma-workspace
> 
> 
> Description
> ---
> 
> I can't reproduce this tons of bug reports and i event can't undertaind how 
> containment can be nullptr, when i see corona.cpp 
> http://api.kde.org/frameworks/plasma-framework/html/corona_8cpp_source.html#l00447
> 
> 
> Diffs
> -
> 
>   shell/shellcorona.cpp 2a78ca9 
> 
> Diff: https://git.reviewboard.kde.org/r/128040/diff/
> 
> 
> Testing
> ---
> 
> To stop crash ?!
> 
> 
> Thanks,
> 
> Anthony Fieroni
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 128040: [shellcorona] Containment can be nullptr

[Anthony Fieroni]

> On Май 29, 2016, 6:30 след обяд, Kai Uwe Broulik wrote:
> > shell/shellcorona.cpp, line 907
> > 
> >
> > I think we need to figure out *why* containment is null, this assert is 
> > probably there for a reason.
> 
> Anthony Fieroni wrote:
> For me, the problem is kscreen. shellcorona.cpp:631 numScreens returns 0 
> cause kscreen not finish initializing who reflect on corona.cpp:211 if 
> (screen >= 0 && screen < numScreens()) so returning containment is nullptr. 
> Possible fix can be to wait kscreen to finish.
> 
> Kai Uwe Broulik wrote:
> https://git.reviewboard.kde.org/r/125451/ Or that :)

I saw this, but it's waiting for minimum depends to be Qt 5.6? So maybe we can 
provide some patch till it happend? I think it can be ugly but users will be 
happy, almost :)


- Anthony


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128040/#review95983
---


On Май 29, 2016, 8:17 преди обяд, Anthony Fieroni wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/128040/
> ---
> 
> (Updated Май 29, 2016, 8:17 преди обяд)
> 
> 
> Review request for Plasma, Aleix Pol Gonzalez and David Edmundson.
> 
> 
> Bugs: 361548
> https://bugs.kde.org/show_bug.cgi?id=361548
> 
> 
> Repository: plasma-workspace
> 
> 
> Description
> ---
> 
> I can't reproduce this tons of bug reports and i event can't undertaind how 
> containment can be nullptr, when i see corona.cpp 
> http://api.kde.org/frameworks/plasma-framework/html/corona_8cpp_source.html#l00447
> 
> 
> Diffs
> -
> 
>   shell/shellcorona.cpp 2a78ca9 
> 
> Diff: https://git.reviewboard.kde.org/r/128040/diff/
> 
> 
> Testing
> ---
> 
> To stop crash ?!
> 
> 
> Thanks,
> 
> Anthony Fieroni
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 128040: [shellcorona] Containment can be nullptr

[Kai Uwe Broulik]

> On Mai 29, 2016, 3:30 nachm., Kai Uwe Broulik wrote:
> > shell/shellcorona.cpp, line 907
> > 
> >
> > I think we need to figure out *why* containment is null, this assert is 
> > probably there for a reason.
> 
> Anthony Fieroni wrote:
> For me, the problem is kscreen. shellcorona.cpp:631 numScreens returns 0 
> cause kscreen not finish initializing who reflect on corona.cpp:211 if 
> (screen >= 0 && screen < numScreens()) so returning containment is nullptr. 
> Possible fix can be to wait kscreen to finish.

https://git.reviewboard.kde.org/r/125451/ Or that :)


- Kai Uwe


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128040/#review95983
---


On Mai 29, 2016, 5:17 vorm., Anthony Fieroni wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/128040/
> ---
> 
> (Updated Mai 29, 2016, 5:17 vorm.)
> 
> 
> Review request for Plasma, Aleix Pol Gonzalez and David Edmundson.
> 
> 
> Bugs: 361548
> https://bugs.kde.org/show_bug.cgi?id=361548
> 
> 
> Repository: plasma-workspace
> 
> 
> Description
> ---
> 
> I can't reproduce this tons of bug reports and i event can't undertaind how 
> containment can be nullptr, when i see corona.cpp 
> http://api.kde.org/frameworks/plasma-framework/html/corona_8cpp_source.html#l00447
> 
> 
> Diffs
> -
> 
>   shell/shellcorona.cpp 2a78ca9 
> 
> Diff: https://git.reviewboard.kde.org/r/128040/diff/
> 
> 
> Testing
> ---
> 
> To stop crash ?!
> 
> 
> Thanks,
> 
> Anthony Fieroni
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 128040: [shellcorona] Containment can be nullptr

[Anthony Fieroni]

> On Май 29, 2016, 6:30 след обяд, Kai Uwe Broulik wrote:
> > shell/shellcorona.cpp, line 907
> > 
> >
> > I think we need to figure out *why* containment is null, this assert is 
> > probably there for a reason.

For me, the problem is kscreen. shellcorona.cpp:631 numScreens returns 0 cause 
kscreen not finish initializing who reflect on corona.cpp:211 if (screen >= 0 
&& screen < numScreens()) so returning containment is nullptr. Possible fix can 
be to wait kscreen to finish.


- Anthony


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128040/#review95983
---


On Май 29, 2016, 8:17 преди обяд, Anthony Fieroni wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/128040/
> ---
> 
> (Updated Май 29, 2016, 8:17 преди обяд)
> 
> 
> Review request for Plasma, Aleix Pol Gonzalez and David Edmundson.
> 
> 
> Bugs: 361548
> https://bugs.kde.org/show_bug.cgi?id=361548
> 
> 
> Repository: plasma-workspace
> 
> 
> Description
> ---
> 
> I can't reproduce this tons of bug reports and i event can't undertaind how 
> containment can be nullptr, when i see corona.cpp 
> http://api.kde.org/frameworks/plasma-framework/html/corona_8cpp_source.html#l00447
> 
> 
> Diffs
> -
> 
>   shell/shellcorona.cpp 2a78ca9 
> 
> Diff: https://git.reviewboard.kde.org/r/128040/diff/
> 
> 
> Testing
> ---
> 
> To stop crash ?!
> 
> 
> Thanks,
> 
> Anthony Fieroni
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 128040: [shellcorona] Containment can be nullptr

[Kai Uwe Broulik]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128040/#review95983
---



-1


shell/shellcorona.cpp (line 907)


I think we need to figure out *why* containment is null, this assert is 
probably there for a reason.


- Kai Uwe Broulik


On Mai 29, 2016, 5:17 vorm., Anthony Fieroni wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/128040/
> ---
> 
> (Updated Mai 29, 2016, 5:17 vorm.)
> 
> 
> Review request for Plasma, Aleix Pol Gonzalez and David Edmundson.
> 
> 
> Bugs: 361548
> https://bugs.kde.org/show_bug.cgi?id=361548
> 
> 
> Repository: plasma-workspace
> 
> 
> Description
> ---
> 
> I can't reproduce this tons of bug reports and i event can't undertaind how 
> containment can be nullptr, when i see corona.cpp 
> http://api.kde.org/frameworks/plasma-framework/html/corona_8cpp_source.html#l00447
> 
> 
> Diffs
> -
> 
>   shell/shellcorona.cpp 2a78ca9 
> 
> Diff: https://git.reviewboard.kde.org/r/128040/diff/
> 
> 
> Testing
> ---
> 
> To stop crash ?!
> 
> 
> Thanks,
> 
> Anthony Fieroni
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Review Request 128040: [shellcorona] Containment can be nullptr

[Anthony Fieroni]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128040/
---

Review request for Plasma, Aleix Pol Gonzalez and David Edmundson.


Bugs: 361548
https://bugs.kde.org/show_bug.cgi?id=361548


Repository: plasma-workspace


Description
---

I can't reproduce this tons of bug reports and i event can't undertaind how 
containment can be nullptr, when i see corona.cpp 
http://api.kde.org/frameworks/plasma-framework/html/corona_8cpp_source.html#l00447


Diffs
-

  shell/shellcorona.cpp 2a78ca9 

Diff: https://git.reviewboard.kde.org/r/128040/diff/


Testing
---

To stop crash ?!


Thanks,

Anthony Fieroni

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel