Re: Review Request 129158: [PluginLoader] Use operator<< for finalArgs instead of initializer list
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129158/ --- (Updated Oct. 13, 2016, 8:19 a.m.) Status -- This change has been marked as submitted. Review request for Plasma and Aleix Pol Gonzalez. Changes --- Submitted with commit e7e0344d356460b0e9872c2c6d5a5c6a1dc6bb23 by Kai Uwe Broulik to branch master. Repository: plasma-framework Description --- When appending a list to an existing list using append or operator<< each item in the list is added individually whereas with initializer list it just adds the entire list as one entry. This caused the applet args to never be empty usually and resulted in externalData being called in init() with a QVariantList as argument. While this didn't do much for most applets it did break FolderView (and potentially others) which updates its URL in response to this signal and stored the "data" it got in plasmoid.configuration.url. FolderView's model did not accept this broken data [1] so the folder would still work initially. On next startup, however, it loaded said value from config and just went blank. [1] "file:///usr/share/plasma/plasmoids/org.kde.desktopcontainment/contents/ui/FolderViewLayer.qml:202:14: Unable to assign QJSValue to QString" Diffs - src/plasma/pluginloader.cpp 15e0ead Diff: https://git.reviewboard.kde.org/r/129158/diff/ Testing --- I created a FolderView applet, restarted plasmashell twice, FolderView still there and also in subsequent startups both on desktop and in panel. Thanks, Kai Uwe Broulik
Re: Review Request 129158: [PluginLoader] Use operator<< for finalArgs instead of initializer list
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129158/#review99959 --- Ship it! Ship It! - Aleix Pol Gonzalez On Oct. 12, 2016, 2:51 p.m., Kai Uwe Broulik wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/129158/ > --- > > (Updated Oct. 12, 2016, 2:51 p.m.) > > > Review request for Plasma and Aleix Pol Gonzalez. > > > Repository: plasma-framework > > > Description > --- > > When appending a list to an existing list using append or operator<< each > item in the list is added individually whereas with initializer list it just > adds the entire list as one entry. > > This caused the applet args to never be empty usually and resulted in > externalData being called in init() with a QVariantList as argument. > > While this didn't do much for most applets it did break FolderView (and > potentially others) which updates its URL in response to this signal and > stored the "data" it got in plasmoid.configuration.url. FolderView's model > did not accept this broken data [1] so the folder would still work initially. > On next startup, however, it loaded said value from config and just went > blank. > > [1] > "file:///usr/share/plasma/plasmoids/org.kde.desktopcontainment/contents/ui/FolderViewLayer.qml:202:14: > Unable to assign QJSValue to QString" > > > Diffs > - > > src/plasma/pluginloader.cpp 15e0ead > > Diff: https://git.reviewboard.kde.org/r/129158/diff/ > > > Testing > --- > > I created a FolderView applet, restarted plasmashell twice, FolderView still > there and also in subsequent startups both on desktop and in panel. > > > Thanks, > > Kai Uwe Broulik > >
Re: Review Request 129158: [PluginLoader] Use operator<< for finalArgs instead of initializer list
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129158/#review99958 --- Ship it! Ship It! - David Edmundson On Oct. 12, 2016, 12:51 p.m., Kai Uwe Broulik wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/129158/ > --- > > (Updated Oct. 12, 2016, 12:51 p.m.) > > > Review request for Plasma and Aleix Pol Gonzalez. > > > Repository: plasma-framework > > > Description > --- > > When appending a list to an existing list using append or operator<< each > item in the list is added individually whereas with initializer list it just > adds the entire list as one entry. > > This caused the applet args to never be empty usually and resulted in > externalData being called in init() with a QVariantList as argument. > > While this didn't do much for most applets it did break FolderView (and > potentially others) which updates its URL in response to this signal and > stored the "data" it got in plasmoid.configuration.url. FolderView's model > did not accept this broken data [1] so the folder would still work initially. > On next startup, however, it loaded said value from config and just went > blank. > > [1] > "file:///usr/share/plasma/plasmoids/org.kde.desktopcontainment/contents/ui/FolderViewLayer.qml:202:14: > Unable to assign QJSValue to QString" > > > Diffs > - > > src/plasma/pluginloader.cpp 15e0ead > > Diff: https://git.reviewboard.kde.org/r/129158/diff/ > > > Testing > --- > > I created a FolderView applet, restarted plasmashell twice, FolderView still > there and also in subsequent startups both on desktop and in panel. > > > Thanks, > > Kai Uwe Broulik > >
Review Request 129158: [PluginLoader] Use operator<< for finalArgs instead of initializer list
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129158/ --- Review request for Plasma and Aleix Pol Gonzalez. Repository: plasma-framework Description --- When appending a list to an existing list using append or operator<< each item in the list is added individually whereas with initializer list it just adds the entire list as one entry. This caused the applet args to never be empty usually and resulted in externalData being called in init() with a QVariantList as argument. While this didn't do much for most applets it did break FolderView (and potentially others) which updates its URL in response to this signal and stored the "data" it got in plasmoid.configuration.url. FolderView's model did not accept this broken data [1] so the folder would still work initially. On next startup, however, it loaded said value from config and just went blank. [1] "file:///usr/share/plasma/plasmoids/org.kde.desktopcontainment/contents/ui/FolderViewLayer.qml:202:14: Unable to assign QJSValue to QString" Diffs - src/plasma/pluginloader.cpp 15e0ead Diff: https://git.reviewboard.kde.org/r/129158/diff/ Testing --- I created a FolderView applet, restarted plasmashell twice, FolderView still there and also in subsequent startups both on desktop and in panel. Thanks, Kai Uwe Broulik
