Re: Review Request 129404: [AppletInterface] Never pull focus away from fullRepresentation
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129404/ --- (Updated Nov. 15, 2016, 9:31 a.m.) Status -- This change has been marked as submitted. Review request for Plasma and Fabian Vogt. Changes --- Submitted with commit a195a6b0b3971f864b1b95ca93ac034bae9fa736 by Kai Uwe Broulik to branch master. Repository: plasma-framework Description --- When closing the launcher using Meta key, it pulls focus away and when clicking the button to expand the applet, it won't get focus. BUG: 372476 Diffs - src/scriptengines/qml/plasmoid/appletinterface.cpp f24bc51 Diff: https://git.reviewboard.kde.org/r/129404/diff/ Testing --- started plasmashell: click on kickoff -> it opened, typing searched click on kickoff -> it closed pressed meta -> it opened, typing searched pressed meta -> it closed click on kickoff -> it opened, typing searched (before it wouldnt search until I click the window) Thanks, Kai Uwe Broulik
Re: Review Request 129404: [AppletInterface] Never pull focus away from fullRepresentation
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129404/#review100843 --- Ship it! Ship It! - Marco Martin On Nov. 14, 2016, 4:25 p.m., Kai Uwe Broulik wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/129404/ > --- > > (Updated Nov. 14, 2016, 4:25 p.m.) > > > Review request for Plasma and Fabian Vogt. > > > Repository: plasma-framework > > > Description > --- > > When closing the launcher using Meta key, it pulls focus away and when > clicking the button to expand the applet, it won't get focus. > > BUG: 372476 > > > Diffs > - > > src/scriptengines/qml/plasmoid/appletinterface.cpp f24bc51 > > Diff: https://git.reviewboard.kde.org/r/129404/diff/ > > > Testing > --- > > started plasmashell: > > click on kickoff -> it opened, typing searched > click on kickoff -> it closed > pressed meta -> it opened, typing searched > pressed meta -> it closed > click on kickoff -> it opened, typing searched (before it wouldnt search > until I click the window) > > > Thanks, > > Kai Uwe Broulik > >
Re: Review Request 129404: [AppletInterface] Never pull focus away from fullRepresentation
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129404/#review100841 --- Ship it! Tested, works fine! - Fabian Vogt On Nov. 14, 2016, 4:25 nachm., Kai Uwe Broulik wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/129404/ > --- > > (Updated Nov. 14, 2016, 4:25 nachm.) > > > Review request for Plasma and Fabian Vogt. > > > Repository: plasma-framework > > > Description > --- > > When closing the launcher using Meta key, it pulls focus away and when > clicking the button to expand the applet, it won't get focus. > > BUG: 372476 > > > Diffs > - > > src/scriptengines/qml/plasmoid/appletinterface.cpp f24bc51 > > Diff: https://git.reviewboard.kde.org/r/129404/diff/ > > > Testing > --- > > started plasmashell: > > click on kickoff -> it opened, typing searched > click on kickoff -> it closed > pressed meta -> it opened, typing searched > pressed meta -> it closed > click on kickoff -> it opened, typing searched (before it wouldnt search > until I click the window) > > > Thanks, > > Kai Uwe Broulik > >
Re: Review Request 129404: [AppletInterface] Never pull focus away from fullRepresentation
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129404/#review100836 --- Ship it! Ship It! - David Edmundson On Nov. 14, 2016, 4:25 p.m., Kai Uwe Broulik wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/129404/ > --- > > (Updated Nov. 14, 2016, 4:25 p.m.) > > > Review request for Plasma and Fabian Vogt. > > > Repository: plasma-framework > > > Description > --- > > When closing the launcher using Meta key, it pulls focus away and when > clicking the button to expand the applet, it won't get focus. > > BUG: 372476 > > > Diffs > - > > src/scriptengines/qml/plasmoid/appletinterface.cpp f24bc51 > > Diff: https://git.reviewboard.kde.org/r/129404/diff/ > > > Testing > --- > > started plasmashell: > > click on kickoff -> it opened, typing searched > click on kickoff -> it closed > pressed meta -> it opened, typing searched > pressed meta -> it closed > click on kickoff -> it opened, typing searched (before it wouldnt search > until I click the window) > > > Thanks, > > Kai Uwe Broulik > >
Review Request 129404: [AppletInterface] Never pull focus away from fullRepresentation
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129404/ --- Review request for Plasma and Fabian Vogt. Repository: plasma-framework Description --- When closing the launcher using Meta key, it pulls focus away and when clicking the button to expand the applet, it won't get focus. BUG: 372476 Diffs - src/scriptengines/qml/plasmoid/appletinterface.cpp f24bc51 Diff: https://git.reviewboard.kde.org/r/129404/diff/ Testing --- started plasmashell: click on kickoff -> it opened, typing searched click on kickoff -> it closed pressed meta -> it opened, typing searched pressed meta -> it closed click on kickoff -> it opened, typing searched (before it wouldnt search until I click the window) Thanks, Kai Uwe Broulik
