Re: Webslice applet moved to kdereview
On Friday 13 November 2009 01:51:53 Sebastian Kügler wrote: > I've just moved the webslice plasmoid to kdereview, for inclusion in KDE > 4.4. > > The webslice applet is there to put an interactive part of a webpage onto > Plasma as an applet. I've addressed all the comments (thanks, btw!) and moved it to kdeplasma-addons. > Thanks, -- sebas http://www.kde.org | http://vizZzion.org | GPG Key ID: 9119 0EF9 signature.asc Description: This is a digitally signed message part. ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Webslice applet moved to kdereview
On Friday 13 November 2009 18:20:33 Albert Astals Cid wrote:
> A Divendres, 13 de novembre de 2009, Sebastian Kügler va escriure:
> > Hey,
> >
> > I've just moved the webslice plasmoid to kdereview, for inclusion in KDE
> > 4.4.
> >
> > The webslice applet is there to put an interactive part of a webpage onto
> > Plasma as an applet.
> >
> > You can specify an element with a CSS selector (a.k.a. the nice way) or
> > by its geometry (the way that works for semantically-not-so-nice
> > webpages, but can easily break). This can be handy if you want to monitor
> > only the news box on a webpage, for example.
> >
> > The webslice widget uses Qt WebKit for rendering the element and is fully
> > interactive. I'm planning to make use of the KDE integration soon that
> > has just entered kdelibs, so we also share cookies and login information.
> >
> > There are two widgets coming along with this. First, a
> > SliceGraphicsWidget which is used inside the plasmoid, and a QWidget,
> > which basically wraps the SliceGraphicsWidget. Those are possible
> > candidates for inclusion into kdelibs, if other developers want to use
> > this as well. If you use the qmake-based build, you get a small binary
> > you can play around with.
> > The webslice plasmoid has been written by Richard Moore and me with the
> > help of some of the qtwebkit guys and is another early part of Silk we'd
> > like to see merged.
>
> Where do you plan to move it?
kdeplasma-addons, unless someone wants to see it somewhere else.
> > Please let me know if there's anything wrong with it, or where you see
> > room for improvement and I'll address it.
>
> i18n("%1,%2,%3,%4", ) is a bit difficult to translate, some context
> won't hurt
>
> frame->setHtml("Loading ..."); needs i18n and probably some
> context to tell what is loading.
>
> The first configuration page layout is broken, if maximixed, i lost a
> paragraph of explanation text.
Thanks for reviewing, I'll fix those (and the one you mentioned on IRC).
--
sebas
http://www.kde.org | http://vizZzion.org | GPG Key ID: 9119 0EF9
signature.asc
Description: This is a digitally signed message part.
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Webslice applet moved to kdereview
On Fri, Nov 13, 2009 at 12:58 PM, Marco Martin wrote: > it would probably add too much complexity to all webviews with no gain... > but what about Plasma::WebView::setSlice() and making webview itself manage > slices? In future we might want to add more stuff to the slices, eg. changing the way focus etc. is handled. I'm not sure we could do this cleanly if it was integrated into Plasma::WebView without making the code there more complex. Rich. ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Webslice applet moved to kdereview
On Friday 13 November 2009, Aaron J. Seigo wrote: > On November 12, 2009, Kenneth Christiansen wrote: > > Plasma widgets are by default GraphicsItems right? So what about > > Plasma::WebSlice? and then call the QWidget for KWebSlide? > > +1 on Plasma::WebSlice if it goes into libplasma; otherwise > KGraphicsWebSliceWidget to go the route of the Qt naming of > QGraphics[Item|Widget] > it would probably add too much complexity to all webviews with no gain... but what about Plasma::WebView::setSlice() and making webview itself manage slices? Cheers, Marco Martin ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Webslice applet moved to kdereview
Thanks all for the feedback so far, I'll make the changes in the coming days. On Friday 13 November 2009 01:51:53 Sebastian Kügler wrote: > Hey, > > I've just moved the webslice plasmoid to kdereview, for inclusion in KDE > 4.4. > > The webslice applet is there to put an interactive part of a webpage onto > Plasma as an applet. > > You can specify an element with a CSS selector (a.k.a. the nice way) or by > its geometry (the way that works for semantically-not-so-nice webpages, > but can easily break). This can be handy if you want to monitor only the > news box on a webpage, for example. > > The webslice widget uses Qt WebKit for rendering the element and is fully > interactive. I'm planning to make use of the KDE integration soon that has > just entered kdelibs, so we also share cookies and login information. > > There are two widgets coming along with this. First, a SliceGraphicsWidget > which is used inside the plasmoid, and a QWidget, which basically wraps > the SliceGraphicsWidget. Those are possible candidates for inclusion into > kdelibs, if other developers want to use this as well. If you use the > qmake-based build, you get a small binary you can play around with. > > The webslice plasmoid has been written by Richard Moore and me with the > help of some of the qtwebkit guys and is another early part of Silk we'd > like to see merged. > > Please let me know if there's anything wrong with it, or where you see room > for improvement and I'll address it. > > Thanks, > -- sebas http://www.kde.org | http://vizZzion.org | GPG Key ID: 9119 0EF9 ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: [Kde-silk] Webslice applet moved to kdereview
On Friday 13 November 2009, Sebastian Kügler wrote: > Hey, > > I've just moved the webslice plasmoid to kdereview, for inclusion in KDE > 4.4. > > The webslice applet is there to put an interactive part of a webpage onto > Plasma as an applet. > > You can specify an element with a CSS selector (a.k.a. the nice way) or by > its geometry (the way that works for semantically-not-so-nice webpages, > but can easily break). This can be handy if you want to monitor only the > news box on a webpage, for example. > > The webslice widget uses Qt WebKit for rendering the element and is fully > interactive. I'm planning to make use of the KDE integration soon that has > just entered kdelibs, so we also share cookies and login information. > > There are two widgets coming along with this. First, a SliceGraphicsWidget > which is used inside the plasmoid, and a QWidget, which basically wraps > the SliceGraphicsWidget. Those are possible candidates for inclusion into > kdelibs, if other developers want to use this as well. If you use the > qmake-based build, you get a small binary you can play around with. > > The webslice plasmoid has been written by Richard Moore and me with the > help of some of the qtwebkit guys and is another early part of Silk we'd > like to see merged. > > Please let me know if there's anything wrong with it, or where you see room > for improvement and I'll address it. > > Thanks, > apart from the widget naming already addressed seems fine to me. just wondering, couldn't slicegraphicswidget directly inherit qgraphicswebwidget? or was it important to hide the qgraphicswebwidget api to not pollute the final api? for the plasmoid, just a thing and then it's rocking: setAssociatedApplicationUrls() to the url of the page from where the slice is ttaken from and it's perfect. In the future it could even check if there is a selkie plugin registered for that page and launch that instead in this case (we would need a setAssociatedApplicationParameters() too probably) Cheers, Marco Martin ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Webslice applet moved to kdereview
On November 12, 2009, Kenneth Christiansen wrote: > If you go with KGraphics, I would prefer KGraphicsWebSlide. fair enough :) -- Aaron J. Seigo humru othro a kohnu se GPG Fingerprint: 8B8B 2209 0C6F 7C47 B1EA EE75 D6B7 2EB1 A7F1 DB43 KDE core developer sponsored by Qt Development Frameworks signature.asc Description: This is a digitally signed message part. ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Webslice applet moved to kdereview
Qt 4.6 has QGraphicsWebView :-) which is a QGraphicsWidget. If we would make a QGraphics version of, lets say, QLineEdit, it would probably be called QGraphicsLineEdit and not QGraphicsLineEditWidget. That was more or less the consensus we had when naming the QGraphicsWebView (which was renamed some times along the way :-)) If you go with KGraphics, I would prefer KGraphicsWebSlide. Cheers! On Thu, Nov 12, 2009 at 11:05 PM, Aaron J. Seigo wrote: > On November 12, 2009, Kenneth Christiansen wrote: >> Plasma widgets are by default GraphicsItems right? So what about >> Plasma::WebSlice? and then call the QWidget for KWebSlide? > > +1 on Plasma::WebSlice if it goes into libplasma; otherwise > KGraphicsWebSliceWidget to go the route of the Qt naming of > QGraphics[Item|Widget] > > -- > Aaron J. Seigo > humru othro a kohnu se > GPG Fingerprint: 8B8B 2209 0C6F 7C47 B1EA EE75 D6B7 2EB1 A7F1 DB43 > > KDE core developer sponsored by Qt Development Frameworks > > ___ > Plasma-devel mailing list > Plasma-devel@kde.org > https://mail.kde.org/mailman/listinfo/plasma-devel > > -- Kenneth Rohde Christiansen Technical Lead / Software Engineer Qt Labs Americas, Nokia Technology Institute, INdT Phone +55 81 8895 6002 / E-mail kenneth.christiansen at openbossa.org ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Webslice applet moved to kdereview
On November 12, 2009, Kenneth Christiansen wrote: > Plasma widgets are by default GraphicsItems right? So what about > Plasma::WebSlice? and then call the QWidget for KWebSlide? +1 on Plasma::WebSlice if it goes into libplasma; otherwise KGraphicsWebSliceWidget to go the route of the Qt naming of QGraphics[Item|Widget] -- Aaron J. Seigo humru othro a kohnu se GPG Fingerprint: 8B8B 2209 0C6F 7C47 B1EA EE75 D6B7 2EB1 A7F1 DB43 KDE core developer sponsored by Qt Development Frameworks signature.asc Description: This is a digitally signed message part. ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Webslice applet moved to kdereview
Hi there, Cool stuff. I don't know about the Plasma naming, but we are trying to not call anything but base classes for *Widget. Plasma widgets are by default GraphicsItems right? So what about Plasma::WebSlice? and then call the QWidget for KWebSlide? Just a suggestion :-) Kenneth On Thu, Nov 12, 2009 at 9:51 PM, Sebastian Kügler wrote: > Hey, > > I've just moved the webslice plasmoid to kdereview, for inclusion in KDE 4.4. > > The webslice applet is there to put an interactive part of a webpage onto > Plasma as > an applet. > > You can specify an element with a CSS selector (a.k.a. the nice way) or by its > geometry (the way that works for semantically-not-so-nice webpages, but can > easily > break). This can be handy if you want to monitor only the news box on a > webpage, for > example. > > The webslice widget uses Qt WebKit for rendering the element and is fully > interactive. I'm planning to make use of the KDE integration soon that has > just > entered kdelibs, so we also share cookies and login information. > > There are two widgets coming along with this. First, a SliceGraphicsWidget > which is > used inside the plasmoid, and a QWidget, which basically wraps the > SliceGraphicsWidget. Those are possible candidates for inclusion into > kdelibs, if > other developers want to use this as well. If you use the qmake-based build, > you get > a small binary you can play around with. > > The webslice plasmoid has been written by Richard Moore and me with the help > of some > of the qtwebkit guys and is another early part of Silk we'd like to see > merged. > > Please let me know if there's anything wrong with it, or where you see room > for > improvement and I'll address it. > > Thanks, > -- > sebas > > http://www.kde.org | http://vizZzion.org | GPG Key ID: 9119 0EF9 > ___ > Plasma-devel mailing list > Plasma-devel@kde.org > https://mail.kde.org/mailman/listinfo/plasma-devel > -- Kenneth Rohde Christiansen Technical Lead / Software Engineer Qt Labs Americas, Nokia Technology Institute, INdT Phone +55 81 8895 6002 / E-mail kenneth.christiansen at openbossa.org ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Webslice applet moved to kdereview
Hey, I've just moved the webslice plasmoid to kdereview, for inclusion in KDE 4.4. The webslice applet is there to put an interactive part of a webpage onto Plasma as an applet. You can specify an element with a CSS selector (a.k.a. the nice way) or by its geometry (the way that works for semantically-not-so-nice webpages, but can easily break). This can be handy if you want to monitor only the news box on a webpage, for example. The webslice widget uses Qt WebKit for rendering the element and is fully interactive. I'm planning to make use of the KDE integration soon that has just entered kdelibs, so we also share cookies and login information. There are two widgets coming along with this. First, a SliceGraphicsWidget which is used inside the plasmoid, and a QWidget, which basically wraps the SliceGraphicsWidget. Those are possible candidates for inclusion into kdelibs, if other developers want to use this as well. If you use the qmake-based build, you get a small binary you can play around with. The webslice plasmoid has been written by Richard Moore and me with the help of some of the qtwebkit guys and is another early part of Silk we'd like to see merged. Please let me know if there's anything wrong with it, or where you see room for improvement and I'll address it. Thanks, -- sebas http://www.kde.org | http://vizZzion.org | GPG Key ID: 9119 0EF9 ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
