Re: multiscreen fix
On Tuesday, March 1, 2011, Yuen Hoe Lim wrote: - start with external screen at 1440x900 - Add an empty horizontal panel, add some widgets, click the maximize button - change screen to 1280x800 - Observe that a portion to the right of the panel gets cut off due to smaller resolution this seems to be the biggest problem, and would be nice to have fixed regardless of the reverse problem and i half suspect that the reverse problem is actually a configuration issue on people's local system and not an actual bug in plasma-desktop, anyways. -- Aaron J. Seigo humru othro a kohnu se GPG Fingerprint: 8B8B 2209 0C6F 7C47 B1EA EE75 D6B7 2EB1 A7F1 DB43 KDE core developer sponsored by Qt Development Frameworks signature.asc Description: This is a digitally signed message part. ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: multiscreen fix
Sorry been quiet on this, lots of stuff on me now. I tested things out a little and I'm having some trouble reproducing some of the symptoms described by the bug. Specifically I can do the following: - start with external screen at 1440x900 - Add an empty horizontal panel, add some widgets, click the maximize button - change screen to 1280x800 - Observe that a portion to the right of the panel gets cut off due to smaller resolution However, I can't seem to reproduce the vice versa case. - start with external screen at 1280x800 - Add an empty horizontal panel, add some widgets, click the maximize button - change screen to 1440x900 - Panel properly maximizes to fill up the horizontal space This tried on both 4.6.0 and on master. Can someone else try it out and confirm that this is the behaviour? There seems to be some reports in the bug page on the vice versa case, but it doesn't seem reproducible from here. Jason moofang Lim Yuen Hoe http://yuenhoe.co.cc/ On Sat, Feb 19, 2011 at 5:33 AM, Jeffery MacEachern j.maceach...@gmail.comwrote: On Thu, Feb 17, 2011 at 14:19, Aaron J. Seigo ase...@kde.org wrote: On Thursday, February 17, 2011, John Layt wrote: and panels and plugging/unplugging that I should really find/open bug s,open,fix,g ;) seriously, the main reason why kicker got as good with multiscreen (not to mention multiple panels on the same screen) as it did is because i used a 2 screen desktop for ~2 years, during which time i fixed every issue i spotted. it was worth it to me because it affected my daily usage. i used multiple panels on both screens of a multi-screen set up, my workflow at the time relied on it, so i put some effort into it. opening bug reports does nothing, directly, to make the code better. i'm not expecting to have a multiscreen setup again for the foreseeable future, so it really needs some other people chipping away at the user experience of panels in multiscreen. your lives will improve, as will many others who also use multiscreen. I would very much like to, but I am far too busy with school right now. I hope to make it a priority once I have dev time again. just think how absurd it is that, once again, most of the current multiscreen features and fixes in plasma-desktop (including multihead) have been written by me on a single screen system. absurd is the perfect word. i've had some grateful and dedicated testers, but that's like feeding each other with 10 foot chopsticks: yes, it's possible, but it's really clumsy and very silly. Possible, yes... it also sounds fun to try. :) Where can I buy 10 foot chopsticks? ...and safety glasses... - Jeffery MacEachern i know man of you have a million other things to do, but this is an excellent investment in your day to day experience on your computer. and generally, once it's Fixed(tm) it doesn't need to be revisited as that code tends not to change at all once working. -- Aaron J. Seigo humru othro a kohnu se GPG Fingerprint: 8B8B 2209 0C6F 7C47 B1EA EE75 D6B7 2EB1 A7F1 DB43 KDE core developer sponsored by Qt Development Frameworks ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: multiscreen fix
On Thu, Feb 17, 2011 at 14:19, Aaron J. Seigo ase...@kde.org wrote: On Thursday, February 17, 2011, John Layt wrote: and panels and plugging/unplugging that I should really find/open bug s,open,fix,g ;) seriously, the main reason why kicker got as good with multiscreen (not to mention multiple panels on the same screen) as it did is because i used a 2 screen desktop for ~2 years, during which time i fixed every issue i spotted. it was worth it to me because it affected my daily usage. i used multiple panels on both screens of a multi-screen set up, my workflow at the time relied on it, so i put some effort into it. opening bug reports does nothing, directly, to make the code better. i'm not expecting to have a multiscreen setup again for the foreseeable future, so it really needs some other people chipping away at the user experience of panels in multiscreen. your lives will improve, as will many others who also use multiscreen. I would very much like to, but I am far too busy with school right now. I hope to make it a priority once I have dev time again. just think how absurd it is that, once again, most of the current multiscreen features and fixes in plasma-desktop (including multihead) have been written by me on a single screen system. absurd is the perfect word. i've had some grateful and dedicated testers, but that's like feeding each other with 10 foot chopsticks: yes, it's possible, but it's really clumsy and very silly. Possible, yes... it also sounds fun to try. :) Where can I buy 10 foot chopsticks? ...and safety glasses... - Jeffery MacEachern i know man of you have a million other things to do, but this is an excellent investment in your day to day experience on your computer. and generally, once it's Fixed(tm) it doesn't need to be revisited as that code tends not to change at all once working. -- Aaron J. Seigo humru othro a kohnu se GPG Fingerprint: 8B8B 2209 0C6F 7C47 B1EA EE75 D6B7 2EB1 A7F1 DB43 KDE core developer sponsored by Qt Development Frameworks ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: multiscreen fix
I have multiscreen now :) Will give this a go over the weekend if no one's free. Jason moofang Lim Yuen Hoe http://yuenhoe.co.cc/ On Wed, Feb 16, 2011 at 3:36 AM, Aaron J. Seigo ase...@kde.org wrote: hi all... it is currently impossible for me to even try to fix this multiscreen issue which has re-surfaced in 4.6.0: https://bugs.kde.org/show_bug.cgi?id=209962 all of my monitors are packed in boxes or otherwise gone in preparation of my impending move. it would be great if someone could take this one on. it shouldn't even be that difficult. the important bits are: * the lastscreen values in plasma-desktoprc * the code in plasma/desktop/shell/panelview.cpp around getting the right last size and adaption to whatever the new current size is. putting some debug outpot in the PanelView constructor where it is reading in the last seen size, getting the current screen size, making sure that pinchContainment is getting called with the correct screen rect, etc... i pushed some changes there for 4.6 which fixed some issues as confirmed by opensuse users. however, it seems a regression also made its way in. :( with some basic testing, the cause should show up pretty quickly as the code paths are rather limited (thankfully :). it would be very good to have this fixed for 4.6.1 ... -- Aaron J. Seigo humru othro a kohnu se GPG Fingerprint: 8B8B 2209 0C6F 7C47 B1EA EE75 D6B7 2EB1 A7F1 DB43 KDE core developer sponsored by Qt Development Frameworks ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: multiscreen fix
On Thursday, February 17, 2011, todd rme wrote: Would this also fix https://bugs.kde.org/show_bug.cgi?id=248080 ? no, that's an entirely different issue. and likely something in kephal. -- Aaron J. Seigo humru othro a kohnu se GPG Fingerprint: 8B8B 2209 0C6F 7C47 B1EA EE75 D6B7 2EB1 A7F1 DB43 KDE core developer sponsored by Qt Development Frameworks signature.asc Description: This is a digitally signed message part. ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: multiscreen fix
On Thu, Feb 17, 2011 at 09:02, Yuen Hoe Lim yuenho...@gmail.com wrote: I have multiscreen now :) Will give this a go over the weekend if no one's free. If you need further testing, I'll be game, providing I have my dev environment (re)set up by then. This affects me a lot. Thanks! - Jeffery MacEachern Jason moofang Lim Yuen Hoe http://yuenhoe.co.cc/ On Wed, Feb 16, 2011 at 3:36 AM, Aaron J. Seigo ase...@kde.org wrote: hi all... it is currently impossible for me to even try to fix this multiscreen issue which has re-surfaced in 4.6.0: https://bugs.kde.org/show_bug.cgi?id=209962 all of my monitors are packed in boxes or otherwise gone in preparation of my impending move. it would be great if someone could take this one on. it shouldn't even be that difficult. the important bits are: * the lastscreen values in plasma-desktoprc * the code in plasma/desktop/shell/panelview.cpp around getting the right last size and adaption to whatever the new current size is. putting some debug outpot in the PanelView constructor where it is reading in the last seen size, getting the current screen size, making sure that pinchContainment is getting called with the correct screen rect, etc... i pushed some changes there for 4.6 which fixed some issues as confirmed by opensuse users. however, it seems a regression also made its way in. :( with some basic testing, the cause should show up pretty quickly as the code paths are rather limited (thankfully :). it would be very good to have this fixed for 4.6.1 ... -- Aaron J. Seigo humru othro a kohnu se GPG Fingerprint: 8B8B 2209 0C6F 7C47 B1EA EE75 D6B7 2EB1 A7F1 DB43 KDE core developer sponsored by Qt Development Frameworks ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: multiscreen fix
On Thursday 17 February 2011 20:03:28 Jeffery MacEachern wrote: On Thu, Feb 17, 2011 at 09:02, Yuen Hoe Lim yuenho...@gmail.com wrote: I have multiscreen now :) Will give this a go over the weekend if no one's free. If you need further testing, I'll be game, providing I have my dev environment (re)set up by then. This affects me a lot. Thanks! - Jeffery MacEachern Ditto, I should be able to test as well (git branches makes this stuff easy!). There's a whole bunch of other problems I find with dual screens and panels and plugging/unplugging that I should really find/open bug reports for. John. ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: multiscreen fix
On Thursday, February 17, 2011, John Layt wrote: and panels and plugging/unplugging that I should really find/open bug s,open,fix,g ;) seriously, the main reason why kicker got as good with multiscreen (not to mention multiple panels on the same screen) as it did is because i used a 2 screen desktop for ~2 years, during which time i fixed every issue i spotted. it was worth it to me because it affected my daily usage. i used multiple panels on both screens of a multi-screen set up, my workflow at the time relied on it, so i put some effort into it. opening bug reports does nothing, directly, to make the code better. i'm not expecting to have a multiscreen setup again for the foreseeable future, so it really needs some other people chipping away at the user experience of panels in multiscreen. your lives will improve, as will many others who also use multiscreen. just think how absurd it is that, once again, most of the current multiscreen features and fixes in plasma-desktop (including multihead) have been written by me on a single screen system. absurd is the perfect word. i've had some grateful and dedicated testers, but that's like feeding each other with 10 foot chopsticks: yes, it's possible, but it's really clumsy and very silly. i know man of you have a million other things to do, but this is an excellent investment in your day to day experience on your computer. and generally, once it's Fixed(tm) it doesn't need to be revisited as that code tends not to change at all once working. -- Aaron J. Seigo humru othro a kohnu se GPG Fingerprint: 8B8B 2209 0C6F 7C47 B1EA EE75 D6B7 2EB1 A7F1 DB43 KDE core developer sponsored by Qt Development Frameworks signature.asc Description: This is a digitally signed message part. ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
multiscreen fix
hi all... it is currently impossible for me to even try to fix this multiscreen issue which has re-surfaced in 4.6.0: https://bugs.kde.org/show_bug.cgi?id=209962 all of my monitors are packed in boxes or otherwise gone in preparation of my impending move. it would be great if someone could take this one on. it shouldn't even be that difficult. the important bits are: * the lastscreen values in plasma-desktoprc * the code in plasma/desktop/shell/panelview.cpp around getting the right last size and adaption to whatever the new current size is. putting some debug outpot in the PanelView constructor where it is reading in the last seen size, getting the current screen size, making sure that pinchContainment is getting called with the correct screen rect, etc... i pushed some changes there for 4.6 which fixed some issues as confirmed by opensuse users. however, it seems a regression also made its way in. :( with some basic testing, the cause should show up pretty quickly as the code paths are rather limited (thankfully :). it would be very good to have this fixed for 4.6.1 ... -- Aaron J. Seigo humru othro a kohnu se GPG Fingerprint: 8B8B 2209 0C6F 7C47 B1EA EE75 D6B7 2EB1 A7F1 DB43 KDE core developer sponsored by Qt Development Frameworks signature.asc Description: This is a digitally signed message part. ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: [PATCH] Multiscreen fix!
2009/2/1 Alessandro Diaferia alediafe...@gmail.com: I deeply checked and Kephal actually returns correct screen info (2 screens, the first (0, 0, 1280, 1024), the second(1280, 0, 1680, 1050)). Moreover adjustSize() uses Plasma::View::screen() in order to resize the view, and before delaying adjustSize, that screen was just wrong. Ok, so if Kephal reports the correct sizes then you most likely have xrandr1.2, and so you are right, it's another problem. So I agree with your patch now :-) Cheers, g I actually had a patch to fix this but I was waiting for somebody to test it before committing. Can you check this bug: http://bugs.kde.org/show_bug.cgi?id=181325 and test the patch, reverting your own patch, and see if it works for you? It does not do me the trick.. I still have second screen displacement.. I feel the issues are not correlated, anyway i'd wait for someone else, more expert than me, to talk :) Cheers, g Cheers :) 2009/1/30 Alessandro Diaferia alediafe...@gmail.com: As you can see from the sources Plasma::View uses QTimer::singleShot(0, this, SLOT(privateInit())) in the ctor but DesktopView calls adjustSize() in the ctor with no delay.. This causes the fact that adjustSize() uses invalid information about the current screen to setup its size and makes my second screen disappear (or actually, with a wrong size/position). I managed to fix this giving a delay also to adjustSize() so that when it is called the correct information are already set (and screen() returns the correct number in this case). Hope this is ok to commit, since i'd like to have my screen back officially :P Since i'm having troubles with the reviewboard here comes the patch: Index: shells/desktop/desktopview.cpp === --- shells/desktop/desktopview.cpp(revision 918687) +++ shells/desktop/desktopview.cpp(working copy) @@ -104,7 +104,7 @@ DesktopView::DesktopView(Plasma::Contain QBrush b(tile); setBackgroundBrush(tile); -adjustSize(); +QTimer::singleShot(0, this, SLOT(adjustSize())); Kephal::Screens *screens = Kephal::Screens::self(); connect(screens, SIGNAL(screenResized(Kephal::Screen *, QSize, QSize)), Hugs!! -- Alessandro Diaferia ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel -- Alessandro Diaferia ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: [PATCH] Multiscreen fix!
2009/2/1 Guillaume Pothier gpoth...@gmail.com 2009/2/1 Alessandro Diaferia alediafe...@gmail.com: I deeply checked and Kephal actually returns correct screen info (2 screens, the first (0, 0, 1280, 1024), the second(1280, 0, 1680, 1050)). Moreover adjustSize() uses Plasma::View::screen() in order to resize the view, and before delaying adjustSize, that screen was just wrong. Ok, so if Kephal reports the correct sizes then you most likely have xrandr1.2, and so you are right, it's another problem. So I agree with your patch now :-) Yeah, i have xrandr-1.2.3 :D Cheers, g Regards I actually had a patch to fix this but I was waiting for somebody to test it before committing. Can you check this bug: http://bugs.kde.org/show_bug.cgi?id=181325 and test the patch, reverting your own patch, and see if it works for you? It does not do me the trick.. I still have second screen displacement.. I feel the issues are not correlated, anyway i'd wait for someone else, more expert than me, to talk :) Cheers, g Cheers :) 2009/1/30 Alessandro Diaferia alediafe...@gmail.com: As you can see from the sources Plasma::View uses QTimer::singleShot(0, this, SLOT(privateInit())) in the ctor but DesktopView calls adjustSize() in the ctor with no delay.. This causes the fact that adjustSize() uses invalid information about the current screen to setup its size and makes my second screen disappear (or actually, with a wrong size/position). I managed to fix this giving a delay also to adjustSize() so that when it is called the correct information are already set (and screen() returns the correct number in this case). Hope this is ok to commit, since i'd like to have my screen back officially :P Since i'm having troubles with the reviewboard here comes the patch: Index: shells/desktop/desktopview.cpp === --- shells/desktop/desktopview.cpp(revision 918687) +++ shells/desktop/desktopview.cpp(working copy) @@ -104,7 +104,7 @@ DesktopView::DesktopView(Plasma::Contain QBrush b(tile); setBackgroundBrush(tile); -adjustSize(); +QTimer::singleShot(0, this, SLOT(adjustSize())); Kephal::Screens *screens = Kephal::Screens::self(); connect(screens, SIGNAL(screenResized(Kephal::Screen *, QSize, QSize)), Hugs!! -- Alessandro Diaferia ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel -- Alessandro Diaferia ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel -- Alessandro Diaferia ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: [PATCH] Multiscreen fix!
2009/2/1 Guillaume Pothier gpoth...@gmail.com Hi Alessandro, sorry I didn't reply earlier, Hi Guillaume, np :) I was offline this week. I think your fix is not in the ideal place. I think that what happens is that you are using a driver that is not xrandr1.2-aware (please tell me if I'm wrong), how can I check that? and therefore Kephal falls back to QDesktopWidget for screen management; unfortunately QDesktopWidget has this problem that it still reports the old screen information while the notifications are processed. But the fix for this should be in Kephal, not in plasma (otherwise the problem would reappear in other components such as kwin). I deeply checked and Kephal actually returns correct screen info (2 screens, the first (0, 0, 1280, 1024), the second(1280, 0, 1680, 1050)). Moreover adjustSize() uses Plasma::View::screen() in order to resize the view, and before delaying adjustSize, that screen was just wrong. I actually had a patch to fix this but I was waiting for somebody to test it before committing. Can you check this bug: http://bugs.kde.org/show_bug.cgi?id=181325 and test the patch, reverting your own patch, and see if it works for you? It does not do me the trick.. I still have second screen displacement.. I feel the issues are not correlated, anyway i'd wait for someone else, more expert than me, to talk :) Cheers, g Cheers :) 2009/1/30 Alessandro Diaferia alediafe...@gmail.com: As you can see from the sources Plasma::View uses QTimer::singleShot(0, this, SLOT(privateInit())) in the ctor but DesktopView calls adjustSize() in the ctor with no delay.. This causes the fact that adjustSize() uses invalid information about the current screen to setup its size and makes my second screen disappear (or actually, with a wrong size/position). I managed to fix this giving a delay also to adjustSize() so that when it is called the correct information are already set (and screen() returns the correct number in this case). Hope this is ok to commit, since i'd like to have my screen back officially :P Since i'm having troubles with the reviewboard here comes the patch: Index: shells/desktop/desktopview.cpp === --- shells/desktop/desktopview.cpp(revision 918687) +++ shells/desktop/desktopview.cpp(working copy) @@ -104,7 +104,7 @@ DesktopView::DesktopView(Plasma::Contain QBrush b(tile); setBackgroundBrush(tile); -adjustSize(); +QTimer::singleShot(0, this, SLOT(adjustSize())); Kephal::Screens *screens = Kephal::Screens::self(); connect(screens, SIGNAL(screenResized(Kephal::Screen *, QSize, QSize)), Hugs!! -- Alessandro Diaferia ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel -- Alessandro Diaferia ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: [PATCH] Multiscreen fix!
Hi Alessandro, sorry I didn't reply earlier, I was offline this week. I think your fix is not in the ideal place. I think that what happens is that you are using a driver that is not xrandr1.2-aware (please tell me if I'm wrong), and therefore Kephal falls back to QDesktopWidget for screen management; unfortunately QDesktopWidget has this problem that it still reports the old screen information while the notifications are processed. But the fix for this should be in Kephal, not in plasma (otherwise the problem would reappear in other components such as kwin). I actually had a patch to fix this but I was waiting for somebody to test it before committing. Can you check this bug: http://bugs.kde.org/show_bug.cgi?id=181325 and test the patch, reverting your own patch, and see if it works for you? Cheers, g 2009/1/30 Alessandro Diaferia alediafe...@gmail.com: As you can see from the sources Plasma::View uses QTimer::singleShot(0, this, SLOT(privateInit())) in the ctor but DesktopView calls adjustSize() in the ctor with no delay.. This causes the fact that adjustSize() uses invalid information about the current screen to setup its size and makes my second screen disappear (or actually, with a wrong size/position). I managed to fix this giving a delay also to adjustSize() so that when it is called the correct information are already set (and screen() returns the correct number in this case). Hope this is ok to commit, since i'd like to have my screen back officially :P Since i'm having troubles with the reviewboard here comes the patch: Index: shells/desktop/desktopview.cpp === --- shells/desktop/desktopview.cpp(revision 918687) +++ shells/desktop/desktopview.cpp(working copy) @@ -104,7 +104,7 @@ DesktopView::DesktopView(Plasma::Contain QBrush b(tile); setBackgroundBrush(tile); -adjustSize(); +QTimer::singleShot(0, this, SLOT(adjustSize())); Kephal::Screens *screens = Kephal::Screens::self(); connect(screens, SIGNAL(screenResized(Kephal::Screen *, QSize, QSize)), Hugs!! -- Alessandro Diaferia ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: [PATCH] Multiscreen fix!
On Friday 30 January 2009, Marco Martin wrote: to me seems correct, it's a bit tricky the fact that privateinit was enqueued before so by enqueuing adjustsize we are sure that it will be executed after, but i don't see other ways to achieve that, so just put a comment about that and i think it's good to go +1 (busy +1'ing emails before the airplane starts boarding here in zurich ;) -- Aaron J. Seigo humru othro a kohnu se GPG Fingerprint: 8B8B 2209 0C6F 7C47 B1EA EE75 D6B7 2EB1 A7F1 DB43 KDE core developer sponsored by Qt Software signature.asc Description: This is a digitally signed message part. ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: [PATCH] Multiscreen fix!
2009/1/31 Aaron J. Seigo ase...@kde.org On Friday 30 January 2009, Marco Martin wrote: to me seems correct, it's a bit tricky the fact that privateinit was enqueued before so by enqueuing adjustsize we are sure that it will be executed after, but i don't see other ways to achieve that, so just put a comment about that and i think it's good to go +1 (busy +1'ing emails before the airplane starts boarding here in zurich ;) lol, np Aaron, have a good trip :D -- Aaron J. Seigo humru othro a kohnu se GPG Fingerprint: 8B8B 2209 0C6F 7C47 B1EA EE75 D6B7 2EB1 A7F1 DB43 KDE core developer sponsored by Qt Software ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel -- Alessandro Diaferia ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: [PATCH] Multiscreen fix!
On Friday 30 January 2009, Alessandro Diaferia wrote: As you can see from the sources Plasma::View uses QTimer::singleShot(0, this, SLOT(privateInit())) in the ctor but DesktopView calls adjustSize() in the ctor with no delay.. This causes the fact that adjustSize() uses invalid information about the current screen to setup its size and makes my second screen disappear (or actually, with a wrong size/position). I managed to fix this giving a delay also to adjustSize() so that when it is called the correct information are already set (and screen() returns the correct number in this case). Hope this is ok to commit, since i'd like to have my screen back officially :P to me seems correct, it's a bit tricky the fact that privateinit was enqueued before so by enqueuing adjustsize we are sure that it will be executed after, but i don't see other ways to achieve that, so just put a comment about that and i think it's good to go Cheers, Marco Martin Since i'm having troubles with the reviewboard here comes the patch: Index: shells/desktop/desktopview.cpp === --- shells/desktop/desktopview.cpp(revision 918687) +++ shells/desktop/desktopview.cpp(working copy) @@ -104,7 +104,7 @@ DesktopView::DesktopView(Plasma::Contain QBrush b(tile); setBackgroundBrush(tile); -adjustSize(); +QTimer::singleShot(0, this, SLOT(adjustSize())); Kephal::Screens *screens = Kephal::Screens::self(); connect(screens, SIGNAL(screenResized(Kephal::Screen *, QSize, QSize)), Hugs!! ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
