Re: plasma-wayland-protocols, kwayland, kwayland-server, and kwin have to recompiled

[Aleix Pol]

On Wed, Sep 1, 2021 at 10:28 AM Ben Cooksley  wrote:
>
> On Wed, Sep 1, 2021 at 9:56 AM David Edmundson  
> wrote:
>>
>> Bumping this thread to say, this (a bump of plasma-wayland-protocols)
>> has just happened again and I imagine we have two more landing this
>> week.
>>
>> This probably will result in broken CI for a few days, which is far
>> from ideal, but it's why we have our feature freeze early.
>
>
> I find the acceptance here of things being "broken" concerning, especially in 
> something that is a dependency of a Framework.
> As plasma-wayland-protocols is a dependency of KWayland (a Framework) any 
> issues with it have far greater implications than just Plasma.
>
> Breakages in Frameworks cannot be accepted for several days.

There's a bit of a misunderstanding here. Nothing should break as long
as we make sure we build against the correct version of
plasma-wayland-protocols (which is always master). We just need to
coordinate the CI builds.

Aleix

Re: plasma-wayland-protocols, kwayland, kwayland-server, and kwin have to recompiled

[Ben Cooksley]

On Wed, Sep 1, 2021 at 9:56 AM David Edmundson 
wrote:

> Bumping this thread to say, this (a bump of plasma-wayland-protocols)
> has just happened again and I imagine we have two more landing this
> week.
>
> This probably will result in broken CI for a few days, which is far
> from ideal, but it's why we have our feature freeze early.
>

I find the acceptance here of things being "broken" concerning, especially
in something that is a dependency of a Framework.
As plasma-wayland-protocols is a dependency of KWayland (a Framework) any
issues with it have far greater implications than just Plasma.

Breakages in Frameworks cannot be accepted for several days.


> David
>

Regards,
Ben

Re: plasma-wayland-protocols, kwayland, kwayland-server, and kwin have to recompiled

[Aleix Pol]

In preparation I did run the dependency build for frameworks and
plasma. I did forget to run it for Plasma stable which is probably
what you saw.

Leaving some time between submitting the protocols patch, letting the
dependency build jobs finish (successfully :D) and then merging the
actual implementations makes for a much easier integration.
I'll be happy to press the right buttons if someone tells me they'd
merged to the protocols repository.

Aleix

On Tue, Aug 31, 2021 at 11:56 PM David Edmundson
 wrote:
>
> Bumping this thread to say, this (a bump of plasma-wayland-protocols)
> has just happened again and I imagine we have two more landing this
> week.
>
> This probably will result in broken CI for a few days, which is far
> from ideal, but it's why we have our feature freeze early.
>
> David

Re: plasma-wayland-protocols, kwayland, kwayland-server, and kwin have to recompiled

[David Edmundson]

Bumping this thread to say, this (a bump of plasma-wayland-protocols)
has just happened again and I imagine we have two more landing this
week.

This probably will result in broken CI for a few days, which is far
from ideal, but it's why we have our feature freeze early.

David

Re: plasma-wayland-protocols, kwayland, kwayland-server, and kwin have to recompiled

[Ben Cooksley]

On Fri, Aug 27, 2021 at 6:10 PM Vlad Zahorodnii 
wrote:

> On 8/26/21 9:58 PM, Ben Cooksley wrote:
> > On Wed, Aug 25, 2021 at 9:58 PM Vlad Zahorodnii  > > wrote:
> >
> > Hi,
> >
> >
> > Hi Vlad,
> >
> >
> > I've just merged a patch that tweaks some protocol additions in the
> > plasma window management protocol that were made this month and
> haven't
> > been released yet.
> >
> > Even though that change won't affect users running stable version of
> > plasma, it may cause issues on developer machines.
> >
> > If you experience startup issues with plasma on wayland, in
> particular
> > plasma not starting at all, please recompile the following projects:
> >
> > * plasma-wayland-protocols
> > * kwayland
> > * kwayland-server
> > * kwin
> > * plasma-workspace
> >
> >
> > I'm afraid the CI system may disagree with you regarding the impact on
> > stable branches, please see
> > https://build.kde.org/view/Failing/job/Plasma/job/kwayland/
> > 
> > These breakages look to be related to plasma-wayland-protocols.
> >
> > I also note that these changes caused substantial disruption to the CI
> > system requiring multiple Dependency Builds to be run to correct the
> > issue and restore normal service.
> >
> > As plasma-wayland-protocols is not part of either Frameworks or Plasma,
> > please ensure necessary changes to it are landed well in advance of
> > starting to use them - rather than all at the same time.
>
> The issue is that Frameworks and Plasma builds break even if
> plasma-wayland-protocols changes land in advance.
>

You have to land changes a week in advance for the Dependency Builds to
pick them up on their normal cadence.
Depending on timing you may be able to land them earlier, but there is no
guarantee as the builds are run on a staggered basis by Jenkins.

That brings the disruption caused by this to 6 Dependency Builds (two for
Frameworks, four for Plasma)

Please note you also have to arrange for a release of
plasma-wayland-protocols as that is part of Extragear.
This needs to be done before the next Frameworks release.


> >
> > Sorry for the inconvenience,
> > Vlad
> >
> >
> > Thanks,
> > Ben
>
>
Cheers,
Ben

Re: plasma-wayland-protocols, kwayland, kwayland-server, and kwin have to recompiled

[Vlad Zahorodnii]

On 8/26/21 9:58 PM, Ben Cooksley wrote:
On Wed, Aug 25, 2021 at 9:58 PM Vlad Zahorodnii > wrote:


Hi,


Hi Vlad,


I've just merged a patch that tweaks some protocol additions in the
plasma window management protocol that were made this month and haven't
been released yet.

Even though that change won't affect users running stable version of
plasma, it may cause issues on developer machines.

If you experience startup issues with plasma on wayland, in particular
plasma not starting at all, please recompile the following projects:

* plasma-wayland-protocols
* kwayland
* kwayland-server
* kwin
* plasma-workspace


I'm afraid the CI system may disagree with you regarding the impact on 
stable branches, please see 
https://build.kde.org/view/Failing/job/Plasma/job/kwayland/ 


These breakages look to be related to plasma-wayland-protocols.

I also note that these changes caused substantial disruption to the CI 
system requiring multiple Dependency Builds to be run to correct the 
issue and restore normal service.


As plasma-wayland-protocols is not part of either Frameworks or Plasma, 
please ensure necessary changes to it are landed well in advance of 
starting to use them - rather than all at the same time.


The issue is that Frameworks and Plasma builds break even if 
plasma-wayland-protocols changes land in advance.




Sorry for the inconvenience,
Vlad


Thanks,
Ben

Re: plasma-wayland-protocols, kwayland, kwayland-server, and kwin have to recompiled

[Vlad Zahorodnii]

On 8/26/21 9:58 PM, Ben Cooksley wrote:
On Wed, Aug 25, 2021 at 9:58 PM Vlad Zahorodnii > wrote:


Hi,


Hi Vlad,


I've just merged a patch that tweaks some protocol additions in the
plasma window management protocol that were made this month and haven't
been released yet.

Even though that change won't affect users running stable version of
plasma, it may cause issues on developer machines.

If you experience startup issues with plasma on wayland, in particular
plasma not starting at all, please recompile the following projects:

* plasma-wayland-protocols
* kwayland
* kwayland-server
* kwin
* plasma-workspace


I'm afraid the CI system may disagree with you regarding the impact on 
stable branches, please see 
https://build.kde.org/view/Failing/job/Plasma/job/kwayland/ 


These breakages look to be related to plasma-wayland-protocols.


It looks like stable-kf5-qt5 SUSEQt5.15 and stable-kf5-qt5 FreeBSDQt5.15 
need a dependency build.


Just to clarify, plasma-wayland-protocols with relevant protocol changes 
hasn't been released yet. It's not possible to break API or ABI 
compatibility with KWayland 5.85 or earlier.


Cheers,
Vlad

I also note that these changes caused substantial disruption to the CI 
system requiring multiple Dependency Builds to be run to correct the 
issue and restore normal service.


As plasma-wayland-protocols is not part of either Frameworks or Plasma, 
please ensure necessary changes to it are landed well in advance of 
starting to use them - rather than all at the same time.



Sorry for the inconvenience,
Vlad


Thanks,
Ben

Re: plasma-wayland-protocols, kwayland, kwayland-server, and kwin have to recompiled

[Ben Cooksley]

On Wed, Aug 25, 2021 at 9:58 PM Vlad Zahorodnii 
wrote:

> Hi,
>

Hi Vlad,


> I've just merged a patch that tweaks some protocol additions in the
> plasma window management protocol that were made this month and haven't
> been released yet.
>
> Even though that change won't affect users running stable version of
> plasma, it may cause issues on developer machines.
>
> If you experience startup issues with plasma on wayland, in particular
> plasma not starting at all, please recompile the following projects:
>
> * plasma-wayland-protocols
> * kwayland
> * kwayland-server
> * kwin
> * plasma-workspace
>

I'm afraid the CI system may disagree with you regarding the impact on
stable branches, please see
https://build.kde.org/view/Failing/job/Plasma/job/kwayland/
These breakages look to be related to plasma-wayland-protocols.

I also note that these changes caused substantial disruption to the CI
system requiring multiple Dependency Builds to be run to correct the issue
and restore normal service.

As plasma-wayland-protocols is not part of either Frameworks or Plasma,
please ensure necessary changes to it are landed well in advance of
starting to use them - rather than all at the same time.


> Sorry for the inconvenience,
> Vlad
>

Thanks,
Ben

plasma-wayland-protocols, kwayland, kwayland-server, and kwin have to recompiled

[Vlad Zahorodnii]

Hi,

I've just merged a patch that tweaks some protocol additions in the 
plasma window management protocol that were made this month and haven't 
been released yet.


Even though that change won't affect users running stable version of 
plasma, it may cause issues on developer machines.


If you experience startup issues with plasma on wayland, in particular 
plasma not starting at all, please recompile the following projects:


* plasma-wayland-protocols
* kwayland
* kwayland-server
* kwin
* plasma-workspace

Sorry for the inconvenience,
Vlad