date:20170101

[Differential] [Closed] D3901: Applet: Toggle mute of items with middle mouse button

2017-01-01 Thread drosca (David Rosca)

This revision was automatically updated to reflect the committed changes.
Closed by commit R115:8acf4e6a78c8: Applet: Toggle mute of items with middle 
mouse button (authored by drosca).

REPOSITORY
  R115 Plasma Audio Volume Applet

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D3901?vs=9575=9591

REVISION DETAIL
  https://phabricator.kde.org/D3901

AFFECTED FILES
  applet/contents/ui/ListItemBase.qml

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: drosca, #plasma, davidedmundson
Cc: plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas

[plasmashell] [Bug 340063] Please make KDE fade to black before turning screen off

2017-01-01 Thread S

https://bugs.kde.org/show_bug.cgi?id=340063

--- Comment #17 from S  ---
(In reply to Kai Uwe Broulik from comment #16)
> A couple of seconds before the screen turns off, no matter what is currently
> shown (desktop or lock screen)

OK, thanks for the explanation. So I can confirm that I am definitely not
seeing any fading. About 5 seconds before the energy saver turns off the
screen, my screen goes straight to a black screen with the backlight and mouse
pointer still on. Then the screen turns off. Could you please help me diagnose
why this isn't working?

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Powerdevil] [Bug 348529] Turn off screen after lock screen

2017-01-01 Thread Martin Gräßlin

https://bugs.kde.org/show_bug.cgi?id=348529

--- Comment #13 from Martin Gräßlin  ---
Some thoughts from using my system. I often listen to music provided by 
the computer. The computer's audio is connected through HDMI to one of 
my screens. When the screen goes into DPMS the audio is turned off with 
a loud *knacks* and when being turned on again it *knacks* again.

When I listen to music I hate it when the system goes into DPMS.

Even worse, though, is that the screen is very slow when going into DPMS 
or returning from it. The screen needs a fair 10 sec or more to do the 
mode switch. And it cannot handle it correctly. After resume from DPMS 
I'm greeted with a message that "invalid mode is used", while in truth 
everything is correct. To get rid of the message I need to press the 
menu button of the screen.

The screen is about 5/6 years old.

I'm telling this just to make aware that not all users would benefit 
from instant turning on DPMS when going to lock the screen. It can be 
highly annoying.

Given that we must have an option for it. I do see the energy saving 
aspect and would suggest to reduce the timeout to 30 sec after the 
screen is locked. But if DPMS is broken the normal energy saving levels 
should be used. We do support things like audio control in the lock 
screen. This doesn't make sense if the system goes into DPMS every half 
a minute.

Also we need to be careful. We only should do this if the screen gets 
locked either explicitly by the user or through idle timeout. Not when 
switching user session or going to suspend.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Differential] [Accepted] D3902: Fix X-Plasma-Drop* types

2017-01-01 Thread apol (Aleix Pol Gonzalez)

apol accepted this revision.

REPOSITORY
  R242 Plasma Frameworks

REVISION DETAIL
  https://phabricator.kde.org/D3902

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: broulik, #plasma, davidedmundson, apol
Cc: plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas

[Differential] [Updated] D3743: [Folder View] Show proper trash icon when it points to trash:/

2017-01-01 Thread hein (Eike Hein)

hein added a comment.


  I agree with mart's review comment ... why did we need to hardcode this in FV 
code, Kai?

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D3743

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: broulik, #plasma, #plasma:_design, mart, hein
Cc: mart, plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas

[plasmashell] [Bug 340063] Please make KDE fade to black before turning screen off

2017-01-01 Thread S

https://bugs.kde.org/show_bug.cgi?id=340063

--- Comment #19 from S  ---
Hmm I see. So I guess what I was requesting with this bug report is what
mate-screensaver does, ~5 second fade to black which gives the user a chance to
interrupt it before the screen goes completely black.

-- 
You are receiving this mail because:
You are the assignee for the bug.

Re: Review Request 129736: KHoliday update - reworked holidays for Poland

2017-01-01 Thread Laurent Montel


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/129736/#review101714
---


Ship it!




Seems ok.
Ship it.
Regards

- Laurent Montel


On Jan. 1, 2017, 8:38 a.m., Roman Standzikowski wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/129736/
> ---
> 
> (Updated Jan. 1, 2017, 8:38 a.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Repository: kholidays
> 
> 
> Description
> ---
> 
> The patch contains updated holidays for Poland. This would fix bug 
> https://bugs.kde.org/show_bug.cgi?id=365153.
> 
> 
> For general information about polish holidays (especially the ones we do not 
> work in Poland), see:
> 
> - see https://en.wikipedia.org/wiki/Public_holidays_in_Poland
> - polish law act: http://isap.sejm.gov.pl/DetailsServlet?id=WDU2015090
> 
> Changes:
> - [most important, this HAS TO BE MAINLINED!!!] 6th of January is now a 
> public holiday, since 2011 (see 
> https://en.wikipedia.org/wiki/Epiphany_(holiday)#Poland)
> - '?ledzik' is not really a religious holiday, this is just the last day of 
> carnival (see https://en.wikipedia.org/wiki/Carnival#Poland), there are no 
> special religious celebrations at this day in Poland
> - moved Valentine's Day ('Walentynki') to civil holidays; I'm not really sure 
> what is the different between 'civil' and 'cultural' holidays, but it seems 
> no sense to have just the Valentine's Day in cultural and nothing else there
> - 'Zaduszki' (full name: 'Dzie? Zaduszny') is definitely a religious holiday 
> (see https://en.wikipedia.org/wiki/All_Souls%27_Day, 
> https://pl.wikipedia.org/wiki/Zaduszki)
> - 'Wigilia' is also a religious holiday (see 
> https://en.wikipedia.org/wiki/Christmas_Eve, 
> https://pl.wikipedia.org/wiki/Wigilia_Bo%C5%BCego_Narodzenia)
> - 'Wniebowzi?cie NMP' ('Assumption of the Blessed Virgin Mary') is a bit 
> complicated; this is both Army Day and Assumption of the Blessed Virgin Mary 
> (see https://en.wikipedia.org/wiki/Public_holidays_in_Poland). Since in the 
> polish law act the Assumption is mentioned, it is now a 'public religious', 
> and the Army Day ('Dzie? Wojska Polskiego') was added as a civil one
> - 'Lany Poniedzia?ek' ('Wet Monday') is a (still live) slavic-pagan 
> tradition; since it is not mentioned in the polish law act, I have moved it 
> to civil (this day is a holiday, because it is also a second day of Easter). 
> I am not 100% sure about this change, any help would be welcome
> - 'Dzie? Programisty' ('Programmers Day') added as a civil holiday; I 
> couldn't resist :)
> - added 'T?usty Czwartek' ('Fat Thursday' - 
> https://en.wikipedia.org/wiki/Fat_Thursday#Poland); since there are no 
> special religious celebrations this day, I have marked it as civil
> - added 'Dzie? Górnika' ('Miners Day' - 
> https://pl.wikipedia.org/wiki/Barb%C3%B3rka) - there are traditional 
> celebration held in mining areas of Poland
> - added 'Dzie? Edukacji Narodowej' ('Teacher's Day' - 
> https://en.wikipedia.org/wiki/Teachers%27_Day), it is celebrated in every 
> school
> - renamed '?w' Miko?aj' to 'Miko?ajki', as this is more common name - see 
> https://pl.wikipedia.org/wiki/Miko%C5%82ajki_(zwyczaj)
> - polish 'Andrzejki' is a night 29/30 November (again, slavic-pagan tradition 
> - https://pl.wikipedia.org/wiki/Andrzejki), not really the same as 'St. 
> Andrew's Day'; moved to 29th November, as 30th November is already after the 
> feast
> - daylight saving time added (same time is in the whole European Union) - 
> 'Czas letni', 'Czas zimowy'
> - added 'Prima Aprilis' ('April Fools' Day')
> - added 'Dzie? Solidarno?ci i Wolno?ci' ('Solidarity and Freedom Day' - see 
> https://pl.wikipedia.org/wiki/Dzie%C5%84_Solidarno%C5%9Bci_i_Wolno%C5%9Bci)
> - added 'Dzie? Zwyci?stwa' ('Victory Day' - see 
> https://pl.wikipedia.org/wiki/Dzie%C5%84_Zwyci%C4%99stwa)
> - added equinoxes and solstices
> - added comment about polish school holidays
> 
> 
> Diffs
> -
> 
>   holidays/plan2/holiday_pl_pl 54d56ac 
> 
> Diff: https://git.reviewboard.kde.org/r/129736/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Roman Standzikowski
> 
>

[Powerdevil] [Bug 348529] Turn off screen after lock screen

2017-01-01 Thread bugzilla_noreply

https://bugs.kde.org/show_bug.cgi?id=348529

k...@web.de changed:

   What|Removed |Added

 CC||k...@web.de

--- Comment #11 from k...@web.de ---
A better workaround:
Go to System Settings > Notifications > Event Source: Screen Saver
Click on "Screen locked"
Enable "Run command" and copy this into the text box:
/usr/bin/sleep 2.0 && /usr/bin/xset dpms force off

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Breeze] [Bug 374255] Notes widget icons not visible depending on Notes background and Plasma Shell Dark/Light variant

2017-01-01 Thread Kai Uwe Broulik

https://bugs.kde.org/show_bug.cgi?id=374255

Kai Uwe Broulik  changed:

   What|Removed |Added

 Resolution|--- |DUPLICATE
 Status|UNCONFIRMED |RESOLVED
 CC||k...@privat.broulik.de

--- Comment #2 from Kai Uwe Broulik  ---


*** This bug has been marked as a duplicate of bug 353819 ***

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Differential] [Request, 21 lines] D3915: Sync startplasma with a startkde change

2017-01-01 Thread davidedmundson (David Edmundson)

davidedmundson created this revision.
davidedmundson added a reviewer: Plasma.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.

REVISION SUMMARY
  https://phabricator.kde.org/R120:bc1324ceebbd71d1571d3adb51371b17391ab425 in 
startkde had a change
  
Don't try to set $qdbus to a path to qdbus... it wasn't used
conherently, without issue don't really need it
  
  this wasn't synced with startplasma.
  
  BUG: 374402

REPOSITORY
  R120 Plasma Workspace

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D3915

AFFECTED FILES
  startkde/startplasma.cmake

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: davidedmundson, #plasma
Cc: plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas

[plasmashell] [Bug 340063] Please make KDE fade to black before turning screen off

2017-01-01 Thread Kai Uwe Broulik

https://bugs.kde.org/show_bug.cgi?id=340063

--- Comment #18 from Kai Uwe Broulik  ---
The fade animation is pretty quick, it's not a long fade. The "black screen
with cursor still on" is indicates you actually have it working.

(I was thinking about fading the entire duration slowly but that requires some
more effort, that effect wasn't actually meant to be used for this purpose. The
important bit is that it gives you time to react before actually engaging
energy saving from which it might take a considerable amount of time to wake
up)

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Differential] [Closed] D3900: Set mute when changing volume to 0 with slider

2017-01-01 Thread drosca (David Rosca)

This revision was automatically updated to reflect the committed changes.
Closed by commit R115:db9f523a03c2: Set mute when changing volume to 0 with 
slider (authored by drosca).

REPOSITORY
  R115 Plasma Audio Volume Applet

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D3900?vs=9574=9592

REVISION DETAIL
  https://phabricator.kde.org/D3900

AFFECTED FILES
  applet/contents/ui/ListItemBase.qml
  src/kcm/package/contents/ui/VolumeSlider.qml

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: drosca, #plasma, davidedmundson
Cc: davidedmundson, plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas

[Differential] [Closed] D3899: Applet: Make sure to never show empty icon

2017-01-01 Thread drosca (David Rosca)

This revision was automatically updated to reflect the committed changes.
Closed by commit R115:26dfed1e5df8: Applet: Make sure to never show empty icon 
(authored by drosca).

REPOSITORY
  R115 Plasma Audio Volume Applet

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D3899?vs=9573=9593

REVISION DETAIL
  https://phabricator.kde.org/D3899

AFFECTED FILES
  applet/contents/ui/DeviceListItem.qml
  applet/contents/ui/ListItemBase.qml
  applet/contents/ui/StreamListItem.qml

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: drosca, #plasma, davidedmundson
Cc: plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas

[Differential] [Closed] D3898: Applet: Don't delete delegates while drag is active

2017-01-01 Thread drosca (David Rosca)

This revision was automatically updated to reflect the committed changes.
Closed by commit R115:f21aa35e9946: Applet: Don't delete delegates while drag 
is active (authored by drosca).

REPOSITORY
  R115 Plasma Audio Volume Applet

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D3898?vs=9572=9590

REVISION DETAIL
  https://phabricator.kde.org/D3898

AFFECTED FILES
  applet/contents/ui/ListItemBase.qml

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: drosca, #plasma, davidedmundson
Cc: davidedmundson, plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas

[plasmashell] [Bug 340063] Please make KDE fade to black before turning screen off

2017-01-01 Thread Kai Uwe Broulik

https://bugs.kde.org/show_bug.cgi?id=340063

--- Comment #16 from Kai Uwe Broulik  ---
A couple of seconds before the screen turns off, no matter what is currently
shown (desktop or lock screen)

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Differential] [Request, 5 lines] D3911: [Containment Appearance] Make sure to always load a config view

2017-01-01 Thread broulik (Kai Uwe Broulik)

broulik created this revision.
broulik added a reviewer: Plasma.
broulik set the repository for this revision to R119 Plasma Desktop.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.

REVISION SUMMARY
  If StackView is empty, currentItem will be null and we would break all over 
the place.
  This can happen when you have a wallpaper without config, so "sourceFile" 
would stay empty and thus onSourceFileChanged wouldn't be triggered and we 
wouldn't load anything into our StackView.
  
  BUG: 360862
  FIXED-IN: 5.8.6

TEST PLAN
  Switching between wallpapers still works (minus the usual glitches of default 
values not being applied but that's a different story) and applying settings. I 
can now switch between Hunyango and Haenau no problem.
  
  Ideally this dialog was refactored to use onActivated instead of 
onCurrentIndexChanged and Component.onCompleted to populate itself etc etc but 
when I did something similar to applet config dialog, it broke various places 
relying on the fact that values change *after* creation, so let's go with this 
least invasive patch, for 5.8 series anyway.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D3911

AFFECTED FILES
  desktoppackage/contents/configuration/ConfigurationContainmentAppearance.qml

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: broulik, #plasma
Cc: plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas

[Powerdevil] [Bug 348529] Turn off screen after lock screen

2017-01-01 Thread Kai Uwe Broulik

https://bugs.kde.org/show_bug.cgi?id=348529

Kai Uwe Broulik  changed:

   What|Removed |Added

 CC||mgraess...@kde.org
  Flags||Usability?

--- Comment #12 from Kai Uwe Broulik  ---
So, Martin, and Usability, what do you think about this?

Looks like we have three options:
1.) Add option to turn off screen when user locks it
2.) Add option to reduce turn off timeout when screen is locked (to e.g. 30
seconds or 1 minute) ← would be my preference
3.) Keep it as it is

(I was just thinking of the phone usecase, too, but currently pressing the
power button directly turns off the screen independently of the lock screen?)

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Differential] [Request, 2 lines] D3914: Rename expander icon tooltip to "close popup" to close the popup

2017-01-01 Thread davidedmundson (David Edmundson)

davidedmundson created this revision.
davidedmundson added a reviewer: Plasma.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.

REVISION SUMMARY
  Quoting Thomas from the bug report:
  
  > The tooltip over the triangle button when the popup was opened by a
  
  widget says "Hide icons" which is misleading in this case because it
  does not hide icons.
  
  > Therefore, I'd keep the behavior as it is and just change the tooltip
  
  to "Close popup" when it is opened regardless of the reason.
  
  BUG: 374335

REPOSITORY
  R120 Plasma Workspace

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D3914

AFFECTED FILES
  applets/systemtray/package/contents/ui/ExpanderArrow.qml

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: davidedmundson, #plasma
Cc: plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas

Re: Review Request 129736: KHoliday update - reworked holidays for Poland

2017-01-01 Thread Roman Standzikowski


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/129736/
---

(Updated Jan. 1, 2017, 8:37 a.m.)


Review request for Plasma.


Repository: kholidays


Description
---

The patch contains updated holidays for Poland. This would fix bug 
https://bugs.kde.org/show_bug.cgi?id=365153.


For general information about polish holidays (especially the ones we do not 
work in Poland), see:

- see https://en.wikipedia.org/wiki/Public_holidays_in_Poland
- polish law act: http://isap.sejm.gov.pl/DetailsServlet?id=WDU2015090

Changes:
- [most important, this HAS TO BE MAINLINED!!!] 6th of January is now a public 
holiday, since 2011 (see 
https://en.wikipedia.org/wiki/Epiphany_(holiday)#Poland)
- '?ledzik' is not really a religious holiday, this is just the last day of 
carnival (see https://en.wikipedia.org/wiki/Carnival#Poland), there are no 
special religious celebrations at this day in Poland
- moved Valentine's Day ('Walentynki') to civil holidays; I'm not really sure 
what is the different between 'civil' and 'cultural' holidays, but it seems no 
sense to have just the Valentine's Day in cultural and nothing else there
- 'Zaduszki' (full name: 'Dzie? Zaduszny') is definitely a religious holiday 
(see https://en.wikipedia.org/wiki/All_Souls%27_Day, 
https://pl.wikipedia.org/wiki/Zaduszki)
- 'Wigilia' is also a religious holiday (see 
https://en.wikipedia.org/wiki/Christmas_Eve, 
https://pl.wikipedia.org/wiki/Wigilia_Bo%C5%BCego_Narodzenia)
- 'Wniebowzi?cie NMP' ('Assumption of the Blessed Virgin Mary') is a bit 
complicated; this is both Army Day and Assumption of the Blessed Virgin Mary 
(see https://en.wikipedia.org/wiki/Public_holidays_in_Poland). Since in the 
polish law act the Assumption is mentioned, it is now a 'public religious', and 
the Army Day ('Dzie? Wojska Polskiego') was added as a civil one
- 'Lany Poniedzia?ek' ('Wet Monday') is a (still live) slavic-pagan tradition; 
since it is not mentioned in the polish law act, I have moved it to civil (this 
day is a holiday, because it is also a second day of Easter). I am not 100% 
sure about this change, any help would be welcome
- 'Dzie? Programisty' ('Programmers Day') added as a civil holiday; I couldn't 
resist :)
- added 'T?usty Czwartek' ('Fat Thursday' - 
https://en.wikipedia.org/wiki/Fat_Thursday#Poland); since there are no special 
religious celebrations this day, I have marked it as civil
- added 'Dzie? Górnika' ('Miners Day' - 
https://pl.wikipedia.org/wiki/Barb%C3%B3rka) - there are traditional 
celebration held in mining areas of Poland
- added 'Dzie? Edukacji Narodowej' ('Teacher's Day' - 
https://en.wikipedia.org/wiki/Teachers%27_Day), it is celebrated in every school
- renamed '?w' Miko?aj' to 'Miko?ajki', as this is more common name - see 
https://pl.wikipedia.org/wiki/Miko%C5%82ajki_(zwyczaj)
- polish 'Andrzejki' is a night 29/30 November (again, slavic-pagan tradition - 
https://pl.wikipedia.org/wiki/Andrzejki), not really the same as 'St. Andrew's 
Day'; moved to 29th November, as 30th November is already after the feast
- daylight saving time added (same time is in the whole European Union) - 'Czas 
letni', 'Czas zimowy'
- added 'Prima Aprilis' ('April Fools' Day')
- added 'Dzie? Solidarno?ci i Wolno?ci' ('Solidarity and Freedom Day' - see 
https://pl.wikipedia.org/wiki/Dzie%C5%84_Solidarno%C5%9Bci_i_Wolno%C5%9Bci)
- added 'Dzie? Zwyci?stwa' ('Victory Day' - see 
https://pl.wikipedia.org/wiki/Dzie%C5%84_Zwyci%C4%99stwa)
- added equinoxes and solstices
- added comment about polish school holidays


Diffs (updated)
-

  holidays/plan2/holiday_pl_pl 54d56ac 

Diff: https://git.reviewboard.kde.org/r/129736/diff/


Testing
---


Thanks,

Roman Standzikowski

Re: Review Request 129736: KHoliday update - reworked holidays for Poland

2017-01-01 Thread Roman Standzikowski


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/129736/
---

(Updated Jan. 1, 2017, 8:38 a.m.)


Review request for Plasma.


Repository: kholidays


Description
---

The patch contains updated holidays for Poland. This would fix bug 
https://bugs.kde.org/show_bug.cgi?id=365153.


For general information about polish holidays (especially the ones we do not 
work in Poland), see:

- see https://en.wikipedia.org/wiki/Public_holidays_in_Poland
- polish law act: http://isap.sejm.gov.pl/DetailsServlet?id=WDU2015090

Changes:
- [most important, this HAS TO BE MAINLINED!!!] 6th of January is now a public 
holiday, since 2011 (see 
https://en.wikipedia.org/wiki/Epiphany_(holiday)#Poland)
- '?ledzik' is not really a religious holiday, this is just the last day of 
carnival (see https://en.wikipedia.org/wiki/Carnival#Poland), there are no 
special religious celebrations at this day in Poland
- moved Valentine's Day ('Walentynki') to civil holidays; I'm not really sure 
what is the different between 'civil' and 'cultural' holidays, but it seems no 
sense to have just the Valentine's Day in cultural and nothing else there
- 'Zaduszki' (full name: 'Dzie? Zaduszny') is definitely a religious holiday 
(see https://en.wikipedia.org/wiki/All_Souls%27_Day, 
https://pl.wikipedia.org/wiki/Zaduszki)
- 'Wigilia' is also a religious holiday (see 
https://en.wikipedia.org/wiki/Christmas_Eve, 
https://pl.wikipedia.org/wiki/Wigilia_Bo%C5%BCego_Narodzenia)
- 'Wniebowzi?cie NMP' ('Assumption of the Blessed Virgin Mary') is a bit 
complicated; this is both Army Day and Assumption of the Blessed Virgin Mary 
(see https://en.wikipedia.org/wiki/Public_holidays_in_Poland). Since in the 
polish law act the Assumption is mentioned, it is now a 'public religious', and 
the Army Day ('Dzie? Wojska Polskiego') was added as a civil one
- 'Lany Poniedzia?ek' ('Wet Monday') is a (still live) slavic-pagan tradition; 
since it is not mentioned in the polish law act, I have moved it to civil (this 
day is a holiday, because it is also a second day of Easter). I am not 100% 
sure about this change, any help would be welcome
- 'Dzie? Programisty' ('Programmers Day') added as a civil holiday; I couldn't 
resist :)
- added 'T?usty Czwartek' ('Fat Thursday' - 
https://en.wikipedia.org/wiki/Fat_Thursday#Poland); since there are no special 
religious celebrations this day, I have marked it as civil
- added 'Dzie? Górnika' ('Miners Day' - 
https://pl.wikipedia.org/wiki/Barb%C3%B3rka) - there are traditional 
celebration held in mining areas of Poland
- added 'Dzie? Edukacji Narodowej' ('Teacher's Day' - 
https://en.wikipedia.org/wiki/Teachers%27_Day), it is celebrated in every school
- renamed '?w' Miko?aj' to 'Miko?ajki', as this is more common name - see 
https://pl.wikipedia.org/wiki/Miko%C5%82ajki_(zwyczaj)
- polish 'Andrzejki' is a night 29/30 November (again, slavic-pagan tradition - 
https://pl.wikipedia.org/wiki/Andrzejki), not really the same as 'St. Andrew's 
Day'; moved to 29th November, as 30th November is already after the feast
- daylight saving time added (same time is in the whole European Union) - 'Czas 
letni', 'Czas zimowy'
- added 'Prima Aprilis' ('April Fools' Day')
- added 'Dzie? Solidarno?ci i Wolno?ci' ('Solidarity and Freedom Day' - see 
https://pl.wikipedia.org/wiki/Dzie%C5%84_Solidarno%C5%9Bci_i_Wolno%C5%9Bci)
- added 'Dzie? Zwyci?stwa' ('Victory Day' - see 
https://pl.wikipedia.org/wiki/Dzie%C5%84_Zwyci%C4%99stwa)
- added equinoxes and solstices
- added comment about polish school holidays


Diffs (updated)
-

  holidays/plan2/holiday_pl_pl 54d56ac 

Diff: https://git.reviewboard.kde.org/r/129736/diff/


Testing
---


Thanks,

Roman Standzikowski

[Differential] [Request, 12 lines] D3899: Applet: Make sure to never show empty icon

2017-01-01 Thread drosca (David Rosca)

drosca created this revision.
drosca added a reviewer: Plasma.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.

REVISION SUMMARY
  Streams needs to have icon to be possible to drag them to different
  devices. Show "unknown" icon when icon is empty or not found in theme.

TEST PLAN
  Tried to set "asdas" as icon name, "unknown" icon was picked instead.

REPOSITORY
  R115 Plasma Audio Volume Applet

BRANCH
  no-empty-icon (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D3899

AFFECTED FILES
  applet/contents/ui/DeviceListItem.qml
  applet/contents/ui/ListItemBase.qml
  applet/contents/ui/StreamListItem.qml

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: drosca, #plasma
Cc: plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas

[Differential] [Commented On] D3829: [touchpad] Use a separate X11 Display to monitor the XInput event.

2017-01-01 Thread Martin Gräßlin

graesslin added a comment.


  I would say the overall problem is that this here still uses an XLib event 
queue. But Qt uses an xcb connection. I would say this needs a porting away 
from the XLib code and use Qt's XCB connection and event handling.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D3829

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: xuetianweng, davidedmundson
Cc: knambiar, graesslin, plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas

[Differential] [Request, 2 lines] D3898: Applet: Don't delete delegates while drag is active

2017-01-01 Thread drosca (David Rosca)

drosca created this revision.
drosca added a reviewer: Plasma.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.

REVISION SUMMARY
  BUG: 374288

TEST PLAN
  No crash, delegates are still correctly deleted

REPOSITORY
  R115 Plasma Audio Volume Applet

BRANCH
  Plasma/5.8

REVISION DETAIL
  https://phabricator.kde.org/D3898

AFFECTED FILES
  applet/contents/ui/ListItemBase.qml

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: drosca, #plasma
Cc: plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas

[Differential] [Request, 4 lines] D3900: Set mute when changing volume to 0 with slider

2017-01-01 Thread drosca (David Rosca)

drosca created this revision.
drosca added a reviewer: Plasma.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.

REPOSITORY
  R115 Plasma Audio Volume Applet

BRANCH
  mute-slider (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D3900

AFFECTED FILES
  applet/contents/ui/ListItemBase.qml
  src/kcm/package/contents/ui/VolumeSlider.qml

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: drosca, #plasma
Cc: plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas

[Differential] [Accepted] D3901: Applet: Toggle mute of items with middle mouse button

2017-01-01 Thread davidedmundson (David Edmundson)

davidedmundson accepted this revision.
davidedmundson added a reviewer: davidedmundson.
This revision is now accepted and ready to land.

REPOSITORY
  R115 Plasma Audio Volume Applet

BRANCH
  middle-mute (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D3901

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: drosca, #plasma, davidedmundson
Cc: plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas

[Differential] [Request, 6 lines] D3901: Applet: Toggle mute of items with middle mouse button

2017-01-01 Thread drosca (David Rosca)

drosca created this revision.
drosca added a reviewer: Plasma.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.

REPOSITORY
  R115 Plasma Audio Volume Applet

BRANCH
  middle-mute (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D3901

AFFECTED FILES
  applet/contents/ui/ListItemBase.qml

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: drosca, #plasma
Cc: plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas

[Differential] [Request, 10 lines] D3902: Fix X-Plasma-Drop* types

2017-01-01 Thread broulik (Kai Uwe Broulik)

broulik created this revision.
broulik added reviewers: Plasma, apol.
broulik set the repository for this revision to R242 Plasma Frameworks.
Restricted Application added projects: Plasma, Frameworks.
Restricted Application added a subscriber: plasma-devel.

REVISION SUMMARY
  They are supposed to be lists. This fixes dropping folders on desktops to 
create a FolderView. Dropping trash:/ also offers to create a trash applet 
again. Don't know what else might have broken by this JSON migration...
  
  BUG: 374418

TEST PLAN
  X-Plasma-DropUrlPatterns is properly turned into a JSON array at build time 
but X-Plasma-DropMimeTypes is not and I have no idea why, ie. sticky note has 
two mime types but only gets a string (I tried both foo,bar and foo;bar; and 
foo;bar but neither works) so it is not offered for text documents

REPOSITORY
  R242 Plasma Frameworks

REVISION DETAIL
  https://phabricator.kde.org/D3902

AFFECTED FILES
  src/plasma/pluginloader.cpp
  src/scriptengines/qml/plasmoid/wallpaperinterface.cpp

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: broulik, #plasma, apol
Cc: plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas

[Differential] [Updated, 62 lines] D3892: [Icon Item] Support non-square icons

2017-01-01 Thread broulik (Kai Uwe Broulik)

broulik updated this revision to Diff 9577.

REPOSITORY
  R242 Plasma Frameworks

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D3892?vs=9561=9577

REVISION DETAIL
  https://phabricator.kde.org/D3892

AFFECTED FILES
  autotests/iconitemtest.cpp
  autotests/iconitemtest.h
  src/declarativeimports/core/iconitem.cpp
  src/declarativeimports/core/iconitem.h

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: broulik, #plasma, hein
Cc: plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas

Re: Plasma 5.9 Release Announcement

2017-01-01 Thread Marco Martin

On Sunday 01 January 2017, Martin Gräßlin wrote:
> > ‎https://share.kde.org/index.php/s/BNY8F9IuC1PT6dH
> 
> I'm not able to edit it at all. If I click that link all I have is a
> read-only document. Tried with both Firefox and Chrome and I was logged
> into share.kde.org at the same time.

same for me

-- 
Marco Martin

Re: Plasma 5.9 Release Announcement

2017-01-01 Thread Martin Gräßlin


Am 2017-01-01 17:48, schrieb Kai Uwe Broulik:

Hi all,

Happy new year!
‎
Plasma 5.9 beta is approaching fast, so I setup a document for the
release announcement.

Please fill in all the exciting new features you awesome people have
worked on, so we can get a good release announcement for the Beta and
a kick-ass video for the final!

I tried to use the new nextcloud thingie Admin setup, let's see how it 
goes*:


‎https://share.kde.org/index.php/s/BNY8F9IuC1PT6dH


I'm not able to edit it at all. If I click that link all I have is a 
read-only document. Tried with both Firefox and Chrome and I was logged 
into share.kde.org at the same time.


Cheers
Martin

[Differential] [Commented On] D3829: [touchpad] Use a separate X11 Display to monitor the XInput event.

2017-01-01 Thread xuetianweng (Xuetian Weng)

xuetianweng added a comment.


  In https://phabricator.kde.org/D3829#72924, @graesslin wrote:
  
  > I would say the overall problem is that this here still uses an XLib event 
queue. But Qt uses an xcb connection. I would say this needs a porting away 
from the XLib code and use Qt's XCB connection and event handling.
  
  
  At that time the xinput in xcb is incomplete and buggy so XLib is the only 
choice. Not sure if things change now.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D3829

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: xuetianweng, davidedmundson
Cc: knambiar, graesslin, plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas

[Differential] [Requested Changes To] D3908: [Look and feel KCM] Notify PaletteChange on DBus

2017-01-01 Thread davidedmundson (David Edmundson)

davidedmundson requested changes to this revision.
davidedmundson added a reviewer: davidedmundson.
davidedmundson added a comment.
This revision now requires changes to proceed.


  Check the "setColors" method you call on line 299
  
  It ends with: 
KGlobalSettings::self()->emitChange(KGlobalSettings::PaletteChanged);
  
  which is what this does.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D3908

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: broulik, #plasma, davidedmundson
Cc: davidedmundson, plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas

[Differential] [Commented On] D3900: Set mute when changing volume to 0 with slider

2017-01-01 Thread davidedmundson (David Edmundson)

davidedmundson added a comment.


  You've not said why

REPOSITORY
  R115 Plasma Audio Volume Applet

REVISION DETAIL
  https://phabricator.kde.org/D3900

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: drosca, #plasma
Cc: davidedmundson, plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas

[Differential] [Accepted] D3902: Fix X-Plasma-Drop* types

2017-01-01 Thread davidedmundson (David Edmundson)

davidedmundson accepted this revision.
davidedmundson added a reviewer: davidedmundson.
This revision is now accepted and ready to land.

REPOSITORY
  R242 Plasma Frameworks

REVISION DETAIL
  https://phabricator.kde.org/D3902

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: broulik, apol, #plasma, davidedmundson
Cc: plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas

[Differential] [Commented On] D3900: Set mute when changing volume to 0 with slider

2017-01-01 Thread drosca (David Rosca)

drosca added a comment.


  That's what changing volume with hotkeys is already doing.
  Also, we show mute icon when volume is 0, so we should also actually mute it.
  And at last, some hw have leds indicating mute, so this makes it light up 
when moving the slider to zero.

REPOSITORY
  R115 Plasma Audio Volume Applet

REVISION DETAIL
  https://phabricator.kde.org/D3900

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: drosca, #plasma
Cc: davidedmundson, plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas

[Differential] [Accepted] D3900: Set mute when changing volume to 0 with slider

2017-01-01 Thread davidedmundson (David Edmundson)

davidedmundson accepted this revision.
davidedmundson added a reviewer: davidedmundson.
This revision is now accepted and ready to land.

REPOSITORY
  R115 Plasma Audio Volume Applet

BRANCH
  mute-slider (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D3900

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: drosca, #plasma, davidedmundson
Cc: davidedmundson, plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas

[Differential] [Accepted] D3899: Applet: Make sure to never show empty icon

2017-01-01 Thread davidedmundson (David Edmundson)

davidedmundson accepted this revision.
davidedmundson added a reviewer: davidedmundson.
This revision is now accepted and ready to land.

REPOSITORY
  R115 Plasma Audio Volume Applet

BRANCH
  no-empty-icon (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D3899

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: drosca, #plasma, davidedmundson
Cc: plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas

[Differential] [Changed Subscribers] D3892: [Icon Item] Support non-square icons

2017-01-01 Thread davidedmundson (David Edmundson)

davidedmundson added inline comments.

INLINE COMMENTS

> iconitem.cpp:325
> +const QSize  = 
> m_iconPixmap.size().scaled(actualContainerSize, Qt::KeepAspectRatio);
> +return QSize(Units::roundToIconSize(paintedSize.width()), 
> Units::roundToIconSize(paintedSize.height()));
>  }

This makes no sense.
You can't round it to icon sizes *after* scaling, it means the shorter size is 
always just wrong.

If we do merge this patch, you want:

m_iconPixmap.size().scaled(QSize(Units.roundtoIconSize(actualContainerSize.width),
 Units.roundToIconSize(actualContainerSize.height)

> iconitem.cpp:377
>  if (m_sizeChanged) {
> -const int iconSize = 
> Units::roundToIconSize(qMin(boundingRect().size().width(), 
> boundingRect().size().height()));
> -const QRect destRect(QPointF(boundingRect().center() - 
> QPointF(iconSize/2, iconSize/2)).toPoint(),
> - QSize(iconSize, iconSize));
> -
> +const QSize  = paintedSize();
> +const QRect destRect(QPointF(boundingRect().center() - 
> QPointF(newSize.width(), newSize.height()) / 2).toPoint(), newSize);

You're using references a lot in a few patches that don't make any sense.

paintedSize returns a new QSize object; you're keeping a reference to a value 
that would just be immediately discarded. This doesn't result in an 
optimisation but instead doing something that would crash if it wasn't for a 
magic C++ feature where it lengthens the lifespan of the object.

REPOSITORY
  R242 Plasma Frameworks

REVISION DETAIL
  https://phabricator.kde.org/D3892

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: broulik, #plasma, hein
Cc: davidedmundson, plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas

[Differential] [Accepted] D3898: Applet: Don't delete delegates while drag is active

2017-01-01 Thread davidedmundson (David Edmundson)

davidedmundson accepted this revision.
davidedmundson added a reviewer: davidedmundson.
davidedmundson added a comment.
This revision is now accepted and ready to land.


  That's clever, we could do with a similar fix in kicker somewhere.

REPOSITORY
  R115 Plasma Audio Volume Applet

BRANCH
  Plasma/5.8

REVISION DETAIL
  https://phabricator.kde.org/D3898

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: drosca, #plasma, davidedmundson
Cc: davidedmundson, plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas

[Differential] [Accepted] D3904: MediaController: Stop queuedPositionUpdate timer when receiving mpris position change

2017-01-01 Thread broulik (Kai Uwe Broulik)

broulik accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R120 Plasma Workspace

BRANCH
  mediacontroller-fix1 (branched from Plasma/5.8)

REVISION DETAIL
  https://phabricator.kde.org/D3904

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: drosca, broulik, #plasma
Cc: plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas

[Differential] [Commented On] D3904: MediaController: Stop queuedPositionUpdate timer when receiving mpris position change

2017-01-01 Thread drosca (David Rosca)

drosca added a comment.


  It's wrong, sorry. Removing the timer.running check from if is correct, but 
stopping it is not. In that state, it now fixes issue with seeking to 0 but it 
still seeks to *current* position - so you may hear pause in the playing song.

REPOSITORY
  R120 Plasma Workspace

BRANCH
  mediacontroller-fix1 (branched from Plasma/5.8)

REVISION DETAIL
  https://phabricator.kde.org/D3904

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: drosca, broulik, #plasma
Cc: plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas

[Differential] [Updated, 5 lines] D3904: MediaController: Stop queuedPositionUpdate timer when receiving mpris position change

2017-01-01 Thread drosca (David Rosca)

drosca updated this revision to Diff 9581.
drosca added a comment.


  Also don't call SetPosition when slider value equals position

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D3904?vs=9579=9581

BRANCH
  mediacontroller-fix1 (branched from Plasma/5.8)

REVISION DETAIL
  https://phabricator.kde.org/D3904

AFFECTED FILES
  applets/mediacontroller/contents/ui/ExpandedRepresentation.qml

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: drosca, #plasma, broulik
Cc: plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas

[Differential] [Request, 9 lines] D3908: [Look and feel KCM] Notify PaletteChange on DBus

2017-01-01 Thread broulik (Kai Uwe Broulik)

broulik created this revision.
broulik added a reviewer: Plasma.
broulik set the repository for this revision to R119 Plasma Desktop.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.

REVISION SUMMARY
  Code taken from Colors KCM.
  
  BUG: 373328
  FIXED-IN: 5.8.6

TEST PLAN
  When I switch look and feel packages context menus in Plasma instantly 
reflect the new color choice

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D3908

AFFECTED FILES
  kcms/lookandfeel/kcm.cpp

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: broulik, #plasma
Cc: plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas

[Differential] [Request, 3 lines] D3904: MediaController: Stop queuedPositionUpdate timer when receiving mpris position change

2017-01-01 Thread drosca (David Rosca)

drosca created this revision.
drosca added reviewers: Plasma, broulik.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.

REVISION SUMMARY
  Fixes sometimes reseting position to 0 after expanding applet.

TEST PLAN
  No longer resets to start of song after showing applet

REPOSITORY
  R120 Plasma Workspace

BRANCH
  mediacontroller-fix1 (branched from Plasma/5.8)

REVISION DETAIL
  https://phabricator.kde.org/D3904

AFFECTED FILES
  applets/mediacontroller/contents/ui/ExpandedRepresentation.qml

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: drosca, #plasma, broulik
Cc: plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas

[Differential] [Request, 119 lines] D3905: [Icon Applet] Add "Open With" and "Open Containing Folder" actions

2017-01-01 Thread broulik (Kai Uwe Broulik)

broulik created this revision.
broulik added reviewers: Plasma, Plasma: Design.
broulik set the repository for this revision to R120 Plasma Workspace.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.

REVISION SUMMARY
  This adds the "Open With..." option known from Dolphin to the icon applet 
when it points to a file. Also adds a "Open Containing Folder".
  While at it, moves the action logic for jump list actions to C++ side

TEST PLAN
  - Jump list actions still work
  - Open with works, both the primary entry, submenu, and "Open with" dialog
  - "open containing folder" opens the parent folder and scrolls to the file
  
  F1689543: Screenshot_20170101_164115.png 


REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D3905

AFFECTED FILES
  applets/icon/CMakeLists.txt
  applets/icon/iconapplet.cpp
  applets/icon/iconapplet.h
  applets/icon/package/contents/ui/main.qml

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: broulik, #plasma, #plasma:_design
Cc: plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas

[Differential] [Request, 9 lines] D3906: [Icon Applet] Fully re-populate when user changes Link URL

2017-01-01 Thread broulik (Kai Uwe Broulik)

broulik created this revision.
broulik added reviewers: Plasma, dfaure.
broulik set the repository for this revision to R120 Plasma Workspace.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.

REVISION SUMMARY
  When applying KPropertiesDialog of a Link desktop file, the URL might have 
changed. In this case nuke the local file and start afresh.

TEST PLAN
  Created an icon applet pointing to a file, now changed the Link to the file, 
it updated its icon, name, open with actions, etc etc. as if I had placed a new 
icon applet.

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D3906

AFFECTED FILES
  applets/icon/iconapplet.cpp

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: broulik, #plasma, dfaure
Cc: plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas

[Differential] [Commented On] D3908: [Look and feel KCM] Notify PaletteChange on DBus

2017-01-01 Thread broulik (Kai Uwe Broulik)

broulik added a comment.


  Hmm, still able to reproduce the bug at times :/ No idea why it only affects 
plasmashell context menus, though. Other apps like Dolphin pick up the color 
right away.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D3908

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: broulik, #plasma
Cc: plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas

[Differential] [Changed Subscribers] D3822: use a native event filter to notice the screen was swapped

2017-01-01 Thread broulik (Kai Uwe Broulik)

broulik added inline comments.

INLINE COMMENTS

> screenpool.cpp:37
>  {
> +qApp->installNativeEventFilter(this);
> +

No need to install if not on X?

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D3822

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: mart, sebas, davidedmundson, #plasma
Cc: broulik, pmuralidharan, plasma-devel, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas

Plasma 5.9 Release Announcement

2017-01-01 Thread Kai Uwe Broulik

Hi all,

Happy new year!
‎
Plasma 5.9 beta is approaching fast, so I setup a document for the release 
announcement.

Please fill in all the exciting new features you awesome people have worked on, 
so we can get a good release announcement for the Beta and a kick-ass video for 
the final!

I tried to use the new nextcloud thingie Admin setup, let's see how it goes*:

‎https://share.kde.org/index.php/s/BNY8F9IuC1PT6dH

‎Cheers, 
Kai Uwe ‎
‎
* I quite dislike the A4 paper layout and font rendering is quite blurry here‎, 
not to mention subpar performance and tearing :/

[Differential] [Request, 11 lines] D3910: [Kicker] Don't nuke favorites on startup

2017-01-01 Thread broulik (Kai Uwe Broulik)

broulik created this revision.
broulik added reviewers: Plasma, hein.
broulik set the repository for this revision to R119 Plasma Desktop.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.

REVISION SUMMARY
  Likely race introduced by using QQmlParserStatus in 
https://phabricator.kde.org/R119:3e88ac63f25d526f8f7d4d58266fd303b722a1d0
  
  BUG: 374156

TEST PLAN
  Explained in the comment.
  Default favorites in Kicker show up properly and my changes persist across 
plasmashell reboots

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D3910

AFFECTED FILES
  applets/kicker/plugin/favoritesmodel.cpp

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: broulik, #plasma, hein
Cc: plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas

50 matches

Mail list logo