D25362: Don't add and remove player element if it is already in the page

[Kai Uwe Broulik]

broulik created this revision.
broulik added reviewers: Plasma, fvogt, tasossahanidis.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
broulik requested review of this revision.

REVISION SUMMARY
  In case the player has genuinely been added to the website as visible player 
control.
  
  CCBUG: 411742

TEST PLAN
  - Wikipedia player works again: https://en.wikipedia.org/wiki/File:Thunder.ogg
  - All of the test cases in D24870  still 
work

REPOSITORY
  R856 Plasma Browser Integration

REVISION DETAIL
  https://phabricator.kde.org/D25362

AFFECTED FILES
  extension/content-script.js

To: broulik, #plasma, fvogt, tasossahanidis
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, 
ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D24070: Don't use toolTipMainText to show info, rather use the second line

[Kai Uwe Broulik]

broulik added inline comments.

INLINE COMMENTS

> batterymonitor.qml:72
> +if (powermanagementDisabled) {
> +return i18n("Power management is disabled");
> +}

This early return still hasn't been addressed.
When I keep the screen on I still want to see my remaining battery time.

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D24070

To: mthw, ngraham, #vdg, #plasma, broulik, ndavis
Cc: ndavis, broulik, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D25362: Don't add and remove player element if it is already in the page

[Tasos Sahanidis]

tasossahanidis accepted this revision.
tasossahanidis added a comment.
This revision is now accepted and ready to land.


  I can confirm that the Wikipedia player works correctly again, as well as the 
websites outlined in the test cases (that I have access to) continue to 
function as expected.
  
  Thank you

REPOSITORY
  R856 Plasma Browser Integration

REVISION DETAIL
  https://phabricator.kde.org/D25362

To: broulik, #plasma, fvogt, tasossahanidis
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, 
ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D25362: Don't add and remove player element if it is already in the page

[Kai Uwe Broulik]

This revision was automatically updated to reflect the committed changes.
Closed by commit R856:47a2790188bf: Dont add and remove player element if 
it is already in the page (authored by broulik).

REPOSITORY
  R856 Plasma Browser Integration

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D25362?vs=69904=69905

REVISION DETAIL
  https://phabricator.kde.org/D25362

AFFECTED FILES
  extension/content-script.js

To: broulik, #plasma, fvogt, tasossahanidis
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, 
ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D24070: Don't use toolTipMainText to show info, rather use the second line

[Matej Mrenica]

mthw updated this revision to Diff 69910.
mthw added a comment.


  Done

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D24070?vs=69869=69910

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D24070

AFFECTED FILES
  applets/batterymonitor/package/contents/ui/batterymonitor.qml

To: mthw, ngraham, #vdg, #plasma, broulik, ndavis
Cc: ndavis, broulik, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

KDE CI: Plasma » kmenuedit » kf5-qt5 SUSEQt5.12 - Build # 35 - Failure!

[CI System]

BUILD FAILURE
 Build URL
https://build.kde.org/job/Plasma/job/kmenuedit/job/kf5-qt5%20SUSEQt5.12/35/
 Project:
kf5-qt5 SUSEQt5.12
 Date of build:
Mon, 18 Nov 2019 10:15:49 +
 Build duration:
1 min 20 sec and counting
   CONSOLE OUTPUT
  [...truncated 327 lines...][2019-11-18T10:16:59.169Z] -- Found KF5DBusAddons: /home/jenkins/install-prefix/lib64/cmake/KF5DBusAddons/KF5DBusAddonsConfig.cmake (found version "5.65.0") [2019-11-18T10:16:59.169Z] -- Found KF5IconThemes: /home/jenkins/install-prefix/lib64/cmake/KF5IconThemes/KF5IconThemesConfig.cmake (found version "5.65.0") [2019-11-18T10:16:59.429Z] -- Found KF5KIO: /home/jenkins/install-prefix/lib64/cmake/KF5KIO/KF5KIOConfig.cmake (found version "5.65.0") [2019-11-18T10:16:59.429Z] -- Found KF5ItemViews: /home/jenkins/install-prefix/lib64/cmake/KF5ItemViews/KF5ItemViewsConfig.cmake (found version "5.65.0") [2019-11-18T10:16:59.429Z] -- Found KF5Sonnet: /home/jenkins/install-prefix/lib64/cmake/KF5Sonnet/KF5SonnetConfig.cmake (found version "5.65.0") [2019-11-18T10:16:59.429Z] -- Found KF5DocTools: /home/jenkins/install-prefix/lib64/cmake/KF5DocTools/KF5DocToolsConfig.cmake (found version "5.65.0") [2019-11-18T10:16:59.429Z] -- Found KF5Init: /home/jenkins/install-prefix/lib64/cmake/KF5Init/KF5InitConfig.cmake (found version "5.65.0") [2019-11-18T10:16:59.429Z] -- Found KF5GlobalAccel: /home/jenkins/install-prefix/lib64/cmake/KF5GlobalAccel/KF5GlobalAccelConfig.cmake (found version "5.65.0") [2019-11-18T10:16:59.429Z] -- Found KF5: success (found suitable version "5.65.0", minimum required is "5.62.0") found components:  I18n XmlGui DBusAddons IconThemes KIO ItemViews Sonnet DocTools Init GlobalAccel [2019-11-18T10:16:59.429Z] -- The following OPTIONAL packages have been found:[2019-11-18T10:16:59.429Z] [2019-11-18T10:16:59.429Z]  * Qt5Gui (required version >= 5.12.5)[2019-11-18T10:16:59.429Z]  * KF5Service (required version >= 5.64.0)[2019-11-18T10:16:59.429Z]  * KF5Bookmarks (required version >= 5.64.0)[2019-11-18T10:16:59.429Z]  * KF5JobWidgets (required version >= 5.64.0)[2019-11-18T10:16:59.429Z]  * KF5Solid (required version >= 5.64.0)[2019-11-18T10:16:59.429Z]  * KF5CoreAddons (required version >= 5.64.0)[2019-11-18T10:16:59.429Z]  * KF5Auth (required version >= 5.64.0)[2019-11-18T10:16:59.429Z]  * KF5Codecs (required version >= 5.64.0)[2019-11-18T10:16:59.429Z]  * KF5Config (required version >= 5.64.0)[2019-11-18T10:16:59.429Z] [2019-11-18T10:16:59.429Z] -- The following REQUIRED packages have been found:[2019-11-18T10:16:59.429Z] [2019-11-18T10:16:59.429Z]  * ECM (required version >= 5.62.0)[2019-11-18T10:16:59.429Z]  * Qt5 (required version >= 5.12.0)[2019-11-18T10:16:59.429Z]  * Gettext[2019-11-18T10:16:59.429Z]  * KF5I18n (required version >= 5.62.0)[2019-11-18T10:16:59.429Z]  * KF5DBusAddons (required version >= 5.62.0)[2019-11-18T10:16:59.429Z]  * KF5IconThemes (required version >= 5.62.0)[2019-11-18T10:16:59.429Z]  * Qt5Xml (required version >= 5.11.0)[2019-11-18T10:16:59.429Z]  * KF5KIO (required version >= 5.62.0)[2019-11-18T10:16:59.429Z]  * KF5ItemViews (required version >= 5.62.0)[2019-11-18T10:16:59.429Z]  * KF5Sonnet (required version >= 5.62.0)[2019-11-18T10:16:59.429Z]  * Qt5Core (required version >= 5.11.0)[2019-11-18T10:16:59.429Z]  * KF5DocTools (required version >= 5.62.0)[2019-11-18T10:16:59.429Z]  * KF5Init (required version >= 5.62.0)[2019-11-18T10:16:59.429Z]  * Qt5DBus (required version >= 5.11.0)[2019-11-18T10:16:59.429Z]  * KF5GlobalAccel (required version >= 5.62.0)[2019-11-18T10:16:59.429Z]  * KF5 (required version >= 5.62.0)[2019-11-18T10:16:59.429Z] [2019-11-18T10:16:59.429Z] -- Configuring done[2019-11-18T10:16:59.429Z] -- Generating done[2019-11-18T10:16:59.429Z] -- Build files have been written to: /home/jenkins/workspace/Plasma/kmenuedit/kf5-qt5 SUSEQt5.12/build[Pipeline] }[Pipeline] // stage[Pipeline] stage[Pipeline] { (Compiling)[Pipeline] sh[2019-11-18T10:17:01.151Z] + python3 -u ci-tooling/helpers/compile-build.py --product Plasma --project kmenuedit --branchGroup kf5-qt5 --platform SUSEQt5.12 --usingInstall /home/jenkins//install-prefix/[2019-11-18T10:17:01.151Z] Scanning dependencies of target kdeinit_kmenuedit_autogen[2019-11-18T10:17:01.151Z] Scanning dependencies of target kmenuedit_globalaccel_autogen[2019-11-18T10:17:01.151Z] Scanning dependencies of target kmenuedit_autogen[2019-11-18T10:17:01.151Z] Scanning dependencies of target doc-index-cache-bz2[2019-11-18T10:17:01.151Z] [ 14%] Automatic MOC for target kdeinit_kmenuedit[2019-11-18T10:17:01.151Z] [ 14%] Generating index.cache.bz2[2019-11-18T10:17:01.151Z] [ 14%] Automatic MOC for target kmenuedit_globalaccel[2019-11-18T10:17:01.151Z] [ 14%] Automatic MOC for target kmenuedit[2019-11-18T10:17:01.151Z] [ 14%] Built target kmenuedit_globalaccel_autogen[2019-11-18T10:17:01.151Z] [ 14%] Built target kmenuedit_autogen[2019-11-18T10:17:01.151Z] Scanning dependencies of target 

KDE CI: Plasma » kmenuedit » kf5-qt5 FreeBSDQt5.13 - Build # 24 - Failure!

[CI System]

BUILD FAILURE
 Build URL
https://build.kde.org/job/Plasma/job/kmenuedit/job/kf5-qt5%20FreeBSDQt5.13/24/
 Project:
kf5-qt5 FreeBSDQt5.13
 Date of build:
Mon, 18 Nov 2019 10:15:49 +
 Build duration:
1 min 17 sec and counting
   CONSOLE OUTPUT
  [...truncated 257 lines...][2019-11-18T10:17:00.058Z] -- Performing Test _OFFT_IS_64BIT[2019-11-18T10:17:00.058Z] -- Performing Test _OFFT_IS_64BIT - Success[2019-11-18T10:17:00.058Z] -- Performing Test HAVE_DATE_TIME[2019-11-18T10:17:00.058Z] -- Performing Test HAVE_DATE_TIME - Success[2019-11-18T10:17:00.058Z] -- Found Gettext: /usr/local/bin/msgmerge (found version "0.20.1") [2019-11-18T10:17:00.058Z] -- Found KF5I18n: /usr/home/jenkins/install-prefix/lib/cmake/KF5I18n/KF5I18nConfig.cmake (found version "5.65.0") [2019-11-18T10:17:00.058Z] -- Found KF5XmlGui: /usr/home/jenkins/install-prefix/lib/cmake/KF5XmlGui/KF5XmlGuiConfig.cmake (found version "5.65.0") [2019-11-18T10:17:00.058Z] -- Found KF5DBusAddons: /usr/home/jenkins/install-prefix/lib/cmake/KF5DBusAddons/KF5DBusAddonsConfig.cmake (found version "5.65.0") [2019-11-18T10:17:00.058Z] -- Found KF5IconThemes: /usr/home/jenkins/install-prefix/lib/cmake/KF5IconThemes/KF5IconThemesConfig.cmake (found version "5.65.0") [2019-11-18T10:17:00.058Z] -- Found KF5KIO: /usr/home/jenkins/install-prefix/lib/cmake/KF5KIO/KF5KIOConfig.cmake (found version "5.65.0") [2019-11-18T10:17:00.058Z] -- Found KF5ItemViews: /usr/home/jenkins/install-prefix/lib/cmake/KF5ItemViews/KF5ItemViewsConfig.cmake (found version "5.65.0") [2019-11-18T10:17:00.058Z] -- Found KF5Sonnet: /usr/home/jenkins/install-prefix/lib/cmake/KF5Sonnet/KF5SonnetConfig.cmake (found version "5.65.0") [2019-11-18T10:17:00.058Z] -- Found KF5DocTools: /usr/home/jenkins/install-prefix/lib/cmake/KF5DocTools/KF5DocToolsConfig.cmake (found version "5.65.0") [2019-11-18T10:17:00.058Z] -- Found KF5Init: /usr/home/jenkins/install-prefix/lib/cmake/KF5Init/KF5InitConfig.cmake (found version "5.65.0") [2019-11-18T10:17:00.058Z] -- Found KF5GlobalAccel: /usr/home/jenkins/install-prefix/lib/cmake/KF5GlobalAccel/KF5GlobalAccelConfig.cmake (found version "5.65.0") [2019-11-18T10:17:00.058Z] -- Found KF5: success (found suitable version "5.65.0", minimum required is "5.62.0") found components:  I18n XmlGui DBusAddons IconThemes KIO ItemViews Sonnet DocTools Init GlobalAccel [2019-11-18T10:17:00.314Z] -- The following OPTIONAL packages have been found:[2019-11-18T10:17:00.314Z] [2019-11-18T10:17:00.314Z]  * Qt5Gui (required version >= 5.13.0)[2019-11-18T10:17:00.314Z] [2019-11-18T10:17:00.314Z] -- The following REQUIRED packages have been found:[2019-11-18T10:17:00.314Z] [2019-11-18T10:17:00.314Z]  * ECM (required version >= 5.62.0)[2019-11-18T10:17:00.314Z]  * Qt5Core[2019-11-18T10:17:00.314Z]  * Qt5DBus[2019-11-18T10:17:00.314Z]  * Qt5Xml[2019-11-18T10:17:00.314Z]  * Qt5 (required version >= 5.12.0)[2019-11-18T10:17:00.314Z]  * Gettext[2019-11-18T10:17:00.314Z]  * KF5I18n (required version >= 5.62.0)[2019-11-18T10:17:00.314Z]  * KF5XmlGui (required version >= 5.62.0)[2019-11-18T10:17:00.314Z]  * KF5DBusAddons (required version >= 5.62.0)[2019-11-18T10:17:00.314Z]  * KF5IconThemes (required version >= 5.62.0)[2019-11-18T10:17:00.314Z]  * KF5KIO (required version >= 5.62.0)[2019-11-18T10:17:00.314Z]  * KF5ItemViews (required version >= 5.62.0)[2019-11-18T10:17:00.314Z]  * KF5Sonnet (required version >= 5.62.0)[2019-11-18T10:17:00.314Z]  * KF5DocTools (required version >= 5.62.0)[2019-11-18T10:17:00.314Z]  * KF5Init (required version >= 5.62.0)[2019-11-18T10:17:00.314Z]  * KF5GlobalAccel (required version >= 5.62.0)[2019-11-18T10:17:00.314Z]  * KF5 (required version >= 5.62.0)[2019-11-18T10:17:00.314Z] [2019-11-18T10:17:00.314Z] -- Configuring done[2019-11-18T10:17:00.314Z] -- Generating done[2019-11-18T10:17:00.314Z] -- Build files have been written to: /usr/home/jenkins/workspace/Plasma/kmenuedit/kf5-qt5 FreeBSDQt5.13/build[Pipeline] }[Pipeline] // stage[Pipeline] stage[Pipeline] { (Compiling)[Pipeline] sh[2019-11-18T10:17:01.867Z] + python3 -u ci-tooling/helpers/compile-build.py --product Plasma --project kmenuedit --branchGroup kf5-qt5 --platform FreeBSDQt5.13 --usingInstall /home/jenkins/install-prefix/[2019-11-18T10:17:02.131Z] Scanning dependencies of target kmenuedit_autogen[2019-11-18T10:17:02.131Z] Scanning dependencies of target kmenuedit_globalaccel_autogen[2019-11-18T10:17:02.131Z] Scanning dependencies of target doc-index-cache-bz2[2019-11-18T10:17:02.131Z] Scanning dependencies of target kdeinit_kmenuedit_autogen[2019-11-18T10:17:02.131Z] [  7%] Automatic MOC for target kdeinit_kmenuedit[2019-11-18T10:17:02.131Z] [ 11%] Automatic MOC for target kmenuedit_globalaccel[2019-11-18T10:17:02.131Z] [ 14%] Automatic MOC for target kmenuedit[2019-11-18T10:17:02.131Z] [ 14%] Generating index.cache.bz2[2019-11-18T10:17:02.131Z] [ 14%] Built target kmenuedit_globalaccel_autogen[2019-11-18T10:17:02.131Z] [ 14%] Built target 

KDE CI: Plasma » kmenuedit » kf5-qt5 SUSEQt5.12 - Build # 36 - Fixed!

[CI System]

BUILD SUCCESS
 Build URL
https://build.kde.org/job/Plasma/job/kmenuedit/job/kf5-qt5%20SUSEQt5.12/36/
 Project:
kf5-qt5 SUSEQt5.12
 Date of build:
Mon, 18 Nov 2019 11:32:34 +
 Build duration:
2 min 7 sec and counting
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report0%
(0/2)0%
(0/15)0%
(0/15)0%
(0/2214)0%
(0/1245)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsdefault0%
(0/14)0%
(0/14)0%
(0/2174)0%
(0/1229)kconf_update0%
(0/1)0%
(0/1)0%
(0/40)0%
(0/16)

D25363: Fix one more buffer overread in ksysguard network helper

[Malte Kraus]

maltek created this revision.
maltek added reviewers: ahiemstra, fvogt.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
maltek requested review of this revision.

REVISION SUMMARY
  fix one more bug in the ksysguard network helper found by my fuzzer.

REPOSITORY
  R106 KSysguard

REVISION DETAIL
  https://phabricator.kde.org/D25363

AFFECTED FILES
  plugins/process/network/helper/Packet.cpp

To: maltek, ahiemstra, fvogt
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, 
ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D25361: [Workspace KCM] Expose setting to choose what left-clicking in the scrollbar track does

[David Edmundson]

davidedmundson added a comment.


  We have all other scrollbar settings in:
  
  breeze -> settings -> scrollbars
  
  Which has the added advantage that it won't be shown if it's not supported, 
for example if you use Fusion.

REPOSITORY
  R119 Plasma Desktop

BRANCH
  left-click-warps-scrollbar-settings-ui (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D25361

To: ngraham, #plasma, #vdg, ndavis
Cc: davidedmundson, ndavis, gikari, plasma-devel, LeGast00n, The-Feren-OS-Dev, 
jraleigh, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D25086: Port to KGlobalAccel

[David Redondo]

This revision was automatically updated to reflect the committed changes.
Closed by commit R103:507bc58bf3e8: Port to KGlobalAccel (authored by davidre).

REPOSITORY
  R103 KMenu Editor

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D25086?vs=69577=69913

REVISION DETAIL
  https://phabricator.kde.org/D25086

AFFECTED FILES
  CMakeLists.txt
  basictab.cpp
  globalaccel.cpp
  globalaccel.h
  kconf_update/CMakeLists.txt
  kconf_update/globalaccel.cpp
  kconf_update/globalaccel.upd
  khotkeys.cpp
  khotkeys.h
  main.cpp
  menuinfo.cpp

To: davidre, #plasma, davidedmundson, mlaurent
Cc: apol, mlaurent, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, ahiemstra, mart

KDE CI: Plasma » kmenuedit » kf5-qt5 FreeBSDQt5.13 - Build # 25 - Fixed!

[CI System]

BUILD SUCCESS
 Build URL
https://build.kde.org/job/Plasma/job/kmenuedit/job/kf5-qt5%20FreeBSDQt5.13/25/
 Project:
kf5-qt5 FreeBSDQt5.13
 Date of build:
Mon, 18 Nov 2019 11:32:34 +
 Build duration:
1 min 2 sec and counting

monday meeting notes for 18/11/2019

[Marco Martin]

Kai Uwe:
plasma-browser-integration:
* Improved error reporting
* Startup error message (e.g. "native messaging host not found")
is now also shown in popup. Previously only runtime errors (e.g. host
crashed) were shown to the user
* Merged audio playback issue fix/hack
* Did a follow-up fix this morning
* Planning to do a new release end of this week
Other:
* Fixed qqc2-desktop-style ComboBox dimming pure-QML apps when open
(was default Popup behavior when modal)
* Made a patch for Chromium so the "show in folder" in Downloads
actually highlights the file using FileManager1 DBus API
* Will attend Frameworks 6 sprint in Berlin end of this week

David Edmundson:
* I merged / am merging the QML plugin into KItemModels
* including the Plasma SortFilterProxyModel
* it's an opportunity to do API changes, so this hasn't been as much
of a simple copy pasta as I'd hoped
* fixed a crasher in kirigami (columnview componentspool)
* next week qtcs and kf6 sprint

Nico Fe:
* Worked on a patch that allows to get rid of the KXMLGui dependency
in KBookmarks for kf6
* That will cut down the monstrous dependecy tree of KIO quite a bit
* Besides that I prepared some tasks for KF6 sprint

David Redondo:
* I only have one thing: Port kmenuedit to kglobalccel
* Which the ci  is currently failing on :D
* And I created a task for KGlobalAccel for KF6 because it currently is meh
* I will also be at Frameworks sprint so we can unmeh it :)

Marco:
# Kirigami
* Started direct support in globaldrawer for toolbars for the desktop
use case of app sidebar. Semi automatic way to switch between a
desktop toolbar and mobile big image thing
# KWin
* Finished/merged D25146
Diff 25146 "try to enforce borders settings from KWin" [Closed]
https://phabricator.kde.org/D25146
# Other
* next week kf6 sprint

D25363: Fix one more buffer overread in ksysguard network helper

[Fabian Vogt]

fvogt requested changes to this revision.
fvogt added a comment.
This revision now requires changes to proceed.


  I wonder whether this can actually happen, as that header is AFAICT added by 
the kernel and not from the network.
  
  The `Packet` constructor has both `dataLength` and `packetSize` parameters, 
which are equal to the pcap header's `caplen` and `len`, respectively, and only 
the former specifies how much data is actually available in the buffer.
  So the comparison has to use `dataLength`, like the code below.

REPOSITORY
  R106 KSysguard

REVISION DETAIL
  https://phabricator.kde.org/D25363

To: maltek, ahiemstra, fvogt
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, 
ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

KDE CI: Plasma » kwin » stable-kf5-qt5 FreeBSDQt5.13 - Build # 73 - Failure!

[CI System]

BUILD FAILURE
 Build URL
https://build.kde.org/job/Plasma/job/kwin/job/stable-kf5-qt5%20FreeBSDQt5.13/73/
 Project:
stable-kf5-qt5 FreeBSDQt5.13
 Date of build:
Mon, 18 Nov 2019 10:29:50 +
 Build duration:
5 min 30 sec and counting
   CONSOLE OUTPUT
  [...truncated 3185 lines...][2019-11-18T10:35:11.159Z] [ 60%] Generating kwin_effects_interface.cpp, kwin_effects_interface.h[2019-11-18T10:35:11.159Z] [ 60%] Generating kwin_effects_interface.cpp, kwin_effects_interface.h[2019-11-18T10:35:11.159Z] Scanning dependencies of target kwin_wayland_autogen[2019-11-18T10:35:11.159Z] [ 61%] Automatic MOC for target kdeinit_kwin_x11[2019-11-18T10:35:11.159Z] [ 61%] Automatic MOC for target kwin_wayland[2019-11-18T10:35:11.159Z] [ 61%] Generating ui_main.h[2019-11-18T10:35:11.159Z] Scanning dependencies of target KF5GlobalAccelPrivateKWin_autogen[2019-11-18T10:35:11.159Z] [ 61%] Generating kwin_effects_interface.moc[2019-11-18T10:35:11.159Z] [ 61%] Generating kwin_effects_interface.cpp, kwin_effects_interface.h[2019-11-18T10:35:11.159Z] [ 61%] Generating kwin_effects_interface.moc[2019-11-18T10:35:11.159Z] [ 61%] Automatic MOC for target KF5GlobalAccelPrivateKWin[2019-11-18T10:35:11.159Z] gmake[2]: *** [kcmkwin/kwinscreenedges/CMakeFiles/kcm_kwinscreenedges.dir/build.make:62: kcmkwin/kwinscreenedges/kwin_effects_interface.moc] Segmentation fault (core dumped)[2019-11-18T10:35:11.159Z] gmake[1]: *** [CMakeFiles/Makefile2:1484: kcmkwin/kwinscreenedges/CMakeFiles/kcm_kwinscreenedges.dir/all] Error 2[2019-11-18T10:35:11.159Z] gmake[1]: *** Waiting for unfinished jobs[2019-11-18T10:35:11.159Z] [ 61%] Generating kwin_effects_interface.moc[2019-11-18T10:35:11.159Z] [ 61%] Generating kwin_effects_interface.moc[2019-11-18T10:35:11.159Z] Scanning dependencies of target testPluginEffectLoader[2019-11-18T10:35:11.159Z] Scanning dependencies of target kcmkwincommon[2019-11-18T10:35:11.159Z] [ 61%] Building CXX object autotests/CMakeFiles/testPluginEffectLoader.dir/testPluginEffectLoader_autogen/mocs_compilation.cpp.o[2019-11-18T10:35:11.159Z] [ 61%] Building CXX object autotests/CMakeFiles/testPluginEffectLoader.dir/__/effectloader.cpp.o[2019-11-18T10:35:11.159Z] [ 61%] Building CXX object kcmkwin/common/CMakeFiles/kcmkwincommon.dir/kcmkwincommon_autogen/mocs_compilation.cpp.o[2019-11-18T10:35:11.159Z] Scanning dependencies of target kcm_kwintouchscreen[2019-11-18T10:35:11.435Z] [ 61%] Building CXX object kcmkwin/kwinscreenedges/CMakeFiles/kcm_kwintouchscreen.dir/kcm_kwintouchscreen_autogen/mocs_compilation.cpp.o[2019-11-18T10:35:12.025Z] Scanning dependencies of target testScriptedEffectLoader[2019-11-18T10:35:12.025Z] Scanning dependencies of target kcm_kwintabbox[2019-11-18T10:35:12.025Z] [ 61%] Building CXX object autotests/CMakeFiles/testScriptedEffectLoader.dir/testScriptedEffectLoader_autogen/mocs_compilation.cpp.o[2019-11-18T10:35:12.025Z] [ 61%] Building CXX object kcmkwin/kwintabbox/CMakeFiles/kcm_kwintabbox.dir/kcm_kwintabbox_autogen/mocs_compilation.cpp.o[2019-11-18T10:35:12.301Z] [ 61%] Built target KF5GlobalAccelPrivateKWin_autogen[2019-11-18T10:35:12.301Z] [ 61%] Building CXX object autotests/CMakeFiles/testPluginEffectLoader.dir/mock_effectshandler.cpp.o[2019-11-18T10:35:12.568Z] [ 61%] Built target kwin_wayland_autogen[2019-11-18T10:35:12.568Z] [ 61%] Building CXX object autotests/CMakeFiles/testPluginEffectLoader.dir/test_plugin_effectloader.cpp.o[2019-11-18T10:35:13.179Z] [ 61%] Built target kdeinit_kwin_x11_autogen[2019-11-18T10:35:13.179Z] [ 61%] Building CXX object kcmkwin/kwinscreenedges/CMakeFiles/kcm_kwintouchscreen.dir/touch.cpp.o[2019-11-18T10:35:13.461Z] [ 61%] Building CXX object kcmkwin/common/CMakeFiles/kcmkwincommon.dir/effectsmodel.cpp.o[2019-11-18T10:35:13.764Z] [ 61%] Building CXX object kcmkwin/kwinscreenedges/CMakeFiles/kcm_kwintouchscreen.dir/monitor.cpp.o[2019-11-18T10:35:13.764Z] [ 61%] Building CXX object kcmkwin/kwinscreenedges/CMakeFiles/kcm_kwintouchscreen.dir/screenpreviewwidget.cpp.o[2019-11-18T10:35:14.043Z] [ 61%] Building CXX object kcmkwin/kwinscreenedges/CMakeFiles/kcm_kwintouchscreen.dir/kwin_effects_interface.cpp.o[2019-11-18T10:35:14.323Z] [ 61%] Building CXX object autotests/CMakeFiles/testScriptedEffectLoader.dir/__/effectloader.cpp.o[2019-11-18T10:35:14.603Z] [ 61%] Building CXX object kcmkwin/kwintabbox/CMakeFiles/kcm_kwintabbox.dir/__/__/tabbox/tabboxconfig.cpp.o[2019-11-18T10:35:14.864Z] [ 61%] Building CXX object kcmkwin/common/CMakeFiles/kcmkwincommon.dir/kwin_effects_interface.cpp.o[2019-11-18T10:35:15.452Z] [ 61%] Building CXX object kcmkwin/kwintabbox/CMakeFiles/kcm_kwintabbox.dir/layoutpreview.cpp.o[2019-11-18T10:35:15.452Z] [ 61%] Building CXX object kcmkwin/kwintabbox/CMakeFiles/kcm_kwintabbox.dir/main.cpp.o[2019-11-18T10:35:15.452Z] [ 61%] Building CXX object kcmkwin/kwintabbox/CMakeFiles/kcm_kwintabbox.dir/thumbnailitem.cpp.o[2019-11-18T10:35:16.043Z] [ 61%] Building CXX object 

D25363: Fix one more buffer overread in ksysguard network helper

[Malte Kraus]

maltek abandoned this revision.
maltek added a comment.


  Indeed, you're right. This bug was just an artifact of my fuzzing harness.

REPOSITORY
  R106 KSysguard

REVISION DETAIL
  https://phabricator.kde.org/D25363

To: maltek, ahiemstra, fvogt
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, 
ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D25279: [Applet] Only re-enable BT after disabling airplane mode if it was on before

[Jan Grulich]

jgrulich added a comment.


  In D25279#562998 , @ngraham wrote:
  
  > Hmm, reading the code more closely, it looks like it should already work. 
In fact, when I remove all my changes... it does work! I could have sworn that 
it didn't work before though.
  >
  > Does this make any sense? Could it have been fixed by 
7dd740aa963057c255fbbe83366504bbe48a240e 
?
  
  
  Not sure whether the change mentioned above, but it should indeed work just 
fine. The "else if" branch checks whether an adapter was enabled before so it 
does what it's supposed to do.

REPOSITORY
  R116 Plasma Network Management Applet

REVISION DETAIL
  https://phabricator.kde.org/D25279

To: ngraham, #plasma, jgrulich
Cc: davidedmundson, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D25201: Don't set X-Plasma-MainScript for wallpaper plugins

[Vlad Zahorodnii]

This revision was automatically updated to reflect the committed changes.
Closed by commit R120:cf54a3e77395: Dont set X-Plasma-MainScript for 
wallpaper plugins (authored by zzag).

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D25201?vs=69411=69906

REVISION DETAIL
  https://phabricator.kde.org/D25201

AFFECTED FILES
  wallpapers/color/metadata.desktop
  wallpapers/image/imagepackage/metadata.desktop
  wallpapers/image/slideshowpackage/metadata.desktop

To: zzag, #plasma, davidedmundson
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, 
ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

KDE CI: Plasma » kscreenlocker » kf5-qt5 SUSEQt5.12 - Build # 59 - Still unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Plasma/job/kscreenlocker/job/kf5-qt5%20SUSEQt5.12/59/
 Project:
kf5-qt5 SUSEQt5.12
 Date of build:
Mon, 18 Nov 2019 12:32:10 +
 Build duration:
4 min 20 sec and counting
   BUILD ARTIFACTS
  abi-compatibility-results.yamlacc/KScreenLocker-5.17.80.xmlcompat_reports/KScreenLocker_compat_report.htmllogs/KScreenLocker/5.17.80/log.txt
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot Failed: 0 test(s), Passed: 4 test(s), Skipped: 0 test(s), Total: 4 test(s)Name: projectroot.greeter Failed: 1 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 2 test(s)Failed: projectroot.greeter.autotests.kscreenlocker_killTest
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report67%
(4/6)73%
(30/41)73%
(30/41)52%
(1769/3423)25%
(509/2017)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsdefault93%
(14/15)93%
(14/15)62%
(865/1404)39%
(252/652)autotests75%
(6/8)75%
(6/8)79%
(326/413)39%
(81/210)greeter73%
(8/11)73%
(8/11)35%
(468/1328)14%
(140/1037)greeter.autotests100%
(2/2)100%
(2/2)97%
(110/113)55%
(36/66)kcm0%
(0/2)0%
(0/2)0%
(0/126)0%
(0/44)tests0%
(0/3)0%
(0/3)0%
(0/39)0%
(0/8)

KDE CI: Plasma » kscreenlocker » kf5-qt5 FreeBSDQt5.13 - Build # 39 - Still unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Plasma/job/kscreenlocker/job/kf5-qt5%20FreeBSDQt5.13/39/
 Project:
kf5-qt5 FreeBSDQt5.13
 Date of build:
Mon, 18 Nov 2019 12:32:11 +
 Build duration:
3 min 44 sec and counting
   JUnit Tests
  Name: projectroot Failed: 0 test(s), Passed: 4 test(s), Skipped: 0 test(s), Total: 4 test(s)Name: projectroot.greeter Failed: 1 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 2 test(s)Failed: projectroot.greeter.autotests.kscreenlocker_killTest

Software translations

[David Rebolo Magariños]

Hello there,

I was wondering if Plasma Mobile has an official site for translators to
translate their ROM to our respective languages? If so, what is it call?




Thank you for answering my question,


David Rebolo Magariños

D25354: Fix POTD config ComboBox display issue in Lock Screen KCM

[Yunhe Guo]

guoyunhe added a comment.


  Another approach is to shorten the texts:
  
  F7769821: image.png 

REPOSITORY
  R114 Plasma Addons

REVISION DETAIL
  https://phabricator.kde.org/D25354

To: guoyunhe, #plasma
Cc: ngraham, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, 
GB_2, ragreen, ZrenBot, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D25223: Avoid side effects during menu initialization

[Konrad Materka]

This revision was automatically updated to reflect the committed changes.
Closed by commit R135:3c78453b: Avoid side effects during menu 
initialization (authored by kmaterka).

REPOSITORY
  R135 Integration for Qt applications in Plasma

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D25223?vs=69634=69924

REVISION DETAIL
  https://phabricator.kde.org/D25223

AFFECTED FILES
  src/platformtheme/kdeplatformsystemtrayicon.cpp
  src/platformtheme/kdeplatformsystemtrayicon.h

To: kmaterka, #plasma, #frameworks, broulik
Cc: nicolasfella, davidedmundson, cgiboudeaux, plasma-devel, LeGast00n, 
The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, 
alexeymin, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, 
apol, ahiemstra, mart

KDE CI: Plasma » kwin » kf5-qt5 SUSEQt5.12 - Build # 434 - Fixed!

[CI System]

BUILD SUCCESS
 Build URL
https://build.kde.org/job/Plasma/job/kwin/job/kf5-qt5%20SUSEQt5.12/434/
 Project:
kf5-qt5 SUSEQt5.12
 Date of build:
Thu, 14 Nov 2019 14:20:10 +
 Build duration:
48 min and counting
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot Failed: 0 test(s), Passed: 19 test(s), Skipped: 0 test(s), Total: 19 test(s)Name: projectroot.autotests Failed: 0 test(s), Passed: 108 test(s), Skipped: 0 test(s), Total: 108 test(s)Name: projectroot.autotests.integration Failed: 0 test(s), Passed: 20 test(s), Skipped: 0 test(s), Total: 20 test(s)
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report70%
(59/84)57%
(320/558)57%
(320/558)42%
(31131/73439)32%
(14255/44252)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsdefault87%
(132/152)87%
(132/152)66%
(19373/29544)51%
(9982/19643)colorcorrection100%
(4/4)100%
(4/4)81%
(464/575)59%
(200/341)data0%
(0/1)0%
(0/1)0%
(0/30)0%
(0/8)decorations100%
(10/10)100%
(10/10)81%
(451/555)66%
(141/214)effects100%
(2/2)100%
(2/2)99%
(156/158)86%
(24/28)effects.backgroundcontrast25%
(1/4)25%
(1/4)4%
(14/379)4%
(12/292)effects.blur20%
(1/5)20%
(1/5)2%
(14/693)3%
(13/405)effects.colorpicker100%
(2/2)100%
(2/2)19%
(12/62)8%
(2/24)effects.coverswitch33%
(1/3)33%
(1/3)0%
(2/657)1%
(4/530)effects.cube25%
(1/4)25%
(1/4)0%
(2/1291)0%
(0/1015)effects.cubeslide67%
(2/3)67%
(2/3)33%
(158/480)19%
(72/374)effects.desktopgrid67%
(2/3)67%
(2/3)8%
(82/1027)3%
(33/962)effects.diminactive33%
(1/3)33%
(1/3)13%
(30/233)2%
(3/158)effects.fallapart100%
(2/2)100%
(2/2)34%
(38/111)26%
(17/66)effects.flipswitch33%
(1/3)33%
(1/3)7%
(46/657)1%
(5/552)effects.glide67%
(2/3)67%
(2/3)72%
(150/208)65%
(60/93)effects.highlightwindow100%
(2/2)100%
(2/2)40%
   

Re: Plasma 5.17.3

[Mike Simms]

How come Neon User Edition hasn't been updated yet? Are there packaging 
issues or did you guys just forget to push the packages?

On 12/11/2019 13:40, Jonathan Riddell wrote:
> Plasma 5.17.3 is now released 
> https://www.kde.org/announcements/plasma-5.17.3.php
>

D25354: Fix POTD config ComboBox display issue in Lock Screen KCM

[Yunhe Guo]

guoyunhe updated this revision to Diff 69922.
guoyunhe edited the summary of this revision.
guoyunhe added a comment.


  Shorten POTD provider names and remove descriptions that are never used 
anywhere.

REPOSITORY
  R114 Plasma Addons

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D25354?vs=69875=69922

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D25354

AFFECTED FILES
  dataengines/potd/apodprovider.json
  dataengines/potd/bingprovider.json
  dataengines/potd/epodprovider.json
  dataengines/potd/flickrprovider.json
  dataengines/potd/natgeoprovider.json
  dataengines/potd/noaaprovider.json
  dataengines/potd/unsplashprovider.json
  dataengines/potd/wcpotdprovider.json
  wallpapers/potd/contents/ui/config.qml

To: guoyunhe, #plasma
Cc: ngraham, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, 
GB_2, ragreen, ZrenBot, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D25368: connect groupbox toggles to change signal

[Kai Uwe Broulik]

broulik added a comment.


  Don't you have to connect to the `QGroupBox` children? Right now you only 
connect the `QGroupBox` itself (which can be checkable) but not the checkboxes 
within?

REPOSITORY
  R116 Plasma Network Management Applet

REVISION DETAIL
  https://phabricator.kde.org/D25368

To: sitter, jgrulich
Cc: broulik, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, 
GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D25369: Shorten POTD provider names and remove description that is not used anywhere

[Yunhe Guo]

guoyunhe created this revision.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
guoyunhe requested review of this revision.

REVISION SUMMARY
  QtQuick Controls 2 ComboBox doesn't handle long option well. Short names can 
solve the issue of D25354 .

REPOSITORY
  R114 Plasma Addons

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D25369

AFFECTED FILES
  dataengines/potd/apodprovider.json
  dataengines/potd/bingprovider.json
  dataengines/potd/epodprovider.json
  dataengines/potd/flickrprovider.json
  dataengines/potd/natgeoprovider.json
  dataengines/potd/noaaprovider.json
  dataengines/potd/unsplashprovider.json
  dataengines/potd/wcpotdprovider.json

To: guoyunhe
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, 
ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D25361: [Workspace KCM] Expose setting to choose what left-clicking in the scrollbar track does

[Nathaniel Graham]

ngraham added a comment.


  In D25361#563993 , @davidedmundson 
wrote:
  
  > We have all other scrollbar settings in:
  >
  > breeze -> settings -> scrollbars
  >
  > Which has the added advantage that it won't be shown if it's not supported, 
for example if you use Fusion.
  
  
  This isn't only a Breeze setting. Per the discussion in 
https://bugs.kde.org/show_bug.cgi?id=379498, it should affect all widget 
themes, and per https://bugs.kde.org/show_bug.cgi?id=384889 
https://bugs.kde.org/show_bug.cgi?id=412685, I'd like it to affect scrollbars 
in Plasma and QML-based desktop apps as well.

REPOSITORY
  R119 Plasma Desktop

BRANCH
  left-click-warps-scrollbar-settings-ui (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D25361

To: ngraham, #plasma, #vdg, ndavis
Cc: davidedmundson, ndavis, gikari, plasma-devel, LeGast00n, The-Feren-OS-Dev, 
jraleigh, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D25368: connect groupbox toggles to change signal

[Harald Sitter]

sitter created this revision.
sitter added a reviewer: jgrulich.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
Herald added 1 blocking reviewer(s): jgrulich.
sitter requested review of this revision.

REVISION SUMMARY
  the bridge, ppp, and gsm settings contain qgroupboxes which previously
  were not tracked
  
  e.g. the STP box toggle on bridges didn't enable the apply button
  
  since checkable qgroupboxes are a fairly generic concept, let's connect a
  generic watch rule

TEST PLAN
  toggling STP in bridge settings actually enables apply button

REPOSITORY
  R116 Plasma Network Management Applet

BRANCH
  Plasma/5.17

REVISION DETAIL
  https://phabricator.kde.org/D25368

AFFECTED FILES
  libs/editor/widgets/settingwidget.cpp

To: sitter, jgrulich
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, 
ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

KDE CI: Plasma » kwin » stable-kf5-qt5 FreeBSDQt5.13 - Build # 74 - Still unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Plasma/job/kwin/job/stable-kf5-qt5%20FreeBSDQt5.13/74/
 Project:
stable-kf5-qt5 FreeBSDQt5.13
 Date of build:
Mon, 18 Nov 2019 14:07:50 +
 Build duration:
29 min and counting
   JUnit Tests
  Name: projectroot Failed: 1 test(s), Passed: 18 test(s), Skipped: 0 test(s), Total: 19 test(s)Failed: projectroot.autotests.kwin_testClientMachineName: projectroot.autotests Failed: 12 test(s), Passed: 100 test(s), Skipped: 0 test(s), Total: 112 test(s)Failed: projectroot.autotests.integration.kwin_testDbusInterfaceFailed: projectroot.autotests.integration.kwin_testDecorationInputFailed: projectroot.autotests.integration.kwin_testDecorationInput_waylandonlyFailed: projectroot.autotests.integration.kwin_testDontCrashAuroraeDestroyDecoFailed: projectroot.autotests.integration.kwin_testLockScreenFailed: projectroot.autotests.integration.kwin_testPlasmaWindowFailed: projectroot.autotests.integration.kwin_testSceneQPainterFailed: projectroot.autotests.integration.kwin_testScreenEdgeClientShowFailed: projectroot.autotests.integration.kwin_testShellClientFailed: projectroot.autotests.integration.kwin_testShellClient_waylandonlyFailed: projectroot.autotests.integration.kwin_testWindowRulesFailed: projectroot.autotests.integration.kwin_testXwaylandInputName: projectroot.autotests.integration Failed: 7 test(s), Passed: 13 test(s), Skipped: 0 test(s), Total: 20 test(s)Failed: projectroot.autotests.integration.effects.kwin_testMinimizeAnimationFailed: projectroot.autotests.integration.effects.kwin_testMinimizeAnimation_waylandonlyFailed: projectroot.autotests.integration.effects.kwin_testShadeWobblyWindowsFailed: projectroot.autotests.integration.effects.kwin_testSlidingPopupsFailed: projectroot.autotests.integration.effects.kwin_testTranslucencyFailed: projectroot.autotests.integration.scripting.kwin_testMinimizeAllScriptFailed: projectroot.autotests.integration.scripting.kwin_testMinimizeAllScript_waylandonly

D25354: Fix POTD config ComboBox display issue in Lock Screen KCM

[Nathaniel Graham]

ngraham added a comment.


  +1 for simplifying the strings, but keep in mind that any change that alters 
strings, can't be a bugfix on the stable branch and needs to be master-only.
  
  Might be better to only made the code changes on the stable branch, and do 
the string changes in a separate patch bound for master only.

REPOSITORY
  R114 Plasma Addons

REVISION DETAIL
  https://phabricator.kde.org/D25354

To: guoyunhe, #plasma
Cc: ngraham, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, 
GB_2, ragreen, ZrenBot, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D25354: Fix POTD config ComboBox display issue in Lock Screen KCM

[Yunhe Guo]

guoyunhe updated this revision to Diff 69929.
guoyunhe added a comment.


  Move string changes to another patch

REPOSITORY
  R114 Plasma Addons

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D25354?vs=69922=69929

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D25354

AFFECTED FILES
  wallpapers/potd/contents/ui/config.qml

To: guoyunhe, #plasma
Cc: ngraham, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, 
GB_2, ragreen, ZrenBot, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D25369: Shorten POTD provider names and remove description that is not used anywhere

[Nathaniel Graham]

ngraham added a comment.


  For changed strings, you don't need to remove the existing translations; just 
change the English strings.
  
  For removed strings, it's fine to remove everything.

REPOSITORY
  R114 Plasma Addons

REVISION DETAIL
  https://phabricator.kde.org/D25369

To: guoyunhe, #plasma, ngraham
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, 
ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D25369: Shorten POTD provider names and remove description that is not used anywhere

[Yunhe Guo]

guoyunhe updated this revision to Diff 69930.
guoyunhe added a comment.


  Keep old translations

REPOSITORY
  R114 Plasma Addons

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D25369?vs=69928=69930

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D25369

AFFECTED FILES
  dataengines/potd/apodprovider.json
  dataengines/potd/bingprovider.json
  dataengines/potd/epodprovider.json
  dataengines/potd/flickrprovider.json
  dataengines/potd/noaaprovider.json
  dataengines/potd/unsplashprovider.json
  dataengines/potd/wcpotdprovider.json

To: guoyunhe, #plasma, ngraham
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, 
ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D25369: Shorten POTD provider names and remove description that is not used anywhere

[Nathaniel Graham]

ngraham added a comment.


  Thanks! Can you add an explanation in the description section of this patch 
as to why you're removing the Description strings?

REPOSITORY
  R114 Plasma Addons

REVISION DETAIL
  https://phabricator.kde.org/D25369

To: guoyunhe, #plasma, ngraham
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, 
ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D25369: Shorten POTD provider names and remove description that is not used anywhere

[Yunhe Guo]

guoyunhe added a comment.


  In D25369#564159 , @ngraham wrote:
  
  > Thanks! Can you add an explanation in the description section of this patch 
as to why you're removing the Description strings?
  
  
  Added.

REPOSITORY
  R114 Plasma Addons

REVISION DETAIL
  https://phabricator.kde.org/D25369

To: guoyunhe, #plasma, ngraham
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, 
ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D25369: Shorten POTD provider names and remove description that is not used anywhere

[Nathaniel Graham]

ngraham requested changes to this revision.
ngraham added inline comments.
This revision now requires changes to proceed.

INLINE COMMENTS

> noaaprovider.json:4
>  "Icon": "",
> -"Name": "NOAA Environmental Visualization Laboratory Picture of the 
> Day",
> +"Name": "Weaher Satellite (NOAA)",
>  "Name[ca@valencia]": "Imatge del dia del NOAA Environmental 
> Visualization Laboratory",

`Weaher` -> `Weather`

REPOSITORY
  R114 Plasma Addons

REVISION DETAIL
  https://phabricator.kde.org/D25369

To: guoyunhe, #plasma, ngraham
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, 
ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D25369: Shorten POTD provider names and remove description that is not used anywhere

[Nathaniel Graham]

ngraham accepted this revision.
ngraham added a comment.
This revision is now accepted and ready to land.


  LGTM

REPOSITORY
  R114 Plasma Addons

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D25369

To: guoyunhe, #plasma, ngraham
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, 
ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D25369: Shorten POTD provider names and remove description that is not used anywhere

[Yunhe Guo]

guoyunhe updated this revision to Diff 69931.
guoyunhe added a comment.


  Fix typo

REPOSITORY
  R114 Plasma Addons

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D25369?vs=69930=69931

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D25369

AFFECTED FILES
  dataengines/potd/apodprovider.json
  dataengines/potd/bingprovider.json
  dataengines/potd/epodprovider.json
  dataengines/potd/flickrprovider.json
  dataengines/potd/noaaprovider.json
  dataengines/potd/unsplashprovider.json
  dataengines/potd/wcpotdprovider.json

To: guoyunhe, #plasma, ngraham
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, 
ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D25361: [Workspace KCM] Expose setting to choose what left-clicking in the scrollbar track does

[Nathaniel Graham]

ngraham updated this revision to Diff 69933.
ngraham added a comment.


  Improve config file entry namewq

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D25361?vs=69900=69933

BRANCH
  left-click-warps-scrollbar-settings-ui (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D25361

AFFECTED FILES
  kcms/workspaceoptions/package/contents/ui/main.qml
  kcms/workspaceoptions/workspaceoptions.cpp
  kcms/workspaceoptions/workspaceoptions.h

To: ngraham, #plasma, #vdg, ndavis
Cc: davidedmundson, ndavis, gikari, plasma-devel, LeGast00n, The-Feren-OS-Dev, 
jraleigh, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D25369: Shorten POTD provider names and remove description that is not used anywhere

[Phabricator]

This revision was automatically updated to reflect the committed changes.
Closed by commit R114:58b3995b813d: Shorten POTD provider names and remove 
description that is not used anywhere (authored by Guo Yunhe 
i...@guoyunhe.me).

REPOSITORY
  R114 Plasma Addons

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D25369?vs=69931=69934

REVISION DETAIL
  https://phabricator.kde.org/D25369

AFFECTED FILES
  dataengines/potd/apodprovider.json
  dataengines/potd/bingprovider.json
  dataengines/potd/epodprovider.json
  dataengines/potd/flickrprovider.json
  dataengines/potd/noaaprovider.json
  dataengines/potd/unsplashprovider.json
  dataengines/potd/wcpotdprovider.json

To: guoyunhe, #plasma, ngraham
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, 
ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D25361: [Workspace KCM] Expose setting to choose what left-clicking in the scrollbar track does

[Nathaniel Graham]

ngraham added a comment.


  In D25361#564176 , @davidedmundson 
wrote:
  
  > Of those links, only the first discusses which kcm to put it in and the 
suggestion there is the style kcm...
  
  
  Maybe I misunderstood the discussion, sorry.
  
  The Application Style KCM no longer has a "Fine Tuning" tab so the original 
suggestion regarding putting it there no longer seems to apply. I guess we 
could stick it in the pop-up that appears when you click on the "Configure 
Icons and Toolbars" button (which would then need to be renamed).
  
  But the Application Style KCM isn't really an accurate place for it because 
this is a behavioral setting, not an appearance setting. In addition, I want it 
to affect Plasma scrollbars as well and Plasma isn't an application.

REPOSITORY
  R119 Plasma Desktop

BRANCH
  left-click-warps-scrollbar-settings-ui (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D25361

To: ngraham, #plasma, #vdg, ndavis
Cc: davidedmundson, ndavis, gikari, plasma-devel, LeGast00n, The-Feren-OS-Dev, 
jraleigh, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D25354: Fix POTD config ComboBox display issue in Lock Screen KCM

[Phabricator]

This revision was automatically updated to reflect the committed changes.
Closed by commit R114:e8402b9a3156: Fix POTD config ComboBox display issue in 
Lock Screen KCM (authored by Guo Yunhe i...@guoyunhe.me).

REPOSITORY
  R114 Plasma Addons

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D25354?vs=69929=69935

REVISION DETAIL
  https://phabricator.kde.org/D25354

AFFECTED FILES
  wallpapers/potd/contents/ui/config.qml

To: guoyunhe, #plasma, ngraham
Cc: ngraham, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, 
GB_2, ragreen, ZrenBot, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D25354: Fix POTD config ComboBox display issue in Lock Screen KCM

[Yunhe Guo]

guoyunhe added a comment.


  In D25354#564187 , @ngraham wrote:
  
  > 5.17 branch please.
  
  
  Not sure if I did it correctly...

REPOSITORY
  R114 Plasma Addons

REVISION DETAIL
  https://phabricator.kde.org/D25354

To: guoyunhe, #plasma, ngraham
Cc: ngraham, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, 
GB_2, ragreen, ZrenBot, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D25354: Fix POTD config ComboBox display issue in Lock Screen KCM

[Nathaniel Graham]

ngraham added a comment.


  Yep, now you just need to merge `Plasma/5.17` into `master. See 
https://community.kde.org/Infrastructure/Phabricator#Landing_on_the_.22Stable_branch.22
 for the full set of recommended instructions for landing a change on the 
stable branch

REPOSITORY
  R114 Plasma Addons

REVISION DETAIL
  https://phabricator.kde.org/D25354

To: guoyunhe, #plasma, ngraham
Cc: ngraham, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, 
GB_2, ragreen, ZrenBot, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D25361: [Workspace KCM] Expose setting to choose what left-clicking in the scrollbar track does

[David Edmundson]

davidedmundson added a comment.


  Of those links, only the first discusses which kcm to put it in and the 
suggestion there is the style kcm...

REPOSITORY
  R119 Plasma Desktop

BRANCH
  left-click-warps-scrollbar-settings-ui (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D25361

To: ngraham, #plasma, #vdg, ndavis
Cc: davidedmundson, ndavis, gikari, plasma-devel, LeGast00n, The-Feren-OS-Dev, 
jraleigh, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D25368: connect groupbox toggles to change signal

[Harald Sitter]

sitter added a comment.


  @broulik the children are handled by the other connections already (linedit, 
push button etc.)

REPOSITORY
  R116 Plasma Network Management Applet

BRANCH
  Plasma/5.17

REVISION DETAIL
  https://phabricator.kde.org/D25368

To: sitter, jgrulich
Cc: broulik, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, 
GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D25354: Fix POTD config ComboBox display issue in Lock Screen KCM

[Nathaniel Graham]

ngraham accepted this revision.
ngraham added a comment.
This revision is now accepted and ready to land.


  5.17 branch please.

REPOSITORY
  R114 Plasma Addons

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D25354

To: guoyunhe, #plasma, ngraham
Cc: ngraham, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, 
GB_2, ragreen, ZrenBot, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D25368: connect groupbox toggles to change signal

[Harald Sitter]

This revision was automatically updated to reflect the committed changes.
Closed by commit R116:c8775cb198f3: connect groupbox toggles to change signal 
(authored by sitter).

REPOSITORY
  R116 Plasma Network Management Applet

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D25368?vs=69927=69936

REVISION DETAIL
  https://phabricator.kde.org/D25368

AFFECTED FILES
  libs/editor/widgets/settingwidget.cpp

To: sitter, jgrulich
Cc: broulik, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, 
GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

KDE CI: Plasma » discover » kf5-qt5 FreeBSDQt5.13 - Build # 114 - Failure!

[CI System]

BUILD FAILURE
 Build URL
https://build.kde.org/job/Plasma/job/discover/job/kf5-qt5%20FreeBSDQt5.13/114/
 Project:
kf5-qt5 FreeBSDQt5.13
 Date of build:
Mon, 18 Nov 2019 17:18:00 +
 Build duration:
2 min 4 sec and counting
   CONSOLE OUTPUT
  [...truncated 462 lines...][2019-11-18T17:19:30.485Z] [ 59%] Built target kns-backend_autogen[2019-11-18T17:19:30.781Z] [ 60%] Building CXX object libdiscover/backends/DummyBackend/tests/CMakeFiles/dummytest.dir/DummyTest.cpp.o[2019-11-18T17:19:30.781Z] [ 60%] Built target dummy-backend_autogen[2019-11-18T17:19:30.781Z] Scanning dependencies of target kns-backend[2019-11-18T17:19:31.045Z] [ 60%] Built target updatedummytest_autogen[2019-11-18T17:19:31.045Z] [ 60%] Built target CategoriesTest_autogen[2019-11-18T17:19:31.045Z] [ 61%] Building CXX object libdiscover/backends/KNSBackend/tests/CMakeFiles/knsbackendtest.dir/KNSBackendTest.cpp.o[2019-11-18T17:19:31.045Z] [ 62%] Building CXX object libdiscover/backends/KNSBackend/CMakeFiles/kns-backend.dir/kns-backend_autogen/mocs_compilation.cpp.o[2019-11-18T17:19:31.045Z] [ 63%] Building CXX object exporter/CMakeFiles/plasma-discover-exporter.dir/MuonExporter.cpp.o[2019-11-18T17:19:31.045Z] [ 63%] Built target plasma-discover_autogen[2019-11-18T17:19:31.045Z] Scanning dependencies of target dummy-backend[2019-11-18T17:19:31.311Z] [ 64%] Building CXX object libdiscover/backends/DummyBackend/CMakeFiles/dummy-backend.dir/dummy-backend_autogen/mocs_compilation.cpp.o[2019-11-18T17:19:31.573Z] [ 65%] Building CXX object libdiscover/backends/DummyBackend/CMakeFiles/dummy-backend.dir/DummyResource.cpp.o[2019-11-18T17:19:31.862Z] Scanning dependencies of target updatedummytest[2019-11-18T17:19:31.862Z] [ 66%] Building CXX object libdiscover/backends/DummyBackend/tests/CMakeFiles/updatedummytest.dir/updatedummytest_autogen/mocs_compilation.cpp.o[2019-11-18T17:19:31.862Z] [ 67%] Building CXX object libdiscover/backends/DummyBackend/tests/CMakeFiles/updatedummytest.dir/UpdateDummyTest.cpp.o[2019-11-18T17:19:32.123Z] [ 68%] Automatic RCC for assets.qrc[2019-11-18T17:19:32.123Z] Scanning dependencies of target CategoriesTest[2019-11-18T17:19:32.124Z] [ 68%] Building CXX object libdiscover/tests/CMakeFiles/CategoriesTest.dir/CategoriesTest_autogen/mocs_compilation.cpp.o[2019-11-18T17:19:32.124Z] [ 69%] Generating discoversettings.h, discoversettings.cpp[2019-11-18T17:19:32.124Z] [ 70%] Building CXX object libdiscover/tests/CMakeFiles/CategoriesTest.dir/CategoriesTest.cpp.o[2019-11-18T17:19:32.124Z] [ 71%] Generating plasmauserfeedback.h, plasmauserfeedback.cpp[2019-11-18T17:19:32.124Z] [ 72%] Automatic RCC for resources.qrc[2019-11-18T17:19:32.390Z] [ 73%] Generating discoversettings.moc[2019-11-18T17:19:32.390Z] [ 73%] Generating plasmauserfeedback.moc[2019-11-18T17:19:32.660Z] [ 74%] Building CXX object libdiscover/backends/DummyBackend/CMakeFiles/dummy-backend.dir/DummyBackend.cpp.o[2019-11-18T17:19:32.925Z] Scanning dependencies of target plasma-discover[2019-11-18T17:19:32.925Z] [ 75%] Building CXX object discover/CMakeFiles/plasma-discover.dir/plasma-discover_autogen/mocs_compilation.cpp.o[2019-11-18T17:19:32.925Z] [ 76%] Linking CXX executable ../bin/plasma-discover-exporter[2019-11-18T17:19:32.925Z] [ 77%] Building CXX object libdiscover/backends/KNSBackend/CMakeFiles/kns-backend.dir/KNSBackend.cpp.o[2019-11-18T17:19:33.184Z] [ 77%] Built target plasma-discover-exporter[2019-11-18T17:19:33.184Z] [ 77%] Building CXX object libdiscover/backends/KNSBackend/CMakeFiles/kns-backend.dir/KNSResource.cpp.o[2019-11-18T17:19:33.184Z] [ 78%] Building CXX object libdiscover/backends/DummyBackend/CMakeFiles/dummy-backend.dir/DummyReviewsBackend.cpp.o[2019-11-18T17:19:33.829Z] [ 79%] Linking CXX executable ../../../../bin/knsbackendtest[2019-11-18T17:19:34.100Z] [ 79%] Built target knsbackendtest[2019-11-18T17:19:34.100Z] [ 80%] Building CXX object libdiscover/backends/DummyBackend/CMakeFiles/dummy-backend.dir/DummyTransaction.cpp.o[2019-11-18T17:19:34.375Z] [ 81%] Linking CXX executable ../../../../bin/dummytest[2019-11-18T17:19:34.637Z] /usr/home/jenkins/workspace/Plasma/discover/kf5-qt5 FreeBSDQt5.13/libdiscover/backends/KNSBackend/KNSBackend.cpp:565:45: warning: 'signalError' is deprecated: Since 5.53. Use Engine::signalErrorCode(const KNSCore::ErrorCode &, const QString &, const QVariant &) [-Wdeprecated-declarations][2019-11-18T17:19:34.637Z] connect(m_engine, ::Engine::signalError, stream, ::finish);[2019-11-18T17:19:34.637Z] ^[2019-11-18T17:19:34.637Z] /usr/home/jenkins/install-prefix/include/KF5/KNewStuff3/knscore/engine.h:505:5: note: 'signalError' has been explicitly marked deprecated here[2019-11-18T17:19:34.637Z] KNEWSTUFFCORE_DEPRECATED_VERSION(5, 53, "Use Engine::signalErrorCode(const KNSCore::ErrorCode &, const QString &, const QVariant &)")[2019-11-18T17:19:34.637Z] ^[2019-11-18T17:19:34.637Z] 

KDE CI: Plasma » discover » kf5-qt5 SUSEQt5.12 - Build # 261 - Failure!

[CI System]

BUILD FAILURE
 Build URL
https://build.kde.org/job/Plasma/job/discover/job/kf5-qt5%20SUSEQt5.12/261/
 Project:
kf5-qt5 SUSEQt5.12
 Date of build:
Mon, 18 Nov 2019 17:18:00 +
 Build duration:
3 min 11 sec and counting
   CONSOLE OUTPUT
  [...truncated 505 lines...][2019-11-18T17:20:24.519Z] [ 40%] Built target DiscoverNotifier_autogen[2019-11-18T17:20:24.519Z] Scanning dependencies of target dummytest_autogen[2019-11-18T17:20:24.777Z] [ 41%] Automatic MOC for target dummytest[2019-11-18T17:20:24.777Z] [ 41%] Built target dummytest_autogen[2019-11-18T17:20:24.777Z] Scanning dependencies of target fwupd-backend_autogen[2019-11-18T17:20:24.777Z] [ 42%] Automatic MOC for target fwupd-backend[2019-11-18T17:20:25.034Z] [ 42%] Built target updatedummytest_autogen[2019-11-18T17:20:25.034Z] Scanning dependencies of target CategoriesTest_autogen[2019-11-18T17:20:25.034Z] [ 43%] Automatic MOC for target CategoriesTest[2019-11-18T17:20:25.603Z] [ 43%] Built target CategoriesTest_autogen[2019-11-18T17:20:26.173Z] [ 43%] Built target fwupd-backend_autogen[2019-11-18T17:20:26.173Z] Scanning dependencies of target plasma-discover-exporter_autogen[2019-11-18T17:20:26.173Z] [ 43%] Automatic MOC for target plasma-discover-exporter[2019-11-18T17:20:26.173Z] [ 43%] Built target plasma-discover-exporter_autogen[2019-11-18T17:20:26.431Z] Scanning dependencies of target DiscoverNotifier[2019-11-18T17:20:26.431Z] [ 44%] Building CXX object notifier/CMakeFiles/DiscoverNotifier.dir/DiscoverNotifier_autogen/mocs_compilation.cpp.o[2019-11-18T17:20:27.806Z] [ 45%] Building CXX object notifier/CMakeFiles/DiscoverNotifier.dir/BackendNotifierFactory.cpp.o[2019-11-18T17:20:29.704Z] [ 45%] Building CXX object notifier/CMakeFiles/DiscoverNotifier.dir/DiscoverNotifier.cpp.o[2019-11-18T17:20:31.599Z] [ 46%] Building CXX object notifier/CMakeFiles/DiscoverNotifier.dir/NotifierItem.cpp.o[2019-11-18T17:20:32.530Z] /home/jenkins/workspace/Plasma/discover/kf5-qt5 SUSEQt5.12/notifier/NotifierItem.cpp: In function ���KStatusNotifierItem::ItemStatus sniStatus(DiscoverNotifier::State)���:[2019-11-18T17:20:32.530Z] /home/jenkins/workspace/Plasma/discover/kf5-qt5 SUSEQt5.12/notifier/NotifierItem.cpp:27:67: warning: unused parameter ���state��� [-Wunused-parameter][2019-11-18T17:20:32.530Z]27 | KStatusNotifierItem::ItemStatus sniStatus(DiscoverNotifier::State state)[2019-11-18T17:20:32.530Z]   |   ^[2019-11-18T17:20:32.530Z] Scanning dependencies of target DummyNotifier[2019-11-18T17:20:32.530Z] [ 47%] Building CXX object libdiscover/backends/DummyBackend/CMakeFiles/DummyNotifier.dir/DummyNotifier_autogen/mocs_compilation.cpp.o[2019-11-18T17:20:32.786Z] [ 48%] Building CXX object notifier/CMakeFiles/DiscoverNotifier.dir/main.cpp.o[2019-11-18T17:20:33.352Z] [ 50%] Building CXX object libdiscover/backends/DummyBackend/CMakeFiles/DummyNotifier.dir/DummyNotifier.cpp.o[2019-11-18T17:20:38.461Z] [ 50%] Linking CXX shared module ../../../bin/DummyNotifier.so[2019-11-18T17:20:38.461Z] [ 50%] Built target DummyNotifier[2019-11-18T17:20:38.461Z] [ 51%] Linking CXX executable ../bin/DiscoverNotifier[2019-11-18T17:20:38.461Z] [ 51%] Built target DiscoverNotifier[2019-11-18T17:20:38.461Z] Scanning dependencies of target updatedummytest[2019-11-18T17:20:38.461Z] [ 52%] Building CXX object libdiscover/backends/DummyBackend/tests/CMakeFiles/updatedummytest.dir/updatedummytest_autogen/mocs_compilation.cpp.o[2019-11-18T17:20:38.461Z] [ 53%] Building CXX object libdiscover/backends/DummyBackend/tests/CMakeFiles/updatedummytest.dir/UpdateDummyTest.cpp.o[2019-11-18T17:20:38.461Z] Scanning dependencies of target dummytest[2019-11-18T17:20:38.461Z] [ 54%] Building CXX object libdiscover/backends/DummyBackend/tests/CMakeFiles/dummytest.dir/dummytest_autogen/mocs_compilation.cpp.o[2019-11-18T17:20:38.461Z] [ 55%] Linking CXX executable ../../../../bin/updatedummytest[2019-11-18T17:20:38.461Z] [ 56%] Building CXX object libdiscover/backends/DummyBackend/tests/CMakeFiles/dummytest.dir/DummyTest.cpp.o[2019-11-18T17:20:38.461Z] Scanning dependencies of target plasma-discover_autogen[2019-11-18T17:20:38.461Z] [ 57%] Automatic MOC for target plasma-discover[2019-11-18T17:20:38.719Z] [ 57%] Built target updatedummytest[2019-11-18T17:20:38.719Z] Scanning dependencies of target knsbackendtest_autogen[2019-11-18T17:20:38.719Z] Scanning dependencies of target dummy-backend_autogen[2019-11-18T17:20:38.719Z] [ 58%] Automatic MOC for target knsbackendtest[2019-11-18T17:20:38.719Z] [ 58%] Automatic MOC for target dummy-backend[2019-11-18T17:20:38.982Z] [ 58%] Built target plasma-discover_autogen[2019-11-18T17:20:39.249Z] [ 58%] Built target knsbackendtest_autogen[2019-11-18T17:20:39.249Z] Scanning dependencies of target fwupd-backend[2019-11-18T17:20:39.249Z] Scanning dependencies of target kns-backend_autogen[2019-11-18T17:20:39.509Z] [ 59%] Automatic MOC for target 

D25024: Use the same avatar size in lock, login and logout screens

[Filip Fila]

filipf added a comment.


  @ngraham I can change this patch so only the logout avatar' size is increased 
and then land that on the 5.17 as there is no risk of breaking anything. I can 
then change the lock screen as well, but for 5.18. They won't be precisely the 
same size in 5.17 though.

REPOSITORY
  R120 Plasma Workspace

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D25024

To: filipf, #plasma, #vdg, ngraham
Cc: davidedmundson, ngraham, plasma-devel, LeGast00n, The-Feren-OS-Dev, 
jraleigh, fbampaloukas, GB_2, ragreen, ZrenBot, alexeymin, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D25024: Use the same avatar size in lock, login and logout screens

[Nathaniel Graham]

ngraham added a comment.


  Probably okay to make this master-only IMO.

REPOSITORY
  R120 Plasma Workspace

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D25024

To: filipf, #plasma, #vdg, ngraham
Cc: davidedmundson, ngraham, plasma-devel, LeGast00n, The-Feren-OS-Dev, 
jraleigh, fbampaloukas, GB_2, ragreen, ZrenBot, alexeymin, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D24224: Start of the accessibility KCM

[Tomaz Canabrava]

tcanabrava added a comment.


  In D24224#561693 , @ngraham wrote:
  
  > It doesn't compile:
  >
  >   /home/nate/kde/usr/include/KF5/KNewStuff3/KNS3/DownloadDialog:1:10: fatal 
error: kns3/downloaddialog.h: No such file or directory
  >   1 | #include "kns3/downloaddialog.h"
  > |  ^~~
  >
  >
  > Also we should be using the new QML-based GHNS dialog where possible, now 
that it's a first-class citizen.
  
  
  There's no KNS3 on Accessibility

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D24224

To: tcanabrava, ngraham, bport, ervin
Cc: broulik, bport, ervin, mart, ngraham, whiting, plasma-devel, LeGast00n, 
The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, ragreen, ZrenBot, alexeymin, 
himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, 
ahiemstra

D25374: [ResultDelegate] Fix bad text legiblity with certain 3rd party themes

[Filip Fila]

filipf created this revision.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
filipf requested review of this revision.

REVISION SUMMARY
  This is a fix for D25043 .
  
  Using disabledTextColor results in bad text legibility with Plasma themes 
that use filled-style highlight effects.
  
  If colors are prefered over opacity as means of achieving text shading then 
we need to mix disabledTextColor with textColor on selection.
  
  This creates an effect that is comparable to the opacity: isCurrent? 0.8 : 
0.6 code that is used throughout Plasma for subtitles.

REPOSITORY
  R112 Milou

BRANCH
  fix-bad-text-legibility (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D25374

AFFECTED FILES
  lib/qml/ResultDelegate.qml

To: filipf
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, 
ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D25309: [Notifications KCM] Fix keyboard navigation in apps list

[Nathaniel Graham]

This revision was automatically updated to reflect the committed changes.
Closed by commit R119:659fe0a76f19: [Notifications KCM] Fix keyboard navigation 
in apps list (authored by ngraham).

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D25309?vs=69761=69949

REVISION DETAIL
  https://phabricator.kde.org/D25309

AFFECTED FILES
  kcms/notifications/package/contents/ui/SourcesPage.qml

To: ngraham, broulik, #plasma
Cc: plasma-devel, guoyunhe, LeGast00n, The-Feren-OS-Dev, jraleigh, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D25185: Icon: solve threading issue on when the source is http

[Aleix Pol Gonzalez]

This revision was automatically updated to reflect the committed changes.
Closed by commit R169:5cc8be3cd1fd: Icon: solve threading issue on when the 
source is http (authored by apol).

REPOSITORY
  R169 Kirigami

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D25185?vs=69422=69957

REVISION DETAIL
  https://phabricator.kde.org/D25185

AFFECTED FILES
  src/icon.cpp
  src/icon.h

To: apol, #kirigami, mart, davidedmundson
Cc: davidedmundson, anthonyfieroni, bcooksley, plasma-devel, fbampaloukas, 
GB_2, domson, dkardarakos, ngraham, apol, ahiemstra, mart, hein

D25381: Make QPushButton/QToolButton the same height as QLineEdit

[Noah Davis]

ndavis added a comment.


  If we do make flat toolbuttons buttons (`autoRaise == true`) and non-flat 
buttons the same size, we will need to change the default icon size for all 
buttons to 22px, or we will have a ton of UI regressions. Any non-flat button 
with a fixed icon size is going to have a regression. Also, anyone who was 
using non-flat buttons with 22px icons to get a bigger clickable area will need 
to switch to 32px icons. This also means that breeze-icons' problem with 32px 
icon style consistency will show itself more often.

REPOSITORY
  R31 Breeze

REVISION DETAIL
  https://phabricator.kde.org/D25381

To: guoyunhe, #breeze, #plasma
Cc: ndavis, GB_2, ngraham, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, 
fbampaloukas, ragreen, ZrenBot, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D25381: Make QPushButton/QToolButton the same height as QLineEdit

[Nathaniel Graham]

ngraham added a comment.


  +1 conceptually, this will be nice to finally have fixed.
  
  But might the opposite make more sense? If we make buttons shorter, we're 
slightly reducing their click targets, but if we make line edits taller, all 
we're doing it reducing unused whitespace.

REPOSITORY
  R31 Breeze

REVISION DETAIL
  https://phabricator.kde.org/D25381

To: guoyunhe
Cc: ngraham, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, 
GB_2, ragreen, ZrenBot, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D25381: Make QPushButton/QToolButton the same height as QLineEdit

[Björn Feber]

GB_2 added a comment.


  Plus in the screenshot it looks like it's still not quite the same heihgt.

REPOSITORY
  R31 Breeze

REVISION DETAIL
  https://phabricator.kde.org/D25381

To: guoyunhe, #breeze, #plasma
Cc: GB_2, ngraham, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, 
fbampaloukas, ragreen, ZrenBot, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D25381: Make QPushButton/QToolButton the same height as QLineEdit

[Björn Feber]

GB_2 added a comment.


  In D25381#564370 , @ngraham wrote:
  
  > +1 conceptually, this will be nice to finally have fixed.
  >
  > But might the opposite make more sense? If we make buttons shorter, we're 
slightly reducing their click targets, but if we make line edits taller, all 
we're doing it reducing unused whitespace.

REPOSITORY
  R31 Breeze

REVISION DETAIL
  https://phabricator.kde.org/D25381

To: guoyunhe
Cc: GB_2, ngraham, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, 
fbampaloukas, ragreen, ZrenBot, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D24224: Start of the accessibility KCM

[Tomaz Canabrava]

tcanabrava updated this revision to Diff 69945.
tcanabrava added a comment.


  - Use Plasma KCM
  - Adapt to FormLayout
  - Fix label
  - Space every tab equally
  - Form layout port
  - FormLayout
  - Simplify Qml
  - Port to Form Layout
  - A much much better layout than tabs
  - Beginning of KConfigXt Port
  - Add KConfigXt stubs
  - Fix install
  - Fix wrong values accessed
  - s/visibleBell/visualBell
  - Fix Many issues with the KConfigXT port
  - Fixes
  - Fix all the KConfigXT noiseances
  - Add background to the List
  - Add single-connects
  - Fix Layout
  - Adapt to new ManagedConfig
  - Re-add X11Info

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D24224?vs=69651=69945

BRANCH
  kcm_acess

REVISION DETAIL
  https://phabricator.kde.org/D24224

AFFECTED FILES
  kcms/access/CMakeLists.txt
  kcms/access/accessibility.ui
  kcms/access/kcmaccess.cpp
  kcms/access/kcmaccess.desktop
  kcms/access/kcmaccess.h
  kcms/access/kcmaccessibilitybell.kcfg
  kcms/access/kcmaccessibilitybell.kcfgc
  kcms/access/kcmaccessibilitykeyboard.kcfg
  kcms/access/kcmaccessibilitykeyboard.kcfgc
  kcms/access/kcmaccessibilitymouse.kcfg
  kcms/access/kcmaccessibilitymouse.kcfgc
  kcms/access/kcmaccessibilityscreenreader.kcfg
  kcms/access/kcmaccessibilityscreenreader.kcfgc
  kcms/access/package/contents/ui/ActivationGestures.qml
  kcms/access/package/contents/ui/Bell.qml
  kcms/access/package/contents/ui/KeyboardFilters.qml
  kcms/access/package/contents/ui/ModifierKeys.qml
  kcms/access/package/contents/ui/MouseNavigation.qml
  kcms/access/package/contents/ui/ScreenReader.qml
  kcms/access/package/contents/ui/main.qml
  kcms/access/package/metadata.desktop
  kcms/colors/CMakeLists.txt

To: tcanabrava, ngraham, bport, ervin
Cc: broulik, bport, ervin, mart, ngraham, whiting, plasma-devel, LeGast00n, 
The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, ragreen, ZrenBot, alexeymin, 
himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, 
ahiemstra

D24224: Start of the accessibility KCM

[Tomaz Canabrava]

tcanabrava added a comment.


  After squashing the commits to remove the broken history, arc diff opened a 
new revision.
  https://phabricator.kde.org/D25375

INLINE COMMENTS

> ervin wrote in kcmaccessibilitymouse.kcfg:34
> Wouldn't an Enum be more suited here?

This i a spinBox with a range from 0 to 1000 in the original code, so I dont 
think an enum will be better there.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D24224

To: tcanabrava, ngraham, bport, ervin
Cc: broulik, bport, ervin, mart, ngraham, whiting, plasma-devel, LeGast00n, 
The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, ragreen, ZrenBot, alexeymin, 
himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, 
ahiemstra

D25381: Make QPushButton/QToolButton the same height as QLineEdit

[Yunhe Guo]

guoyunhe added a comment.


  In D25381#564378 , @GB_2 wrote:
  
  > Plus in the screenshot it looks like it's still not quite the same height.
  
  
  Yes, still 1px taller :(

REPOSITORY
  R31 Breeze

REVISION DETAIL
  https://phabricator.kde.org/D25381

To: guoyunhe, #breeze, #plasma
Cc: GB_2, ngraham, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, 
fbampaloukas, ragreen, ZrenBot, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

KDE CI: Plasma » discover » kf5-qt5 SUSEQt5.12 - Build # 262 - Fixed!

[CI System]

BUILD SUCCESS
 Build URL
https://build.kde.org/job/Plasma/job/discover/job/kf5-qt5%20SUSEQt5.12/262/
 Project:
kf5-qt5 SUSEQt5.12
 Date of build:
Mon, 18 Nov 2019 21:58:53 +
 Build duration:
3 min 5 sec and counting
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot.discover Failed: 0 test(s), Passed: 12 test(s), Skipped: 0 test(s), Total: 12 test(s)Name: projectroot.libdiscover Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot.libdiscover.backends.DummyBackend Failed: 0 test(s), Passed: 2 test(s), Skipped: 0 test(s), Total: 2 test(s)Name: projectroot.libdiscover.backends.KNSBackend Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report72%
(13/18)72%
(76/105)72%
(76/105)64%
(3640/5694)49%
(1735/3526)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsdiscover100%
(12/12)100%
(12/12)76%
(585/773)55%
(254/464)discover.autotests100%
(1/1)100%
(1/1)100%
(100/100)55%
(35/64)exporter0%
(0/3)0%
(0/3)0%
(0/65)0%
(0/40)libdiscover86%
(6/7)86%
(6/7)88%
(241/274)70%
(129/185)libdiscover.Category100%
(5/5)100%
(5/5)67%
(164/244)48%
(111/230)libdiscover.ReviewsBackend100%
(7/7)100%
(7/7)84%
(188/225)75%
(54/72)libdiscover.Transaction88%
(7/8)88%
(7/8)79%
(236/299)68%
(98/144)libdiscover.UpdateModel100%
(3/3)100%
(3/3)91%
(224/247)74%
(92/125)libdiscover.appstream0%
(0/5)0%
(0/5)0%
(0/236)0%
(0/126)libdiscover.backends.DummyBackend82%
(9/11)82%
(9/11)84%
(265/315)75%
(124/166)libdiscover.backends.DummyBackend.tests100%
(2/2)100%
(2/2)97%
(250/259)53%
(143/268)libdiscover.backends.FwupdBackend0%
(0/8)0%
(0/8)0%
(0/544)0%
(0/259)libdiscover.backends.KNSBackend100%
(5/5)100%
(5/5)59%
(343/579)43%
(138/323)libdiscover.backends.KNSBackend.tests100%
(1/1)100%
(1/1)98%
(90/92)55%
(63/114)libdiscover.notifiers0%
(0/2)0%
(0/2)0%
(0/7)0%
(0/2)libdiscover.resources94%
(17/18)94%
   

D24224: Start of the accessibility KCM

[Nathaniel Graham]

ngraham added a comment.


  So... fix it? :)

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D24224

To: tcanabrava, ngraham, bport, ervin
Cc: broulik, bport, ervin, mart, ngraham, whiting, plasma-devel, LeGast00n, 
The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, ragreen, ZrenBot, alexeymin, 
himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, 
ahiemstra

D25381: Make QPushButton/QToolButton the same height as QLineEdit

[Yunhe Guo]

guoyunhe added a comment.


  In D25381#564370 , @ngraham wrote:
  
  > +1 conceptually, this will be nice to finally have fixed.
  >
  > But might the opposite make more sense? If we make buttons shorter, we're 
slightly reducing their click targets, but if we make line edits taller, all 
we're doing it reducing unused whitespace.
  
  
  From my personal experience, I didn't have any difficulty to click buttons of 
new sizes. And it seems the same height as buttons in Phabricator.

REPOSITORY
  R31 Breeze

REVISION DETAIL
  https://phabricator.kde.org/D25381

To: guoyunhe, #breeze, #plasma
Cc: GB_2, ngraham, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, 
fbampaloukas, ragreen, ZrenBot, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D25375: Start of the accessibility KCM

[Tomaz Canabrava]

tcanabrava created this revision.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
tcanabrava requested review of this revision.

REVISION SUMMARY
  This rewrites the Accessibility KCM to use Qml and the new Managed
  Config classes.

REPOSITORY
  R119 Plasma Desktop

BRANCH
  kcm_acess

REVISION DETAIL
  https://phabricator.kde.org/D25375

AFFECTED FILES
  kcms/access/CMakeLists.txt
  kcms/access/accessibility.ui
  kcms/access/kcmaccess.cpp
  kcms/access/kcmaccess.desktop
  kcms/access/kcmaccess.h
  kcms/access/kcmaccessibilitybell.kcfg
  kcms/access/kcmaccessibilitybell.kcfgc
  kcms/access/kcmaccessibilitykeyboard.kcfg
  kcms/access/kcmaccessibilitykeyboard.kcfgc
  kcms/access/kcmaccessibilitymouse.kcfg
  kcms/access/kcmaccessibilitymouse.kcfgc
  kcms/access/kcmaccessibilityscreenreader.kcfg
  kcms/access/kcmaccessibilityscreenreader.kcfgc
  kcms/access/package/contents/ui/ActivationGestures.qml
  kcms/access/package/contents/ui/Bell.qml
  kcms/access/package/contents/ui/KeyboardFilters.qml
  kcms/access/package/contents/ui/ModifierKeys.qml
  kcms/access/package/contents/ui/MouseNavigation.qml
  kcms/access/package/contents/ui/ScreenReader.qml
  kcms/access/package/contents/ui/main.qml
  kcms/access/package/metadata.desktop

To: tcanabrava
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, 
ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D25375: Start of the accessibility KCM

[Nathaniel Graham]

ngraham added inline comments.

INLINE COMMENTS

> main.qml:42
> +
> +ListView {
> +id: listView

Needs keyboard navigation. See 
https://cgit.kde.org/plasma-desktop.git/commit/?id=659fe0a76f19b60021733c4a74e451d4318a8359
 for details regarding how.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D25375

To: tcanabrava
Cc: ngraham, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, 
GB_2, ragreen, ZrenBot, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D25379: WIP: Beginning of the work for Simplifying the Emoticon KCM

[Tomaz Canabrava]

tcanabrava created this revision.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
tcanabrava requested review of this revision.

REVISION SUMMARY
  Before we port this to Qml we need to simplify the code
  it's currently monolithycal, and need to be split into at least
  two models and a few helper classes.
  
  Load Emoticon from the Models
  
  Problem: Something is *very* heavy. I think creating and
  destroying KEmoticons is not the best approach, I'll load
  everything and store in memory for next commit

REPOSITORY
  R119 Plasma Desktop

BRANCH
  kcm_emoticon

REVISION DETAIL
  https://phabricator.kde.org/D25379

AFFECTED FILES
  kcms/emoticons/CMakeLists.txt
  kcms/emoticons/editdialog.cpp
  kcms/emoticons/editdialog.h
  kcms/emoticons/emoticonslist.cpp
  kcms/emoticons/emoticonslist.h
  kcms/emoticons/emoticonslist.ui
  kcms/emoticons/emoticonsmodel.cpp
  kcms/emoticons/emoticonsmodel.h
  kcms/emoticons/emoticonthemesmodel.cpp
  kcms/emoticons/emoticonthemesmodel.h
  kcms/emoticons/helpers.cpp
  kcms/emoticons/helpers.h

To: tcanabrava
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, 
ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

KDE CI: Plasma » discover » kf5-qt5 FreeBSDQt5.13 - Build # 115 - Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Plasma/job/discover/job/kf5-qt5%20FreeBSDQt5.13/115/
 Project:
kf5-qt5 FreeBSDQt5.13
 Date of build:
Mon, 18 Nov 2019 21:58:53 +
 Build duration:
6 min 2 sec and counting
   JUnit Tests
  Name: projectroot.discover Failed: 0 test(s), Passed: 12 test(s), Skipped: 0 test(s), Total: 12 test(s)Name: projectroot.libdiscover Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot.libdiscover.backends.DummyBackend Failed: 1 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 2 test(s)Failed: projectroot.libdiscover.backends.DummyBackend.tests.updatedummytestName: projectroot.libdiscover.backends.KNSBackend Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)

D25381: Make QPushButton/QToolButton the same height as QLineEdit

[Yunhe Guo]

guoyunhe created this revision.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
guoyunhe requested review of this revision.

REVISION SUMMARY
  BUG 411811

REPOSITORY
  R31 Breeze

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D25381

AFFECTED FILES
  kstyle/breezestyle.cpp

To: guoyunhe
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, 
ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D25385: Use icon name instead of pixmap in notification

[Nicolas Fella]

nicolasfella updated this revision to Diff 69964.
nicolasfella added a comment.


  - More

REPOSITORY
  R116 Plasma Network Management Applet

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D25385?vs=69963=69964

BRANCH
  noti

REVISION DETAIL
  https://phabricator.kde.org/D25385

AFFECTED FILES
  kded/notification.cpp
  libs/editor/connectioneditorbase.cpp
  libs/handler.cpp

To: nicolasfella, #plasma, jgrulich
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, 
ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D25383: Remove some unused includes

[Nicolas Fella]

nicolasfella created this revision.
nicolasfella added reviewers: Plasma, drosca.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
nicolasfella requested review of this revision.

TEST PLAN
  builds

REPOSITORY
  R97 Bluedevil

BRANCH
  incl

REVISION DETAIL
  https://phabricator.kde.org/D25383

AFFECTED FILES
  src/wizard/pages/discover.cpp
  src/wizard/pages/pairing.cpp

To: nicolasfella, #plasma, drosca
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, 
ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D25385: Use icon name instead of pixmap in notification

[Nicolas Fella]

nicolasfella created this revision.
nicolasfella added a reviewer: Plasma.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
Herald added a reviewer: jgrulich.
nicolasfella requested review of this revision.

REVISION SUMMARY
  It's both easier and better

TEST PLAN
  builds

REPOSITORY
  R116 Plasma Network Management Applet

BRANCH
  noti

REVISION DETAIL
  https://phabricator.kde.org/D25385

AFFECTED FILES
  kded/notification.cpp

To: nicolasfella, #plasma, jgrulich
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, 
ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D25384: Remove some unused includes

[Nicolas Fella]

nicolasfella created this revision.
nicolasfella added a reviewer: Plasma.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
nicolasfella requested review of this revision.

TEST PLAN
  builds

REPOSITORY
  R119 Plasma Desktop

BRANCH
  incl

REVISION DETAIL
  https://phabricator.kde.org/D25384

AFFECTED FILES
  kcms/kfontinst/kcmfontinst/DuplicatesDialog.cpp

To: nicolasfella, #plasma
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, 
ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart