D6183: [Digital Clock] Allow copying current date and time to clipboard

[Bernhard Schiffner]

bschiffner updated this revision to Diff 15381.
bschiffner added a comment.


  Upating https://phabricator.kde.org/D6183: [Digital Clock] Allow copying 
current date and time to clipboard

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D6183?vs=15348=15381

REVISION DETAIL
  https://phabricator.kde.org/D6183

AFFECTED FILES
  applets/digital-clock/package/contents/ui/DigitalClock.qml
  applets/digital-clock/package/contents/ui/main.qml
  applets/digital-clock/plugin/CMakeLists.txt
  applets/digital-clock/plugin/clipboardmenu.cpp
  applets/digital-clock/plugin/clipboardmenu.h
  applets/digital-clock/plugin/digitalclockplugin.cpp

To: bschiffner, #plasma, broulik
Cc: davidedmundson, plasma-devel, ZrenBot, spstarr, progwolff, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart, lukas

D6183: [Digital Clock] Allow copying current date and time to clipboard

[Bernhard Schiffner]

bschiffner added a comment.


  Thanks for the feedback.
  It was integrated to my  best understanding and works for me.
  
  Why "^[0-9:]"? Sometimes it is just fun using the biggest sledgehammer. But 
in all respect: it is even gender neutral to be smashed this way!
  (I tried something to do it more politely but think of rigt to left 
languages, unknown literals etc. So I did this bet.)
  
  The QML / once a minute update problem (seconds all time 0) I didn't notice 
until now (4 PC/Notebook).

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D6183

To: bschiffner, #plasma, broulik
Cc: davidedmundson, plasma-devel, ZrenBot, spstarr, progwolff, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart, lukas

D6183: [Digital Clock] Allow copying current date and time to clipboard

[Bernhard Schiffner]

bschiffner created this revision.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.

REVISION SUMMARY
  Fixes https://bugs.kde.org/show_bug.cgi?id=355190
  
  BUG: 355190
  FIXED-IN: 5.11.0
  
  It supersedes https://phabricator.kde.org/D1350 which was accepted but didn't 
make it into plasma-workspace.

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D6183

AFFECTED FILES
  applets/digital-clock/package/contents/ui/DigitalClock.qml
  applets/digital-clock/package/contents/ui/main.qml
  applets/digital-clock/plugin/CMakeLists.txt
  applets/digital-clock/plugin/clipboardmenu.cpp
  applets/digital-clock/plugin/clipboardmenu.h
  applets/digital-clock/plugin/digitalclockplugin.cpp

To: bschiffner, #plasma, broulik
Cc: plasma-devel, ZrenBot, spstarr, progwolff, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart, lukas

D6183: [Digital Clock] Allow copying current date and time to clipboard

[Bernhard Schiffner]

bschiffner updated this revision to Diff 15348.
bschiffner added a comment.


  - [Digital Clock] Allow copying current date and time to clipboard (polishing)

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D6183?vs=15347=15348

REVISION DETAIL
  https://phabricator.kde.org/D6183

AFFECTED FILES
  applets/digital-clock/package/contents/ui/DigitalClock.qml
  applets/digital-clock/package/contents/ui/main.qml
  applets/digital-clock/plugin/CMakeLists.txt
  applets/digital-clock/plugin/clipboardmenu.cpp
  applets/digital-clock/plugin/clipboardmenu.h
  applets/digital-clock/plugin/digitalclockplugin.cpp

To: bschiffner, #plasma, broulik
Cc: plasma-devel, ZrenBot, spstarr, progwolff, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart, lukas

D6183: [Digital Clock] Allow copying current date and time to clipboard

[Bernhard Schiffner]

bschiffner added a comment.


  KDE 4.11 was this way
  
  F3781189: copy_datetime_to_clipboard_old.png 


REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D6183

To: bschiffner, #plasma, broulik
Cc: plasma-devel, ZrenBot, spstarr, progwolff, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart, lukas

D1350: [Digital Clock] Allow copying current date to clipboard

[Bernhard Schiffner]

bschiffner added a comment.


  The saga continues here:
  
  https://phabricator.kde.org/D6183

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D1350

To: broulik, #plasma:_design, #plasma, davidedmundson
Cc: bschiffner, colomar, plasma-devel, ZrenBot, spstarr, progwolff, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart, lukas

D6183: [Digital Clock] Allow copying current date and time to clipboard

[Bernhard Schiffner]

bschiffner added a comment.


  diff 2  structures the original patch from Kai Uwe by a clear arrangement of 
date/time/datetime and size.
  
  It separates data shown from data to be copied.
  
This prevents automagically added access codes to be copied.
This enables comments in the entries not to be copied too.
  
  The patch adds a submenu intended for other calendars as they get doable with 
a more advanced QLocale.
  
As a POC it shows now UNIX Time and Julian Date.
  
  (Thanks Konrad Rosenbaum for nurturing.)

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D6183

To: bschiffner, #plasma, broulik
Cc: plasma-devel, ZrenBot, spstarr, progwolff, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart, lukas

D6183: [Digital Clock] Allow copying current date and time to clipboard

[Bernhard Schiffner]

bschiffner added a comment.


  I think you get it much faster done. Please do it.
  I'am sitting in a hotel now without tools do to something software related :-(

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D6183

To: bschiffner, #plasma, broulik
Cc: davidedmundson, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart, lukas

D6183: [Digital Clock] Allow copying current date and time to clipboard

[Bernhard Schiffner]

bschiffner added a comment.


  Sorry for not understanding the (perhaps your?) problem with the seconds.
  Do you like to express that you:
  1.) do not get seconds at all (erverytime 00 or 59) or
  2.) do not get an actualized value of seconds (or time) in very the moment of 
clicking the intended format or
  3.) can have a platform related problem or
  4.) someting else?
  
  On all PCs (x86/AMD64) I use the patch on i get the time of opening the 
context menu with a "correct" value of seconds. This value can be copied from 
the clipboard anywhere.
  
  And you are right: there is no urgent need for a  display of seconds and if 
not displayed it would remove some "visual bloat".
  (Nevertheless I like this "geekiness" for my personal use: excel sheets, exif 
correction, ...)

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D6183

To: bschiffner, #plasma, broulik
Cc: davidedmundson, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart, lukas

D6183: [Digital Clock] Allow copying current date and time to clipboard

[Bernhard Schiffner]

bschiffner added a comment.


  Ah, I got it now and will try it.
  
  But if the user decides not to see seconds displayed, it can be interpreted 
plausibly he doesn't want to see them in the clipboard too.
  Pseudocode: if config.seconds() then ...

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D6183

To: bschiffner, #plasma, broulik
Cc: davidedmundson, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart, lukas

D6183: [Digital Clock] Allow copying current date and time to clipboard

[Bernhard Schiffner]

bschiffner added a comment.


  ping ...
  
  Kai Uwe, David any ideas how to proceed with the  change last week?
  
  Bernhard

REVISION DETAIL
  https://phabricator.kde.org/D6183

To: bschiffner, #plasma, broulik
Cc: davidedmundson, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D6183: [Digital Clock] Allow copying current date and time to clipboard

[Bernhard Schiffner]

bschiffner updated this revision to Diff 31690.
bschiffner added a comment.


  works for me now / ready to ship
  
  Thanks Kai-Uwe for your advices with the qml problems.
  I'am far from understanding this topic. Mostly cargo cult, but nevertheless 
working.

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D6183?vs=30975=31690

REVISION DETAIL
  https://phabricator.kde.org/D6183

AFFECTED FILES
  applets/digital-clock/package/contents/ui/DigitalClock.qml
  applets/digital-clock/package/contents/ui/main.qml
  applets/digital-clock/plugin/CMakeLists.txt
  applets/digital-clock/plugin/clipboardmenu.cpp
  applets/digital-clock/plugin/clipboardmenu.h
  applets/digital-clock/plugin/digitalclockplugin.cpp

To: bschiffner, #plasma, broulik
Cc: sharvey, davidedmundson, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D6183: [Digital Clock] Allow copying current date and time to clipboard

[Bernhard Schiffner]

bschiffner added a comment.


  No, I don't have commit access.
  "Bernhard Schiffner" <bernhard.schiff...@gmx.net>
  
  But why my email, Kai-Uwe did 98,7% of the work ...
  
  @Kai-Uwe: Can you do the merge (DigitalClock.qml#77) before pushing, please?

REVISION DETAIL
  https://phabricator.kde.org/D6183

To: bschiffner, #plasma, broulik
Cc: sharvey, davidedmundson, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D6183: [Digital Clock] Allow copying current date and time to clipboard

[Bernhard Schiffner]

bschiffner updated this revision to Diff 30975.
bschiffner added a comment.


  It supressed the seconds to be copied into the clipboard in case of the per 
minute update of the display.
  
  Missing: I don't know how to make the result of the action available to the 
MMB (middle mouse button).

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D6183?vs=15381=30975

REVISION DETAIL
  https://phabricator.kde.org/D6183

AFFECTED FILES
  applets/digital-clock/package/contents/ui/DigitalClock.qml
  applets/digital-clock/package/contents/ui/main.qml
  applets/digital-clock/plugin/CMakeLists.txt
  applets/digital-clock/plugin/clipboardmenu.cpp
  applets/digital-clock/plugin/clipboardmenu.h
  applets/digital-clock/plugin/digitalclockplugin.cpp

To: bschiffner, #plasma, broulik
Cc: davidedmundson, plasma-devel, ragreen, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart