[Differential] [Updated, 916 lines] D409: new mobile components
mart updated this revision to Diff 1066. REPOSITORY rPLASMAMOBILE plasma-mobile CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D409?vs=1009=1066 REVISION DETAIL https://phabricator.kde.org/D409 AFFECTED FILES components/mobilecomponents/ActionGroup.qml components/mobilecomponents/ApplicationWindow.qml components/mobilecomponents/CMakeLists.txt components/mobilecomponents/ContextDrawer.qml components/mobilecomponents/GlobalDrawer.qml components/mobilecomponents/Page.qml components/mobilecomponents/examples/ActionGroup.qml components/mobilecomponents/examples/ApplicationWindow.qml components/mobilecomponents/examples/ContextDrawer.qml components/mobilecomponents/examples/ExampleApp.qml components/mobilecomponents/examples/GlobalDrawer.qml components/mobilecomponents/examples/Page.qml components/mobilecomponents/examples/PageRow.qml components/mobilecomponents/qmldir EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: mart, davidedmundson, Plasma: Mobile Cc: davidedmundson, plasma-devel ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
[Differential] [Commented On] D409: new mobile components
mart added inline comments. INLINE COMMENTS components/mobilecomponents/ActionGroup.qml:26 yes, to do a tree-like thing components/mobilecomponents/ContextDrawer.qml:40 I'm still not sure wether the dependencies should be. I think i'll go for using qqc and wrapping the other classes that i need such as theme and units to make the plsma dependency optional components/mobilecomponents/ContextDrawer.qml:80 mistake components/mobilecomponents/GlobalDrawer.qml:101 it's still possible to drag back the page to the previous level, but yeah, it may be onfusing components/mobilecomponents/GlobalDrawer.qml:128 that's because of the scrolltolevel used before. it pops all the way trough the current level, in case there was some other children under it. if we are on the top of the stack, ths pop doesn't do anything. if the other becomes a pop, this pop can be removed components/mobilecomponents/GlobalDrawer.qml:132 hmm, yeah, it should go to the top, the idea is like a menubar menu, that just closes after triggering components/mobilecomponents/GlobalDrawer.qml:140 hmm, i didn't think about this, i assumed any page opened with an action here would have been pushed in the central pagerow, not this little one in the sidebar, which i tought it purely as a menu. it may make sense but then should be added someway in the api, like just a direct access for the pagerow REPOSITORY rPLASMAMOBILE plasma-mobile REVISION DETAIL https://phabricator.kde.org/D409 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: mart, davidedmundson, Plasma: Mobile Cc: davidedmundson, plasma-devel ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
[Differential] [Updated] D409: new mobile components
mart marked 5 inline comments as done. mart added a comment. REPOSITORY rPLASMAMOBILE plasma-mobile REVISION DETAIL https://phabricator.kde.org/D409 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: mart, davidedmundson, Plasma: Mobile Cc: davidedmundson, plasma-devel ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
[Differential] [Closed] D409: new mobile components
This revision was automatically updated to reflect the committed changes. mart marked 4 inline comments as done. Closed by commit rPLASMAMOBILEd3b28119a79f: new mobile components (authored by mart). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D409?vs=1110=1141#toc REPOSITORY rPLASMAMOBILE plasma-mobile CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D409?vs=1110=1141 REVISION DETAIL https://phabricator.kde.org/D409 AFFECTED FILES components/mobilecomponents/GlobalDrawer.qml EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: mart, davidedmundson, Plasma: Mobile Cc: davidedmundson, plasma-devel ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
[Differential] [Updated, 917 lines] D409: new mobile components
mart updated this revision to Diff 1110. REPOSITORY rPLASMAMOBILE plasma-mobile CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D409?vs=1066=1110 REVISION DETAIL https://phabricator.kde.org/D409 AFFECTED FILES components/mobilecomponents/ActionGroup.qml components/mobilecomponents/ApplicationWindow.qml components/mobilecomponents/CMakeLists.txt components/mobilecomponents/ContextDrawer.qml components/mobilecomponents/GlobalDrawer.qml components/mobilecomponents/Page.qml components/mobilecomponents/examples/ActionGroup.qml components/mobilecomponents/examples/ApplicationWindow.qml components/mobilecomponents/examples/ContextDrawer.qml components/mobilecomponents/examples/ExampleApp.qml components/mobilecomponents/examples/GlobalDrawer.qml components/mobilecomponents/examples/Page.qml components/mobilecomponents/examples/PageRow.qml components/mobilecomponents/qmldir EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: mart, Plasma: Mobile, davidedmundson Cc: davidedmundson, plasma-devel ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
[Differential] [Request, 3,636 lines] D502: RFC: start in making plasma deps optional
mart created this revision. mart added a reviewer: Plasma: Mobile. mart set the repository for this revision to rPLASMAMOBILE plasma-mobile. Herald added a subscriber: plasma-devel. REVISION SUMMARY make a wrapper for theme and units: one using plasma deps and one without, with more hardcoded values, eventually what to installlshould be decided at build time. To be possible to have a full application done with it, some components should be cloned from plasma components and plasma stuff removed. right now the clones are PageRow, Heading, Label. porting is still not complete, more of an RFC for now REPOSITORY rPLASMAMOBILE plasma-mobile REVISION DETAIL https://phabricator.kde.org/D502 AFFECTED FILES components/mobilecomponents/ActionGroup.qml components/mobilecomponents/ApplicationWindow.qml components/mobilecomponents/CMakeLists.txt components/mobilecomponents/ContextDrawer.qml components/mobilecomponents/GlobalDrawer.qml components/mobilecomponents/IconGrid.qml components/mobilecomponents/OverlayDrawer.qml components/mobilecomponents/Page.qml components/mobilecomponents/SplitDrawer.qml components/mobilecomponents/fallbacktheme/Theme.qml components/mobilecomponents/fallbacktheme/Units.qml components/mobilecomponents/plasmatheme/Theme.qml components/mobilecomponents/plasmatheme/Units.qml components/mobilecomponents/qml/ActionGroup.qml components/mobilecomponents/qml/ApplicationWindow.qml components/mobilecomponents/qml/ContextDrawer.qml components/mobilecomponents/qml/GlobalDrawer.qml components/mobilecomponents/qml/Heading.qml components/mobilecomponents/qml/IconGrid.qml components/mobilecomponents/qml/Label.qml components/mobilecomponents/qml/OverlayDrawer.qml components/mobilecomponents/qml/Page.qml components/mobilecomponents/qml/PageRow.qml components/mobilecomponents/qml/SplitDrawer.qml components/mobilecomponents/qml/private/PageStack.js components/mobilecomponents/qml/qmldir components/mobilecomponents/qmldir EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: mart, Plasma: Mobile Cc: plasma-devel ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
[Differential] [Accepted] D729: Add Package to activesettings module
mart accepted this revision. mart added a comment. This revision is now accepted and ready to land. We'll have to definitely get rid of that class, but for now just to unbreak things is fine REVISION DETAIL https://phabricator.kde.org/D729 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: bshah, mart, Plasma: Mobile Cc: plasma-devel, obogdan, sebas ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
[Differential] [Closed] D502: RFC: start in making plasma deps optional
This revision was automatically updated to reflect the committed changes. Closed by commit rPLASMAMOBILE962e592afdf2: RFC: start in making plasma deps optional (authored by mart). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D502?vs=1329=1436#toc REPOSITORY rPLASMAMOBILE plasma-mobile CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D502?vs=1329=1436 REVISION DETAIL https://phabricator.kde.org/D502 AFFECTED FILES activeshellpackage/package/contents/explorer/MenuTabBar.qml activeshellpackage/package/contents/views/ApplicationList.qml components/CMakeLists.txt components/mobilecomponents/ActionGroup.qml components/mobilecomponents/ApplicationWindow.qml components/mobilecomponents/CMakeLists.txt components/mobilecomponents/ContextDrawer.qml components/mobilecomponents/GlobalDrawer.qml components/mobilecomponents/IconGrid.qml components/mobilecomponents/OverlayDrawer.qml components/mobilecomponents/Page.qml components/mobilecomponents/SplitDrawer.qml components/mobilecomponents/applicationlistmodel.cpp components/mobilecomponents/applicationlistmodel.h components/mobilecomponents/examples/ExampleApp.qml components/mobilecomponents/examples/MainPage.qml components/mobilecomponents/examples/banner.jpg components/mobilecomponents/examples/gallery/ButtonGallery.qml components/mobilecomponents/examples/gallery/CheckBoxGallery.qml components/mobilecomponents/examples/gallery/IconGridGallery.qml components/mobilecomponents/examples/gallery/ProgressBarGallery.qml components/mobilecomponents/examples/gallery/RadioButtonGallery.qml components/mobilecomponents/examples/gallery/SliderGallery.qml components/mobilecomponents/examples/gallery/SwitchGallery.qml components/mobilecomponents/examples/gallery/TextFieldGallery.qml components/mobilecomponents/fallbacktheme/Icon.qml components/mobilecomponents/fallbacktheme/Theme.qml components/mobilecomponents/fallbacktheme/Units.qml components/mobilecomponents/fallbacktheme/qmldir components/mobilecomponents/fullscreenpanel.cpp components/mobilecomponents/fullscreenpanel.h components/mobilecomponents/mobilecomponentsplugin.cpp components/mobilecomponents/mobilecomponentsplugin.h components/mobilecomponents/package.cpp components/mobilecomponents/package.h components/mobilecomponents/pagedproxymodel.cpp components/mobilecomponents/pagedproxymodel.h components/mobilecomponents/plasmatheme/Icon.qml components/mobilecomponents/plasmatheme/Theme.qml components/mobilecomponents/plasmatheme/Units.qml components/mobilecomponents/private/CMakeLists.txt components/mobilecomponents/private/mobilecomponentsprivateplugin.cpp components/mobilecomponents/private/mobilecomponentsprivateplugin.h components/mobilecomponents/private/pagedproxymodel.cpp components/mobilecomponents/private/pagedproxymodel.h components/mobilecomponents/private/qmldir components/mobilecomponents/qml/ActionGroup.qml components/mobilecomponents/qml/ApplicationWindow.qml components/mobilecomponents/qml/ContextDrawer.qml components/mobilecomponents/qml/GlobalDrawer.qml components/mobilecomponents/qml/Heading.qml components/mobilecomponents/qml/IconGrid.qml components/mobilecomponents/qml/Label.qml components/mobilecomponents/qml/ListItem.qml components/mobilecomponents/qml/ListItemWithActions.qml components/mobilecomponents/qml/OverlayDrawer.qml components/mobilecomponents/qml/Page.qml components/mobilecomponents/qml/PageRow.qml components/mobilecomponents/qml/SplitDrawer.qml components/mobilecomponents/qml/private/AbstractDrawer.qml components/mobilecomponents/qml/private/ActionButton.qml components/mobilecomponents/qml/private/ActionButtonArrow.qml components/mobilecomponents/qml/private/PageStack.js components/mobilecomponents/qml/qmldir components/mobilecomponents/qmldir components/mobileshellprivate/CMakeLists.txt components/mobileshellprivate/Messages.sh components/mobileshellprivate/fullscreenpanel.cpp components/mobileshellprivate/fullscreenpanel.h components/mobileshellprivate/mobileshellprivateplugin.cpp components/mobileshellprivate/mobileshellprivateplugin.h components/mobileshellprivate/qmldir EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: mart, Plasma: Mobile Cc: plasma-devel ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
[Differential] [Updated, 9,642 lines] D502: RFC: start in making plasma deps optional
mart updated this revision to Diff 1329. mart added a comment. weekly update of the current status of the branch REPOSITORY rPLASMAMOBILE plasma-mobile CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D502?vs=1178=1329 REVISION DETAIL https://phabricator.kde.org/D502 AFFECTED FILES activeshellpackage/package/contents/explorer/MenuTabBar.qml activeshellpackage/package/contents/views/ApplicationList.qml components/CMakeLists.txt components/mobilecomponents/ActionGroup.qml components/mobilecomponents/ApplicationWindow.qml components/mobilecomponents/CMakeLists.txt components/mobilecomponents/ContextDrawer.qml components/mobilecomponents/GlobalDrawer.qml components/mobilecomponents/IconGrid.qml components/mobilecomponents/OverlayDrawer.qml components/mobilecomponents/Page.qml components/mobilecomponents/SplitDrawer.qml components/mobilecomponents/applicationlistmodel.cpp components/mobilecomponents/applicationlistmodel.h components/mobilecomponents/examples/ExampleApp.qml components/mobilecomponents/examples/MainPage.qml components/mobilecomponents/examples/banner.jpg components/mobilecomponents/examples/gallery/ButtonGallery.qml components/mobilecomponents/examples/gallery/CheckBoxGallery.qml components/mobilecomponents/examples/gallery/IconGridGallery.qml components/mobilecomponents/examples/gallery/ProgressBarGallery.qml components/mobilecomponents/examples/gallery/RadioButtonGallery.qml components/mobilecomponents/examples/gallery/SliderGallery.qml components/mobilecomponents/examples/gallery/SwitchGallery.qml components/mobilecomponents/examples/gallery/TextFieldGallery.qml components/mobilecomponents/fallbacktheme/Icon.qml components/mobilecomponents/fallbacktheme/Theme.qml components/mobilecomponents/fallbacktheme/Units.qml components/mobilecomponents/fallbacktheme/qmldir components/mobilecomponents/fullscreenpanel.cpp components/mobilecomponents/fullscreenpanel.h components/mobilecomponents/mobilecomponentsplugin.cpp components/mobilecomponents/plasmatheme/Icon.qml components/mobilecomponents/plasmatheme/Theme.qml components/mobilecomponents/plasmatheme/Units.qml components/mobilecomponents/qml/ActionGroup.qml components/mobilecomponents/qml/ApplicationWindow.qml components/mobilecomponents/qml/ContextDrawer.qml components/mobilecomponents/qml/GlobalDrawer.qml components/mobilecomponents/qml/Heading.qml components/mobilecomponents/qml/IconGrid.qml components/mobilecomponents/qml/Label.qml components/mobilecomponents/qml/ListItem.qml components/mobilecomponents/qml/ListItemWithActions.qml components/mobilecomponents/qml/OverlayDrawer.qml components/mobilecomponents/qml/Page.qml components/mobilecomponents/qml/PageRow.qml components/mobilecomponents/qml/SplitDrawer.qml components/mobilecomponents/qml/plasmadep.diff components/mobilecomponents/qml/private/ActionButton.qml components/mobilecomponents/qml/private/PageStack.js components/mobilecomponents/qml/qmldir components/mobilecomponents/qmldir components/mobileshellprivate/CMakeLists.txt components/mobileshellprivate/Messages.sh components/mobileshellprivate/fullscreenpanel.cpp components/mobileshellprivate/fullscreenpanel.h components/mobileshellprivate/mobileshellprivateplugin.cpp components/mobileshellprivate/mobileshellprivateplugin.h components/mobileshellprivate/qmldir EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: mart, Plasma: Mobile Cc: plasma-devel ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
[Differential] [Accepted] D782: Require Qt 5.5
mart accepted this revision. mart added a reviewer: mart. This revision is now accepted and ready to land. REPOSITORY rPLASMAINTEGRATION Integration for Qt applications in Plasma BRANCH qt-increase-version REVISION DETAIL https://phabricator.kde.org/D782 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: graesslin, Plasma, mart Cc: apol, plasma-devel ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
[Differential] [Accepted] D1768: Pass screen ID to systray applets
mart accepted this revision. mart added a reviewer: mart. mart added a comment. This revision is now accepted and ready to land. yeah, i'm not happy that the screen is not passed. I'm not sure i like this approach completely (if the panel gets moved to another screen the internal screen won't be updated?), but i didn't manage to think about a viable way to pass the screen without making the systray container try to take a panel. so I'm fine with this going in. don't know how easy will be when a proper way is found. one way may be some offscreen category for either formfactor or location, that then the corona would ignore, then the containment has correctly a screen? REPOSITORY rPLASMAWORKSPACE Plasma Workspace BRANCH notifications_screen REVISION DETAIL https://phabricator.kde.org/D1768 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: davidedmundson, #plasma, mart Cc: mart, plasma-devel, sebas ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
[Differential] [Commented On] D1757: [Panel] Reduce duplicate enabled borders calculation
mart added inline comments. INLINE COMMENTS > mart wrote in Panel.qml:32 > there is no enabledborders property in containment? (neither i want such a > property, is not the right place) perhaps as a property of the view could work REPOSITORY rPLASMADESKTOP Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D1757 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: broulik, #plasma, davidedmundson, mart Cc: mart, davidedmundson, plasma-devel, sebas ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
[Differential] [Closed] D1791: Give a screen to systray applets
mart closed this revision. REPOSITORY rPLASMAWORKSPACE Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D1791 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: mart, davidedmundson Cc: davidedmundson, plasma-devel, sebas ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
[Differential] [Accepted] D1778: [PanelConfigView] Set enabled borders on PanelShadow
mart accepted this revision. mart added a reviewer: mart. This revision is now accepted and ready to land. REPOSITORY rPLASMAWORKSPACE Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D1778 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: broulik, #plasma, mart Cc: plasma-devel, sebas ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
[Differential] [Updated, 12 lines] D1791: Give a screen to systray applets
mart updated this revision to Diff 4277. REPOSITORY rPLASMAWORKSPACE Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D1791?vs=4276=4277 REVISION DETAIL https://phabricator.kde.org/D1791 AFFECTED FILES applets/systemtray/container/systemtraycontainer.cpp applets/systemtray/systemtray.cpp shell/shellcorona.cpp EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: mart Cc: plasma-devel, sebas ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
[Differential] [Accepted] D1788: [Pager] Don't update models when not visible
mart accepted this revision. mart added a reviewer: mart. This revision is now accepted and ready to land. REPOSITORY rPLASMADESKTOP Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D1788 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: broulik, #plasma, mart Cc: plasma-devel, sebas ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
[Differential] [Commented On] D1757: [Panel] Reduce duplicate enabled borders calculation
mart added inline comments. INLINE COMMENTS > davidedmundson wrote in Panel.qml:29 > In PanelView::themeChanged > > call positionPanel() > Will acheive the same thing. > > and then we can get rid of this. ok REPOSITORY rPLASMADESKTOP Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D1757 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: broulik, mart, davidedmundson, #plasma Cc: mart, davidedmundson, plasma-devel, sebas ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
[Differential] [Request, 13 lines] D1791: Give a screen to systray applets
mart created this revision. mart set the repository for this revision to rPLASMAWORKSPACE Plasma Workspace. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY don't hardcode -a as the internal systray screen anymore. give it the new customembeddedcontainment containment type, and ignore those in panel creation. the old systray logic in containmentforscreen gets reused. TEST PLAN tried to move the panel from one screen to another, notifications screen went from 0 to 1 REPOSITORY rPLASMAWORKSPACE Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D1791 AFFECTED FILES applets/systemtray/container/systemtraycontainer.cpp applets/systemtray/systemtray.cpp shell/shellcorona.cpp EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: mart Cc: plasma-devel, sebas ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
[Differential] [Accepted] D1770: [OSD] Allow disabling OSD through config file
mart accepted this revision. mart added a reviewer: mart. mart added a comment. This revision is now accepted and ready to land. ah, ok fine then ;) REPOSITORY rPLASMAWORKSPACE Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D1770 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: broulik, #plasma, mart Cc: mart, graesslin, plasma-devel, sebas ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
[Differential] [Commented On] D1770: [OSD] Allow disabling OSD through config file
mart added a comment. this configuration is intended for kiosk setups? if it's hidden, there is always the risk of bitrot REPOSITORY rPLASMAWORKSPACE Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D1770 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: broulik, #plasma Cc: mart, graesslin, plasma-devel, sebas ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
[Differential] [Commented On] D1768: Pass screen ID to systray applets
mart added a comment. yeah, i'm not happy that the screen is not passed. I'm not sure i like this approach completely (if the panel gets moved to another screen the internal screen won't be updated?), but i didn't manage to think about a viable way to pass the screen without making the systray container try to take a panel. so I'm fine with this going in. don't know how easy will be when a proper way is found. one way may be some offscreen category for either formfactor or location, that then the corona would ignore, then the containment has correctly a screen? REPOSITORY rPLASMAWORKSPACE Plasma Workspace BRANCH notifications_screen REVISION DETAIL https://phabricator.kde.org/D1768 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: davidedmundson, #plasma, mart Cc: mart, plasma-devel, sebas ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
[Differential] [Commented On] D1757: [Panel] Reduce duplicate enabled borders calculation
mart added a comment. I don't understand what the patch is supposed to be doing.. the enabled bprders of the svg can be calculated only based on the location of the panel, that has been completely removed INLINE COMMENTS > broulik wrote in Panel.qml:29 > Dunno if we still need this, ie. if we need a way to signal this back to cpp this is used on themes that have different svgs for different panel locations ( default ones don't anymore) should be found some obscure theme on kdelook that uses this feature (i can see an use for it, don't think it can be removed to force only one background per theme) > broulik wrote in Panel.qml:32 > Needs to check for containment being null or else prints warning there is no enabledborders property in containment? (neither i want such a property, is not the right place) REPOSITORY rPLASMADESKTOP Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D1757 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: broulik, #plasma, davidedmundson Cc: mart, davidedmundson, plasma-devel, sebas ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
[Differential] [Requested Changes To] D1757: [Panel] Reduce duplicate enabled borders calculation
mart requested changes to this revision. mart added a reviewer: mart. This revision now requires changes to proceed. REPOSITORY rPLASMADESKTOP Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D1757 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: broulik, #plasma, davidedmundson, mart Cc: mart, davidedmundson, plasma-devel, sebas ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
[Differential] [Updated, 14 lines] D1791: Give a screen to systray applets
mart updated this revision to Diff 4279. REPOSITORY rPLASMAWORKSPACE Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D1791?vs=4277=4279 REVISION DETAIL https://phabricator.kde.org/D1791 AFFECTED FILES applets/systemtray/container/systemtraycontainer.cpp applets/systemtray/systemtray.cpp shell/shellcorona.cpp EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: mart Cc: plasma-devel, sebas ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
[Differential] [Accepted] D1826: systemtray container: fix m_internalSystray nullptr crash
mart accepted this revision. This revision is now accepted and ready to land. REPOSITORY rPLASMAWORKSPACE Plasma Workspace BRANCH master REVISION DETAIL https://phabricator.kde.org/D1826 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: dfaure, mart Cc: plasma-devel, sebas ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
[Differential] [Commented On] D1813: Fix selected name filter with multiple mimetypes
mart added a comment. shouldn't be kde2QtFilter() fixed instead? REPOSITORY rPLASMAINTEGRATION Integration for Qt applications in Plasma REVISION DETAIL https://phabricator.kde.org/D1813 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: elvisangelaccio, #plasma Cc: mart, plasma-devel, #plasma, sebas ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
[Differential] [Accepted] D1793: [Device Notifier] Be more declarative
mart accepted this revision. mart added a reviewer: mart. This revision is now accepted and ready to land. REPOSITORY rPLASMAWORKSPACE Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D1793 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: broulik, #plasma, mart Cc: plasma-devel, sebas ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
[Differential] [Commented On] D1814: Add TaskManager requestActivities
mart added a comment. +1 REPOSITORY rPLASMAWORKSPACE Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D1814 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: davidedmundson, #plasma Cc: mart, plasma-devel, sebas ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
[Differential] [Accepted] D1752: [Panel Configuration] Disallow pressing Escape whilst manipulating panel
mart accepted this revision. mart added a reviewer: mart. This revision is now accepted and ready to land. REPOSITORY rPLASMADESKTOP Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D1752 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: broulik, #plasma, mart Cc: plasma-devel, sebas ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
[Differential] [Accepted] D1757: [Panel] Reduce duplicate enabled borders calculation
mart accepted this revision. This revision is now accepted and ready to land. REPOSITORY rPLASMADESKTOP Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D1757 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: broulik, davidedmundson, #plasma, mart Cc: mart, davidedmundson, plasma-devel, sebas ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
[Differential] [Commented On] D1772: Port custom collasablebutton to KWidgetAddons::KCollapsibleGroupBox
mart added a comment. +1 REPOSITORY rKSCREEN KScreen REVISION DETAIL https://phabricator.kde.org/D1772 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: davidedmundson, #plasma Cc: mart, plasma-devel, sebas ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
[Differential] [Commented On] D1816: Switch to Noto Mono as default monospace font
mart added a comment. In https://phabricator.kde.org/D1816#34042, @davidedmundson wrote: > ok, but it'd have to be 5.8 given we're past dependency freeze. yeah, makes sense, let's go for 5.8 REPOSITORY rPLASMAINTEGRATION Integration for Qt applications in Plasma REVISION DETAIL https://phabricator.kde.org/D1816 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: jriddell, #plasma, #plasma:_design Cc: mart, davidedmundson, plasma-devel, sebas ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
[Differential] [Commented On] D1816: Switch to Noto Mono as default monospace font
mart added a comment. even if not optimal i think we should go for it REPOSITORY rPLASMAINTEGRATION Integration for Qt applications in Plasma REVISION DETAIL https://phabricator.kde.org/D1816 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: jriddell, #plasma, #plasma:_design Cc: mart, davidedmundson, plasma-devel, sebas ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
[Differential] [Accepted] D1735: Notify about low peripheral batteries (mouse, keyboard)
mart accepted this revision. mart added a reviewer: mart. This revision is now accepted and ready to land. REPOSITORY rPOWERDEVIL Powerdevil BRANCH broulik/notifyPeripherals REVISION DETAIL https://phabricator.kde.org/D1735 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: broulik, #plasma, #plasma:_design, mart Cc: colomar, lueck, graesslin, plasma-devel, sebas ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
[Differential] [Accepted] D1839: [Panel] Fix warning and don't cause side-effects in binding
mart accepted this revision. mart added a reviewer: mart. This revision is now accepted and ready to land. REPOSITORY rPLASMADESKTOP Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D1839 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: broulik, #plasma, mart Cc: plasma-devel, sebas ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
[Differential] [Accepted] D1848: [System Tray] Fix current item highlight
mart accepted this revision. mart added a reviewer: mart. This revision is now accepted and ready to land. REPOSITORY rPLASMAWORKSPACE Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D1848 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: broulik, #plasma, mart Cc: plasma-devel, sebas ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
[Differential] [Accepted] D1847: [System Tray AbstractItem] Hide tooltip when clicking item
mart accepted this revision. mart added a reviewer: mart. This revision is now accepted and ready to land. REPOSITORY rPLASMAWORKSPACE Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D1847 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: broulik, #plasma, mart Cc: plasma-devel, sebas ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
[Differential] [Accepted] D1830: [DrKonqi] Remove heartbeat icon
mart accepted this revision. mart added a reviewer: mart. mart added a comment. This revision is now accepted and ready to land. makes sense REPOSITORY rPLASMAWORKSPACE Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D1830 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: broulik, #plasma, #plasma:_design, mart Cc: mart, plasma-devel, sebas ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
[Differential] [Accepted] D1845: [Compact Applet] Hide tooltip when showing contextual actions
mart accepted this revision. mart added a reviewer: mart. This revision is now accepted and ready to land. REPOSITORY rPLASMADESKTOP Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D1845 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: broulik, #plasma, mart Cc: plasma-devel, sebas ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
[Differential] [Accepted] D1860: make kirigamiplugin also directly linkable
mart accepted this revision.
mart added a comment.
This revision is now accepted and ready to land.
apart minor cosmetic issues is good to go.
do you have permissions to push on git?
INLINE COMMENTS
> kirigamiplugin.h:69
> +QUrl componentPath(const QString ) const;
> +QString toFilePath(const QString ) const {
> +return QLatin1Char(':') + path;
i would call them resolveFilePath/resolveFileUrl
also, implementation in the cpp with the { in new line
REPOSITORY
rKIRIGAMI Kirigami
REVISION DETAIL
https://phabricator.kde.org/D1860
EMAIL PREFERENCES
https://phabricator.kde.org/settings/panel/emailpreferences/
To: bearsh, mart
Cc: plasma-devel
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel
[Differential] [Commented On] D1860: make kirigamiplugin also directly linkable
mart added a comment. ok, you can send me a patch with git format-patch, o with git am i can push it with you as author. for future ones, you gan do: https://identity.kde.org/index.php?r=developerApplication REPOSITORY rKIRIGAMI Kirigami REVISION DETAIL https://phabricator.kde.org/D1860 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: bearsh, mart Cc: plasma-devel ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
[Differential] [Accepted] D1895: Finish implementation of mode in which launchers are not kept separate.
mart accepted this revision. mart added a reviewer: mart. This revision is now accepted and ready to land. REPOSITORY rPLASMAWORKSPACE Plasma Workspace BRANCH master REVISION DETAIL https://phabricator.kde.org/D1895 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: hein, davidedmundson, mart Cc: plasma-devel, jensreuterberg, sebas ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
[Differential] [Accepted] D1896: Expose separate-launchers toggle in config.
mart accepted this revision. mart added a reviewer: mart. This revision is now accepted and ready to land. REPOSITORY rPLASMADESKTOP Plasma Desktop BRANCH master REVISION DETAIL https://phabricator.kde.org/D1896 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: hein, davidedmundson, mart Cc: plasma-devel, jensreuterberg, sebas ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
[Differential] [Accepted] D1869: [Containment Actions] Offer "Remove this panel" option only when panel is being edited
mart accepted this revision. mart added a reviewer: mart. This revision is now accepted and ready to land. REPOSITORY rPLASMAWORKSPACE Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D1869 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: broulik, #plasma, #plasma:_design, mart Cc: plasma-devel, jensreuterberg, sebas ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
[Differential] [Accepted] D1867: [Calendar Applet] Show day or week number in icon
mart accepted this revision.
mart added a reviewer: mart.
mart added inline comments.
This revision is now accepted and ready to land.
INLINE COMMENTS
> calendarplugin.h:37
> +
> +class CalendarPlugin : public QQmlExtensionPlugin
> +{
i would prefer to have a c++ calendar applet instead of having more private qml
imports, that i would like to completely get rid of eventually.
REPOSITORY
rPLASMAWORKSPACE Plasma Workspace
REVISION DETAIL
https://phabricator.kde.org/D1867
EMAIL PREFERENCES
https://phabricator.kde.org/settings/panel/emailpreferences/
To: broulik, #plasma, #plasma:_design, mart
Cc: mart, colomar, plasma-devel, jensreuterberg, sebas
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel
[Differential] [Accepted] D1882: Expose inline grouping mode.
mart accepted this revision. mart added a reviewer: mart. This revision is now accepted and ready to land. REPOSITORY rPLASMADESKTOP Plasma Desktop BRANCH blblblbl REVISION DETAIL https://phabricator.kde.org/D1882 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: hein, davidedmundson, mart Cc: plasma-devel, jensreuterberg, sebas ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
[Differential] [Accepted] D1881: Add an inline grouping mode.
mart accepted this revision. mart added a reviewer: mart. This revision is now accepted and ready to land. REPOSITORY rPLASMAWORKSPACE Plasma Workspace BRANCH master REVISION DETAIL https://phabricator.kde.org/D1881 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: hein, davidedmundson, mart Cc: plasma-devel, jensreuterberg, sebas ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
[Differential] [Accepted] D1889: [shell] Properly position DesktopView on Wayland
mart accepted this revision. mart added a reviewer: mart. This revision is now accepted and ready to land. REPOSITORY rPLASMAWORKSPACE Plasma Workspace BRANCH desktopview-set-position REVISION DETAIL https://phabricator.kde.org/D1889 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: graesslin, #plasma_on_wayland, mart Cc: plasma-devel, jensreuterberg, sebas ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
[Differential] [Accepted] D1849: Write out QT_SCREEN_SCALE_FACTORS instead of deprecated QT_DEVICE_PIXEL_RATIO
mart accepted this revision. mart added a reviewer: mart. This revision is now accepted and ready to land. REPOSITORY rPLASMAWORKSPACE Plasma Workspace BRANCH origin-master (branched from master) REVISION DETAIL https://phabricator.kde.org/D1849 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: davidedmundson, #plasma, mart Cc: plasma-devel, sebas ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
[Differential] [Accepted] D1721: Rename libtaskmanager to liblegacytaskmanager to make way for rewrite.
mart accepted this revision. mart added a reviewer: mart. This revision is now accepted and ready to land. REPOSITORY rPLASMAWORKSPACE Plasma Workspace BRANCH master REVISION DETAIL https://phabricator.kde.org/D1721 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: hein, Plasma, mart Cc: plasma-devel, sebas ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
[Differential] [Changed Subscribers] D1670: New login screen
mart added inline comments. INLINE COMMENTS > broulik wrote in Background.qml:36 > Rectangle still allows Gradient with GradientStop, just that the gradient can > only be top to bottom which is what we want here anyway. are we sure that one is implemented with a software renderer? REPOSITORY rPLASMAWORKSPACE Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D1670 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: davidedmundson, Plasma Cc: mart, broulik, plasma-devel, sebas ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
[Differential] [Accepted] D1562: [OSD] Enable wrapping into two lines
mart accepted this revision. mart added a reviewer: mart. This revision is now accepted and ready to land. REPOSITORY rPLASMAWORKSPACE Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D1562 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: broulik, Plasma, mart Cc: graesslin, plasma-devel, sebas ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
[Differential] [Accepted] D1680: [server] Don't destroy resource from dtor of a Resource sub class
mart accepted this revision. mart added a reviewer: mart. This revision is now accepted and ready to land. REPOSITORY rKWAYLAND KWayland BRANCH no-destroy-from-dtor REVISION DETAIL https://phabricator.kde.org/D1680 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: graesslin, Plasma, mart Cc: plasma-devel, sebas ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
[Differential] [Commented On] D1664: Update for Breeze-gtk
mart added a comment. doesn't seem to apply over breeze-gtk master i get: The next patch would delete the file Breeze-dark-gtk/assets/arrow-down-active.png, which does not exist! Assume -R? [n] (while there is Breeze-dark-gtk/gtk-2.0/assets/ and Breeze-dark-gtk/gtk-3.0/assets/ ) also can you provide a screenshot if there are significant visual differenceies? REPOSITORY rBREEZEGTK Breeze for Gtk REVISION DETAIL https://phabricator.kde.org/D1664 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: dirrukd, Plasma Cc: mart, plasma-devel, sebas ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
[Differential] [Accepted] D1664: Update for Breeze-gtk
mart accepted this revision. mart added a reviewer: mart. This revision is now accepted and ready to land. REPOSITORY rBREEZEGTK Breeze for Gtk REVISION DETAIL https://phabricator.kde.org/D1664 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: dirrukd, Plasma, mart Cc: mart, plasma-devel, sebas ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
[Differential] [Changed Subscribers] D1724: Import Task Manager widgets ports to the new library.
mart added inline comments.
INLINE COMMENTS
> Task.qml:203
> +var smartLauncher = Qt.createQmlObject("
> +import org.kde.plasma.private.taskmanager 0.1 as TaskManagerApplet;
> +TaskManagerApplet.SmartLauncherItem { }", task);
maybe using an inline Component{} ?
REPOSITORY
rPLASMADESKTOP Plasma Desktop
REVISION DETAIL
https://phabricator.kde.org/D1724
EMAIL PREFERENCES
https://phabricator.kde.org/settings/panel/emailpreferences/
To: hein, #plasma
Cc: mart, broulik, plasma-devel, sebas
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel
[Differential] [Commented On] D1706: [Switch Window Containment Action] Fix listing windows with just one virtual desktop
mart added a comment.
there was an inconsistency at some point between the applet counting from 0
and x counting from 1 iirc, and nowdays *should* be possible to remove that if
(KWindowSystem::numberOfDesktops() < 2) { code?
REPOSITORY
rPLASMAWORKSPACE Plasma Workspace
REVISION DETAIL
https://phabricator.kde.org/D1706
EMAIL PREFERENCES
https://phabricator.kde.org/settings/panel/emailpreferences/
To: broulik, Plasma, hein, graesslin
Cc: mart, plasma-devel, sebas
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel
[Differential] [Accepted] D1723: Rename Task Manager applets out of the way of rewrites.
mart accepted this revision. mart added a reviewer: mart. mart added a comment. This revision is now accepted and ready to land. that should go in asap REPOSITORY rPLASMADESKTOP Plasma Desktop BRANCH master REVISION DETAIL https://phabricator.kde.org/D1723 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: hein, Plasma, mart Cc: mart, plasma-devel, sebas ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
[Differential] [Accepted] D1966: Set System Tray AppletItem width properly
mart accepted this revision. mart added a reviewer: mart. This revision is now accepted and ready to land. REPOSITORY rPLASMAWORKSPACE Plasma Workspace BRANCH Plasma/5.7 REVISION DETAIL https://phabricator.kde.org/D1966 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: davidedmundson, #plasma, mart Cc: plasma-devel, jensreuterberg, sebas ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
[Differential] [Accepted] D1967: Don't try to reorder an item before itself.
mart accepted this revision. mart added a reviewer: mart. This revision is now accepted and ready to land. REPOSITORY rPLASMAWORKSPACE Plasma Workspace BRANCH Plasma/5.7 REVISION DETAIL https://phabricator.kde.org/D1967 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: hein, #plasma, mart Cc: plasma-devel, jensreuterberg, sebas ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
[Differential] [Accepted] D821: Drop not needed KF5::Plasma dependency
mart accepted this revision. mart added a reviewer: mart. This revision is now accepted and ready to land. REPOSITORY rKSCREENLOCKER KScreenLocker BRANCH drop-plasma-dependency REVISION DETAIL https://phabricator.kde.org/D821 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: graesslin, bshah, Plasma, mart Cc: plasma-devel ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
[Differential] [Accepted] D2013: Right align the distribution logo
mart accepted this revision. This revision is now accepted and ready to land. REPOSITORY rKINFOCENTER KInfoCenter BRANCH Plasma/5.7 REVISION DETAIL https://phabricator.kde.org/D2013 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: ltoscano, jriddell, davidedmundson, mart Cc: plasma-devel, jensreuterberg, sebas ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
[Differential] [Commented On] D1986: WIP: Save PanelView settings in terms of grid units
mart added a comment. anyways, i like the idea. uh, also no more plans of supporting QT_SCREEN_SCALE_FACTORS instead? (in this case the pixel based sizes should be just fine as they would be scaled?) REPOSITORY rPLASMAWORKSPACE Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D1986 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: davidedmundson, #plasma Cc: mart, plasma-devel, jensreuterberg, sebas ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
[Differential] [Accepted] D1901: [PolicyAgent] Ignore "Keep screen on" request while screen is locked
mart accepted this revision. mart added a reviewer: mart. This revision is now accepted and ready to land. REPOSITORY rPOWERDEVIL Powerdevil REVISION DETAIL https://phabricator.kde.org/D1901 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: broulik, #plasma, #plasma:_design, mart Cc: graesslin, colomar, plasma-devel, jensreuterberg, sebas ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
[Differential] [Accepted] D2020: [Folder View internallibkonq] Use KIO::highlightInFileManager
mart accepted this revision. mart added a reviewer: mart. This revision is now accepted and ready to land. REPOSITORY rPLASMADESKTOP Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D2020 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: broulik, #plasma, mart Cc: plasma-devel, jensreuterberg, sebas ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
[Differential] [Accepted] D2009: Update Keyboard focus when the Surface of the active client changes
mart accepted this revision. mart added a reviewer: mart. This revision is now accepted and ready to land. REPOSITORY rKWIN KWin BRANCH update-keyboard-focus-x11-5.7 REVISION DETAIL https://phabricator.kde.org/D2009 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: graesslin, #plasma_on_wayland, #kwin, mart Cc: plasma-devel, kwin, hardening, jensreuterberg, sebas ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
[Differential] [Changed Subscribers] D1986: WIP: Save PanelView settings in terms of grid units
mart added inline comments.
INLINE COMMENTS
> panelview.cpp:1096
>
> +void PanelView::writeScaledConfigEntry(const char *name, int pixelSize)
> +{
why adding a new setter and getter that work in pixels? if something like that
should be added, i wuld like just working with grid units.
perhaps having the old thickness/setThickness etc that still accept sizes in
pixels for compatibility and have new setUnitsThickness or whatever that
accepts units?
> panelview.cpp:1098
> +{
> +config().writeEntry(name, pixelSize / m_theme.mSize().width());
> +}
in the scripting the m height is binded, not the width
REPOSITORY
rPLASMAWORKSPACE Plasma Workspace
REVISION DETAIL
https://phabricator.kde.org/D1986
EMAIL PREFERENCES
https://phabricator.kde.org/settings/panel/emailpreferences/
To: davidedmundson, #plasma
Cc: mart, plasma-devel, jensreuterberg, sebas
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel
[Differential] [Accepted] D2023: Properly trigger repaint for sofware cursor
mart accepted this revision. mart added a reviewer: mart. This revision is now accepted and ready to land. REPOSITORY rKWIN KWin BRANCH platform-cursor-repaint REVISION DETAIL https://phabricator.kde.org/D2023 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: graesslin, #kwin, #plasma_on_wayland, mart Cc: plasma-devel, kwin, hardening, jensreuterberg, sebas ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
[Differential] [Accepted] D1800: Load a Wallpaper plugin in kscreenlocker_greet
mart accepted this revision. mart added a reviewer: mart. This revision is now accepted and ready to land. REPOSITORY rKSCREENLOCKER KScreenLocker BRANCH wallpaper-plugin REVISION DETAIL https://phabricator.kde.org/D1800 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: graesslin, #plasma, mart Cc: broulik, plasma-devel, jensreuterberg, sebas ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
[Differential] [Accepted] D1801: [lnf] Make LockScreen.qml an Item instead of an Image
mart accepted this revision. mart added a reviewer: mart. This revision is now accepted and ready to land. REPOSITORY rPLASMAWORKSPACE Plasma Workspace BRANCH lnf-lockscreen-item REVISION DETAIL https://phabricator.kde.org/D1801 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: graesslin, #plasma, mart Cc: plasma-devel, jensreuterberg, sebas ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
[Differential] [Accepted] D819: [shell] Listen for QEvent::PlatformSurface to perform Wayland integration
mart accepted this revision. This revision is now accepted and ready to land. REPOSITORY rPLASMAWORKSPACE Plasma Workspace BRANCH wayland-platform-surface REVISION DETAIL https://phabricator.kde.org/D819 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: graesslin, Plasma, mart Cc: plasma-devel ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
[Differential] [Accepted] D902: [DesktopView] Allow Shift modifier for triggering KRunner
mart accepted this revision. mart added a reviewer: mart. This revision is now accepted and ready to land. REPOSITORY rPLASMAWORKSPACE Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D902 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: broulik, Plasma, mart Cc: plasma-devel ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
[Differential] [Accepted] D899: [notifications] Make the text selectable in the popup too
mart accepted this revision. mart added a reviewer: mart. This revision is now accepted and ready to land. REPOSITORY rPLASMAWORKSPACE Plasma Workspace BRANCH mklapetek/selectableTextInNotifications REVISION DETAIL https://phabricator.kde.org/D899 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: mck182, Plasma, mart Cc: plasma-devel ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
[Differential] [Accepted] D1009: Added indicator of whether there are windows in an activity to the switcher
mart accepted this revision. mart added a comment. This revision is now accepted and ready to land. it will take a lot of thinking on the wayland side ;) but yes, i like it REPOSITORY rPLASMADESKTOP Plasma Desktop BRANCH master REVISION DETAIL https://phabricator.kde.org/D1009 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: ivan, davidedmundson, graesslin, sebas, mart Cc: plasma-devel ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
[Differential] [Accepted] D1037: fix build properly by adding the lib dir to the includes
mart accepted this revision. mart added a reviewer: mart. This revision is now accepted and ready to land. REPOSITORY rPLASMADESKTOP Plasma Desktop BRANCH master REVISION DETAIL https://phabricator.kde.org/D1037 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: sitter, dfaure, mart Cc: plasma-devel ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
[Differential] [Accepted] D1007: [server] Add a signal SeatInterface::focusedPointerChanged
mart accepted this revision. mart added a reviewer: mart. This revision is now accepted and ready to land. REPOSITORY rKWAYLAND KWayland BRANCH server-seat-signal-pointer-changed REVISION DETAIL https://phabricator.kde.org/D1007 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: graesslin, Plasma, sebas, mart Cc: plasma-devel ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
[Differential] [Accepted] D742: Wayland integration: support for server-side decorations
mart accepted this revision. This revision is now accepted and ready to land. INLINE COMMENTS src/platformtheme/kwaylandintegration.cpp:94 since is a long name already, going all the way, waylandserverdecoration ? REPOSITORY rPLASMAINTEGRATION Integration for Qt applications in Plasma BRANCH wayland-server-side-deco REVISION DETAIL https://phabricator.kde.org/D742 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: graesslin, sebas, mart Cc: plasma-devel ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
[Differential] [Accepted] D948: Don't show applet handle outside of desktop
mart accepted this revision. mart added a reviewer: mart. This revision is now accepted and ready to land. REPOSITORY rPLASMADESKTOP Plasma Desktop BRANCH handle-position (branched from master) REVISION DETAIL https://phabricator.kde.org/D948 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: drosca, Plasma, mart Cc: plasma-devel ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
[Differential] [Accepted] D986: Revamp of the activity switcher backend
mart accepted this revision. This revision is now accepted and ready to land. REPOSITORY rPLASMADESKTOP Plasma Desktop BRANCH master REVISION DETAIL https://phabricator.kde.org/D986 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: ivan, davidedmundson, sebas, mart Cc: plasma-devel ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
[Differential] [Request, 109 lines] D987: KSplash looking consistent to sddm and lockscreen
mart created this revision. mart set the repository for this revision to rPLASMAWORKSPACE Plasma Workspace. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. REVISION SUMMARY this makes kspash be in a rectanle that looks just like the one used now in lockscreen and sddm. the weird start animation is removed, but the k+progressbar enter from the right (to complete, sddm could have its content sliding to the left before the actual login, not sure is possible) it also *should* kindof play nice with hig dpi (not tested, a bit trivky since still restricting to pure Qt imports for load times) REPOSITORY rPLASMAWORKSPACE Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D987 AFFECTED FILES lookandfeel/contents/splash/Splash.qml EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: mart Cc: plasma-devel ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
[Differential] [Updated] D987: KSplash looking consistent to sddm and lockscreen
mart added reviewers: davidedmundson, broulik, andreaska. REPOSITORY rPLASMAWORKSPACE Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D987 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: mart, davidedmundson, broulik, andreaska Cc: plasma-devel ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
[Differential] [Commented On] D987: KSplash looking consistent to sddm and lockscreen
mart added a comment. http://youtu.be/68FDY4t0cIE REPOSITORY rPLASMAWORKSPACE Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D987 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: mart, davidedmundson, broulik, andreaska Cc: plasma-devel ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
[Differential] [Updated, 108 lines] D987: KSplash looking consistent to sddm and lockscreen
mart updated this revision to Diff 2394. REPOSITORY rPLASMAWORKSPACE Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D987?vs=2392=2394 REVISION DETAIL https://phabricator.kde.org/D987 AFFECTED FILES lookandfeel/contents/splash/Splash.qml EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: mart, davidedmundson, andreaska, broulik Cc: mck182, plasma-devel ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
[Differential] [Accepted] D1045: Emit PaletteChanged when setting colors from look and feel package
mart accepted this revision. mart added a reviewer: mart. This revision is now accepted and ready to land. REPOSITORY rPLASMADESKTOP Plasma Desktop BRANCH kcm-laf (branched from master) REVISION DETAIL https://phabricator.kde.org/D1045 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: drosca, Plasma, mart Cc: graesslin, plasma-devel ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
[Differential] [Accepted] D1152: [client] Perform ConnectionThread::roundtrip through QPA interface
mart accepted this revision. mart added a reviewer: mart. This revision is now accepted and ready to land. REPOSITORY rKWAYLAND KWayland BRANCH roundtrip-qpa-5.6 REVISION DETAIL https://phabricator.kde.org/D1152 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: graesslin, Plasma, mart Cc: plasma-devel ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
[Differential] [Accepted] D1153: [plugins/qpa] Add a roundtrip platform function
mart accepted this revision. mart added a reviewer: mart. This revision is now accepted and ready to land. REPOSITORY rKWIN KWin BRANCH qpa-roundtrip-5.6 REVISION DETAIL https://phabricator.kde.org/D1153 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: graesslin, Plasma, mart Cc: plasma-devel ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
[Differential] [Accepted] D1143: do not install development helper files via cmake
mart accepted this revision. mart added a reviewer: mart. REPOSITORY rBREEZEGTK Breeze for Gtk BRANCH master REVISION DETAIL https://phabricator.kde.org/D1143 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: sitter, graesslin, mart Cc: plasma-devel ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
[Differential] [Accepted] D1090: [krunner] Make it work on Wayland
mart accepted this revision. mart added a reviewer: mart. This revision is now accepted and ready to land. REPOSITORY rPLASMAWORKSPACE Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D1090 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: graesslin, Plasma, mart Cc: plasma-devel, Plasma ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
[Differential] [Accepted] D1120: LayoutManager: Restore rotation on remove applet undo
mart accepted this revision. mart added a reviewer: mart. This revision is now accepted and ready to land. REPOSITORY rPLASMADESKTOP Plasma Desktop BRANCH undo-rotation (branched from Plasma/5.6) REVISION DETAIL https://phabricator.kde.org/D1120 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: drosca, Plasma, mart Cc: plasma-devel ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
[Differential] [Accepted] D1128: Trigger a roundtrip after creating the ServerSideDecoration
mart accepted this revision. mart added a reviewer: mart. This revision is now accepted and ready to land. REPOSITORY rPLASMAINTEGRATION Integration for Qt applications in Plasma BRANCH kwayland-roundtrip-server REVISION DETAIL https://phabricator.kde.org/D1128 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: graesslin, Plasma, mart Cc: plasma-devel ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
[Differential] [Commented On] D1134: Alternatives: Add new applet only after the old one was removed
mart added a comment. good that makes it look more uniform. tough at some point there was the idea of the possibility of running a script between the addition of the new one and the destruction of the old one, making possible for a script to try to convert some of the config between the two. that was probaably not an awesome idea as it has a lot of obvious problems, so in general the patch is good for me, just to consider the possibility REPOSITORY rPLASMAWORKSPACE Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D1134 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: drosca, Plasma Cc: mart, plasma-devel ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
[Differential] [Accepted] D1171: simple cleanup in geometryByDistance
mart accepted this revision. mart added a reviewer: mart. REPOSITORY rPLASMAWORKSPACE Plasma Workspace BRANCH master REVISION DETAIL https://phabricator.kde.org/D1171 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: davidedmundson, Plasma, apol, mart Cc: apol, plasma-devel ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
[Differential] [Accepted] D1161: PanelView length cleanup
mart accepted this revision. mart added a reviewer: mart. This revision is now accepted and ready to land. REPOSITORY rPLASMAWORKSPACE Plasma Workspace BRANCH REVISION DETAIL https://phabricator.kde.org/D1161 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: davidedmundson, Plasma, mart Cc: mart, plasma-devel ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
[Differential] [Accepted] D1271: Use a QTabWidget for the different modes in DebugConsole
mart accepted this revision. mart added a reviewer: mart. mart added a comment. This revision is now accepted and ready to land. yes :D REPOSITORY rKWIN KWin BRANCH debug-console-tab-widget REVISION DETAIL https://phabricator.kde.org/D1271 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: graesslin, Plasma, mart Cc: mart, plasma-devel, sebas ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
[Differential] [Accepted] D1390: systemtray: Disable tooltip when applet is expanded
mart accepted this revision. mart added a reviewer: mart. This revision is now accepted and ready to land. REPOSITORY rPLASMAWORKSPACE Plasma Workspace BRANCH systray-currentpopup REVISION DETAIL https://phabricator.kde.org/D1390 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: drosca, Plasma, mart Cc: plasma-devel, sebas ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
[Differential] [Accepted] D1391: systemtray: Align menu to item's topleft corner
mart accepted this revision. mart added a reviewer: mart. This revision is now accepted and ready to land. REPOSITORY rPLASMAWORKSPACE Plasma Workspace BRANCH systray-menupos REVISION DETAIL https://phabricator.kde.org/D1391 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: drosca, Plasma, mart Cc: plasma-devel, sebas ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
[Differential] [Accepted] D1338: Fix null values in currency conversion
mart accepted this revision. mart added a reviewer: mart. This revision is now accepted and ready to land. REPOSITORY rKDEPLASMAADDONS Plasma Addons BRANCH master REVISION DETAIL https://phabricator.kde.org/D1338 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: davidedmundson, Plasma, mart Cc: plasma-devel, sebas ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
[Differential] [Commented On] D1340: Rename AbstractBackend to Platform
mart added a comment. the new name sounds better, but.. didn't you want to keep kwayland binary compatible? REPOSITORY rKWIN KWin REVISION DETAIL https://phabricator.kde.org/D1340 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: graesslin, Plasma Cc: mart, plasma-devel, sebas ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
[Differential] [Accepted] D1162: Panel cleanup
mart accepted this revision. mart added a reviewer: mart. This revision is now accepted and ready to land. INLINE COMMENTS desktoppackage/contents/views/Panel.qml:120 what happens if the sequece of events happens: 1) preferredWidth changes, tries to update the length, but it can't because minimum/maximum don't allow 2) minimum/maximum change, but preferredWidth doesn't 3) does the panel size get updated correctly? (this i guess answers my question on review D1161) REPOSITORY rPLASMADESKTOP Plasma Desktop BRANCH master REVISION DETAIL https://phabricator.kde.org/D1162 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: davidedmundson, Plasma, mart Cc: mart, plasma-devel ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
[Differential] [Request, 67 lines] D1170: Api to rename activities in desktop scripting
mart created this revision. mart set the repository for this revision to rPLASMADESKTOP Plasma Desktop. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. REVISION SUMMARY the api containment.name was incorrect and broken, (using it it actually breaks the whole layout since breaks the containment->activity association) in order to make it coherent with the other activity related api, add global functions activityName and setActivityName it's not very object oriented but is coherent with the other api already in place (as there isn't an "Activity" class binding) REPOSITORY rPLASMADESKTOP Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D1170 AFFECTED FILES shell/scripting/containment.cpp shell/scripting/containment.h shell/scripting/panel.h shell/scripting/scriptengine.cpp shell/scripting/scriptengine.h EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: mart Cc: plasma-devel ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
