Re: rpm/macros.java

2006-05-22 Thread Elan Ruusamäe
i believe the macros should be just moved to rpm-build-macros
and the macros.java be added to main rpm(-build) package, because you can't 
fetch specs (with builder) if some %include is missing.

On Monday 22 May 2006 02:09, Jakub Bogusz wrote:
 IMO more changes are required in this file.

  %define _jvmdir %{_prefix}/lib/jvm

 Why not %{_libdir}/jvm (or %{_prefix}/%{_lib}/jvm)?
 (and similarly all other %{_prefix}/lib/j*)

 All icons and menu stuff can be dropped.
 We don't need to make specs portable to RH/Mdk.

  %define _desktopdir%{_datadir}/applications

 Duplicate.

-- 
glen
___
pld-devel-en mailing list
pld-devel-en@lists.pld-linux.org
http://lists.pld-linux.org/mailman/listinfo/pld-devel-en


Re: SPECS: apache1.spec - updated to 1.3.36; acc. to announcement incl...

2006-05-22 Thread Elan Ruusamäe
On Monday 22 May 2006 14:31, qboosh wrote:
 Author: qboosh   Date: Mon May 22 11:31:59 2006 GMT
 Module: SPECS Tag: HEAD
  Log message:
 - updated to 1.3.36; acc. to announcement include wildcards have been fixed
oh. thank god don't have to merge the old patch ;))

-- 
glen
___
pld-devel-en mailing list
pld-devel-en@lists.pld-linux.org
http://lists.pld-linux.org/mailman/listinfo/pld-devel-en


Re: rpm/macros.java

2006-05-22 Thread Jacek Konieczny
On Mon, May 22, 2006 at 01:09:27AM +0200, Jakub Bogusz wrote:
 IMO more changes are required in this file.
 
  %define _jvmdir %{_prefix}/lib/jvm
 
 Why not %{_libdir}/jvm (or %{_prefix}/%{_lib}/jvm)?
 (and similarly all other %{_prefix}/lib/j*)

Yes, that could be changed -- that was copied verbatim from jpackage.
But that will break jpackage compatibility on archs with %{_lib}!=lib64.
Jpackage contains a lot of Java packages so it can be considered a
problem.

 All icons and menu stuff can be dropped.
 We don't need to make specs portable to RH/Mdk.

Ok.

  %define _desktopdir%{_datadir}/applications
 
 Duplicate.

Right.

Greets,
Jacek
___
pld-devel-en mailing list
pld-devel-en@lists.pld-linux.org
http://lists.pld-linux.org/mailman/listinfo/pld-devel-en


Re: builder bug: fetching patch from URL when it's already in CVS

2006-05-22 Thread Elan Ruusamäe
On Tuesday 04 April 2006 16:27, Jakub Bogusz wrote:
 $ ./builder -bp -r LINUX_2_6 kernel.spec
 [...]
 --15:21:35--  http://bluetooth-alsa.sourceforge.net/sco-mtu.patch
= `sco-mtu.patch'
 [...]
 cvs server: move away sco-mtu.patch; it is in the way
 C sco-mtu.patch
the offending change is:
http://cvs.pld-linux.org/cgi-bin/cvsweb.cgi/SPECS/builder.diff?r1=1.376;r2=1.377;f=h

 builder shouldn't fetch anything from URLs given in SourceX/PatchX if
 it's present in CVS/distfiles and fetching from CVS/df is not disabled
 by command line option. And it didn't... till some day.
 It seems to be some bug introduced quite recently.

-- 
glen
___
pld-devel-en mailing list
pld-devel-en@lists.pld-linux.org
http://lists.pld-linux.org/mailman/listinfo/pld-devel-en


Re: builder bug: fetching patch from URL when it's already in CVS

2006-05-22 Thread Elan Ruusamäe
On Tuesday 04 April 2006 17:20, Elan Ruusamäe wrote:
 i noticed the bug too, and i wasn't sure is it worth to fix, as if the
 source patch and patch in cvs are identical, there's no such warning
 issued. so in most cases just update the patch in SOURCES?
i was wrong here. the bug is not reproducible if you had the file in SOURCES 
before the fetch.

ie to overcome the problem 
- cd ../SOURCES
- rm offending_file
- cvs up offending_file
- cd - 
- !builder

-- 
glen
___
pld-devel-en mailing list
pld-devel-en@lists.pld-linux.org
http://lists.pld-linux.org/mailman/listinfo/pld-devel-en