Re: [Plplot-devel] example 19 failure
On Tue, Sep 15, 2009 at 11:47:53AM -0700, Alan Irwin wrote:
> Hi Werner:
>
> This is mostly directed to you, but there is also a quick question for Andrew
> about the java bindings in my comments below.
>
> On 2009-09-15 15:34+0200 Werner Smekal wrote:
>
>> Hi Alan,
>>
>> I added these redefinition macros to plcdemos.h and plc++demos.h. But
>> since we already use such a macro for isnan(), where PL__HAVE_ISNAN is
>> defined in plConfig.h, I decided to do the same as well for _snprintf.
>> So I copied the relevant part form config.h.cmake to plConfig.h.cmake
>> and all works again for Visual C++.
>
> I far prefer your idea (using configured macros for PL_HAVE_SNPRINTF and
> _PL_HAVE_SNPRINTF in plConfig.h) to mine (configuring those same macros in
> plcdemos.h and plc++demos.h). I had forgotten that plConfig.h was already
> #included by plcdemos.h and plc++demos.h. Anyhow, like what you have done
> subject to the duplicate macros issue (see below).
>
> N.B. I hope you or somebody else will follow up and replace sprintf by
> snprintf throughout the C and C++ examples (to demonstrate our good practice
> for those examples and to inspire users to use snprintf as well for their
> own PLplot applications).
>
>> Actually, why do we have config.h and plConfig.h, where the latter
>> seems to be a subset of the first?
>
> Before answering that important question I would like to give some
> background for those here who are not aware of it.
>
> The purpose of config.h is to contain all the configured macro dreck that is
> required in the core build but which we don't want to expose for example
> builds and user application builds. The purpose of plConfig.h is to contain
> the minimal set of configured macros that you do need to expose for example
> builds and user application builds. The way the build system implements this
> separation between the two sets of configured macros in config.h and
> plConfig.h is via HAVE_CONFIG_H. That is just #defined (see
>
> ADD_DEFINITIONS("-DHAVE_CONFIG_H")
>
> in the top-level CMakeLists.txt file) for the core build of PLplot, but
> not for the build of the examples (see
>
> remove_definitions("-DHAVE_CONFIG_H")
>
> in examples/CMakeLists.txt (as of revision 10413).
>
> As of revision 10412 I have documented the different purposes of
> config.h.cmake and plConfig.h.cmake in those files, and because there is
> obviously no need of duplicate macros (in answer to your question) I have
> removed all such duplicates from config.h.cmake.
>
> Revision 10413 gives me good results for a (rather) complete core build
> (including build-tree examples) and separate installed examples build, but
> others should test that revision 10413 as well to make sure that change to
> no duplication between config.h and plConfig.h introduces no build errors
> for their particular configuration/platform.
>
> FOR Andrew: There is one other place in our build system
> 'remove_definitions("-DHAVE_CONFIG_H")' occurs and that is in
> bindings/java/CMakeLIsts.txt. I don't know the purpose of that or even
> whether it is necessary. Andrew, do you remember? Anyhow, for now I am
> leaving it because it appears to work okay for the test mentioned above.
Firstly, sorry for the silence over the last few weeks. I have been away
with work. I hoped to have email access but it didn't work out.
I don't recall. I think it was copied from somewhere else. It is possible
that config.h interferes with some of the C swig generated files, but it
seems unlikely.
Andrew
--
Come build with us! The BlackBerry® Developer Conference in SF, CA
is the only developer event you need to attend this year. Jumpstart your
developing skills, take BlackBerry mobile applications to market and stay
ahead of the curve. Join us from November 9-12, 2009. Register now!
http://p.sf.net/sfu/devconf
___
Plplot-devel mailing list
Plplot-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/plplot-devel
Re: [Plplot-devel] example 19 failure
On 2009-09-16 09:22+0100 Andrew Ross wrote:
>> There is one other place in our build system
>> 'remove_definitions("-DHAVE_CONFIG_H")' occurs and that is in
>> bindings/java/CMakeLIsts.txt. I don't know the purpose of that or even
>> whether it is necessary. Andrew, do you remember?
> I don't recall. I think it was copied from somewhere else. It is possible
> that config.h interferes with some of the C swig generated files, but it
> seems unlikely.
Hi Andrew:
It was good to hear from you again after your trip.
That question was generated by a grep for remove_definitions in all files of
our build tree. I actually didn't take a look at the file itself until now.
It has some commentary about why that remove_definitions is needed.
# Java compiler doesn't support -D option.
remove_definitions("-DHAVE_CONFIG_H")
That appears to be a pretty straightforward explanation, but I noticed this
remove_definitions appears at the end of the file where it probably did not
have any effect at all. So I tried dropping it, and on my gcj/gij platform
there were no issues. Anyhow, I have experimentally committed that change
(revision 10417), but if it causes problems for any java platform we should
reinstate the above again (at the top of the file so it is obvious to humans
it has an effect).
Alan
__
Alan W. Irwin
Astronomical research affiliation with Department of Physics and Astronomy,
University of Victoria (astrowww.phys.uvic.ca).
Programming affiliations with the FreeEOS equation-of-state implementation
for stellar interiors (freeeos.sf.net); PLplot scientific plotting software
package (plplot.org); the libLASi project (unifont.org/lasi); the Loads of
Linux Links project (loll.sf.net); and the Linux Brochure Project
(lbproject.sf.net).
__
Linux-powered Science
__
--
Come build with us! The BlackBerry® Developer Conference in SF, CA
is the only developer event you need to attend this year. Jumpstart your
developing skills, take BlackBerry mobile applications to market and stay
ahead of the curve. Join us from November 9-12, 2009. Register now!
http://p.sf.net/sfu/devconf
___
Plplot-devel mailing list
Plplot-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/plplot-devel
Re: [Plplot-devel] Please delay next release
Alan W. Irwin wrote: > Hi Hazen: > > I have a number of PLplot projects I am actively working on at this time. > Those include > > * Improving the ocaml build. > > * Finishing up the new testing framework. > > * Bug fixing (such as the -bg bug that was just demonstrated). > > Once the above three are taken care of I also plan to restart work on > adding > functionality to libqsastime, extend example 29 to show off that new > functionality, etc. This is long overdue, and I am determined to get it in > this next release if at all possible. > > Finally, as discussed previously I intend to organize a testing group to > help > improve the quality of the next release, but that testing will add > essentially an extra week to the release cycle as well as consume quite a > bit of my time. > > So a release near the beginning of October like we discussed before would > not fit my needs at all, and I wouldn't mind a bit if you put off the > release for at least a month and maybe more depending on how quickly I can > get through all the above projects. Ok. Do you think there will be enough changes to warrant another development release before the stable release? -Hazen -- Come build with us! The BlackBerry® Developer Conference in SF, CA is the only developer event you need to attend this year. Jumpstart your developing skills, take BlackBerry mobile applications to market and stay ahead of the curve. Join us from November 9-12, 2009. Register now! http://p.sf.net/sfu/devconf ___ Plplot-devel mailing list Plplot-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/plplot-devel
Re: [Plplot-devel] Please delay next release
On 2009-09-16 12:06-0400 Hazen Babcock wrote: > Alan W. Irwin wrote: >> Hi Hazen: >> >> I have a number of PLplot projects I am actively working on at this time. >> Those include >> >> * Improving the ocaml build. >> >> * Finishing up the new testing framework. >> >> * Bug fixing (such as the -bg bug that was just demonstrated). >> >> Once the above three are taken care of I also plan to restart work on >> adding >> functionality to libqsastime, extend example 29 to show off that new >> functionality, etc. This is long overdue, and I am determined to get it in >> this next release if at all possible. >> >> Finally, as discussed previously I intend to organize a testing group to >> help >> improve the quality of the next release, but that testing will add >> essentially an extra week to the release cycle as well as consume quite a >> bit of my time. >> >> So a release near the beginning of October like we discussed before would >> not fit my needs at all, and I wouldn't mind a bit if you put off the >> release for at least a month and maybe more depending on how quickly I can >> get through all the above projects. > > Ok. Thanks for that delay. > Do you think there will be enough changes to warrant another development > release before the stable release? Probably, but let's see how it goes. Alan __ Alan W. Irwin Astronomical research affiliation with Department of Physics and Astronomy, University of Victoria (astrowww.phys.uvic.ca). Programming affiliations with the FreeEOS equation-of-state implementation for stellar interiors (freeeos.sf.net); PLplot scientific plotting software package (plplot.org); the libLASi project (unifont.org/lasi); the Loads of Linux Links project (loll.sf.net); and the Linux Brochure Project (lbproject.sf.net). __ Linux-powered Science __ -- Come build with us! The BlackBerry® Developer Conference in SF, CA is the only developer event you need to attend this year. Jumpstart your developing skills, take BlackBerry mobile applications to market and stay ahead of the curve. Join us from November 9-12, 2009. Register now! http://p.sf.net/sfu/devconf ___ Plplot-devel mailing list Plplot-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/plplot-devel
Re: [Plplot-devel] Setting background colour breaks colour map introduced by r10354
On 2009-09-15 12:34-0700 Alan W. Irwin wrote: > Thanks [Mark] for spotting this [-bg] issue which I confirm in latest svn > trunk. The > revision you mentioned is in my pre-release flurry of commits to plctrl.c to > fix up issues with setting up default colour palettes exclusively from > files. > > I don't have time to investigate this bug at the moment, but I will take > responsibility for fixing it (say, in the next two weeks) unless somebody > else beats me to it. The problem was that the plcmap0_def logic called indirectly by plscmap0n(0) read in the colours from the default palette file okay but then didn't actually set cmap0 with those colours! Details, details :-) FIXED as of revision 10418. Prior to that revision, the result was cmap0 was zeroed (black, transparent colours). For older devices like xwin which are not transparency aware, the result was opaque black lines. For modern devices like xcairo the result was transparent black lines (which of course you could not see). We don't actually call plscmap0n(0) anymore from the chain of routines invoked by plinit. Instead, if cmap0 has not been initialized yet we simply call plspal0 directly for the default palette file which bypasses the logic problems of plcmap0_def. Thus, this bug was not seen by any of our testing, and it took Mark's use of the -bg option to show the bug. If any user complains about colour issues with 5.9.5, it is probably this issue so the first advice should be to try the svn trunk revision 10418 or higher. Alan __ Alan W. Irwin Astronomical research affiliation with Department of Physics and Astronomy, University of Victoria (astrowww.phys.uvic.ca). Programming affiliations with the FreeEOS equation-of-state implementation for stellar interiors (freeeos.sf.net); PLplot scientific plotting software package (plplot.org); the libLASi project (unifont.org/lasi); the Loads of Linux Links project (loll.sf.net); and the Linux Brochure Project (lbproject.sf.net). __ Linux-powered Science __ -- Come build with us! The BlackBerry® Developer Conference in SF, CA is the only developer event you need to attend this year. Jumpstart your developing skills, take BlackBerry mobile applications to market and stay ahead of the curve. Join us from November 9-12, 2009. Register now! http://p.sf.net/sfu/devconf ___ Plplot-devel mailing list Plplot-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/plplot-devel
