Re: [SlimDevices: Plugins] FTS: No results for "spanish e" but for "spanish ey"

2018-09-18 Thread dolodobendan


DJanGo wrote: 
> Ahh ;-)
> 
> on 7.9.2 - 1537254228 @ Tue Sep 18 09:16:24 CEST 2018 deb64 "spanish e"
> shows Spanish Eyes ;-)
> Well done Michael:o

I can confirm this, too. Well done, indeed!



QLMS 7.9.2@1.09e (digimaster) / QNAP 469L QTS 4.3.4

dolodobendan's Profile: http://forums.slimdevices.com/member.php?userid=67663
View this thread: http://forums.slimdevices.com/showthread.php?t=109476

___
plugins mailing list
plugins@lists.slimdevices.com
http://lists.slimdevices.com/mailman/listinfo/plugins


Re: [SlimDevices: Plugins] FTS: No results for "spanish e" but for "spanish ey"

2018-09-18 Thread dolodobendan


mherger wrote: 
> And when I saw the title without the screenshots I was wondering what 
> the "spanish ey" character was :-).
> 

:D

mherger wrote: 
> 
> We do indeed optimize the single character case out. Most likely there 
> were performance due to too many results. But then I wonder why this 
> would happen when there is another token. You'd think that would be less
> 
> result than a single token only. Hmm...
> 

That's what got me wondering.

mherger wrote: 
> 
> I tweaked the behaviour earlier today.
> Michael

That was scary fast. Thank you!



QLMS 7.9.2@1.09e (digimaster) / QNAP 469L QTS 4.3.4

dolodobendan's Profile: http://forums.slimdevices.com/member.php?userid=67663
View this thread: http://forums.slimdevices.com/showthread.php?t=109476

___
plugins mailing list
plugins@lists.slimdevices.com
http://lists.slimdevices.com/mailman/listinfo/plugins


Re: [SlimDevices: Plugins] FTS: No results for "spanish e" but for "spanish ey"

2018-09-18 Thread DJanGo


mherger wrote: 
> What build? I tweaked the behaviour earlier today.
> 
> -- 
> 
> Michael

Ahh ;-)

on 7.9.2 - 1537254228 @ Tue Sep 18 09:16:24 CEST 2018 deb64 "spanish e"
shows Spanish Eyes ;-)
Well done Michael:o



DJanGo's Profile: http://forums.slimdevices.com/member.php?userid=1516
View this thread: http://forums.slimdevices.com/showthread.php?t=109476

___
plugins mailing list
plugins@lists.slimdevices.com
http://lists.slimdevices.com/mailman/listinfo/plugins


Re: [SlimDevices: Plugins] FTS: No results for "spanish e" but for "spanish ey"

2018-09-18 Thread Michael Herger

but there is a difference
searching for "spanish G" founds all my spanish guitars.
searching for "spanish v" shows spanish fly from Van Halen.


What build? I tweaked the behaviour earlier today.

--

Michael
___
plugins mailing list
plugins@lists.slimdevices.com
http://lists.slimdevices.com/mailman/listinfo/plugins


Re: [SlimDevices: Plugins] FTS: No results for "spanish e" but for "spanish ey"

2018-09-17 Thread DJanGo


mherger wrote: 
> https://github.com/Logitech/slimserver/blob/public/7.9/Slim/Plugin/FullTextSearch/Plugin.pm#L256
> 
> We do indeed optimize the single character case out.

hmm
but there is a difference 
searching for "spanish G" founds all my spanish guitars.
searching for "spanish v" shows spanish fly from Van Halen.



DJanGo's Profile: http://forums.slimdevices.com/member.php?userid=1516
View this thread: http://forums.slimdevices.com/showthread.php?t=109476

___
plugins mailing list
plugins@lists.slimdevices.com
http://lists.slimdevices.com/mailman/listinfo/plugins


Re: [SlimDevices: Plugins] FTS: No results for "spanish e" but for "spanish ey"

2018-09-17 Thread Michael Herger

https://github.com/Logitech/slimserver/blob/public/7.9/Slim/Plugin/FullTextSearch/Plugin.pm#L256

We do indeed optimize the single character case out. Most likely there 
were performance due to too many results. But then I wonder why this 
would happen when there is another token. You'd think that would be less 
result than a single token only. Hmm...

--

Michael
___
plugins mailing list
plugins@lists.slimdevices.com
http://lists.slimdevices.com/mailman/listinfo/plugins


Re: [SlimDevices: Plugins] FTS: No results for "spanish e" but for "spanish ey"

2018-09-17 Thread Michael Herger

What the title says and the pictures show:


And when I saw the title without the screenshots I was wondering what 
the "spanish ey" character was :-).



Is this the intended behavior (because e is too short?)


Don't know, really. I do indeed see in server.log that it would do the 
following (set plugin.fulltext to debug):


Search token (track): 'TONY* AND LE*'
Search token (track): 'TONY* AND L'

Must be some optimization gone wrong.

--

Michael
___
plugins mailing list
plugins@lists.slimdevices.com
http://lists.slimdevices.com/mailman/listinfo/plugins


[SlimDevices: Plugins] FTS: No results for "spanish e" but for "spanish ey"

2018-09-17 Thread dolodobendan


What the title says and the pictures show:

25657

25658

Is this the intended behavior (because e is too short?) I would expect
results to become less, not more, when tightening the search parameters.
(Just wondering, not complaining. :p )


+---+
|Filename: lms_ey2.png  |
|Download: http://forums.slimdevices.com/attachment.php?attachmentid=25658|
+---+


QLMS 7.9.2@1.09e (digimaster) / QNAP 469L QTS 4.3.4

dolodobendan's Profile: http://forums.slimdevices.com/member.php?userid=67663
View this thread: http://forums.slimdevices.com/showthread.php?t=109476

___
plugins mailing list
plugins@lists.slimdevices.com
http://lists.slimdevices.com/mailman/listinfo/plugins