[jira] [Closed] (PLUTO-728) TCK: Contesting usage of PortletSession attributes in V3HeaderPortletTests
[
https://issues.apache.org/jira/browse/PLUTO-728?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Neil Griffin closed PLUTO-728.
--
Resolution: Fixed
> TCK: Contesting usage of PortletSession attributes in V3HeaderPortletTests
> --
>
> Key: PLUTO-728
> URL: https://issues.apache.org/jira/browse/PLUTO-728
> Project: Pluto
> Issue Type: Bug
> Components: tck
>Affects Versions: 3.0.0, 3.0.1
>Reporter: Neil Griffin
>Assignee: Neil Griffin
>Priority: Major
> Fix For: 3.0.2-TCK
>
>
> This issue contests the usage of {{PortletSession}} attributes in
> V3HeaderPortletTests.
> The results of V3HeaderPortletTests executed in the {{HEADER_PHASE}} are
> stored in the {{PortletSession}} so that they can be written to the response
> in the subsequent {{RENDER_PHASE}}.
> However, after PLUTO-727 was fixed, most of the V3HeaderPortletTests failed.
> This is because test case
> [V3HeaderPortletTests_SPEC14_PortletRequest_ApiHeader_isRequestedSessionIdValid2
> calls
> PortletSession.invalidate()|https://github.com/apache/portals-pluto/blob/pluto-3.0.1/portlet-tck_3.0/V3HeaderPortletTests/src/main/java/javax/portlet/tck/portlets/HeaderPortletTests_SPEC14_PortletRequest_ApiHeader1.java#L559]
> which in turn causes all of the {{PortletSession}} attributes to be cleared.
> The proposed fix is to store the results of V3HeaderPortletTests executed in
> the {{HEADER_PHASE}} as {{HeaderRequest}} attributes, rather than
> {{PortletSession}} attributes. This will provide a more natural way for such
> information to survive from the {{HEADER_PHASE}} into the {{RENDER_PHASE}}
> since {{HeaderRequest}} attributes are preserved as {{RenderRequest}}
> attributes.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Closed] (PLUTO-728) TCK: Contesting usage of PortletSession attributes in V3HeaderPortletTests
[
https://issues.apache.org/jira/browse/PLUTO-728?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Neil Griffin closed PLUTO-728.
--
Resolution: Fixed
Fixed in commit
[1ba39987873c3ba7eb6f0c42f155d882d8f87ac5|https://github.com/apache/portals-pluto/commit/1ba39987873c3ba7eb6f0c42f155d882d8f87ac5]
> TCK: Contesting usage of PortletSession attributes in V3HeaderPortletTests
> --
>
> Key: PLUTO-728
> URL: https://issues.apache.org/jira/browse/PLUTO-728
> Project: Pluto
> Issue Type: Bug
> Components: tck
>Affects Versions: 3.0.0, 3.0.1
>Reporter: Neil Griffin
>Assignee: Neil Griffin
>Priority: Major
> Fix For: 3.0.2
>
>
> This issue contests the usage of {{PortletSession}} attributes in
> V3HeaderPortletTests.
> The results of V3HeaderPortletTests executed in the {{HEADER_PHASE}} are
> stored in the {{PortletSession}} so that they can be written to the response
> in the subsequent {{RENDER_PHASE}}.
> However, after PLUTO-727 was fixed, most of the V3HeaderPortletTests failed.
> This is because test case
> [V3HeaderPortletTests_SPEC14_PortletRequest_ApiHeader_isRequestedSessionIdValid2
> calls
> PortletSession.invalidate()|https://github.com/apache/portals-pluto/blob/pluto-3.0.1/portlet-tck_3.0/V3HeaderPortletTests/src/main/java/javax/portlet/tck/portlets/HeaderPortletTests_SPEC14_PortletRequest_ApiHeader1.java#L559]
> which in turn causes all of the {{PortletSession}} attributes to be cleared.
> The proposed fix is to store the results of V3HeaderPortletTests executed in
> the {{HEADER_PHASE}} as {{HeaderRequest}} attributes, rather than
> {{PortletSession}} attributes. This will provide a more natural way for such
> information to survive from the {{HEADER_PHASE}} into the {{RENDER_PHASE}}
> since {{HeaderRequest}} attributes are preserved as {{RenderRequest}}
> attributes.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
