Re: [pmacct-discussion] print plugin and src_as_path
Hi Paolo, thanks for taking care of this! Regards, Mario > -Original Message- > From: pmacct-discussion [mailto:pmacct-discussion-boun...@pmacct.net] > On Behalf Of Paolo Lucente > Sent: Mittwoch, 26. Februar 2014 18:49 > To: pmacct-discussion@pmacct.net > Subject: Re: [pmacct-discussion] print plugin and src_as_path > > Hi Mario, All, > > A quick note to say this has now been implemented: > > http://www.mail-archive.com/pmacct-commits@pmacct.net/msg01006.html > > Cheers, > Paolo > > ___ > pmacct-discussion mailing list > http://www.pmacct.net/#mailinglists ___ pmacct-discussion mailing list http://www.pmacct.net/#mailinglists
Re: [pmacct-discussion] print plugin and src_as_path
Hi Mario, All, A quick note to say this has now been implemented: http://www.mail-archive.com/pmacct-commits@pmacct.net/msg01006.html Cheers, Paolo On Thu, Feb 20, 2014 at 04:27:31PM +, Paolo Lucente wrote: > Hi Mario, > > Thanks for bringing this up, as you are scratching on a limbo > situation which is good to iron out. My take on src_as_path, > src_local_pref, src_std_comms, etc. is that they are all evil > since are based on reverse BGP lookups. Hence i've removed > mentions from official docs and stopped implementing it on > newer plugin (in summary: it is implemented in memory and all > SQL plugins; it is not in print, MongoDB and AMQP plugins). > > Nevertheless people catch these primitives are there in a way > or in another and seems they are popular (at least src_as_path > is). I reckon the best approach should be: implement them and > put a disclaimer: use at your own risk/if you know what you are > doing - which was perhaps the missing statement when, back in > 2009, during the initial general excitement for implementation > of these primitives i got bombed of ".. yes, but i know for a > fact those flows did not get in through that transit provider". > Putting this item on my todo list. > > Cheers, > Paolo > > On Thu, Feb 20, 2014 at 03:21:35PM +, Jentsch, Mario wrote: > > Hi, > > > > the print plugin doesn't output src_as_path (tested with 1.5.0rc2). > > I verified a similar setup with the memory plugin successfully and checked > > the source code, src/print_plugin.c misses src_as_path. Duplicating the > > lines for as_path and updating them to reflect src_as_path worked for me. > > > > Regards, > > Mario > > > ___ > > pmacct-discussion mailing list > > http://www.pmacct.net/#mailinglists > > > ___ > pmacct-discussion mailing list > http://www.pmacct.net/#mailinglists ___ pmacct-discussion mailing list http://www.pmacct.net/#mailinglists
Re: [pmacct-discussion] print plugin and src_as_path
Hi Mario, Thanks for bringing this up, as you are scratching on a limbo situation which is good to iron out. My take on src_as_path, src_local_pref, src_std_comms, etc. is that they are all evil since are based on reverse BGP lookups. Hence i've removed mentions from official docs and stopped implementing it on newer plugin (in summary: it is implemented in memory and all SQL plugins; it is not in print, MongoDB and AMQP plugins). Nevertheless people catch these primitives are there in a way or in another and seems they are popular (at least src_as_path is). I reckon the best approach should be: implement them and put a disclaimer: use at your own risk/if you know what you are doing - which was perhaps the missing statement when, back in 2009, during the initial general excitement for implementation of these primitives i got bombed of ".. yes, but i know for a fact those flows did not get in through that transit provider". Putting this item on my todo list. Cheers, Paolo On Thu, Feb 20, 2014 at 03:21:35PM +, Jentsch, Mario wrote: > Hi, > > the print plugin doesn't output src_as_path (tested with 1.5.0rc2). > I verified a similar setup with the memory plugin successfully and checked > the source code, src/print_plugin.c misses src_as_path. Duplicating the lines > for as_path and updating them to reflect src_as_path worked for me. > > Regards, > Mario > ___ > pmacct-discussion mailing list > http://www.pmacct.net/#mailinglists ___ pmacct-discussion mailing list http://www.pmacct.net/#mailinglists
