Re: [Podofo-users] CCITT encoding filter
On Tue, 2015-11-03 at 11:02 +, Nick Penny wrote: > I had a need to use a CCITT encoding filter as part of some work I > was doing using PoDoFo. So I found the DS_CCITT_DEVELOPMENT_CODE > area and modified that. > > How do you want me to provide this code and suitable documentation > back to the project? Hi, ideally checkout the sources using svn: $ svn checkout https://svn.code.sf.net/p/podofo/code/podofo/trunk podofo apply your changes to it, compile and verify it still works (some trunk changes might cause trouble), then generate a patch using svn: $ svn diff>podofo.patch then send the patch to this list as an attachment. Thanks and bye, zyx -- http://www.litePDF.cz i...@litepdf.cz -- ___ Podofo-users mailing list Podofo-users@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/podofo-users
[Podofo-users] typo fixes and clarification for FAQ list
Hi all, I have attached a patch as per the subject to this e-mail. Please review it and if accepted, please apply it (separately) to the public repository, otherwise please tell me why not. Best regards, mabriIndex: FAQ.html === --- FAQ.html (revision 1686) +++ FAQ.html (working copy) @@ -38,7 +38,7 @@ What platforms are supported by PoDoFo? Can I use PoDoFo in my commercial application? What language is PoDoFo written in? - Does PoDoFo offer a stable API or ABI + Does PoDoFo offer a stable API or ABI? Does PoDoFo have a mailing list? My question isn't answered here. Where do I go next?" @@ -55,7 +55,7 @@ and produces a traceback including a call to std::terminate(). Why? Why does my program crash with a SIGABRT (Signal #6) in a call to PoDoFo? - PoDoFo creates invalid PDF files because , is used in floats instead of .? + PoDoFo creates invalid PDF files because , is used in floats instead of .Why? @@ -64,7 +64,7 @@ What platforms are supported by PoDoFo? PoDoFo has been tested on Linux, Mac OS X and - Windows. It is developed in a way platform independent way so that + Windows. It is developed in a platform-independent way so that porting to any other system should be no problem. Can I use PoDoFo in my commercial application? @@ -71,12 +71,12 @@ Yes, though you must follow the terms of the LGPL license for PoDoFo. The license permits you to use PoDoFo in any - commercial application, though the LGTL obliges you to provide - source to PoDoFo its self and any changes you made to it under + commercial application, though the LGPL obliges you to provide + source to PoDoFo itself and any changes you made to it under the LGPL. That means that you may link code to PoDoFo that is - not GPL or LGPL licensed so long as you follow the LGPL's + not GPL- or LGPL-licensed so long as you follow the LGPL's rules. You need not fear "viral code" here - not unless you - start copying chunks of podofo into your own application, of + start copying chunks of PoDoFo into your own application, of course. The inlining done by the compiler is considered "linking" for the purposes of the license and thus not an issue. @@ -87,8 +87,8 @@ What language is PoDoFo written in? - PoDoFo is written entirely in C++ . If you're interested in using it from other languages, see the - section below. + PoDoFo is written entirely in C++. If you're interested in using it from other languages, see the + section on those below. Does PoDoFo offer a stable API or ABI? @@ -115,8 +115,8 @@ Does PoDoFo have a mailing list? Yes. See our http://podofo.sourceforge.net/support.html;>support pages. You're very welcome on the lists, - and they're not high traffic. If you have a question, make sure to tell us your compiler and version, platform / OS and version, PoDoFo version, - where you got PoDoFo / how it was built, and the details of any error messages. If possible, upload a problem PDF somewhere that we can + and they're not high-traffic. If you have a question, make sure to tell us your compiler and version, platform / OS and version, PoDoFo version, + where you got PoDoFo / how it was built, and the details of any error messages. If possible, upload a problem PDF document somewhere so that we can get to it, too. My question isn't answered here. Where do I go next? @@ -154,7 +154,7 @@ Not as yet. - As PoDoFo does not make heavy use of templates in its general public API, it would be possible to write a fairly full featured C wrapper around PoDoFo's public C++ APIs. Most of what'd be needed would be to: + As PoDoFo does not make heavy use of templates in its general public API, it would be possible to write a fairly full-featured C wrapper around PoDoFo's public C++ APIs. Most of what'd be needed would be to: provide factory functions for PoDoFo objects @@ -170,17 +170,17 @@ I'm a Java developer. Can I use PoDoFo? Not with Java, no, though we don't discriminate if - you've used it but want to move to another language ;-) . In all + you've used it but want to move to another language ;-). In all seriousness a wrapper for Java may be possible, but nobody has been in touch with the PoDoFo developers to express an interest in writing one. Java users will probably want to look at http://sourceforge.net/project/showfiles.php?group_id=2435;>iText. - I'm a C# or other .NET develiper. Can I use PoDoFo? + I'm a C# or other .NET developer. Can I use PoDoFo? Not easily. Since PoDoFo is unmanaged C++ code, you can use it with P/Invoke and a glue layer, but I wouldn't recommend this as a pleasant way to use a library. If writing your PDF output code in C++ is an option, you may well be able to use PoDoFo. Are any other languages supported? - No. Python bindings would be a fun http://www.boost.org/libs/python/doc/;>Boost::Python project, though.
Re: [Podofo-users] Enabling C++98 Standard build also on Win32
Hi all,
please disregard the earlier post this belongs to
(same Subject after the Re:). There I inadvertently
left in some lines of a try to get a base-only build
(with which I failed :-(, I'm no CMake expert, could
you please help?
I have attached a patch as per the subject to this e-mail.
The patch attached changes the build for Win32 gcc only.
Please review it and if accepted, please apply it (separately)
to the public repository, otherwise please tell me why not.
Best regards, mabri
P.S. I meant to post this on Tuesday, sorry.Index: CMakeLists.txt
===
--- CMakeLists.txt (revision 1687)
+++ CMakeLists.txt (working copy)
@@ -285,13 +292,7 @@
SET(PODOFO_USE_VISIBILITY ${PODOFO_HAVE_GCC4})
ENDIF(NOT DEFINED PODOFO_USE_VISIBILITY)
-# We can't request C++98 compliance on win32, because mingw
-# will hide _tzset() and _timezone, which we need for PdfDate.
-# At least until that code is replaced with something better,
-# just don't enable it on win32.
-IF(NOT WIN32)
-ADD_DEFINITIONS(-std=c++98)
-ENDIF(NOT WIN32)
+ADD_DEFINITIONS(-std=c++98)
ADD_DEFINITIONS(
-Wall
--
___
Podofo-users mailing list
Podofo-users@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/podofo-users
[Podofo-users] tidying up PdfString documentation around deactivated lines before/affecting ToUnicode()
Hi all,
I have attached a patch as per the subject to this e-mail.
Please review it and if accepted, please apply it (separately)
to the public repository, otherwise please tell me why not.
Best regards, mabriIndex: src/base/PdfString.cpp
===
--- src/base/PdfString.cpp (revision 1687)
+++ src/base/PdfString.cpp (working copy)
@@ -620,7 +620,7 @@
#endif // _WIN32
-/*
+#ifdef PODOFO_PUBLIC_STRING_HEX_CODEC // never set, Decode even TODO: REMOVE :(
PdfString PdfString::HexEncode() const
{
if( this->IsHex() )
@@ -674,8 +674,8 @@
return str;
}
-}
-*/
+}
+#endif // PODOFO_PUBLIC_STRING_HEX_CODEC
PdfString PdfString::ToUnicode() const
{
Index: src/base/PdfString.h
===
--- src/base/PdfString.h (revision 1687)
+++ src/base/PdfString.h (working copy)
@@ -331,29 +331,31 @@
*/
bool operator!=(const PdfString& rhs) const { return !operator==(rhs); }
-/** Converts this string to a hex encoded string.
+#ifdef PODOFO_PUBLIC_STRING_HEX_CODEC // never set, impl. still TODO: REMOVE :(
+/** Converts this string to a hex-encoded string.
*
* If IsHex returns true, a copy of this string is returned
- * otherwise the strings data is hex encoded and returned.
+ * otherwise the string's data is hex-encoded and returned.
*
- * \returns a hex encoded version of this string or this string
- * if it is already hex ecoded.
+ * \returns a hex-encoded version of this string, or this string if it is
+ * already hex-encoded.
*
* \see IsHex
*/
-//PdfString HexEncode() const;
+PdfString HexEncode() const;
-/** Converts this string to a ascii string (not hex encoded)
+/** Converts this string to an ASCII string (not hex-encoded)
*
- * If IsHex returns false, a copy of this string is returned
- * otherwise the strings data is hex decoded and returned.
+ * If IsHex returns false, a copy of this string is returned,
+ * otherwise the string's data is hex-decoded and returned.
*
- * \returns a plain version of this string which is not hex encoded
- * or this string if it is already a plain not hex encoded string.
+ * \returns a plain version, which is not hex-encoded, of this string, or
+ * this string if it is already a plain not hex-encoded string.
*
* \see IsHex
*/
-//PdfString HexDecode() const;
+PdfString HexDecode() const;
+#endif
/** Converts this string to a unicode string
*
--
___
Podofo-users mailing list
Podofo-users@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/podofo-users
Re: [Podofo-users] how do I become a contributor?
On Tue, 2015-11-03 at 15:21 -0600, Kenny Ostrom wrote: > I have written a LoadFromTiffData extension for PdfImage, similar to > LoadFromJpegData. > How can I submit it, to get it into the code base? > > I have created an account here https://sourceforge.net/projects/podofo/ > but I don’t see a way to branch and submit a pull request. Hi, there are no pull requests for sourceforge (I'm not aware of any such functionality at least), the PoDoFo project uses simple patch submission to this mailing list. Please see more detailed answer from another thread here: http://sourceforge.net/p/podofo/mailman/message/34590010/ Bye, zyx -- http://www.litePDF.cz i...@litepdf.cz -- ___ Podofo-users mailing list Podofo-users@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/podofo-users
Re: [Podofo-users] tidying up PdfString documentation around deactivated lines before/affecting ToUnicode()
On Tue, 2015-11-03 at 23:20 +, Matthew Brincke wrote: > I have attached a patch as per the subject to this e-mail. Hi, I wouldn't do this change. Adding TODO is something I'd not accept. Furthermore, the change is simply void, thus unnecessary. Once the whole thing will work it'll make sense to be done together, but this part alone doesn't. I'm sorry. Bye, zyx -- http://www.litePDF.cz i...@litepdf.cz -- ___ Podofo-users mailing list Podofo-users@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/podofo-users
Re: [Podofo-users] unreachable-code and robustness fixes in PdfPagesTree::GetPageNode()
On Tue, 2015-11-03 at 23:43 +, Matthew Brincke wrote: > thanks for accepting/committing the patch and your > apologies. I am sorry for not implementing PdfFontFlags, > which is because I have to study, do you still want it? Hi, honestly, having a class for something what is naturally an (unsigned) integer, or an enum, feels like an unneeded complexity of the API. > I have posted (and probably will post) some documentation > patches and a build system patch today, but I can't test > because of that, sorry. So if I post some code change, > could you with commit access please test/review it? If you mean that you send code patches which you actually didn't test, then, well, it doesn't work this way. Do not expect anybody doing "the hard work" for you. I do some smoke testing before committing, but also nothing deep. I hope you test code changes at least on one platform, like when you sent a Win32 build patch, then I expect that you also tested it in the Win32 environment. Please be aware of a fact that I am _not_ a PoDoFo developer, whatever I do for PoDoFo I do in my free time, which is quite limited. There are other people with commit rights, thus asking namely me doesn't help anything (unless it's part of an ongoing discussion/review, of course). You already noticed that my response can take several weeks, thus you have a little overview of my free time availability. Like in any Open Source project, any contribution is highly welcome, thus do not hesitate to send your changes into the list. There will be someone reviewing and eventually committing your changes, sooner or later. Bye, zyx -- http://www.litePDF.cz i...@litepdf.cz -- ___ Podofo-users mailing list Podofo-users@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/podofo-users
