[Podofo-users] Abolishing no-longer-useful CMake module from PoDoFo

[Matthew Brincke]

Hi PoDoFo developers,

I have attached a patch to this e-mail to abolish
a CMake module from PoDoFo which was used for
CMake 2.4 to get a functionality of CMake 2.5, but
as the trunk/CMakeLists.txt specifies CMake 2.6 as
minimum version, the module is no longer useful.
It is cmake/modules/PoDoFoFindPackageHandleStandardArgs.cmake
so please delete it, apply the attached patch,
test (I have build-tested without problems) and
commit separately to the public repository.

Best regards, mabri
Index: cmake/modules/FindBoost.cmake
===
--- cmake/modules/FindBoost.cmake	(revision 1714)
+++ cmake/modules/FindBoost.cmake	(working copy)
@@ -149,7 +149,7 @@
 # compiled any libraries so we set Boost_FOUND to be true here.
 # handle the QUIETLY and REQUIRED arguments and set BOOST_FOUND to TRUE if 
 # all listed variables are TRUE
-INCLUDE(PoDoFoFindPackageHandleStandardArgs)
+INCLUDE(FindPackageHandleStandardArgs)
 FIND_PACKAGE_HANDLE_STANDARD_ARGS(Boost "Boost was not found. ${BOOST_DIR_MESSAGE}" Boost_INCLUDE_DIR )
 SET(Boost_FOUND ${BOOST_FOUND})
 
Index: cmake/modules/FindFONTCONFIG.cmake
===
--- cmake/modules/FindFONTCONFIG.cmake	(revision 1714)
+++ cmake/modules/FindFONTCONFIG.cmake	(working copy)
@@ -37,7 +37,7 @@
 ${FONTCONFIG_LIBRARY_DIRS}
   )
 
-  include(PoDoFoFindPackageHandleStandardArgs)
+  include(FindPackageHandleStandardArgs)
   FIND_PACKAGE_HANDLE_STANDARD_ARGS(Fontconfig DEFAULT_MSG FONTCONFIG_LIBRARIES FONTCONFIG_INCLUDE_DIR )
   
   mark_as_advanced(FONTCONFIG_LIBRARIES FONTCONFIG_INCLUDE_DIR)
Index: cmake/modules/FindFREETYPE.cmake
===
--- cmake/modules/FindFREETYPE.cmake	(revision 1714)
+++ cmake/modules/FindFREETYPE.cmake	(working copy)
@@ -99,7 +99,7 @@
 # MESSAGE(STATUS "ft2 build ${FREETYPE_INCLUDE_DIR_FT2BUILD}")
 # MESSAGE(STATUS "ft header ${FREETYPE_INCLUDE_DIR_FTHEADER}")
 
-INCLUDE(PoDoFoFindPackageHandleStandardArgs)
+INCLUDE(FindPackageHandleStandardArgs)
 FIND_PACKAGE_HANDLE_STANDARD_ARGS(FREETYPE DEFAULT_MSG FREETYPE_LIBRARY FREETYPE_INCLUDE_DIR)
 
 IF (NOT FREETYPE_FIND_QUIETLY)
Index: cmake/modules/FindLIBCRYPTO.cmake
===
--- cmake/modules/FindLIBCRYPTO.cmake	(revision 1714)
+++ cmake/modules/FindLIBCRYPTO.cmake	(working copy)
@@ -36,7 +36,7 @@
 
 # handle the QUIETLY and REQUIRED arguments and set LIBCRYPTO_FOUND to TRUE if 
 # all listed variables are TRUE
-INCLUDE(PoDoFoFindPackageHandleStandardArgs)
+INCLUDE(FindPackageHandleStandardArgs)
 FIND_PACKAGE_HANDLE_STANDARD_ARGS(LIBCRYPTO DEFAULT_MSG LIBCRYPTO_LIBRARY LIBCRYPTO_INCLUDE_DIR)
 
 IF(LIBCRYPTO_FOUND)
Index: cmake/modules/FindLIBIDN.cmake
===
--- cmake/modules/FindLIBIDN.cmake	(revision 1714)
+++ cmake/modules/FindLIBIDN.cmake	(working copy)
@@ -27,7 +27,7 @@
 
 # handle the QUIETLY and REQUIRED arguments and set LIBIDN_FOUND to TRUE if 
 # all listed variables are TRUE
-INCLUDE(PoDoFoFindPackageHandleStandardArgs)
+INCLUDE(FindPackageHandleStandardArgs)
 FIND_PACKAGE_HANDLE_STANDARD_ARGS(LIBIDN DEFAULT_MSG LIBIDN_LIBRARY LIBIDN_INCLUDE_DIR)
 
 IF(LIBIDN_FOUND)
Index: cmake/modules/FindLIBJPEG.cmake
===
--- cmake/modules/FindLIBJPEG.cmake	(revision 1714)
+++ cmake/modules/FindLIBJPEG.cmake	(working copy)
@@ -20,7 +20,7 @@
 
 # handle the QUIETLY and REQUIRED arguments and set LIBJPEG_FOUND to TRUE if 
 # all listed variables are TRUE
-INCLUDE(PoDoFoFindPackageHandleStandardArgs)
+INCLUDE(FindPackageHandleStandardArgs)
 FIND_PACKAGE_HANDLE_STANDARD_ARGS(LIBJPEG DEFAULT_MSG LIBJPEG_LIBRARY LIBJPEG_INCLUDE_DIR)
 
 IF(LIBJPEG_FOUND)
Index: cmake/modules/FindLUA.cmake
===
--- cmake/modules/FindLUA.cmake	(revision 1714)
+++ cmake/modules/FindLUA.cmake	(working copy)
@@ -18,7 +18,7 @@
 
   FIND_PACKAGE(Lua51)
 
-  include(PoDoFoFindPackageHandleStandardArgs)
+  include(FindPackageHandleStandardArgs)
   FIND_PACKAGE_HANDLE_STANDARD_ARGS(Lua DEFAULT_MSG LUA_LIBRARIES LUA_INCLUDE_DIR )
   
   mark_as_advanced(LUA_LIBRARIES LUA_INCLUDE_DIR)
Index: cmake/modules/FindLua51.cmake
===
--- cmake/modules/FindLua51.cmake	(revision 1714)
+++ cmake/modules/FindLua51.cmake	(working copy)
@@ -65,7 +65,7 @@
   ENDIF(UNIX AND NOT APPLE)
 ENDIF(LUA_LIBRARY)
 
-INCLUDE(PoDoFoFindPackageHandleStandardArgs)
+INCLUDE(FindPackageHandleStandardArgs)
 # handle the QUIETLY and REQUIRED arguments and set LUA_FOUND to TRUE if 
 # all listed variables are TRUE
 FIND_PACKAGE_HANDLE_STANDARD_ARGS(Lua50  DEFAULT_MSG  LUA_LIBRARIES LUA_INCLUDE_DIR)
Index: cmake/modules/FindTIFF.cmake
===
--- 

Re: [Podofo-users] Patches for font encoding and digital signatures

[Matthew Brincke]

Hi Jeff, hi PoDoFo developers,

thanks, Jeff, just one little thing is left:
I have attached a patch to this e-mail to correct
the encoding names in the documentation comments
for the Unicode conversion tables for the new encodings.
Could a committer please review, apply and commit it
separately to the public repository?

Best regards, mabri


From: Josef Rokos 
To: podofo-users@lists.sourceforge.net 
Sent: Monday, 25 April 2016, 10:09 UTC
Subject: Re: [Podofo-users] Patches for font encoding and digital signatures



Hi,

yes it is ok. My mistake, sorry.

J. Rokos


On Thu, Apr 21, 2016 at 5:07 PM, zyx  wrote:

On Wed, 2016-04-20 at 16:07 +, Matthew Brincke wrote:
>> There are some bad spelling mistakes in it ("Cerifiacion" instead of
>> the correct "Certification"), so could you (zyx) please commit the
>> patch I have attached to correct them?
>
>Hi,
>thanks for the patch, I overlooked the typo during the review. My
>fault. I committed your patch as revision 1708:
>http://sourceforge.net/p/podofo/code/1708
>
>> Because it was only committed less than 3 days ago, AFAICS nobody
>> should already rely on them (Josef, I hope you are OK with spelling
>> your calls to the new API correctly?).
>
>No problem with this, it's still in the development version only, which
>was not released yet, thus it's still safe to do such changes in the
>new API functions/methods/variables...
>
>Thanks again and bye,
>
>zyx
>
>--
>http://www.litePDF.cz i...@litepdf.cz
>Index: src/base/PdfEncoding.h
===
--- src/base/PdfEncoding.h	(revision 1714)
+++ src/base/PdfEncoding.h	(working copy)
@@ -767,7 +767,7 @@
 virtual const pdf_utf16be* GetToUnicodeTable() const;
 
  private:
-static const pdf_utf16be s_cEncoding[256]; ///< conversion table from ZapfDingbatsEncoding to UTF16
+static const pdf_utf16be s_cEncoding[256]; ///< conversion table from Win1250Encoding to UTF16
 };
 
 /**
@@ -797,7 +797,7 @@
 virtual const pdf_utf16be* GetToUnicodeTable() const;
 
  private:
-static const pdf_utf16be s_cEncoding[256]; ///< conversion table from ZapfDingbatsEncoding to UTF16
+static const pdf_utf16be s_cEncoding[256]; ///< conversion table from Iso88592Encoding to UTF16
 };
 
 }; /* namespace PoDoFo */
--
Find and fix application performance issues faster with Applications Manager
Applications Manager provides deep performance insights into multiple tiers of
your business applications. It resolves application problems quickly and
reduces your MTTR. Get your free trial!
https://ad.doubleclick.net/ddm/clk/302982198;130105516;z___
Podofo-users mailing list
Podofo-users@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/podofo-users

[Podofo-users] PNG library-finding fix for build system

[Matthew Brincke]

Hi PoDoFo developers,

I have found a problem which causes libpng not to be
found even if it's available: the module FindPNG.cmake
of the system cmake (I have version 3.0.2 here) seems
to include the system FindZLIB.cmake only, even with
CMAKE_MODULE_PATH set and CMP0017 policy set to NEW
(as is already done in trunk/CMakeLists.txt). So to
make cmake use PoDoFo's FindZLIB.cmake (as the system's
one seems unsuitable for GNU/Linux) I have copied the
system's FindPNG.cmake to cmake/modules in PoDoFo, made
the changes which are attached to this e-mail as a patch,
and build-tested it: it works now.
So please do the same, make the necessary license notice
completions as specified in cmake's FindPNG.cmake (sorry,
IMHO that's your responsibility ;-) ), test and commit
separately to the public repository.

Best regards, mabri
--- cmake/modules/FindPNG.cmake	2014-09-11 15:24:00.0 +
+++ cmake/modules/FindPNG.cmake	2016-04-26 20:35:13.314347959 +
@@ -79,7 +79,7 @@
   if(NOT PNG_LIBRARY)
 find_library(PNG_LIBRARY_RELEASE NAMES ${PNG_NAMES})
 find_library(PNG_LIBRARY_DEBUG NAMES ${PNG_NAMES_DEBUG})
-include(${CMAKE_CURRENT_LIST_DIR}/SelectLibraryConfigurations.cmake)
+include(SelectLibraryConfigurations)
 select_library_configurations(PNG)
 mark_as_advanced(PNG_LIBRARY_RELEASE PNG_LIBRARY_DEBUG)
   endif()
@@ -116,7 +116,7 @@
 
 # handle the QUIETLY and REQUIRED arguments and set PNG_FOUND to TRUE if
 # all listed variables are TRUE
-include(${CMAKE_CURRENT_LIST_DIR}/FindPackageHandleStandardArgs.cmake)
+include(FindPackageHandleStandardArgs)
 find_package_handle_standard_args(PNG
   REQUIRED_VARS PNG_LIBRARY PNG_PNG_INCLUDE_DIR
   VERSION_VAR PNG_VERSION_STRING)
--
Find and fix application performance issues faster with Applications Manager
Applications Manager provides deep performance insights into multiple tiers of
your business applications. It resolves application problems quickly and
reduces your MTTR. Get your free trial!
https://ad.doubleclick.net/ddm/clk/302982198;130105516;z___
Podofo-users mailing list
Podofo-users@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/podofo-users