Re: NEW: textproc/qpdfview-0.4.18
Ping. On Thu, Apr 28, 2022, 1:29 PM Salil Wadnerkar wrote: > Hi Stuart and Omar, > > Thank you for your review. I have made the changes and checked that the > port is working. > Please find it attached. > > Best regards, > Salil > > > On Thu, Apr 28, 2022 at 12:44 PM Stuart Henderson > wrote: > >> On 2022/04/25 11:18, Omar Polo wrote: >> > to be. That said I'm a little hesintat to import something that hasn't >> > been updated in the last ten years... >> >> Still developed it seems, but no recent releases >> >> https://answers.launchpad.net/qpdfview/+question/701094 >> >> regarding the port, s/Tab/tab/ in COMMENT, and some things are set >> by the qt5 module and should be removed from this port: the COMPILER >> line, and the LIB_DEPENDS on x11/qt5/qtbase >> >>
Re: NEW: textproc/qpdfview-0.4.18
Hi Stuart and Omar, Thank you for your review. I have made the changes and checked that the port is working. Please find it attached. Best regards, Salil On Thu, Apr 28, 2022 at 12:44 PM Stuart Henderson wrote: > On 2022/04/25 11:18, Omar Polo wrote: > > to be. That said I'm a little hesintat to import something that hasn't > > been updated in the last ten years... > > Still developed it seems, but no recent releases > > https://answers.launchpad.net/qpdfview/+question/701094 > > regarding the port, s/Tab/tab/ in COMMENT, and some things are set > by the qt5 module and should be removed from this port: the COMPILER > line, and the LIB_DEPENDS on x11/qt5/qtbase > > qpdfview.tar.gz Description: application/gzip
Re: NEW: textproc/qpdfview-0.4.18
Hi Omar, Could you commit the port, if there is nothing else to be done? Thank you! Salil On Mon, Apr 25, 2022 at 10:05 AM Salil Wadnerkar wrote: > Hi Omar, > > Many thanks for your feedback and corrections, I have added myself as the > maintainer of this port, and regenerated the tar.gz. > Let me know the further actions. > > Best regards, > Salil > > On Mon, Apr 25, 2022 at 2:18 AM Omar Polo wrote: > >> Hello, >> >> Salil Wadnerkar wrote: >> > Hi, >> > >> > qpdfview (https://launchpad.net/qpdfview) is a tabbed document viewer. >> It >> > uses Poppler for PDF support, libspectre for PS support, DjVuLibre for >> DjVu >> > support, CUPS for printing support and the Qt toolkit for its interface. >> > I am using it as my daily pdf reader. And I have tested it locally with >> ps, >> > djvu files as well. >> > Please review the port request. >> >> it's a good start ;) >> >> There are a couple of things that can be improved: >> >> - nitpicking: the pkg/DESCR file is usually formatted, so lines are not >>longer than ~72 chars (it really depends, but that's the idea) >> >> - nitpicking: indentation. We usually use tabs (with a width of 8) to >>align the variables. >> >> - the variable MAINTAINER is not the upstream developer, but an OpenBSD >>user that's maintaining the *port* (not the project) >> >> - `make port-lib-depends-check' reports that the WANTLIBs are not >>correct: >> >> % make port-lib-depends-check >> qpdfview-0.4.18(textproc/qpdfview): >> Missing lib: synctex.3 (/usr/local/bin/qpdfview) (NOT REACHABLE) >> Extra: z.6 >> *** Error 1 in target 'port-lib-depends-check' (ignored) >> >> This means that `z' is extra and the port that provides the `synctex' >> (print/texlive/base,-synctex) shared library is not listed in >> LIB_DEPENDS. >> >> - /usr/ports/infrastructure/bin/portcheck says that it's missing an >>RDEP on x11/gtk+3,-guic >> >> - another nitpicking: usually the *_DEPENDS and MODULES values are >>sorted. >> >> I've fixed these in the attached tarball: with these fixes it looks fine >> to be. That said I'm a little hesintat to import something that hasn't >> been updated in the last ten years... >> >> > Best regards, >> > Salil >> >>
Re: Issue in fetching upstream package source
Thanks a lot, Stuart! It worked.
On Mon, Apr 25, 2022 at 1:33 PM Stuart Henderson
wrote:
> On 2022/04/25 21:31, Stuart Henderson wrote:
> > On 2022/04/25 13:30, Salil Wadnerkar wrote:
> > > Hi,
> > >
> > > I am facing issues in fetching upstream packages hosted on github for
> > > multiple new packages that I am trying to build,
> > >
> > > For example,
> > > https://github.com/easymodo/qimgv/archive/refs/tags/v1.0.2.tar.gz
> > > is hosted on the page:
> https://github.com/easymodo/qimgv/releases/tag/v1.0.2
> >
> > See the examples and description for the GH_xxx variables
> > in /usr/ports/infrastructure/templates/Makefile.template
> >
> > > My Makefile is:
> > >
> > > MASTER_SITES=https://github.com/easymodo/qimgv/archive/refs/tags/
> > > VERSION=1.0.2
> > > DISTNAME=v${VERSION}
> > >
> > > My understanding is this should fetch the tar.gz, but `make fetch`
> fails
> > > with this error:
> > >
> > > $ make fetch
> > > ===> Checking files for qimgv-1.0.2
> > > >> No size recorded for v1.0.2.tar.gz
> > > *** Error 1 in . (/usr/ports/infrastructure/mk/bsd.port.mk:3205
> > > '/usr/ports/distfiles/v1.0.2.tar.gz': @lock=v1.0.2.tar.gz.dist; doas -u
> > > _pbu...)
> > > *** Error 2 in . (/usr/ports/infrastructure/mk/bsd.port.mk:2481
> > > '_internal-fetch': @cd /usr/ports/mystuff/graphics/qimgv &&
> > > PKGPATH=graphics...)
> > > *** Error 2 in /usr/ports/mystuff/graphics/qimgv
> > > (/usr/ports/infrastructure/mk/bsd.port.mk:2607 'fetch':
> @lock=qimgv-1.0.2;
> > > export _LOCKS_H...)
>
> Also "make fetch" checks the downloaded files against recorded size/hash
> in distinfo. If you don't already have the files listed there (as is the
> case
> in a new port or an update), "make makesum" instead.
>
> > >
> > > Can someone show me what I am doing wrong?
> > >
> > > Thanks,
> > > Salil
> >
>
Issue in fetching upstream package source
Hi,
I am facing issues in fetching upstream packages hosted on github for
multiple new packages that I am trying to build,
For example,
https://github.com/easymodo/qimgv/archive/refs/tags/v1.0.2.tar.gz
is hosted on the page: https://github.com/easymodo/qimgv/releases/tag/v1.0.2
My Makefile is:
MASTER_SITES=https://github.com/easymodo/qimgv/archive/refs/tags/
VERSION=1.0.2
DISTNAME=v${VERSION}
My understanding is this should fetch the tar.gz, but `make fetch` fails
with this error:
$ make fetch
===> Checking files for qimgv-1.0.2
>> No size recorded for v1.0.2.tar.gz
*** Error 1 in . (/usr/ports/infrastructure/mk/bsd.port.mk:3205
'/usr/ports/distfiles/v1.0.2.tar.gz': @lock=v1.0.2.tar.gz.dist; doas -u
_pbu...)
*** Error 2 in . (/usr/ports/infrastructure/mk/bsd.port.mk:2481
'_internal-fetch': @cd /usr/ports/mystuff/graphics/qimgv &&
PKGPATH=graphics...)
*** Error 2 in /usr/ports/mystuff/graphics/qimgv
(/usr/ports/infrastructure/mk/bsd.port.mk:2607 'fetch': @lock=qimgv-1.0.2;
export _LOCKS_H...)
Can someone show me what I am doing wrong?
Thanks,
Salil
Re: NEW: textproc/qpdfview-0.4.18
Hi Omar, Many thanks for your feedback and corrections, I have added myself as the maintainer of this port, and regenerated the tar.gz. Let me know the further actions. Best regards, Salil On Mon, Apr 25, 2022 at 2:18 AM Omar Polo wrote: > Hello, > > Salil Wadnerkar wrote: > > Hi, > > > > qpdfview (https://launchpad.net/qpdfview) is a tabbed document viewer. > It > > uses Poppler for PDF support, libspectre for PS support, DjVuLibre for > DjVu > > support, CUPS for printing support and the Qt toolkit for its interface. > > I am using it as my daily pdf reader. And I have tested it locally with > ps, > > djvu files as well. > > Please review the port request. > > it's a good start ;) > > There are a couple of things that can be improved: > > - nitpicking: the pkg/DESCR file is usually formatted, so lines are not >longer than ~72 chars (it really depends, but that's the idea) > > - nitpicking: indentation. We usually use tabs (with a width of 8) to >align the variables. > > - the variable MAINTAINER is not the upstream developer, but an OpenBSD >user that's maintaining the *port* (not the project) > > - `make port-lib-depends-check' reports that the WANTLIBs are not >correct: > > % make port-lib-depends-check > qpdfview-0.4.18(textproc/qpdfview): > Missing lib: synctex.3 (/usr/local/bin/qpdfview) (NOT REACHABLE) > Extra: z.6 > *** Error 1 in target 'port-lib-depends-check' (ignored) > > This means that `z' is extra and the port that provides the `synctex' > (print/texlive/base,-synctex) shared library is not listed in > LIB_DEPENDS. > > - /usr/ports/infrastructure/bin/portcheck says that it's missing an >RDEP on x11/gtk+3,-guic > > - another nitpicking: usually the *_DEPENDS and MODULES values are >sorted. > > I've fixed these in the attached tarball: with these fixes it looks fine > to be. That said I'm a little hesintat to import something that hasn't > been updated in the last ten years... > > > Best regards, > > Salil > > qpdfview.tar.gz Description: application/gzip
NEW: textproc/qpdfview-0.4.18
Hi, qpdfview (https://launchpad.net/qpdfview) is a tabbed document viewer. It uses Poppler for PDF support, libspectre for PS support, DjVuLibre for DjVu support, CUPS for printing support and the Qt toolkit for its interface. I am using it as my daily pdf reader. And I have tested it locally with ps, djvu files as well. Please review the port request. Best regards, Salil qpdfview.tgz Description: application/compressed-tar
