Re: [NEW] graphics/opencsg
Ping? On Mon, Apr 18, 2011 at 03:08:42PM -0700, Matthew Dempsky wrote: Attached is a port for graphics/opencsg; you can also find it at https://github.com/mdempsky/openbsd-stuff/tree/master/ports/graphics/opencsg The port's pretty simple, but a few things I want to check first: 1. The port only builds a shared object; should/must I patch it to build a static library too? Or mark it as only for shared arches? 2. The main code is licensed GPLv2 (with an exception for linking against the CGAL library), but it bundles GLEW (BSD) and RenderTexture (zlib). I patched the build files to use graphics/glew instead of the bundled GLEW. Is it correct to summarize this as GPLv2 with CGAL exception? (RenderTexture is only used internally; it's not intentionally exposed to users, though currently the symbols are still visible in the resulting .so.) 3. Should I make a separate RenderTexture port instead, and patch OpenCSG to depend on that? 4. libopencsg.so depends on symbols from libGLEW.so, but upstream doesn't actually link it against libGLEW.so, so I only added graphics/glew to BUILD_DEPENDS rather than LIB_DEPENDS. Is this correct, or should I patch it to link against libGLEW.so and/or add to LIB_DEPENDS instead?
Re: [NEW] graphics/opencsg
On Mon, Apr 18, 2011 at 03:08:42PM -0700, Matthew Dempsky wrote: Attached is a port for graphics/opencsg; you can also find it at https://github.com/mdempsky/openbsd-stuff/tree/master/ports/graphics/opencsg The port's pretty simple, but a few things I want to check first: 1. The port only builds a shared object; should/must I patch it to build a static library too? Or mark it as only for shared arches? Make that SHARED_ONLY and merge pkg/PFRAG.shared into pkg/PLIST. You're missing the rcs ids in Makefile. 2. The main code is licensed GPLv2 (with an exception for linking against the CGAL library), but it bundles GLEW (BSD) and RenderTexture (zlib). I patched the build files to use graphics/glew instead of the bundled GLEW. Is it correct to summarize this as GPLv2 with CGAL exception? (RenderTexture is only used internally; it's not intentionally exposed to users, though currently the symbols are still visible in the resulting .so.) I'd say yes. 3. Should I make a separate RenderTexture port instead, and patch OpenCSG to depend on that? That would be better, if more stuff want to depend on it later. If not.. your call. 4. libopencsg.so depends on symbols from libGLEW.so, but upstream doesn't actually link it against libGLEW.so, so I only added graphics/glew to BUILD_DEPENDS rather than LIB_DEPENDS. Is this correct, or should I patch it to link against libGLEW.so and/or add to LIB_DEPENDS instead? It all depends if a binary linked with it fails at runtime or not. I'm not sure if there are previous similar things with libGL*.so. Explicitely linking with it might be safer. Landry
Re: [NEW] graphics/opencsg
On Thu, Apr 28, 2011 at 2:39 PM, Landry Breuil lan...@rhaalovely.net wrote: 3. Should I make a separate RenderTexture port instead, and patch OpenCSG to depend on that? That would be better, if more stuff want to depend on it later. If not.. your call. I think I'll leave it bundled for the time being then. It's just one .cpp and one .h file, and RenderTexture upstream doesn't even bother distributing a real Makefile with it. 4. libopencsg.so depends on symbols from libGLEW.so, but upstream doesn't actually link it against libGLEW.so, so I only added graphics/glew to BUILD_DEPENDS rather than LIB_DEPENDS. Is this correct, or should I patch it to link against libGLEW.so and/or add to LIB_DEPENDS instead? It all depends if a binary linked with it fails at runtime or not. I'm not sure if there are previous similar things with libGL*.so. Explicitely linking with it might be safer. Will do.
[NEW] graphics/opencsg
Attached is a port for graphics/opencsg; you can also find it at https://github.com/mdempsky/openbsd-stuff/tree/master/ports/graphics/opencsg The port's pretty simple, but a few things I want to check first: 1. The port only builds a shared object; should/must I patch it to build a static library too? Or mark it as only for shared arches? 2. The main code is licensed GPLv2 (with an exception for linking against the CGAL library), but it bundles GLEW (BSD) and RenderTexture (zlib). I patched the build files to use graphics/glew instead of the bundled GLEW. Is it correct to summarize this as GPLv2 with CGAL exception? (RenderTexture is only used internally; it's not intentionally exposed to users, though currently the symbols are still visible in the resulting .so.) 3. Should I make a separate RenderTexture port instead, and patch OpenCSG to depend on that? 4. libopencsg.so depends on symbols from libGLEW.so, but upstream doesn't actually link it against libGLEW.so, so I only added graphics/glew to BUILD_DEPENDS rather than LIB_DEPENDS. Is this correct, or should I patch it to link against libGLEW.so and/or add to LIB_DEPENDS instead? opencsg-1.3.1.tar.gz Description: application/tar-gz
