Re: [NEW] misc/sword

[Anthony J. Bentley]

Hi Aaron,

Aaron Poffenberger writes:
> Thanks for the feedback. I've attached the revised port. I made a
> couple of changes:
>
> - Two new patch files. Thanks to sthen@ for helping me track down the
>   lines to fix SHARED_LIB versioning.
>
> - I added more detail to pkg/README about ~/.sword.conf, modules, and
>   the other cli utilities.

I'm happy with this one. But I have to set SWORD_PATH=/usr/local/share/sword
to do anything. It looks like that is supposed to be handled automatically
(configPath). Can you fix this?


SWMgr: Can't find 'mods.conf' or 'mods.d'.  Try setting:
SWORD_PATH=
Or see the README file for a full description of setup options
()

-- 
Anthony J. Bentley

Re: [NEW] misc/sword

[Aaron Poffenberger]

Hi Anthony,

Thanks for the feedback. I've attached the revised port. I made a
couple of changes:

- Two new patch files. Thanks to sthen@ for helping me track down the
  lines to fix SHARED_LIB versioning.

- I added more detail to pkg/README about ~/.sword.conf, modules, and
  the other cli utilities.

--Aaron

On 2020-12-14 03:04 -0700, Anthony J. Bentley  wrote:
> Hi Aaron,
> 
> Aaron Poffenberger writes:
> > SWORD is a cli app from the CrossWire project for viewing Biblical
> > texts from the command line. It also includes the library used by GUI
> > apps.
> 
> Thanks, good program to have in-tree. A few things need to be fixed:
> 
> - according to Makefile.template COMPILER should be
>   "base-clang ports-gcc base-gcc"
> - libsword.so needs to end in a version number (specifically
>   ${LIBsword_VERSION} which is 0.0). ditto for libsword-1.9.0.so
> - license comment should be "GPLv2 only"
> - AUTORECONF doesn't appear to be necessary
> - COMMENT should not end in a period
> - is -DU_USING_ICU_NAMESPACE=1 still needed? if not it should be removed,
>   if so it should have a comment explaining why it's there
> - remove NO_TEST, "make test" succeeds (even though it runs zero tests,
>   they may add more in the future)
> 
> And some not very important things, to make it look more like other ports:
> 
> - please reorder lines to match Makefile.template
> - don't indent WANTLIB, most people copy and paste port-lib-depends-check
>   output there
> - one LIB_DEPENDS per line, using = and backslashes instead of +=
> - switch homepage and master_sites to https
> 
> -- 
> Anthony J. Bentley
> 


sword-1.9.0.tgz
Description: application/tar-gz

Re: [NEW] misc/sword

[Anthony J. Bentley]

Hi Aaron,

Aaron Poffenberger writes:
> SWORD is a cli app from the CrossWire project for viewing Biblical
> texts from the command line. It also includes the library used by GUI
> apps.

Thanks, good program to have in-tree. A few things need to be fixed:

- according to Makefile.template COMPILER should be
  "base-clang ports-gcc base-gcc"
- libsword.so needs to end in a version number (specifically
  ${LIBsword_VERSION} which is 0.0). ditto for libsword-1.9.0.so
- license comment should be "GPLv2 only"
- AUTORECONF doesn't appear to be necessary
- COMMENT should not end in a period
- is -DU_USING_ICU_NAMESPACE=1 still needed? if not it should be removed,
  if so it should have a comment explaining why it's there
- remove NO_TEST, "make test" succeeds (even though it runs zero tests,
  they may add more in the future)

And some not very important things, to make it look more like other ports:

- please reorder lines to match Makefile.template
- don't indent WANTLIB, most people copy and paste port-lib-depends-check
  output there
- one LIB_DEPENDS per line, using = and backslashes instead of +=
- switch homepage and master_sites to https

-- 
Anthony J. Bentley

[NEW] misc/sword

[Aaron Poffenberger]

SWORD is a cli app from the CrossWire project for viewing Biblical
texts from the command line. It also includes the library used by GUI
apps.

Homepage:


portcheck and port-lib-depends-check: ok

Cheers,

--Aaron


sword-1.9.0.tgz
Description: application/tar-gz

Re: NEW: misc/sword

[Aaron Poffenberger]

On 03/13/16 16:55, Dmitrij D. Czarkoff wrote:
> Aaron Poffenberger said:
>> I thought the LIB_DEPENDS and WANT_LIB were suspiciously empty. I must
>> have had several of the dependencies already installed. What’s the
>> best way to find them in such cases?
> 
> As you might have noticed "port-lib-depends-check" target in
> bsd.port.mk(5) and inside a comment in Makefile.template.  When called
> with this target ("make port-lib-depends-check") make will walk through
> dependencies of the port and through port's WANTLIB, informing user of
> its findings.  Note, this only works with binaries.
> 

Ah, right. I remember that step now that you mention it. I forgot to run
it when making the port.

Thanks!

--Aaron

Re: NEW: misc/sword

[Dmitrij D. Czarkoff]

Aaron Poffenberger said:
> I thought the LIB_DEPENDS and WANT_LIB were suspiciously empty. I must
> have had several of the dependencies already installed. What’s the
> best way to find them in such cases?

As you might have noticed "port-lib-depends-check" target in
bsd.port.mk(5) and inside a comment in Makefile.template.  When called
with this target ("make port-lib-depends-check") make will walk through
dependencies of the port and through port's WANTLIB, informing user of
its findings.  Note, this only works with binaries.

-- 
Dmitrij D. Czarkoff

Re: NEW: misc/sword

[Aaron Poffenberger]

> 
> On Mar 12, 2016, at 4:36 AM, Dmitrij D. Czarkoff  wrote:
> 
> Aaron Poffenberger said:
>> Here is a new port : misc/sword
> [...]
>> I'm working on porting one of the GUIs to use library but since this is
>> my first port I'm sending it now for review.
> 
> You've left out dependency management (LIB_DEPENDS, WANTLIB).  Also, we
> normally start SHARED_LIBS from 0.0 for new ports;  values are not
> supposed to correspond to upstream's library versioning.  See attached
> tarball for the fixes.
> 
> There is also issue with configuration file.  It is installed to
> ${PREFIX}/etc by default, which is not what we normally do.  I've set
> runtime config file location to ${SYSCONFDIR}, but more work is
> required:  default configuration file should be installed to
> "${PREFIX}/share/examples/sword/" and @sampled to ${SYSCONFDIR} from
> there.  I don't have time to finish it, so it is left for homework.  :)
> 
> Overall, I'd say not a bad job for the first port.
> 
> -- 
> Dmitrij D. Czarkoff
> 

Thanks, Dmitrij. Best kind of homework.

I thought the LIB_DEPENDS and WANT_LIB were suspiciously empty. I must have had 
several of the dependencies already installed. What’s the best way to find them 
in such cases?

Cheers,

—Aaron

Re: NEW: misc/sword

[Dmitrij D. Czarkoff]

Aaron Poffenberger said:
> Here is a new port : misc/sword
[...]
> I'm working on porting one of the GUIs to use library but since this is
> my first port I'm sending it now for review.

You've left out dependency management (LIB_DEPENDS, WANTLIB).  Also, we
normally start SHARED_LIBS from 0.0 for new ports;  values are not
supposed to correspond to upstream's library versioning.  See attached
tarball for the fixes.

There is also issue with configuration file.  It is installed to
${PREFIX}/etc by default, which is not what we normally do.  I've set
runtime config file location to ${SYSCONFDIR}, but more work is
required:  default configuration file should be installed to
"${PREFIX}/share/examples/sword/" and @sampled to ${SYSCONFDIR} from
there.  I don't have time to finish it, so it is left for homework.  :)

Overall, I'd say not a bad job for the first port.

-- 
Dmitrij D. Czarkoff


sword-1.7.5.tgz
Description: application/tar-gz

NEW: misc/sword

[Aaron Poffenberger]

Hello ports@,

Here is a new port : misc/sword

Tested on: amd64.

>From DESCR:

The SWORD Engine is a software framework that allows research
manipulation of Biblical texts. There are a number of projects that use
The SWORD Engine, including Bibletime, Xiphos, PocketSword and many
others. Many of these projects already include The SWORD Engine in their
distribution, so only download if you were instructed to do so, or are a
software developer wishing to develop Bible software.

Also includes the command line utility diatheke for working with texts.



I'm working on porting one of the GUIs to use library but since this is
my first port I'm sending it now for review.

Cheers,
Aaron


sword.tar.gz
Description: application/gzip