Re: [NEW] net/py-dnslib

[Bryan C. Everly]

Hello all,

I have worked with the upstream author of this module (Paul Chakravarti -
copied) to address the two issues we were seeing in the test cases and he
kindly cut a new version that takes care of things.  Therefore, I've
updated the port (see attachment) for the new version and taken into
account the other suggestions on this thread.

Is this OK to proceed?  If so, would someone kindly commit it on my behalf?


Thanks,
Bryan

On Tue, Oct 27, 2015 at 8:11 PM, Stuart Henderson  wrote:

> On 2015/10/27 21:04, Remi Pointel wrote:
> > On 10/27/15 20:20, Bryan C. Everly wrote:
> > >Here is a port of py-dnslib which is used by some other ports I will
> > >shortly be submitting.
> > >
> > > From pkg/DESCR:
> > >
> > >A library to encode/decode DNS wire-format packets supporting both
> > >Python 2.7 and Python 3.2+.
> > >
> > >Comments or recommendations gratefully accepted as this is my first
> > >python library port.  As I am not a committer, I will need someone to
> > >commit the changes on my behalf if approved.
> > >
> > >Thanks,
> > >Bryan
> > >
> >
> > with the correct tarball this time...
> >
> > Remi.
>
> This could use MODPY_PI=Yes instead of setting MASTER_SITES, and untested
> but you could probably just do 'VERSIONS=python${MODPY_VER}' (or maybe just
> MODPY_BIN) in the do-test target to avoid patch/SUBST_CMD.
>
>


py-dnslib.tgz
Description: GNU Zip compressed data

Re: [NEW] net/py-dnslib

[Remi Pointel]

On 10/30/15 17:30, Bryan C. Everly wrote:

Hello all,

I have worked with the upstream author of this module (Paul Chakravarti -
copied) to address the two issues we were seeing in the test cases and he
kindly cut a new version that takes care of things.  Therefore, I've
updated the port (see attachment) for the new version and taken into
account the other suggestions on this thread.

Is this OK to proceed?  If so, would someone kindly commit it on my behalf?


Hi,

I just added your port.

Thanks,

Remi.

Re: [NEW] net/py-dnslib

[Bryan C. Everly]

Thanks Remi!


Thanks,
Bryan

On Fri, Oct 30, 2015 at 12:47 PM, Remi Pointel  wrote:

> On 10/30/15 17:30, Bryan C. Everly wrote:
>
>> Hello all,
>>
>> I have worked with the upstream author of this module (Paul Chakravarti -
>> copied) to address the two issues we were seeing in the test cases and he
>> kindly cut a new version that takes care of things.  Therefore, I've
>> updated the port (see attachment) for the new version and taken into
>> account the other suggestions on this thread.
>>
>> Is this OK to proceed?  If so, would someone kindly commit it on my
>> behalf?
>>
>
> Hi,
>
> I just added your port.
>
> Thanks,
>
> Remi.
>
>

Re: [NEW] net/py-dnslib

[Remi Pointel]

On 10/27/15 20:20, Bryan C. Everly wrote:

Here is a port of py-dnslib which is used by some other ports I will
shortly be submitting.

 From pkg/DESCR:

A library to encode/decode DNS wire-format packets supporting both
Python 2.7 and Python 3.2+.

Comments or recommendations gratefully accepted as this is my first
python library port.  As I am not a committer, I will need someone to
commit the changes on my behalf if approved.

Thanks,
Bryan



with the correct tarball this time...

Remi.


py-dnslib.tgz
Description: Binary data

[NEW] net/py-dnslib

[Bryan C. Everly]

Here is a port of py-dnslib which is used by some other ports I will
shortly be submitting.

>From pkg/DESCR:

A library to encode/decode DNS wire-format packets supporting both
Python 2.7 and Python 3.2+.

Comments or recommendations gratefully accepted as this is my first
python library port.  As I am not a committer, I will need someone to
commit the changes on my behalf if approved.

Thanks,
Bryan


py-dnslib.tgz
Description: GNU Zip compressed data

Re: [NEW] net/py-dnslib

[Bryan C. Everly]

Thanks Remi!  I'll check with upstream and see if this is typical of
the library built on other platforms and see if we can collaborate to
get it fixed up.

Thanks,
Bryan


On Tue, Oct 27, 2015 at 4:04 PM, Remi Pointel  wrote:
> On 10/27/15 20:20, Bryan C. Everly wrote:
>>
>> Here is a port of py-dnslib which is used by some other ports I will
>> shortly be submitting.
>>
>>  From pkg/DESCR:
>>
>> A library to encode/decode DNS wire-format packets supporting both
>> Python 2.7 and Python 3.2+.
>>
>> Comments or recommendations gratefully accepted as this is my first
>> python library port.  As I am not a committer, I will need someone to
>> commit the changes on my behalf if approved.
>>
>> Thanks,
>> Bryan
>>
>
> with the correct tarball this time...
>
> Remi.

Re: [NEW] net/py-dnslib

[Remi Pointel]

On 10/27/15 20:20, Bryan C. Everly wrote:

Here is a port of py-dnslib which is used by some other ports I will
shortly be submitting.

 From pkg/DESCR:

A library to encode/decode DNS wire-format packets supporting both
Python 2.7 and Python 3.2+.

Comments or recommendations gratefully accepted as this is my first
python library port.  As I am not a committer, I will need someone to
commit the changes on my behalf if approved.

Thanks,
Bryan



Hi,

it's a good first python port :).

I modified your Makefile to enable regress tests (2 tests failed).
Also, I added the python3 flavor to have the port working with python 2 
and 3.


Attached is the port modified.

Remi.


py-dnslib.tgz
Description: Binary data

Re: [NEW] net/py-dnslib

[Stuart Henderson]

On 2015/10/27 21:04, Remi Pointel wrote:
> On 10/27/15 20:20, Bryan C. Everly wrote:
> >Here is a port of py-dnslib which is used by some other ports I will
> >shortly be submitting.
> >
> > From pkg/DESCR:
> >
> >A library to encode/decode DNS wire-format packets supporting both
> >Python 2.7 and Python 3.2+.
> >
> >Comments or recommendations gratefully accepted as this is my first
> >python library port.  As I am not a committer, I will need someone to
> >commit the changes on my behalf if approved.
> >
> >Thanks,
> >Bryan
> >
> 
> with the correct tarball this time...
> 
> Remi.

This could use MODPY_PI=Yes instead of setting MASTER_SITES, and untested
but you could probably just do 'VERSIONS=python${MODPY_VER}' (or maybe just
MODPY_BIN) in the do-test target to avoid patch/SUBST_CMD.

Re: [NEW] net/py-dnslib

[Jérémie Courrèges-Anglas]

Bryan C. Everly br...@bceassociates.com writes:

 $COMMENT: library to en/decode DNS wire-format packets for Python

 pkg/DESCR:

 library to en/decode DNS wire-format packets for Python.

*BZZT*

ritchie /usr/ports/mystuff/net/py-dnslib$ cat pkg/DESCR
A library to encode/decode DNS wire-format packets supporting both
Python 2.7 and Python 3.2+.

Where's the python3 flavor? (:

 

 This is a standard Python library
 (https://pypi.python.org/pypi/dnslib) that I would like to add to
 OpenBSD because I need it to support several Python-based security
 scanning tools.

 

 This is my first Python library so any comments or questions?

The port looks fine, except that it should use MODPY_PI.

I'm not sure about tests.  Adding MODPY_SETUPTOOLS=Yes leads to a dummy
test target.  Maybe that'd be better that NO_TEST=Yes?

Can this be used by existing or upcoming ports you plan to publish, or
is it for personal use?  I am personally a bit reluctant on adding libs
if they aren't useful for other ports.

 If not,
 would anyone be willing to commit this on my behalf?

 (apologies for not including the attachment last time)

 Thanks,
 Bryan


-- 
jca | PGP : 0x1524E7EE / 5135 92C1 AD36 5293 2BDF  DDCC 0DFA 74AE 1524 E7EE

[NEW] net/py-dnslib

[Bryan C. Everly]

$COMMENT: library to en/decode DNS wire-format packets for Python

pkg/DESCR:

library to en/decode DNS wire-format packets for Python.



This is a standard Python library
(https://pypi.python.org/pypi/dnslib) that I would like to add to
OpenBSD because I need it to support several Python-based security
scanning tools.



This is my first Python library so any comments or questions?  If not,
would anyone be willing to commit this on my behalf?

(apologies for not including the attachment last time)

Thanks,
Bryan


py-dnslib.tgz
Description: GNU Zip compressed data

[NEW] net/py-dnslib

[Bryan C. Everly]

$COMMENT: library to en/decode DNS wire-format packets for Python

pkg/DESCR:

library to en/decode DNS wire-format packets for Python.



This is a standard Python library
(https://pypi.python.org/pypi/dnslib) that I would like to add to
OpenBSD because I need it to support several Python-based security
scanning tools.



This is my first Python library so any comments or questions?  If not,
would anyone be willing to commit this on my behalf?

Thanks,
Bryan