Re: [NEW] www/unit

[Stuart Henderson]

Since www/nginx has now changed the rc-script regarding SIGQUIT I've
dropped the rc_stop from unit's rc-script. And I don't think the ruby30
"extra" in port-lib-depends-check is really a big problem as anybody
doing a sweep of these (which is well overdue actually..) should be
able to figure out that it shouldn't really be removed.

So: any OKs to import?


On 2021/10/11 22:25, Stuart Henderson wrote:
> On 2021/10/11 19:24, Sergey A. Osokin wrote:
> > On Wed, Oct 06, 2021 at 03:30:08AM +, Sergey A. Osokin wrote:
> > > On Wed, Sep 22, 2021 at 08:49:06PM +0100, Stuart Henderson wrote:
> > > > On 2021/09/22 13:34, Sergey A. Osokin wrote:
> > > > > On Fri, Sep 17, 2021 at 03:20:16PM +, Sergey A. Osokin wrote:
> > > > > 
> > > > > P.S. Yes, I know you're busy with a preparation to the upcoming 7.0
> > > > > and it's good time for fixes and probably not a best time for new
> > > > > ports, but I want to let you know that www/unit builds very well
> > > > > with new and shiny 7.0 yesterday snapshot.
> > > > 
> > > > yes, it's been no new imports for a week already.
> > > > I will have a look again when I have time.
> > > 
> > > Seems like a liveness probe returns a positive signal after the
> > > ports change freeze for the upcoming 7.0.
> > > Is there any update?
> > 
> > Could you please provide an update.
> > Thank you.
> > 
> > -- 
> > Sergey Osokin
> 
> 
> Hi Sergey. Updated version attached, A few notes on my changes, there
> are probably some others too but this is what I remember:
> 
> - reduce unnecessary variables, the UNIT_xxx were only used to pass
> to configure and create directories in fake-install. The directory
> creation is pointless, so I dropped the variables and passed directly
> to configure.
> 
> - move libexec to lib. openbsd standard use for libexec is for
> executables invoked by some software. other similar ports use lib for
> plugin modules.
> 
> - /var/run and tmp are cleared at boot so must be created by the rc
> script, I added rc_pre. there is no point including them in the package
> because it gives a false sense that things will work after boot.
> 
> - tidy dependencies
> 
> - use a valid uid for @newuser/@newgroup lines
> 
> - enable tests
> 
> A couple of issues remain:
> 
> - ruby linkage looks a bit wrong, but I think that's on the ruby side
> not the unit side. the NEEDED ELF header in unit's ruby module is set to
> just "libruby30.so" and not "libruby30.so.0.0", I think this is probably
> due to the symlink in /usr/local/lib/libruby30.so -> libruby30.so.0.0
> and/or lack of SONAME in libruby30. Maybe another porter has an idea
> what to do with this though I think it's probably not a show-stopper..
> 
> - rc script nearly duplicates the standard rc_stop section but adds
> -QUIT instead of using the default (-TERM). currently the two singals
> do the same in unit anyway but comments suggest it is intended for a
> graceful shutdown (not yet implemented). I don't think that will work
> very well with rc.d anyway (rcctl restart will wait for shutdown,
> so you either use 'fast shutdown' and kill active connections, or
> use 'graceful' and have a gap while you stop accepting new connections
> while draining old). So I think it might be better to drop the rc_stop
> function.
> 
> Other than those, it builds and starts ok, I have run out of patience
> trying to figure out how to configure to test runtime myself though
> (I was looking for a simple static-file config but there is nothing
> obvious). However the tests that I've enabled look promising (a couple
> of F/E in test_perl_application.py and test_respawn.py, and a couple
> of TLS-related ones, looks fairly minor).
> 




unit.tgz
Description: application/tar-gz

Re: [NEW] www/unit

[Stuart Henderson]

On 2021/10/12 21:58, Sergey A. Osokin wrote:
> Hi Stuart,
> 
> thank you very much for the review and updates.
> 
> On Mon, Oct 11, 2021 at 10:25:57PM +0100, Stuart Henderson wrote:
> 
> [...]
> 
> > Hi Sergey. Updated version attached, A few notes on my changes, there
> > are probably some others too but this is what I remember:
> > 
> > - reduce unnecessary variables, the UNIT_xxx were only used to pass
> > to configure and create directories in fake-install. The directory
> > creation is pointless, so I dropped the variables and passed directly
> > to configure.
> > 
> > - move libexec to lib. openbsd standard use for libexec is for
> > executables invoked by some software. other similar ports use lib for
> > plugin modules.
> > 
> > - /var/run and tmp are cleared at boot so must be created by the rc
> > script, I added rc_pre. there is no point including them in the package
> > because it gives a false sense that things will work after boot.
> > 
> > - tidy dependencies
> > 
> > - use a valid uid for @newuser/@newgroup lines
> > 
> > - enable tests
> > 
> > A couple of issues remain:
> > 
> > - ruby linkage looks a bit wrong, but I think that's on the ruby side
> > not the unit side. the NEEDED ELF header in unit's ruby module is set to
> > just "libruby30.so" and not "libruby30.so.0.0", I think this is probably
> > due to the symlink in /usr/local/lib/libruby30.so -> libruby30.so.0.0
> > and/or lack of SONAME in libruby30. Maybe another porter has an idea
> > what to do with this though I think it's probably not a show-stopper..
> > 
> > - rc script nearly duplicates the standard rc_stop section but adds
> > -QUIT instead of using the default (-TERM). currently the two singals
> > do the same in unit anyway but comments suggest it is intended for a
> > graceful shutdown (not yet implemented). I don't think that will work
> > very well with rc.d anyway (rcctl restart will wait for shutdown,
> > so you either use 'fast shutdown' and kill active connections, or
> > use 'graceful' and have a gap while you stop accepting new connections
> > while draining old). So I think it might be better to drop the rc_stop
> > function.
> 
> Will take a look on that and let you know, thank you so much.
> 
> Two more questions from my side:
> 
> - the first one is related to support of different versions of
>   programming languages: i.e. lang/python supports three versions, 2.7,
>   3.8, and 3.9.  It's a bit unclear how to implement that, so I need
>   your guidance here;

We support one primary version at a time for each major python release.
So for 2.x it's now 2.7, but previously was 2.6, 2.5, ... And for 3.x it's
currently 3.8 and will move to 3.9 sometime when the rest of the ports
tree is ready.

Apart from the core python packages, we don't do builds for multiple
3.x versions. It is possible in an individual port to use an alternative
version but that is really a last resort (the only time I remember this
ever happening was holding back to py3.7 for blender and maybe some
other port needed by blender, because it was holding us back updating
to 3.8.. but this is not at all common).

If there's a particularly strong use case for providing a py27 unit
module then it would be possible to do that, but it's awkward to do that,
and we're trying to avoid adding any new ports using 2.7.

(Some people are building from ports with the default version set to
3.9 locally, some things work but others are broken, but this probably
gives them a way to run unit with 3.9 if they need - we can't really
handle that for packages though).

> - NGINX Unit supports PHP as well, to compile a corresponding NGINX
>   Unit's module a shared library support needs to be enabled.  That's
>   the `--enable-embed' configure option for php, and a couple of files
>   will be installed, a header file and a shared library.

Will need to have a think about how to handle that in ports, we already
build apache sapi (plus cli/cgi/fpm/phpdbg) and php doesn't support
multiple sapi in a single build, so the ports setup will need some
bigger changes to do this (and I think will probably mean building
php twice for each supported version).

> > Other than those, it builds and starts ok, I have run out of patience
> > trying to figure out how to configure to test runtime myself though
> > (I was looking for a simple static-file config but there is nothing
> > obvious). However the tests that I've enabled look promising (a couple
> > of F/E in test_perl_application.py and test_respawn.py, and a couple
> > of TLS-related ones, looks fairly minor).
> 
> NGINX Unit has an excellent tests suite and that one based on a recent
> version of pytest.  There's no static-file config, but it's possible to
> talk to NGINX Unit through a control socket in JSON format.

Oh I meant serving static-files, not file-based config (I understand
about the control socket) - the step-by-step examples at the top of the
quick start docs are for php which obviously isn't supported yet, 

Re: [NEW] www/unit

[Sergey A. Osokin]

Hi Stuart,

thank you very much for the review and updates.

On Mon, Oct 11, 2021 at 10:25:57PM +0100, Stuart Henderson wrote:

[...]

> Hi Sergey. Updated version attached, A few notes on my changes, there
> are probably some others too but this is what I remember:
> 
> - reduce unnecessary variables, the UNIT_xxx were only used to pass
> to configure and create directories in fake-install. The directory
> creation is pointless, so I dropped the variables and passed directly
> to configure.
> 
> - move libexec to lib. openbsd standard use for libexec is for
> executables invoked by some software. other similar ports use lib for
> plugin modules.
> 
> - /var/run and tmp are cleared at boot so must be created by the rc
> script, I added rc_pre. there is no point including them in the package
> because it gives a false sense that things will work after boot.
> 
> - tidy dependencies
> 
> - use a valid uid for @newuser/@newgroup lines
> 
> - enable tests
> 
> A couple of issues remain:
> 
> - ruby linkage looks a bit wrong, but I think that's on the ruby side
> not the unit side. the NEEDED ELF header in unit's ruby module is set to
> just "libruby30.so" and not "libruby30.so.0.0", I think this is probably
> due to the symlink in /usr/local/lib/libruby30.so -> libruby30.so.0.0
> and/or lack of SONAME in libruby30. Maybe another porter has an idea
> what to do with this though I think it's probably not a show-stopper..
> 
> - rc script nearly duplicates the standard rc_stop section but adds
> -QUIT instead of using the default (-TERM). currently the two singals
> do the same in unit anyway but comments suggest it is intended for a
> graceful shutdown (not yet implemented). I don't think that will work
> very well with rc.d anyway (rcctl restart will wait for shutdown,
> so you either use 'fast shutdown' and kill active connections, or
> use 'graceful' and have a gap while you stop accepting new connections
> while draining old). So I think it might be better to drop the rc_stop
> function.

Will take a look on that and let you know, thank you so much.

Two more questions from my side:

- the first one is related to support of different versions of
  programming languages: i.e. lang/python supports three versions, 2.7,
  3.8, and 3.9.  It's a bit unclear how to implement that, so I need
  your guidance here;

- NGINX Unit supports PHP as well, to compile a corresponding NGINX
  Unit's module a shared library support needs to be enabled.  That's
  the `--enable-embed' configure option for php, and a couple of files
  will be installed, a header file and a shared library.

> Other than those, it builds and starts ok, I have run out of patience
> trying to figure out how to configure to test runtime myself though
> (I was looking for a simple static-file config but there is nothing
> obvious). However the tests that I've enabled look promising (a couple
> of F/E in test_perl_application.py and test_respawn.py, and a couple
> of TLS-related ones, looks fairly minor).

NGINX Unit has an excellent tests suite and that one based on a recent
version of pytest.  There's no static-file config, but it's possible to
talk to NGINX Unit through a control socket in JSON format.

-- 
Sergey Osokin


signature.asc
Description: PGP signature

Re: [NEW] www/unit

[Stuart Henderson]

On 2021/10/11 19:24, Sergey A. Osokin wrote:
> On Wed, Oct 06, 2021 at 03:30:08AM +, Sergey A. Osokin wrote:
> > On Wed, Sep 22, 2021 at 08:49:06PM +0100, Stuart Henderson wrote:
> > > On 2021/09/22 13:34, Sergey A. Osokin wrote:
> > > > On Fri, Sep 17, 2021 at 03:20:16PM +, Sergey A. Osokin wrote:
> > > > 
> > > > P.S. Yes, I know you're busy with a preparation to the upcoming 7.0
> > > > and it's good time for fixes and probably not a best time for new
> > > > ports, but I want to let you know that www/unit builds very well
> > > > with new and shiny 7.0 yesterday snapshot.
> > > 
> > > yes, it's been no new imports for a week already.
> > > I will have a look again when I have time.
> > 
> > Seems like a liveness probe returns a positive signal after the
> > ports change freeze for the upcoming 7.0.
> > Is there any update?
> 
> Could you please provide an update.
> Thank you.
> 
> -- 
> Sergey Osokin


Hi Sergey. Updated version attached, A few notes on my changes, there
are probably some others too but this is what I remember:

- reduce unnecessary variables, the UNIT_xxx were only used to pass
to configure and create directories in fake-install. The directory
creation is pointless, so I dropped the variables and passed directly
to configure.

- move libexec to lib. openbsd standard use for libexec is for
executables invoked by some software. other similar ports use lib for
plugin modules.

- /var/run and tmp are cleared at boot so must be created by the rc
script, I added rc_pre. there is no point including them in the package
because it gives a false sense that things will work after boot.

- tidy dependencies

- use a valid uid for @newuser/@newgroup lines

- enable tests

A couple of issues remain:

- ruby linkage looks a bit wrong, but I think that's on the ruby side
not the unit side. the NEEDED ELF header in unit's ruby module is set to
just "libruby30.so" and not "libruby30.so.0.0", I think this is probably
due to the symlink in /usr/local/lib/libruby30.so -> libruby30.so.0.0
and/or lack of SONAME in libruby30. Maybe another porter has an idea
what to do with this though I think it's probably not a show-stopper..

- rc script nearly duplicates the standard rc_stop section but adds
-QUIT instead of using the default (-TERM). currently the two singals
do the same in unit anyway but comments suggest it is intended for a
graceful shutdown (not yet implemented). I don't think that will work
very well with rc.d anyway (rcctl restart will wait for shutdown,
so you either use 'fast shutdown' and kill active connections, or
use 'graceful' and have a gap while you stop accepting new connections
while draining old). So I think it might be better to drop the rc_stop
function.

Other than those, it builds and starts ok, I have run out of patience
trying to figure out how to configure to test runtime myself though
(I was looking for a simple static-file config but there is nothing
obvious). However the tests that I've enabled look promising (a couple
of F/E in test_perl_application.py and test_respawn.py, and a couple
of TLS-related ones, looks fairly minor).



unit.tgz
Description: application/tar-gz

Re: [NEW] www/unit

[Sergey A. Osokin]

On Wed, Oct 06, 2021 at 03:30:08AM +, Sergey A. Osokin wrote:
> On Wed, Sep 22, 2021 at 08:49:06PM +0100, Stuart Henderson wrote:
> > On 2021/09/22 13:34, Sergey A. Osokin wrote:
> > > On Fri, Sep 17, 2021 at 03:20:16PM +, Sergey A. Osokin wrote:
> > > 
> > > P.S. Yes, I know you're busy with a preparation to the upcoming 7.0
> > > and it's good time for fixes and probably not a best time for new
> > > ports, but I want to let you know that www/unit builds very well
> > > with new and shiny 7.0 yesterday snapshot.
> > 
> > yes, it's been no new imports for a week already.
> > I will have a look again when I have time.
> 
> Seems like a liveness probe returns a positive signal after the
> ports change freeze for the upcoming 7.0.
> Is there any update?

Could you please provide an update.
Thank you.

-- 
Sergey Osokin


signature.asc
Description: PGP signature

Re: [NEW] www/unit

[Sergey A. Osokin]

On Wed, Sep 22, 2021 at 08:49:06PM +0100, Stuart Henderson wrote:
> On 2021/09/22 13:34, Sergey A. Osokin wrote:
> > On Fri, Sep 17, 2021 at 03:20:16PM +, Sergey A. Osokin wrote:
> > 
> > P.S. Yes, I know you're busy with a preparation to the upcoming 7.0
> > and it's good time for fixes and probably not a best time for new
> > ports, but I want to let you know that www/unit builds very well
> > with new and shiny 7.0 yesterday snapshot.
> 
> yes, it's been no new imports for a week already.
> I will have a look again when I have time.

Seems like a liveness probe returns a positive signal after the
ports change freeze for the upcoming 7.0.
Is there any update?

Thank you.

-- 
Sergey Osokin


signature.asc
Description: PGP signature

Re: [NEW] www/unit

[Stuart Henderson]

On 2021/09/22 13:34, Sergey A. Osokin wrote:
> Hi,
> 
> On Fri, Sep 17, 2021 at 03:20:16PM +, Sergey A. Osokin wrote:
> 
> [...]
> 
> > > Updated the port followed by suggestions, could please take a look.
> > 
> > And one more.
> 
> Could you please provide an update.
> 
> P.S. Yes, I know you're busy with a preparation to the upcoming 7.0
> and it's good time for fixes and probably not a best time for new
> ports, but I want to let you know that www/unit builds very well
> with new and shiny 7.0 yesterday snapshot.

yes, it's been no new imports for a week already.
I will have a look again when I have time.

Re: [NEW] www/unit

[Sergey A. Osokin]

Hi,

On Fri, Sep 17, 2021 at 03:20:16PM +, Sergey A. Osokin wrote:

[...]

> > Updated the port followed by suggestions, could please take a look.
> 
> And one more.

Could you please provide an update.

P.S. Yes, I know you're busy with a preparation to the upcoming 7.0
and it's good time for fixes and probably not a best time for new
ports, but I want to let you know that www/unit builds very well
with new and shiny 7.0 yesterday snapshot.

Thank you.

-- 
Sergey Osokin


signature.asc
Description: PGP signature

Re: [NEW] www/unit

[Sergey A. Osokin]

On Thu, Sep 16, 2021 at 11:13:40PM +, Sergey A. Osokin wrote:
> On Thu, Sep 16, 2021 at 05:02:15PM +, Sergey A. Osokin wrote:
> > On Thu, Sep 16, 2021 at 05:47:19PM +0100, Stuart Henderson wrote:
> > > On 2021/09/16 16:05, Sergey A. Osokin wrote:
> > > > On Thu, Sep 16, 2021 at 04:00:08PM +0100, Stuart Henderson wrote:
> > > > > On 2021/09/16 14:46, Sergey A. Osokin wrote:
> > > > > > On Tue, Sep 07, 2021 at 12:56:03PM +, Sergey A. Osokin wrote:
> > 
> > [...]
> > 
> > > > NGINX Unit doesn't utilize perl-/python-/ruby-specific infrastructure,
> > > > it just install its own module for specific languages and their 
> > > > versions.
> > > 
> > > they are installed in a directory outside of /usr/local (the normal 
> > > PREFIX for
> > > ports/packages).
> 
> [...]
> 
> > And here's the example: on both FreeBSD and NetBSD it's
> > ${PREFIX}/libexec/unit/modules directory.
> 
> Updated the port followed by suggestions, could please take a look.

And one more.

-- 
Sergey Osokin


unit.tgz
Description: application/gtar-compressed


signature.asc
Description: PGP signature

Re: [NEW] www/unit

[Sergey A. Osokin]

On Thu, Sep 16, 2021 at 05:02:15PM +, Sergey A. Osokin wrote:
> On Thu, Sep 16, 2021 at 05:47:19PM +0100, Stuart Henderson wrote:
> > On 2021/09/16 16:05, Sergey A. Osokin wrote:
> > > On Thu, Sep 16, 2021 at 04:00:08PM +0100, Stuart Henderson wrote:
> > > > On 2021/09/16 14:46, Sergey A. Osokin wrote:
> > > > > On Tue, Sep 07, 2021 at 12:56:03PM +, Sergey A. Osokin wrote:
> 
> [...]
> 
> > > NGINX Unit doesn't utilize perl-/python-/ruby-specific infrastructure,
> > > it just install its own module for specific languages and their versions.
> > 
> > they are installed in a directory outside of /usr/local (the normal PREFIX 
> > for
> > ports/packages).

[...]

> And here's the example: on both FreeBSD and NetBSD it's
> ${PREFIX}/libexec/unit/modules directory.

Updated the port followed by suggestions, could please take a look.

-- 
Sergey Osokin


unit.tgz
Description: application/gtar-compressed

Re: [NEW] www/unit

[Sergey A. Osokin]

On Thu, Sep 16, 2021 at 05:47:19PM +0100, Stuart Henderson wrote:
> On 2021/09/16 16:05, Sergey A. Osokin wrote:
> > On Thu, Sep 16, 2021 at 04:00:08PM +0100, Stuart Henderson wrote:
> > > On 2021/09/16 14:46, Sergey A. Osokin wrote:
> > > > On Tue, Sep 07, 2021 at 12:56:03PM +, Sergey A. Osokin wrote:

[...]

> > NGINX Unit doesn't utilize perl-/python-/ruby-specific infrastructure,
> > it just install its own module for specific languages and their versions.
> 
> they are installed in a directory outside of /usr/local (the normal PREFIX for
> ports/packages).

True.  I've found that www/nginx installs its modules into /var/www/modules,
and that's why I did the same for NGINX Unit, last one installs its own
modules into /var/unit/modules.  Please confirm it's correct.

And if it's not correct, could you guide me where should I install
NGINX Unit modules.

And here's the example: on both FreeBSD and NetBSD it's
${PREFIX}/libexec/unit/modules directory.

> that should be handled by setting PREFIX-$subpkg rather than
> with what is essentially @cwd /var/www/unit/modules

That's a bit unclear, could you provide an example how can I handle that.

Thank you.

-- 
Sergey A. Osokin

Re: [NEW] www/unit

[Stuart Henderson]

On 2021/09/16 16:05, Sergey A. Osokin wrote:
> On Thu, Sep 16, 2021 at 04:00:08PM +0100, Stuart Henderson wrote:
> > On 2021/09/16 14:46, Sergey A. Osokin wrote:
> > > On Tue, Sep 07, 2021 at 12:56:03PM +, Sergey A. Osokin wrote:
> > > > Hi there,
> > > > 
> > > > I'm glad to share with you NGINX Unit port for OpenBSD has been created.
> > > > 
> > > > In addition to the port (it's been attached to this email as a tarball)
> > > > an additional user account `unit' and `unit' group are need to be 
> > > > created.
> > > > 
> > > > Please let me know your thoughts, ask questions, provide comments.
> > 
> > >From a read through (I have not tried building yet):
> > 
> > - usernames for ports daemons should be prefixed by _ and must be
> > created in the PLIST (@newuser / @newgroup annotations)
> 
> done.
> 
> > - the subpackages should just set PREFIX-python etc, don't use @cwd in
> > their PLISTs
> 
> NGINX Unit doesn't utilize perl-/python-/ruby-specific infrastructure,
> it just install its own module for specific languages and their versions.

they are installed in a directory outside of /usr/local (the normal PREFIX for
ports/packages). that should be handled by setting PREFIX-$subpkg rather than
with what is essentially @cwd /var/www/unit/modules




> > - lowercase at the start of COMMENT, unless it's a proper noun, i.e.
> > s/Dynamic/dynamic/ in COMMENT-main
> 
> done.
> 
> > - "include bsd.port.arch.mk" should be later. specifically it needs to go
> > after the FLAVOR ?=, but as it has hard to predict side-effects it's
> > better to have as few parts after it as possible, I would move to just
> > before the ".if ${BUILD_PACKAGES..." lines as those are the only parts
> > which require it.
> 
> done.
> 
> > - drop "DISTFILES=${DISTNAME}${EXTRACT_SUFX}", that is the default
> 
> done.
> 
> > - separate line for each *_DEPENDS entry i.e.  change
> > RUN_DEPENDS-python= www/unit,-main ${MODPY_LIB_DEPENDS}
> > to
> > RUN_DEPENDS-python= www/unit,-main \
> > ${MODPY_LIB_DEPENDS}
> 
> done.
> 
> > - there are specific variables for the binaries for python/ruby:
> > ${MODPY_BIN} and ${RUBY}, unless the configure script really doesn't
> > want a path please use them rather than building up your own in
> > CONFIGURE_ENV ${RUBY}
> 
> done.
> 
> I've also fixed some issues related to building and packaging.
> The updated version is attached, please take a look.
> 
> Thank you.
> 
> -- 
> Sergey A. Osokin

Re: [NEW] www/unit

[Sergey A. Osokin]

On Thu, Sep 16, 2021 at 04:00:08PM +0100, Stuart Henderson wrote:
> On 2021/09/16 14:46, Sergey A. Osokin wrote:
> > On Tue, Sep 07, 2021 at 12:56:03PM +, Sergey A. Osokin wrote:
> > > Hi there,
> > > 
> > > I'm glad to share with you NGINX Unit port for OpenBSD has been created.
> > > 
> > > In addition to the port (it's been attached to this email as a tarball)
> > > an additional user account `unit' and `unit' group are need to be created.
> > > 
> > > Please let me know your thoughts, ask questions, provide comments.
> 
> >From a read through (I have not tried building yet):
> 
> - usernames for ports daemons should be prefixed by _ and must be
> created in the PLIST (@newuser / @newgroup annotations)

done.

> - the subpackages should just set PREFIX-python etc, don't use @cwd in
> their PLISTs

NGINX Unit doesn't utilize perl-/python-/ruby-specific infrastructure,
it just install its own module for specific languages and their versions.

> - lowercase at the start of COMMENT, unless it's a proper noun, i.e.
> s/Dynamic/dynamic/ in COMMENT-main

done.

> - "include bsd.port.arch.mk" should be later. specifically it needs to go
> after the FLAVOR ?=, but as it has hard to predict side-effects it's
> better to have as few parts after it as possible, I would move to just
> before the ".if ${BUILD_PACKAGES..." lines as those are the only parts
> which require it.

done.

> - drop "DISTFILES=${DISTNAME}${EXTRACT_SUFX}", that is the default

done.

> - separate line for each *_DEPENDS entry i.e.  change
> RUN_DEPENDS-python= www/unit,-main ${MODPY_LIB_DEPENDS}
> to
> RUN_DEPENDS-python= www/unit,-main \
>   ${MODPY_LIB_DEPENDS}

done.

> - there are specific variables for the binaries for python/ruby:
> ${MODPY_BIN} and ${RUBY}, unless the configure script really doesn't
> want a path please use them rather than building up your own in
> CONFIGURE_ENV ${RUBY}

done.

I've also fixed some issues related to building and packaging.
The updated version is attached, please take a look.

Thank you.

-- 
Sergey A. Osokin


unit.tgz
Description: application/gtar-compressed

Re: [NEW] www/unit

[Stuart Henderson]

On 2021/09/16 14:46, Sergey A. Osokin wrote:
> Hi,
> 
> kindly reminder.
> Please let me know if you have any questions.
> 
> Thank you.
> 
> On Tue, Sep 07, 2021 at 12:56:03PM +, Sergey A. Osokin wrote:
> > Hi there,
> > 
> > I'm glad to share with you NGINX Unit port for OpenBSD has been created.
> > 
> > In addition to the port (it's been attached to this email as a tarball)
> > an additional user account `unit' and `unit' group are need to be created.
> > 
> > Please let me know your thoughts, ask questions, provide comments.
> 
> -- 
> Sergey Osokin



>From a read through (I have not tried building yet):

- usernames for ports daemons should be prefixed by _ and must be
created in the PLIST (@newuser / @newgroup annotations)

- the subpackages should just set PREFIX-python etc, don't use @cwd in
their PLISTs

- lowercase at the start of COMMENT, unless it's a proper noun, i.e.
s/Dynamic/dynamic/ in COMMENT-main

- "include bsd.port.arch.mk" should be later. specifically it needs to go
after the FLAVOR ?=, but as it has hard to predict side-effects it's
better to have as few parts after it as possible, I would move to just
before the ".if ${BUILD_PACKAGES..." lines as those are the only parts
which require it.

- drop "DISTFILES=${DISTNAME}${EXTRACT_SUFX}", that is the default

- separate line for each *_DEPENDS entry i.e.  change
RUN_DEPENDS-python= www/unit,-main ${MODPY_LIB_DEPENDS}
to
RUN_DEPENDS-python= www/unit,-main \
${MODPY_LIB_DEPENDS}

- there are specific variables for the binaries for python/ruby:
${MODPY_BIN} and ${RUBY}, unless the configure script really doesn't
want a path please use them rather than building up your own in
CONFIGURE_ENV ${RUBY}

Re: [NEW] www/unit

[Sergey A. Osokin]

Hi,

kindly reminder.
Please let me know if you have any questions.

Thank you.

On Tue, Sep 07, 2021 at 12:56:03PM +, Sergey A. Osokin wrote:
> Hi there,
> 
> I'm glad to share with you NGINX Unit port for OpenBSD has been created.
> 
> In addition to the port (it's been attached to this email as a tarball)
> an additional user account `unit' and `unit' group are need to be created.
> 
> Please let me know your thoughts, ask questions, provide comments.

-- 
Sergey Osokin


signature.asc
Description: PGP signature

Re: [NEW] www/unit

[Sergey A. Osokin]

Hi Stuart,

thanks for the update.

On Wed, Sep 08, 2021 at 02:49:10PM +0100, Stuart Henderson wrote:
> It is only about 24h since you posted your first message. Have patience.

Please let me know if you have any questions.

-- 
Sergey Osokin

Re: [NEW] www/unit

[Stuart Henderson]

It is only about 24h since you posted your first message. Have patience.

On 2021/09/08 13:19, Sergey A. Osokin wrote:
> Hi,
> 
> could you please provide an update.
> Thank you.
> 
> -- 
> Sergey Osokin
> 
> On Tue, Sep 07, 2021 at 12:56:03PM +, Sergey A. Osokin wrote:
> > Hi there,
> > 
> > I'm glad to share with you NGINX Unit port for OpenBSD has been created.
> > 
> > In addition to the port (it's been attached to this email as a tarball)
> > an additional user account `unit' and `unit' group are need to be created.
> > 
> > Please let me know your thoughts, ask questions, provide comments.
> 

Re: [NEW] www/unit

[Sergey A. Osokin]

Hi,

could you please provide an update.
Thank you.

-- 
Sergey Osokin

On Tue, Sep 07, 2021 at 12:56:03PM +, Sergey A. Osokin wrote:
> Hi there,
> 
> I'm glad to share with you NGINX Unit port for OpenBSD has been created.
> 
> In addition to the port (it's been attached to this email as a tarball)
> an additional user account `unit' and `unit' group are need to be created.
> 
> Please let me know your thoughts, ask questions, provide comments.

[NEW] www/unit

[Sergey A. Osokin]

Hi there,

I'm glad to share with you NGINX Unit port for OpenBSD has been created.

In addition to the port (it's been attached to this email as a tarball)
an additional user account `unit' and `unit' group are need to be created.

Please let me know your thoughts, ask questions, provide comments.

Thank you.

-- 
Sergey Osokin


unit.tgz
Description: application/gtar-compressed