On Fri, Dec 02, 2016 at 02:37:28PM +0100, Sol??ne Rapenne wrote:
> Le 2016-11-29 17:58, Sol??ne Rapenne a ??crit??:
> > Hello,
> >
> > I got the game "The Tales of Maj'Eyal" to work on OpenBSD.
> >
> > It's a free/open-source game which is also could be paying to get
> > "expansions"
> > (if you look on Steam / GOG / Humble Bundle it costs a few ??? because
> > this
> > includes the expansion). Obviously, paid content is not provided in the
> > port.
> >
> > About the patches :
> >
> > 1. bootstrap/boot.lua and src/getself.c : the game needs to know where
> > are the
> > content files, on linux/FreeBSD/Windows/MAC it finds the location of the
> > executable with /proc or some other magic. I hardcoded the path as it's
> > not
> > possible on OpenBSD. The path is ${GAMEDIR} and is substituted during at
> > do-configure.
> >
> > 2. premake4.lua : adding include and libs directories
> >
> >
> > I named it t-engine but it may be better to name it tome. T-engine is
> > the name
> > of the engine but it comes with files to play ToME.
> >
> > There is a version of the sources without musics, maybe this could be
> > interesting to have a FLAVOR with no_music to have a reduced file usage
> > if
> > you don't want music.
>
> - removed compile flags -O3 and -fomit-frame-pointer
> - changed name of the binary and game directory from t-engine to tome
> - added verbose build
Hi,
first of thanks for the port. The game works great.
Some nitpicks:
- The dependency should be devel/premake4 according to the other thread;
- I am not sure about the license for this port. The game ships 22 license
files. Some of them seem bundled with the upstream repository hence
part of the produced binary. Not sure how to handle this? Maybe point
out in a comment the bundled libraries and where to find their
licenses and check through all the bundled ones if it still allows
to ship on CD;
- Running `make port-lib-depends-check` complains on missing:
WANTLIB += m png pthread vorbisfile
and extra SDL2_mixer.0;
- Maybe the port should be named games/tome4? Upstream has a history of redoing
the engine from scratch on new releases.
Personally I think defaulting to the port *with* the music files is the right
thing to do. The download without music is still above 200 megs so that means
eating up hdd storage of bulk builders for the benefit of the few people who
would like the game without music assets.
I went through unbundling lua from premake4 and I know how the end result looks
so I won't even suggest doing the same for tome.
Regards,
Adam
