Re: [UPDATE] audio/p5-Audio-MPD-Common 1.110550 -> 2.003 (Perl+MPD 4/5)

2019-02-28 Thread Charlene Wendling


Ping :) 

On Fri, 22 Feb 2019 23:37:33 +0100
Charlene Wendling wrote:

> On Thu, 21 Feb 2019 23:22:37 +0100
> Charlene Wendling wrote:
> 
> > 
> > Here is an update for Audio::MPD::Common. You'll need the new
> > devel/p5-String-Formatter i've mailed earlier.
> > 
> > What's new upstream (partial, see [1]): 
> > 
> > - Accounting changes to the mpd API
> > - Various bug fixes
> > 
> > Port-wise, i've just dropped the unneeded CPAN_AUTHOR and cleaned
> > RUN_DEPENDS. 
> > 
> > Testing: 
> > 
> > - 'make test' passes. We don't have Pod::Coverage::TrustPod, so 
> >   qa tests would fail.
> > - There are 2 consumers, audio/p5-Audio-MPD and
> >   audio/p5-POE-Component-Client-MPD, they pass as well. 
> > 
> > Any comment? 
> > 
> > Charlène. 
> > 
> > 
> > [1]
> > https://metacpan.org/changes/release/JQUELIN/Audio-MPD-Common-2.003
> > 
> 
> It has been OK'd by landry@ already, but like Audio::MPD, a 'cvs rm'
> was missing and a patch needs to be removed, here is the proper
> diff.  
> 
> OK to commit? 
> 
> Charlène.
> 
> 
> Index: Makefile
> ===
> RCS file: /cvs/ports/audio/p5-Audio-MPD-Common/Makefile,v
> retrieving revision 1.14
> diff -u -p -u -p -r1.14 Makefile
> --- Makefile  20 Mar 2016 19:56:06 -  1.14
> +++ Makefile  22 Feb 2019 22:31:25 -
> @@ -2,8 +2,7 @@
>  
>  COMMENT= bunch of common helper classes for MPD
>  
> -DISTNAME=Audio-MPD-Common-1.110550
> -REVISION=2
> +DISTNAME=Audio-MPD-Common-2.003
>  CATEGORIES=  audio
>  
>  # perl
> @@ -11,13 +10,13 @@ PERMIT_PACKAGE_CDROM= Yes
>  
>  MODULES= cpan
>  PKG_ARCH=*
> -CPAN_AUTHOR= JQUELIN
>  
>  CONFIGURE_STYLE= modbuild
>  
> -RUN_DEPENDS= devel/p5-Class-Accessor \
> +RUN_DEPENDS= devel/p5-Moose>=0.92 \
>   devel/p5-MooseX-Has-Sugar \
>   devel/p5-MooseX-Types \
> - devel/p5-Readonly
> + devel/p5-Readonly \
> + devel/p5-String-Formatter
>  
>  .include 
> Index: distinfo
> ===
> RCS file: /cvs/ports/audio/p5-Audio-MPD-Common/distinfo,v
> retrieving revision 1.7
> diff -u -p -u -p -r1.7 distinfo
> --- distinfo  18 Jan 2015 03:12:46 -  1.7
> +++ distinfo  22 Feb 2019 22:31:25 -
> @@ -1,2 +1,2 @@
> -SHA256 (Audio-MPD-Common-1.110550.tar.gz) =
> tTOzDvncQW7A66e9w9/t3c9WvAwP58iTUojehPau1d4= -SIZE
> (Audio-MPD-Common-1.110550.tar.gz) = 19418 +SHA256
> (Audio-MPD-Common-2.003.tar.gz) =
> 0bWc1ni7FJwlkVh7SPSlJbK0DTtcBH3eyKn1fP7atqQ= +SIZE
> (Audio-MPD-Common-2.003.tar.gz) = 22569 Index:
> patches/patch-lib_Audio_MPD_Common_Types_pm
> ===
> RCS file: patches/patch-lib_Audio_MPD_Common_Types_pm diff -N
> patches/patch-lib_Audio_MPD_Common_Types_pm
> --- patches/patch-lib_Audio_MPD_Common_Types_pm   17 Apr 2014
> 20:51:25 -1.1 +++ /dev/null   1 Jan 1970 00:00:00
> - @@ -1,16 +0,0 @@
> -$OpenBSD: patch-lib_Audio_MPD_Common_Types_pm,v 1.1 2014/04/17
> 20:51:25 landry Exp $ -
> -https://rt.cpan.org/Public/Bug/Display.html?id=90670
> -https://github.com/zoffixznet/audio-mpd-common/commit/351d454b093927ce204acfa5f8a4c4bb393578f9
> -
>  lib/Audio/MPD/Common/Types.pm.orig   Thu Apr 17 08:18:18
> 2014 -+++ lib/Audio/MPD/Common/Types.pm   Thu Apr 17 08:18:26
> 2014 -@@ -20,7 +20,7 @@ use Moose::Util::TypeConstraints;
> - 
> - use Audio::MPD::Common::Time;
> - 
> --enum 'State' => qw{ play stop pause };
> -+enum 'State' => [qw{ play stop pause }];
> - 
> - coerce 'Audio::MPD::Common::Time'
> - => from 'Str'
> 
> 



Re: [UPDATE] audio/p5-Audio-MPD-Common 1.110550 -> 2.003 (Perl+MPD 4/5)

2019-02-22 Thread Charlene Wendling
On Thu, 21 Feb 2019 23:22:37 +0100
Charlene Wendling wrote:

> 
> Here is an update for Audio::MPD::Common. You'll need the new
> devel/p5-String-Formatter i've mailed earlier.
> 
> What's new upstream (partial, see [1]): 
> 
> - Accounting changes to the mpd API
> - Various bug fixes
> 
> Port-wise, i've just dropped the unneeded CPAN_AUTHOR and cleaned
> RUN_DEPENDS. 
> 
> Testing: 
> 
> - 'make test' passes. We don't have Pod::Coverage::TrustPod, so 
>   qa tests would fail.
> - There are 2 consumers, audio/p5-Audio-MPD and
>   audio/p5-POE-Component-Client-MPD, they pass as well. 
> 
> Any comment? 
> 
> Charlène. 
> 
> 
> [1]
> https://metacpan.org/changes/release/JQUELIN/Audio-MPD-Common-2.003
> 

It has been OK'd by landry@ already, but like Audio::MPD, a 'cvs rm' was
missing and a patch needs to be removed, here is the proper diff.  

OK to commit? 

Charlène.


Index: Makefile
===
RCS file: /cvs/ports/audio/p5-Audio-MPD-Common/Makefile,v
retrieving revision 1.14
diff -u -p -u -p -r1.14 Makefile
--- Makefile20 Mar 2016 19:56:06 -  1.14
+++ Makefile22 Feb 2019 22:31:25 -
@@ -2,8 +2,7 @@
 
 COMMENT=   bunch of common helper classes for MPD
 
-DISTNAME=  Audio-MPD-Common-1.110550
-REVISION=  2
+DISTNAME=  Audio-MPD-Common-2.003
 CATEGORIES=audio
 
 # perl
@@ -11,13 +10,13 @@ PERMIT_PACKAGE_CDROM=   Yes
 
 MODULES=   cpan
 PKG_ARCH=  *
-CPAN_AUTHOR=   JQUELIN
 
 CONFIGURE_STYLE=   modbuild
 
-RUN_DEPENDS=   devel/p5-Class-Accessor \
+RUN_DEPENDS=   devel/p5-Moose>=0.92 \
devel/p5-MooseX-Has-Sugar \
devel/p5-MooseX-Types \
-   devel/p5-Readonly
+   devel/p5-Readonly \
+   devel/p5-String-Formatter
 
 .include 
Index: distinfo
===
RCS file: /cvs/ports/audio/p5-Audio-MPD-Common/distinfo,v
retrieving revision 1.7
diff -u -p -u -p -r1.7 distinfo
--- distinfo18 Jan 2015 03:12:46 -  1.7
+++ distinfo22 Feb 2019 22:31:25 -
@@ -1,2 +1,2 @@
-SHA256 (Audio-MPD-Common-1.110550.tar.gz) = 
tTOzDvncQW7A66e9w9/t3c9WvAwP58iTUojehPau1d4=
-SIZE (Audio-MPD-Common-1.110550.tar.gz) = 19418
+SHA256 (Audio-MPD-Common-2.003.tar.gz) = 
0bWc1ni7FJwlkVh7SPSlJbK0DTtcBH3eyKn1fP7atqQ=
+SIZE (Audio-MPD-Common-2.003.tar.gz) = 22569
Index: patches/patch-lib_Audio_MPD_Common_Types_pm
===
RCS file: patches/patch-lib_Audio_MPD_Common_Types_pm
diff -N patches/patch-lib_Audio_MPD_Common_Types_pm
--- patches/patch-lib_Audio_MPD_Common_Types_pm 17 Apr 2014 20:51:25 -  
1.1
+++ /dev/null   1 Jan 1970 00:00:00 -
@@ -1,16 +0,0 @@
-$OpenBSD: patch-lib_Audio_MPD_Common_Types_pm,v 1.1 2014/04/17 20:51:25 landry 
Exp $
-
-https://rt.cpan.org/Public/Bug/Display.html?id=90670
-https://github.com/zoffixznet/audio-mpd-common/commit/351d454b093927ce204acfa5f8a4c4bb393578f9
-
 lib/Audio/MPD/Common/Types.pm.orig Thu Apr 17 08:18:18 2014
-+++ lib/Audio/MPD/Common/Types.pm  Thu Apr 17 08:18:26 2014
-@@ -20,7 +20,7 @@ use Moose::Util::TypeConstraints;
- 
- use Audio::MPD::Common::Time;
- 
--enum 'State' => qw{ play stop pause };
-+enum 'State' => [qw{ play stop pause }];
- 
- coerce 'Audio::MPD::Common::Time'
- => from 'Str'




[UPDATE] audio/p5-Audio-MPD-Common 1.110550 -> 2.003 (Perl+MPD 4/5)

2019-02-21 Thread Charlene Wendling


Here is an update for Audio::MPD::Common. You'll need the new
devel/p5-String-Formatter i've mailed earlier.

What's new upstream (partial, see [1]): 

- Accounting changes to the mpd API
- Various bug fixes

Port-wise, i've just dropped the unneeded CPAN_AUTHOR and cleaned
RUN_DEPENDS. 

Testing: 

- 'make test' passes. We don't have Pod::Coverage::TrustPod, so 
  qa tests would fail.
- There are 2 consumers, audio/p5-Audio-MPD and
  audio/p5-POE-Component-Client-MPD, they pass as well. 

Any comment? 

Charlène. 


[1] https://metacpan.org/changes/release/JQUELIN/Audio-MPD-Common-2.003


Index: Makefile
===
RCS file: /cvs/ports/audio/p5-Audio-MPD-Common/Makefile,v
retrieving revision 1.14
diff -u -p -u -p -r1.14 Makefile
--- Makefile20 Mar 2016 19:56:06 -  1.14
+++ Makefile21 Feb 2019 20:57:42 -
@@ -2,8 +2,7 @@
 
 COMMENT=   bunch of common helper classes for MPD
 
-DISTNAME=  Audio-MPD-Common-1.110550
-REVISION=  2
+DISTNAME=  Audio-MPD-Common-2.003
 CATEGORIES=audio
 
 # perl
@@ -11,13 +10,13 @@ PERMIT_PACKAGE_CDROM=   Yes
 
 MODULES=   cpan
 PKG_ARCH=  *
-CPAN_AUTHOR=   JQUELIN
 
 CONFIGURE_STYLE=   modbuild
 
-RUN_DEPENDS=   devel/p5-Class-Accessor \
+RUN_DEPENDS=   devel/p5-Moose>=0.92 \
devel/p5-MooseX-Has-Sugar \
devel/p5-MooseX-Types \
-   devel/p5-Readonly
+   devel/p5-Readonly \
+   devel/p5-String-Formatter
 
 .include 
Index: distinfo
===
RCS file: /cvs/ports/audio/p5-Audio-MPD-Common/distinfo,v
retrieving revision 1.7
diff -u -p -u -p -r1.7 distinfo
--- distinfo18 Jan 2015 03:12:46 -  1.7
+++ distinfo21 Feb 2019 20:57:42 -
@@ -1,2 +1,2 @@
-SHA256 (Audio-MPD-Common-1.110550.tar.gz) = 
tTOzDvncQW7A66e9w9/t3c9WvAwP58iTUojehPau1d4=
-SIZE (Audio-MPD-Common-1.110550.tar.gz) = 19418
+SHA256 (Audio-MPD-Common-2.003.tar.gz) = 
0bWc1ni7FJwlkVh7SPSlJbK0DTtcBH3eyKn1fP7atqQ=
+SIZE (Audio-MPD-Common-2.003.tar.gz) = 22569