Re: [UPDATE] mail/spampd 2.30 -> 2.51 + fix boot issue

2018-08-25 Thread Henrik Friedrichsen
On Fri, Aug 24, 2018 at 02:16:31PM -0400, trondd wrote:
> I'd love to get update in for 6.4 as it fixes a long standing issue with 
> spampd
> failing to start correctly via rc at boot time.

I second that notion. Thanks again, looks good to me.



Re: [UPDATE] mail/spampd 2.30 -> 2.51 + fix boot issue

2018-08-24 Thread Josh Grosse
On Fri, Aug 24, 2018 at 02:16:31PM -0400, trondd wrote:
> I'd love to get update in for 6.4 as it fixes a long standing issue with 
> spampd
> failing to start correctly via rc at boot time.
> 
> Tim.

Seems to be working here. Tested on my personal MTA,  an amd64 6.3-release 
system.
(I am not running any MTAs on -current at the moment)



[UPDATE] mail/spampd 2.30 -> 2.51 + fix boot issue

2018-08-24 Thread trondd
I'd love to get update in for 6.4 as it fixes a long standing issue with spampd
failing to start correctly via rc at boot time.

Tim.


 Original Message 
Date: Fri, 24 Aug 2018 11:27:00 +0200
From: Henrik Friedrichsen 
To: trondd 
Subject: Re: [UPDATE] mail/spampd 2.30 -> 2.51 + fix boot issue

Hey Tim,

thanks for your mail. Indeed, I missed the last updates because I kept
checking the project website and not the GitHub repository.

The diff looks good to me. Would you like to post this to ports@ and I
give my 'ok'

Cheers,
Henrik

On Thu, Aug 23, 2018 at 08:24:40PM -0400, trondd wrote:
> Hi Henrik.
> 
> I've put together an update to spampd as it's quite out of date.  Releases
> moved to GitHub so that's probably why they have been missed.  Thanks to Sumit
> Khanna for lighting the fire to fix the start up issue[0] and Max Paperno who
> maintains SpamPD for his responsive fix[1].  I have patched the fix into the
> latest release as I hope to get this in for 6.4 and don't want to wait for an
> official release.
> 
> Can we get tis submitted to ports@ and try to get it infor 64?
> 
> Thanks.
> Tim.
> 
> 
> 2.30 through 2.51 changelog:
> 
> 2.51 (01-May-18)
> 
> - Fix listening to IP address, broken in 2.50 "Unix ports" feature.  (#18)
> - Add --setsid option to start server with setsid if running in background 
> (#18)
> 
> 2.50 (30-Apr-18)
> 
> - Replace IO::Socket::INET with IO::Socket::IP for IPv6 support (#9).
> - Unix ports (ability to listen on UNIX sockets) (#13).
> - Add X-Envelope-* headers before Received (#14).
> - Add /usr/local/bin and /usr/local/sbin to PATH (#17).
> 
> Please refer to commit notes at
> (https://github.com/mpaperno/spampd/compare/2.42...2.50) for details and 
> credits.
> 
> 2.42 (08-Dec-13) (experimental)
> 
> - Untaint some params for compatibility with Perl 5.18.
> 
> 2.41 (11-Aug-10) (experimental)
> 
> - Added setting of user name at SA init time.
> 
> 2.40 (10-Jan-09) (experimental)
> 
> - New config option to load a specific configuration file after the default
>   local.cf file, thereby overriding any settings therein.  The new option is
>   --saconfig=filename. Thanks to Sven Mueller for code and Bernd Zeimetz for 
>   bringing it up. (http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=344373)
>   
> - Integrated code by Alexander Wirt to introduce a parameter which
>   sets a proper home directory (--homedir=path) and also cleans up the 
>   environment before backgrounding. 
>   (http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=421100)
>   * NOTE: * default homedir is /var/spool/spamassassin/spampd which needs to 
> be 
>   writable by the user spampd is running as.  Previously, some files like the
>   auto-whitelist were written to the .spamassassin folder inside the users 
> home
>   directory who started spampd, typically root.
>   
> - Integrated fix from Vladislav Kurz for LMTP multi-line response after DATA
>   is sent. (http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=395355)
>   
> - Yet another fix for older Net::Server versions (<= 0.87) dying when logging 
>   a % character to Sys::Syslog. This also fixes the bug in 2.30 that logs "%s"
>   instead of the actual messages on some system.
>   
> - Fixed bug with temp files sticking around until spampd child exists, 
>   introduced when SA 3.0 was released 
>   (https://issues.apache.org/SpamAssassin/show_bug.cgi?id=5444).
> Thanks to Simon Matter for bringing this to my attention.
> 
> 
> 
> [0] https://penguindreams.org/blog/openbsd-spampd-and-the-startup-bug/
> [1] https://github.com/mpaperno/spampd/issues/19


Index: Makefile
===
RCS file: /cvs/ports/mail/spampd/Makefile,v
retrieving revision 1.7
diff -u -p -r1.7 Makefile
--- Makefile11 Jan 2018 19:27:04 -  1.7
+++ Makefile23 Aug 2018 23:54:39 -
@@ -2,8 +2,9 @@
 
 COMMENT=   SMTP/LMTP proxy for Spamassassin
 
-DISTNAME=  spampd-2.30
-REVISION=  4
+GH_ACCOUNT=mpaperno
+GH_PROJECT=spampd
+GH_TAGNAME=2.51
 
 CATEGORIES=mail
 
@@ -13,8 +14,6 @@ MAINTAINER=   Henrik Friedrichsen http://www.worlddesign.com/Content/rd/mta/spampd/
-
 RUN_DEPENDS=   devel/p5-Net-Server \
mail/p5-Mail-SpamAssassin
 
@@ -24,8 +23,8 @@ NO_TEST=  Yes
 
 do-install:
cd ${WRKSRC} && \
-   pod2man --section=8 --center="Spam Proxy Daemon" spampd > 
spampd.8
+   pod2man --section=8 --center="Spam Proxy Daemon" spampd.pl > 
spampd.8
${INSTALL_MAN} ${WRKBUILD}/spampd.8 ${PREFIX}/man/man8/spampd.8