Re: [UPDATE] print/lyx 2.2.3 -> 2.3.1

[Stuart Henderson]

On 2018/11/28 14:06, Elias M. Mariani wrote:
> Modifications:
> - Changed from textproc/enchant to  textproc/enchant2.
> - Added x11/qt5/qtx11extras to LIB_DEPENDS.
> - Configure picked up new WANTLIBs: xcb Qt5X11Extras
> 
> I love cmake way more than gnu configure...
> std::regex is been used instead of boost::regex, do we have archs without 
> C++11?

landisk and m88k, but I don't think they matter in this case.

I've tested that it also builds ok with ports-gcc (requires hunspell to
also be built with ports-gcc in that case).

looks good to me -> committing shortly.

Re: [UPDATE] print/lyx 2.2.3 -> 2.3.1

[Josh Grosse]

On Wed, Nov 28, 2018 at 02:06:08PM -0300, Elias M. Mariani wrote:
> Modifications:
> - Changed from textproc/enchant to  textproc/enchant2.
> - Added x11/qt5/qtx11extras to LIB_DEPENDS.
> - Configure picked up new WANTLIBs: xcb Qt5X11Extras
> 

Works for me on both amd64 and i386. :)

Re: [UPDATE] print/lyx 2.2.3 -> 2.3.1

[Elias M. Mariani]

Modifications:
- Changed from textproc/enchant to  textproc/enchant2.
- Added x11/qt5/qtx11extras to LIB_DEPENDS.
- Configure picked up new WANTLIBs: xcb Qt5X11Extras

I love cmake way more than gnu configure...
std::regex is been used instead of boost::regex, do we have archs without C++11?

Cheers.
Elias.
On Tue, Nov 27, 2018 at 10:58 PM Elias M. Mariani
 wrote:
>
> On Tue, Nov 27, 2018 at 9:03 PM Josh Grosse  wrote:
> > The only thing I noticed was this port-lib-depends-check complaint:
> >
> >Missing lib: enchant-2.0 (/usr/local/bin/lyx) (NOT REACHABLE)
> >Extra:  enchant.6
> Oh, I see.
> I build with textproc/enchant and you have installed
> textproc/enchant2, so probably the configuration is picking in your
> case the newer library.
> I will send a new diff tomorrow using textproc/enchant2, it has more
> sense than using enchant.
>
> Thanks for the report!
> Elias.


lyx-2.3.1.diff
Description: Binary data

Re: [UPDATE] print/lyx 2.2.3 -> 2.3.1

[Elias M. Mariani]

On Tue, Nov 27, 2018 at 9:03 PM Josh Grosse  wrote:
> The only thing I noticed was this port-lib-depends-check complaint:
>
>Missing lib: enchant-2.0 (/usr/local/bin/lyx) (NOT REACHABLE)
>Extra:  enchant.6
Oh, I see.
I build with textproc/enchant and you have installed
textproc/enchant2, so probably the configuration is picking in your
case the newer library.
I will send a new diff tomorrow using textproc/enchant2, it has more
sense than using enchant.

Thanks for the report!
Elias.

Re: [UPDATE] print/lyx 2.2.3 -> 2.3.1

[Josh Grosse]

On Tue, Nov 27, 2018 at 05:17:32PM -0300, Elias M. Mariani wrote:
> Changes port-wise:
> - Changed from qt4 to qt5.
> - Removed a patch no longer needed.
> - New patch needed for the case when sizeof(long long) == sizeof(long).
> - Take MAINTAINER.
> - Removed files/lyx.desktop, 2.3.1 comes with one already.
> - Added textproc/hunspell support.

Thank you, Elias.

I'm not a big Lyx user, so I did minimal testing on both i386 and amd64.
It runs on both.  

The only thing I noticed was this port-lib-depends-check complaint:

   Missing lib: enchant-2.0 (/usr/local/bin/lyx) (NOT REACHABLE)
   Extra:  enchant.6

[UPDATE] print/lyx 2.2.3 -> 2.3.1

[Elias M. Mariani]

Changes port-wise:
- Changed from qt4 to qt5.
- Removed a patch no longer needed.
- New patch needed for the case when sizeof(long long) == sizeof(long).
- Take MAINTAINER.
- Removed files/lyx.desktop, 2.3.1 comes with one already.
- Added textproc/hunspell support.

My concerns about the port:
- Need to test if it builds and runs in other archs, only amd64 tested
and I don't want to leave anyone without their lyx...
- I changed to qt5 because I like to use all from a single library if
possible, so changing to qt5 might be a personal bias given that I
maintain almost qt5 ports :), is there any problem with the change ?
- For some reason I require devel/boost to build and test lyx, but the
libraries from boost are not in WANTLIB, they are not required to run
the application, someone has an idea of why is that?
- I tried to use python3, it fails to run some scripts, so I
established python2 as mandatory. I know is the default, but I would
prefer to leave the:
MODPY_VERSION= ${MODPY_DEFAULT_VERSION_2}
So I remember that python3 is no good for now.
- Was there any reason why hunspell wasn't been used ?

Added some people to the CC that might be interested in the update for
what I saw in the list.

Anyways, I tried to explain all the changes, can I have you testing a
little bit ? :)

Cheers.
Elias.


lyx-2.3.1.diff
Description: Binary data