Re: [UPDATE] www/youtube-dl 2017.10.07 -> 2017.11.26

[Stuart Henderson]

On 2017/12/04 11:44, Paul Irofti wrote:
> 
> Regarding your regression tests changes, what were the results before
> switching to py3?

It was in an earlier mail -

py2:
> > >   FAILED (errors=568, failures=333)

py3:
> > FAILED (errors=563, failures=326)

Re: [UPDATE] www/youtube-dl 2017.10.07 -> 2017.11.26

[Stuart Henderson]

On 2017/12/01 15:07, Klemens Nanni wrote:
> On Fri, Dec 01, 2017 at 01:46:05PM +, Stuart Henderson wrote:
> > On 2017/12/01 14:34, Klemens Nanni wrote:
> > > On Sat, Nov 25, 2017 at 11:49:12PM +0100, Klemens Nanni wrote:
> > > > Simple version bump, here are the test results from my amd64 machine:
> > > > 
> > > > [...]
> > > > Ran 2242 tests in 5972.530s
> > > > 
> > > > FAILED (errors=568, failures=333)
> > > > 
> > > > Feedback? Any takers?
> > > Bump, here goes the new release which came out in the meantime.
> > 
> > This port has a maintainer, you should cc them on diffs.
> Sure, forgot to do it this time, sorry.
> > 
> > > If noone objects I'd like to add a Python 3 flavor (in a separate diff).
> > 
> > This is *just* intended as a CLI program not a library (and is packaged
> > as such; no py- prefix, etc). I don't see a separate flavour for py3
> > making much sense for this port. I would support switching to
> > MODPY_VERSION=${MODPY_DEFAULT_VERSION_3} though.
> I thought of flavors so users get a choice, but sure: I'm all in for
> defaulting it to Python 3.
> 
> Here's a new diff for that. FWIW, I'm currently running the test suite
> with Python 3.

OK with me. I haven't tried it with any exotic sites though, just youtube.

Re: [UPDATE] www/youtube-dl 2017.10.07 -> 2017.11.26

[Stuart Henderson]

On 2017/12/01 14:34, Klemens Nanni wrote:
> On Sat, Nov 25, 2017 at 11:49:12PM +0100, Klemens Nanni wrote:
> > Simple version bump, here are the test results from my amd64 machine:
> > 
> > [...]
> > Ran 2242 tests in 5972.530s
> > 
> > FAILED (errors=568, failures=333)
> > 
> > Feedback? Any takers?
> Bump, here goes the new release which came out in the meantime.

This port has a maintainer, you should cc them on diffs.

> If noone objects I'd like to add a Python 3 flavor (in a separate diff).

This is *just* intended as a CLI program not a library (and is packaged
as such; no py- prefix, etc). I don't see a separate flavour for py3
making much sense for this port. I would support switching to
MODPY_VERSION=${MODPY_DEFAULT_VERSION_3} though.

Re: [UPDATE] www/youtube-dl 2017.10.07 -> 2017.11.26

[Klemens Nanni]

On Sat, Nov 25, 2017 at 11:49:12PM +0100, Klemens Nanni wrote:
> Simple version bump, here are the test results from my amd64 machine:
> 
>   [...]
>   Ran 2242 tests in 5972.530s
>   
>   FAILED (errors=568, failures=333)
> 
> Feedback? Any takers?
Bump, here goes the new release which came out in the meantime.

If noone objects I'd like to add a Python 3 flavor (in a separate diff).
Feedback?

 www/youtube-dl/Makefile  |  2 +-
 www/youtube-dl/distinfo  |  4 ++--
 www/youtube-dl/pkg/PLIST | 26 --
 3 files changed, 19 insertions(+), 13 deletions(-)

diff --git a/www/youtube-dl/Makefile b/www/youtube-dl/Makefile
index f3e4ba9daf1..c435056ef9c 100644
--- a/www/youtube-dl/Makefile
+++ b/www/youtube-dl/Makefile
@@ -2,7 +2,7 @@
 
 COMMENT =  CLI program to download videos from YouTube and other sites
 
-VERSION =  2017.10.07
+VERSION =  2017.11.26
 MODPY_EGG_VERSION =${VERSION:S/.0/./g}
 
 DISTNAME = youtube-dl-${VERSION}
diff --git a/www/youtube-dl/distinfo b/www/youtube-dl/distinfo
index a4d02a19036..0d7387cef42 100644
--- a/www/youtube-dl/distinfo
+++ b/www/youtube-dl/distinfo
@@ -1,2 +1,2 @@
-SHA256 (youtube-dl-2017.10.07.tar.gz) = 
2aiTUIfB4vozB1lK4V8enqD4Z26CX6Z2pQo6PUcbuoM=
-SIZE (youtube-dl-2017.10.07.tar.gz) = 2816312
+SHA256 (youtube-dl-2017.11.26.tar.gz) = 
R9MK7InNJFa37nAmxmwO5PVqt9JwDESvJ74OAGJ9LVo=
+SIZE (youtube-dl-2017.11.26.tar.gz) = 2839867
diff --git a/www/youtube-dl/pkg/PLIST b/www/youtube-dl/pkg/PLIST
index 37cee20f64f..82cbec83bd5 100644
--- a/www/youtube-dl/pkg/PLIST
+++ b/www/youtube-dl/pkg/PLIST
@@ -413,16 +413,12 @@ 
lib/python${MODPY_VERSION}/site-packages/youtube_dl/extractor/fczenit.py
 lib/python${MODPY_VERSION}/site-packages/youtube_dl/extractor/fczenit.pyc
 lib/python${MODPY_VERSION}/site-packages/youtube_dl/extractor/filmon.py
 lib/python${MODPY_VERSION}/site-packages/youtube_dl/extractor/filmon.pyc
-lib/python${MODPY_VERSION}/site-packages/youtube_dl/extractor/firstpost.py
-lib/python${MODPY_VERSION}/site-packages/youtube_dl/extractor/firstpost.pyc
 lib/python${MODPY_VERSION}/site-packages/youtube_dl/extractor/firsttv.py
 lib/python${MODPY_VERSION}/site-packages/youtube_dl/extractor/firsttv.pyc
 lib/python${MODPY_VERSION}/site-packages/youtube_dl/extractor/fivemin.py
 lib/python${MODPY_VERSION}/site-packages/youtube_dl/extractor/fivemin.pyc
 lib/python${MODPY_VERSION}/site-packages/youtube_dl/extractor/fivetv.py
 lib/python${MODPY_VERSION}/site-packages/youtube_dl/extractor/fivetv.pyc
-lib/python${MODPY_VERSION}/site-packages/youtube_dl/extractor/fktv.py
-lib/python${MODPY_VERSION}/site-packages/youtube_dl/extractor/fktv.pyc
 lib/python${MODPY_VERSION}/site-packages/youtube_dl/extractor/flickr.py
 lib/python${MODPY_VERSION}/site-packages/youtube_dl/extractor/flickr.pyc
 lib/python${MODPY_VERSION}/site-packages/youtube_dl/extractor/flipagram.py
@@ -459,6 +455,8 @@ 
lib/python${MODPY_VERSION}/site-packages/youtube_dl/extractor/freshlive.py
 lib/python${MODPY_VERSION}/site-packages/youtube_dl/extractor/freshlive.pyc
 lib/python${MODPY_VERSION}/site-packages/youtube_dl/extractor/funimation.py
 lib/python${MODPY_VERSION}/site-packages/youtube_dl/extractor/funimation.pyc
+lib/python${MODPY_VERSION}/site-packages/youtube_dl/extractor/funk.py
+lib/python${MODPY_VERSION}/site-packages/youtube_dl/extractor/funk.pyc
 lib/python${MODPY_VERSION}/site-packages/youtube_dl/extractor/funnyordie.py
 lib/python${MODPY_VERSION}/site-packages/youtube_dl/extractor/funnyordie.pyc
 lib/python${MODPY_VERSION}/site-packages/youtube_dl/extractor/fusion.py
@@ -469,8 +467,6 @@ 
lib/python${MODPY_VERSION}/site-packages/youtube_dl/extractor/gameinformer.py
 lib/python${MODPY_VERSION}/site-packages/youtube_dl/extractor/gameinformer.pyc
 lib/python${MODPY_VERSION}/site-packages/youtube_dl/extractor/gameone.py
 lib/python${MODPY_VERSION}/site-packages/youtube_dl/extractor/gameone.pyc
-lib/python${MODPY_VERSION}/site-packages/youtube_dl/extractor/gamersyde.py
-lib/python${MODPY_VERSION}/site-packages/youtube_dl/extractor/gamersyde.pyc
 lib/python${MODPY_VERSION}/site-packages/youtube_dl/extractor/gamespot.py
 lib/python${MODPY_VERSION}/site-packages/youtube_dl/extractor/gamespot.pyc
 lib/python${MODPY_VERSION}/site-packages/youtube_dl/extractor/gamestar.py
@@ -489,6 +485,8 @@ 
lib/python${MODPY_VERSION}/site-packages/youtube_dl/extractor/giantbomb.py
 lib/python${MODPY_VERSION}/site-packages/youtube_dl/extractor/giantbomb.pyc
 lib/python${MODPY_VERSION}/site-packages/youtube_dl/extractor/giga.py
 lib/python${MODPY_VERSION}/site-packages/youtube_dl/extractor/giga.pyc
+lib/python${MODPY_VERSION}/site-packages/youtube_dl/extractor/gigya.py
+lib/python${MODPY_VERSION}/site-packages/youtube_dl/extractor/gigya.pyc
 lib/python${MODPY_VERSION}/site-packages/youtube_dl/extractor/glide.py
 lib/python${MODPY_VERSION}/site-packages/youtube_dl/extractor/glide.pyc
 lib/python${MODPY_VERSION}/site-packages/youtube_dl/extractor/globo.py
@@ -693,6 +691,8 @@