Re: [base-gcc] Unbreak devel/libpeas
On Thu, Nov 14, 2019 at 08:12:07PM +0200, Kurt Mosiejczuk wrote: > On Thu, Nov 14, 2019 at 07:42:28PM +0200, Kurt Mosiejczuk wrote: > > On Wed, Nov 13, 2019 at 02:11:59PM +0100, Charlene Wendling wrote: > > > > > http://build-failures.rhaalovely.net/sparc64/2019-11-08/devel/libpeas.log > > > > It's broken since the latest update. > > > > I did the same thing as i did with vte3, i just added an extra LDFLAG > > > for ld.bfd archs and it builds on macppc [0]. REVISION bump is unneeded, > > > this version never built on these archs. > > > > As i will also send a diff for libgweather, please note that fixing > > > those two will unlock a lot of gnome-related ports. Many will be broken > > > due to base-gcc being used by default for x11/gnome/*, and gnome using > > > C99/C11 constructs. That could be fixed if COMPILER was set the same way > > > x11/qt5 does across gnome ports. > > > > Comments/feedback are welcome, > > > Unfortunately, libpeas still blows up on my test box. > > Ignore this. Looks like I needed to do some updating on my test box. Another > attempt after doing so worked. Typical ninja non determinisic build :-/ -- Antoine
Re: [base-gcc] Unbreak devel/libpeas
On Wed, Nov 13, 2019 at 03:43:41PM +0100, Charlene Wendling wrote:
> On Wed, 13 Nov 2019 13:41:13 +
> Stuart Henderson wrote:
>
> > On 2019/11/13 14:11, Charlene Wendling wrote:
> > >
> > > > http://build-failures.rhaalovely.net/sparc64/2019-11-08/devel/libpeas.log
> > >
> > > It's broken since the latest update.
> > >
> > > I did the same thing as i did with vte3, i just added an extra
> > > LDFLAG for ld.bfd archs and it builds on macppc [0]. REVISION bump
> > > is unneeded, this version never built on these archs.
> > >
> > > As i will also send a diff for libgweather, please note that fixing
> > > those two will unlock a lot of gnome-related ports. Many will be
> > > broken due to base-gcc being used by default for x11/gnome/*, and
> > > gnome using C99/C11 constructs. That could be fixed if COMPILER was
> > > set the same way x11/qt5 does across gnome ports.
> > >
> > >
> > > Comments/feedback are welcome,
> > >
> > > Charlène.
> > >
> > >
> > > [0] https://bin.charlenew.xyz/libpeas.log
> > >
> > >
> > > Index: Makefile
> > > ===
> > > RCS file: /cvs/ports/devel/libpeas/Makefile,v
> > > retrieving revision 1.65
> > > diff -u -p -u -p -r1.65 Makefile
> > > --- Makefile 1 Nov 2019 19:44:13 - 1.65
> > > +++ Makefile 13 Nov 2019 12:52:42 -
> > > @@ -43,4 +43,10 @@ BUILD_DEPENDS +=lang/python/${MODPY_DEFA
> > > RUN_DEPENDS += lang/python/${MODPY_DEFAULT_VERSION_2} \
> > > devel/py-gobject3
> > >
> > > +# Fix X11-related undefined references errors on ld.bfd archs
> > > +.include
> > > +.if !${PROPERTIES:Mlld}
> > > +MODGNOME_LDFLAGS += -L${X11BASE}/lib
> > > +.endif
> > > +
> > > .include
> > >
> >
> > Any idea why it's happening (or why it's not needed for LLD)?
>
> Short answer: no.
>
> I _suspect_ that on ld.bfd side, -rpath and --*group flags are
> misbehaving, it's the common point between all these linker related
> failures on the 3 ld.bfd archs we build packages for.
>
> This is definitely not meson-related, see how rspamd fails on
> powerpc [1] once COMPILER is properly set.
>
> That's why i'm proposing this kind of change only on ports that have a
> fair number of rdeps.
>
> > I don't really like adding this across the tree, I think I'd be
> > happier with adding it in the module (probably unconditionally
> > because I don't think bsd.port.arch.mk is safe to add there) if that
> > doesn't cause other problems ...
>
> Agreed. On that point it's up to Antoine, i've built and run gnome
> months ago on powerpc [2], so i think it's worth it.
By "unconditionally", you mean unconditionally for legacy arches?
If so then sure, I don't care :-)
--
Antoine
Re: [base-gcc] Unbreak devel/libpeas
On Wed, 13 Nov 2019 13:41:13 +
Stuart Henderson wrote:
> On 2019/11/13 14:11, Charlene Wendling wrote:
> >
> > > http://build-failures.rhaalovely.net/sparc64/2019-11-08/devel/libpeas.log
> >
> > It's broken since the latest update.
> >
> > I did the same thing as i did with vte3, i just added an extra
> > LDFLAG for ld.bfd archs and it builds on macppc [0]. REVISION bump
> > is unneeded, this version never built on these archs.
> >
> > As i will also send a diff for libgweather, please note that fixing
> > those two will unlock a lot of gnome-related ports. Many will be
> > broken due to base-gcc being used by default for x11/gnome/*, and
> > gnome using C99/C11 constructs. That could be fixed if COMPILER was
> > set the same way x11/qt5 does across gnome ports.
> >
> >
> > Comments/feedback are welcome,
> >
> > Charlène.
> >
> >
> > [0] https://bin.charlenew.xyz/libpeas.log
> >
> >
> > Index: Makefile
> > ===
> > RCS file: /cvs/ports/devel/libpeas/Makefile,v
> > retrieving revision 1.65
> > diff -u -p -u -p -r1.65 Makefile
> > --- Makefile1 Nov 2019 19:44:13 - 1.65
> > +++ Makefile13 Nov 2019 12:52:42 -
> > @@ -43,4 +43,10 @@ BUILD_DEPENDS +=lang/python/${MODPY_DEFA
> > RUN_DEPENDS += lang/python/${MODPY_DEFAULT_VERSION_2} \
> > devel/py-gobject3
> >
> > +# Fix X11-related undefined references errors on ld.bfd archs
> > +.include
> > +.if !${PROPERTIES:Mlld}
> > +MODGNOME_LDFLAGS +=-L${X11BASE}/lib
> > +.endif
> > +
> > .include
> >
>
> Any idea why it's happening (or why it's not needed for LLD)?
Short answer: no.
I _suspect_ that on ld.bfd side, -rpath and --*group flags are
misbehaving, it's the common point between all these linker related
failures on the 3 ld.bfd archs we build packages for.
This is definitely not meson-related, see how rspamd fails on
powerpc [1] once COMPILER is properly set.
That's why i'm proposing this kind of change only on ports that have a
fair number of rdeps.
> I don't really like adding this across the tree, I think I'd be
> happier with adding it in the module (probably unconditionally
> because I don't think bsd.port.arch.mk is safe to add there) if that
> doesn't cause other problems ...
Agreed. On that point it's up to Antoine, i've built and run gnome
months ago on powerpc [2], so i think it's worth it.
Charlène.
[1] https://bin.charlenew.xyz/rspamd.log
[2] https://bsd.network/@julianaito/102065676125440442
Re: [base-gcc] Unbreak devel/libpeas
On 2019/11/13 14:11, Charlene Wendling wrote:
>
> > http://build-failures.rhaalovely.net/sparc64/2019-11-08/devel/libpeas.log
>
> It's broken since the latest update.
>
> I did the same thing as i did with vte3, i just added an extra LDFLAG
> for ld.bfd archs and it builds on macppc [0]. REVISION bump is unneeded,
> this version never built on these archs.
>
> As i will also send a diff for libgweather, please note that fixing
> those two will unlock a lot of gnome-related ports. Many will be broken
> due to base-gcc being used by default for x11/gnome/*, and gnome using
> C99/C11 constructs. That could be fixed if COMPILER was set the same way
> x11/qt5 does across gnome ports.
>
>
> Comments/feedback are welcome,
>
> Charlène.
>
>
> [0] https://bin.charlenew.xyz/libpeas.log
>
>
> Index: Makefile
> ===
> RCS file: /cvs/ports/devel/libpeas/Makefile,v
> retrieving revision 1.65
> diff -u -p -u -p -r1.65 Makefile
> --- Makefile 1 Nov 2019 19:44:13 - 1.65
> +++ Makefile 13 Nov 2019 12:52:42 -
> @@ -43,4 +43,10 @@ BUILD_DEPENDS +=lang/python/${MODPY_DEFA
> RUN_DEPENDS += lang/python/${MODPY_DEFAULT_VERSION_2} \
> devel/py-gobject3
>
> +# Fix X11-related undefined references errors on ld.bfd archs
> +.include
> +.if !${PROPERTIES:Mlld}
> +MODGNOME_LDFLAGS += -L${X11BASE}/lib
> +.endif
> +
> .include
>
Any idea why it's happening (or why it's not needed for LLD)?
I don't really like adding this across the tree, I think I'd be happier
with adding it in the module (probably unconditionally because I don't
think bsd.port.arch.mk is safe to add there) if that doesn't cause
other problems ...
[base-gcc] Unbreak devel/libpeas
> http://build-failures.rhaalovely.net/sparc64/2019-11-08/devel/libpeas.log
It's broken since the latest update.
I did the same thing as i did with vte3, i just added an extra LDFLAG
for ld.bfd archs and it builds on macppc [0]. REVISION bump is unneeded,
this version never built on these archs.
As i will also send a diff for libgweather, please note that fixing
those two will unlock a lot of gnome-related ports. Many will be broken
due to base-gcc being used by default for x11/gnome/*, and gnome using
C99/C11 constructs. That could be fixed if COMPILER was set the same way
x11/qt5 does across gnome ports.
Comments/feedback are welcome,
Charlène.
[0] https://bin.charlenew.xyz/libpeas.log
Index: Makefile
===
RCS file: /cvs/ports/devel/libpeas/Makefile,v
retrieving revision 1.65
diff -u -p -u -p -r1.65 Makefile
--- Makefile1 Nov 2019 19:44:13 - 1.65
+++ Makefile13 Nov 2019 12:52:42 -
@@ -43,4 +43,10 @@ BUILD_DEPENDS +=lang/python/${MODPY_DEFA
RUN_DEPENDS += lang/python/${MODPY_DEFAULT_VERSION_2} \
devel/py-gobject3
+# Fix X11-related undefined references errors on ld.bfd archs
+.include
+.if !${PROPERTIES:Mlld}
+MODGNOME_LDFLAGS +=-L${X11BASE}/lib
+.endif
+
.include
