*ping* Stefan Hagen wrote (2022-04-18 08:36 CEST): > I finally managed to track down why notion sporadically crashes and why > lua statusbars that invoke commands and read their stdout are (quite > frequently) erroring out with "Interrupted by system call" once there is > load on the system. > > The culprint is the missing SA_RESTART signal, which is needed when > doing file i/o in lua with popen(3). > > I'm removing the _XOPEN_SOURCE and _XOPEN_SOURCE_EXTENDED restrictions > to free up access to the signal, which is behind __XPG_VISIBLE >= 500. > > While the issue is more sporadic in notion itself, I can reliably > reproduce it by putting load on my system and let my statusbar popen a > shell script and read its stdout. > > OK?
I completely forgot about this because I have it in my local version. I would still like this to go in tree. I assume not many people are using this port, because you'd trip over this issue as soon as you try to show the output of a program or shell script in the status bar. While there: GH_* -> DIST_TUPLE. OK? Index: x11/notion/Makefile =================================================================== RCS file: /cvs/ports/x11/notion/Makefile,v diff -u -p -u -p -r1.2 Makefile --- x11/notion/Makefile 11 Mar 2022 20:16:49 -0000 1.2 +++ x11/notion/Makefile 21 Nov 2023 06:25:18 -0000 @@ -1,8 +1,7 @@ COMMENT= light, keyboard friendly static tiling window manager -GH_ACCOUNT= raboof -GH_PROJECT= notion -GH_TAGNAME= 4.0.2 +DIST_TUPLE= github raboof notion 4.0.2 . +REVISION= 0 CATEGORIES= x11 Index: x11/notion/distinfo =================================================================== RCS file: /cvs/ports/x11/notion/distinfo,v diff -u -p -u -p -r1.1.1.1 distinfo --- x11/notion/distinfo 22 Aug 2021 01:57:26 -0000 1.1.1.1 +++ x11/notion/distinfo 21 Nov 2023 06:25:18 -0000 @@ -1,2 +1,2 @@ -SHA256 (notion-4.0.2.tar.gz) = 3O/WINAo9lQcFYecPbIY3ggd986NLpy0/H3dm5JTtpg= -SIZE (notion-4.0.2.tar.gz) = 790842 +SHA256 (raboof-notion-4.0.2.tar.gz) = 3O/WINAo9lQcFYecPbIY3ggd986NLpy0/H3dm5JTtpg= +SIZE (raboof-notion-4.0.2.tar.gz) = 790842 Index: x11/notion/patches/patch-system-autodetect_mk =================================================================== RCS file: /cvs/ports/x11/notion/patches/patch-system-autodetect_mk,v diff -u -p -u -p -r1.2 patch-system-autodetect_mk --- x11/notion/patches/patch-system-autodetect_mk 11 Mar 2022 20:16:49 -0000 1.2 +++ x11/notion/patches/patch-system-autodetect_mk 21 Nov 2023 06:25:18 -0000 @@ -30,3 +30,12 @@ Index: system-autodetect.mk # Cygwin needs this. Also when you disable _BSD_SOURCE you may need it. #DEFINES += -DCF_NO_GETLOADAVG +@@ -205,7 +205,7 @@ POSIX_SOURCE?=-D_POSIX_C_SOURCE=200112L + BSD_SOURCE?=-D_BSD_SOURCE + + # Most systems +-XOPEN_SOURCE=-D_XOPEN_SOURCE -D_XOPEN_SOURCE_EXTENDED ++#XOPEN_SOURCE=-D_XOPEN_SOURCE -D_XOPEN_SOURCE_EXTENDED + # SunOS, (Irix) + #XOPEN_SOURCE=-D__EXTENSIONS__ +
