> http://build-failures.rhaalovely.net/aarch64/2019-08-16/games/puzzles.log
(no link to macppc build failure, landry has been a bit too much
aggressive while archiving failure logs)
Well, this is exactly what the report says, char being unsigned by
default on ppc and arm archs.
I decided to not remove -Werror while here - it has failed to build for
a legit reason this time. I will if asked to do so.
It builds and run fine on macppc [0] and amd64.
OK?
Charlène.
[0] https://bin.charlenew.xyz/puzzles.log
Index: Makefile
===
RCS file: /cvs/ports/games/puzzles/Makefile,v
retrieving revision 1.18
diff -u -p -u -p -r1.18 Makefile
--- Makefile12 Jul 2019 20:46:23 - 1.18
+++ Makefile17 Aug 2019 21:54:21 -
@@ -3,6 +3,7 @@
COMMENT = collection of puzzles games
DISTNAME = puzzles-20190415
+REVISION = 0
CATEGORIES = games
MASTER_SITES = https://rhaalovely.net/stuff/
Index: patches/patch-palisade_c
===
RCS file: patches/patch-palisade_c
diff -N patches/patch-palisade_c
--- /dev/null 1 Jan 1970 00:00:00 -
+++ patches/patch-palisade_c17 Aug 2019 21:54:21 -
@@ -0,0 +1,18 @@
+$OpenBSD$
+
+Fix for archs where char is unsigned by default (ppc, arm):
+error: result of comparison of constant -1 with expression of type
+'clue' (aka 'char')
+
+Index: palisade.c
+--- palisade.c.orig
palisade.c
+@@ -46,7 +46,7 @@ struct game_params {
+ int w, h, k;
+ };
+
+-typedef char clue;
++typedef signed char clue;
+ typedef unsigned char borderflag;
+
+ typedef struct shared_state {
