Re: [tobi...@tmux.org: mark net/rtorrent as broken on powerpc]
On 2015/07/31 15:53, Tobias Ulmer wrote:
Is David around? Any objections should be voiced in the next few hours,
before I commit this.
It's actually libtorrent not rtorrent that should be marked broken.
Would it be worth building on i386 with compiler flags to fix that,
at the expense of not running on crappy old machines that you probably
wouldn't want to run this on anyway?
Index: libtorrent/Makefile
===
RCS file: /cvs/ports/net/libtorrent/Makefile,v
retrieving revision 1.40
diff -u -p -r1.40 Makefile
--- libtorrent/Makefile 24 Mar 2015 13:35:09 - 1.40
+++ libtorrent/Makefile 31 Jul 2015 14:31:14 -
@@ -2,6 +2,10 @@
COMMENT= BitTorrent library written in C++
+BROKEN-hppa = undefined references to __sync atomic ops
+BROKEN-mips64 =undefined references to __sync atomic ops
+BROKEN-sh =undefined references to __sync atomic ops
+
# requires C++ tr1 headers
NOT_FOR_ARCHS= ${GCC3_ARCHS}
@@ -28,5 +32,13 @@ CONFIGURE_ARGS= ${CONFIGURE_SHARED} \
--with-kqueue \
--without-epoll \
--disable-debug
+
+.include bsd.port.arch.mk
+
+# for 64-bit atomic ops
+.if ${ARCH:Mi386}
+CFLAGS+= -march=i586 -fomit-frame-pointer
+CXXFLAGS+= -march=i586 -fomit-frame-pointer
+.endif
.include bsd.port.mk
Index: rtorrent/Makefile
===
RCS file: /cvs/ports/net/rtorrent/Makefile,v
retrieving revision 1.48
diff -u -p -r1.48 Makefile
--- rtorrent/Makefile 28 May 2015 10:17:24 - 1.48
+++ rtorrent/Makefile 31 Jul 2015 14:31:25 -
@@ -1,10 +1,5 @@
# $OpenBSD: Makefile,v 1.48 2015/05/28 10:17:24 pascal Exp $
-BROKEN-hppa = undefined references to __sync atomic ops
-BROKEN-mips64 =undefined references to __sync atomic ops
-BROKEN-sh =undefined references to __sync atomic ops
-BROKEN-i386 = 64-bit atomics (fetch_and_and, add_and_fetch)
-
COMMENT= ncurses BitTorrent client based on libTorrent
DISTNAME= rtorrent-0.9.4
Re: [tobi...@tmux.org: mark net/rtorrent as broken on powerpc]
On Fri, Jul 31, 2015 at 04:02:10PM +0200, David Coppa wrote: Il 31/lug/2015 15:53, Tobias Ulmer tobi...@tmux.org ha scritto: Is David around? Any objections should be voiced in the next few hours, before I commit this. Go ahead! Ah, so that explains why rtorrent on my macppc hasnt been updated in ages guess it's time to find another client.
[tobi...@tmux.org: mark net/rtorrent as broken on powerpc]
Is David around? Any objections should be voiced in the next few hours, before I commit this. - Forwarded message from Tobias Ulmer tobi...@tmux.org - Date: Thu, 30 Jul 2015 18:30:23 +0200 From: Tobias Ulmer tobi...@tmux.org To: dco...@openbsd.org Subject: mark net/rtorrent as broken on powerpc Mark broken and sort the list, no point in wasting cpu time ok? Index: Makefile === RCS file: /home/vcs/cvs/openbsd/ports/net/rtorrent/Makefile,v retrieving revision 1.48 diff -u -p -r1.48 Makefile --- Makefile28 May 2015 10:17:24 - 1.48 +++ Makefile30 Jul 2015 16:13:24 - @@ -1,9 +1,10 @@ # $OpenBSD: Makefile,v 1.48 2015/05/28 10:17:24 pascal Exp $ BROKEN-hppa = undefined references to __sync atomic ops +BROKEN-i386 = 64-bit atomics (fetch_and_and, add_and_fetch) BROKEN-mips64 =undefined references to __sync atomic ops +BROKEN-powerpc = undefined references to __sync atomic ops BROKEN-sh =undefined references to __sync atomic ops -BROKEN-i386 = 64-bit atomics (fetch_and_and, add_and_fetch) COMMENT= ncurses BitTorrent client based on libTorrent - End forwarded message -
Re: [tobi...@tmux.org: mark net/rtorrent as broken on powerpc]
Il 31/lug/2015 15:53, Tobias Ulmer tobi...@tmux.org ha scritto: Is David around? Any objections should be voiced in the next few hours, before I commit this. Go ahead! Thanks, David - Forwarded message from Tobias Ulmer tobi...@tmux.org - Date: Thu, 30 Jul 2015 18:30:23 +0200 From: Tobias Ulmer tobi...@tmux.org To: dco...@openbsd.org Subject: mark net/rtorrent as broken on powerpc Mark broken and sort the list, no point in wasting cpu time ok? Index: Makefile === RCS file: /home/vcs/cvs/openbsd/ports/net/rtorrent/Makefile,v retrieving revision 1.48 diff -u -p -r1.48 Makefile --- Makefile28 May 2015 10:17:24 - 1.48 +++ Makefile30 Jul 2015 16:13:24 - @@ -1,9 +1,10 @@ # $OpenBSD: Makefile,v 1.48 2015/05/28 10:17:24 pascal Exp $ BROKEN-hppa = undefined references to __sync atomic ops +BROKEN-i386 = 64-bit atomics (fetch_and_and, add_and_fetch) BROKEN-mips64 =undefined references to __sync atomic ops +BROKEN-powerpc = undefined references to __sync atomic ops BROKEN-sh =undefined references to __sync atomic ops -BROKEN-i386 = 64-bit atomics (fetch_and_and, add_and_fetch) COMMENT= ncurses BitTorrent client based on libTorrent - End forwarded message -
Re: [tobi...@tmux.org: mark net/rtorrent as broken on powerpc]
Il 31/lug/2015 17:11, Tobias Ulmer tobi...@tmux.org ha scritto:
Thought about that, but was too lazy to check that libtorrent is only
used by rtorrent. It is.
ok
Also ok dcoppa@
On Fri, Jul 31, 2015 at 03:31:41PM +0100, Stuart Henderson wrote:
On 2015/07/31 15:53, Tobias Ulmer wrote:
Is David around? Any objections should be voiced in the next few
hours,
before I commit this.
It's actually libtorrent not rtorrent that should be marked broken.
Would it be worth building on i386 with compiler flags to fix that,
at the expense of not running on crappy old machines that you probably
wouldn't want to run this on anyway?
Index: libtorrent/Makefile
===
RCS file: /cvs/ports/net/libtorrent/Makefile,v
retrieving revision 1.40
diff -u -p -r1.40 Makefile
--- libtorrent/Makefile 24 Mar 2015 13:35:09 - 1.40
+++ libtorrent/Makefile 31 Jul 2015 14:31:14 -
@@ -2,6 +2,10 @@
COMMENT= BitTorrent library written in C++
+BROKEN-hppa =undefined references to __sync atomic ops
+BROKEN-mips64 = undefined references to __sync atomic ops
+BROKEN-sh = undefined references to __sync atomic ops
+
# requires C++ tr1 headers
NOT_FOR_ARCHS= ${GCC3_ARCHS}
@@ -28,5 +32,13 @@ CONFIGURE_ARGS=${CONFIGURE_SHARED} \
--with-kqueue \
--without-epoll \
--disable-debug
+
+.include bsd.port.arch.mk
+
+# for 64-bit atomic ops
+.if ${ARCH:Mi386}
+CFLAGS+= -march=i586 -fomit-frame-pointer
+CXXFLAGS+= -march=i586 -fomit-frame-pointer
+.endif
.include bsd.port.mk
Index: rtorrent/Makefile
===
RCS file: /cvs/ports/net/rtorrent/Makefile,v
retrieving revision 1.48
diff -u -p -r1.48 Makefile
--- rtorrent/Makefile 28 May 2015 10:17:24 - 1.48
+++ rtorrent/Makefile 31 Jul 2015 14:31:25 -
@@ -1,10 +1,5 @@
# $OpenBSD: Makefile,v 1.48 2015/05/28 10:17:24 pascal Exp $
-BROKEN-hppa =undefined references to __sync atomic ops
-BROKEN-mips64 = undefined references to __sync atomic ops
-BROKEN-sh = undefined references to __sync atomic ops
-BROKEN-i386 =64-bit atomics (fetch_and_and,
add_and_fetch)
-
COMMENT= ncurses BitTorrent client based on libTorrent
DISTNAME=rtorrent-0.9.4
Re: [tobi...@tmux.org: mark net/rtorrent as broken on powerpc]
On 31/07/15(Fri) 15:31, Stuart Henderson wrote:
On 2015/07/31 15:53, Tobias Ulmer wrote:
Is David around? Any objections should be voiced in the next few hours,
before I commit this.
It's actually libtorrent not rtorrent that should be marked broken.
Would it be worth building on i386 with compiler flags to fix that,
at the expense of not running on crappy old machines that you probably
wouldn't want to run this on anyway?
There's only one atomic operation on a 64bit value and it is just for
instrumentation. So by adding --disable-instrumentation to the
configure arguments libtorrent builds just fine on macppc. I did not
try i386 but it should be the same.
Index: Makefile
===
RCS file: /cvs/ports/net/libtorrent/Makefile,v
retrieving revision 1.41
diff -u -p -r1.41 Makefile
--- Makefile31 Jul 2015 16:08:44 - 1.41
+++ Makefile31 Jul 2015 16:45:13 -
@@ -11,7 +11,7 @@ NOT_FOR_ARCHS=${GCC3_ARCHS}
DISTNAME= libtorrent-0.13.4
EPOCH= 0
-REVISION= 0
+REVISION= 1
SHARED_LIBS += torrent 21.0# .18.0
CATEGORIES=net devel
@@ -32,14 +32,7 @@ CONFIGURE_ARGS= ${CONFIGURE_SHARED} \
--enable-static \
--with-kqueue \
--without-epoll \
+ --disable-instrumentation \
--disable-debug
-
-.include bsd.port.arch.mk
-
-# for 64-bit atomic ops
-.if ${ARCH:Mi386}
-CFLAGS+= -march=i586 -fomit-frame-pointer
-CXXFLAGS+= -march=i586 -fomit-frame-pointer
-.endif
.include bsd.port.mk
Re: [tobi...@tmux.org: mark net/rtorrent as broken on powerpc]
Thought about that, but was too lazy to check that libtorrent is only
used by rtorrent. It is.
ok
On Fri, Jul 31, 2015 at 03:31:41PM +0100, Stuart Henderson wrote:
On 2015/07/31 15:53, Tobias Ulmer wrote:
Is David around? Any objections should be voiced in the next few hours,
before I commit this.
It's actually libtorrent not rtorrent that should be marked broken.
Would it be worth building on i386 with compiler flags to fix that,
at the expense of not running on crappy old machines that you probably
wouldn't want to run this on anyway?
Index: libtorrent/Makefile
===
RCS file: /cvs/ports/net/libtorrent/Makefile,v
retrieving revision 1.40
diff -u -p -r1.40 Makefile
--- libtorrent/Makefile 24 Mar 2015 13:35:09 - 1.40
+++ libtorrent/Makefile 31 Jul 2015 14:31:14 -
@@ -2,6 +2,10 @@
COMMENT= BitTorrent library written in C++
+BROKEN-hppa =undefined references to __sync atomic ops
+BROKEN-mips64 = undefined references to __sync atomic ops
+BROKEN-sh = undefined references to __sync atomic ops
+
# requires C++ tr1 headers
NOT_FOR_ARCHS= ${GCC3_ARCHS}
@@ -28,5 +32,13 @@ CONFIGURE_ARGS=${CONFIGURE_SHARED} \
--with-kqueue \
--without-epoll \
--disable-debug
+
+.include bsd.port.arch.mk
+
+# for 64-bit atomic ops
+.if ${ARCH:Mi386}
+CFLAGS+= -march=i586 -fomit-frame-pointer
+CXXFLAGS+= -march=i586 -fomit-frame-pointer
+.endif
.include bsd.port.mk
Index: rtorrent/Makefile
===
RCS file: /cvs/ports/net/rtorrent/Makefile,v
retrieving revision 1.48
diff -u -p -r1.48 Makefile
--- rtorrent/Makefile 28 May 2015 10:17:24 - 1.48
+++ rtorrent/Makefile 31 Jul 2015 14:31:25 -
@@ -1,10 +1,5 @@
# $OpenBSD: Makefile,v 1.48 2015/05/28 10:17:24 pascal Exp $
-BROKEN-hppa =undefined references to __sync atomic ops
-BROKEN-mips64 = undefined references to __sync atomic ops
-BROKEN-sh = undefined references to __sync atomic ops
-BROKEN-i386 =64-bit atomics (fetch_and_and, add_and_fetch)
-
COMMENT= ncurses BitTorrent client based on libTorrent
DISTNAME=rtorrent-0.9.4
Re: [tobi...@tmux.org: mark net/rtorrent as broken on powerpc]
Hello Martin, There's only one atomic operation on a 64bit value and it is just for instrumentation. So by adding --disable-instrumentation to the configure arguments libtorrent builds just fine on macppc. I did not try i386 but it should be the same. Works fine on i386 for me. Thank you, Jan
Re: [tobi...@tmux.org: mark net/rtorrent as broken on powerpc]
Il 31/lug/2015 21:17, Landry Breuil lan...@rhaalovely.net ha scritto: On Fri, Jul 31, 2015 at 06:51:19PM +0200, Martin Pieuchot wrote: On 31/07/15(Fri) 15:31, Stuart Henderson wrote: On 2015/07/31 15:53, Tobias Ulmer wrote: Is David around? Any objections should be voiced in the next few hours, before I commit this. It's actually libtorrent not rtorrent that should be marked broken. Would it be worth building on i386 with compiler flags to fix that, at the expense of not running on crappy old machines that you probably wouldn't want to run this on anyway? There's only one atomic operation on a 64bit value and it is just for instrumentation. So by adding --disable-instrumentation to the configure arguments libtorrent builds just fine on macppc. I did not try i386 but it should be the same. latest rtorrent builds and runs here on macppc with this diff, ok for me. Ok with me too. Martin, please go ahead Thanks! David
Re: [tobi...@tmux.org: mark net/rtorrent as broken on powerpc]
On Fri, Jul 31, 2015 at 06:51:19PM +0200, Martin Pieuchot wrote: On 31/07/15(Fri) 15:31, Stuart Henderson wrote: On 2015/07/31 15:53, Tobias Ulmer wrote: Is David around? Any objections should be voiced in the next few hours, before I commit this. It's actually libtorrent not rtorrent that should be marked broken. Would it be worth building on i386 with compiler flags to fix that, at the expense of not running on crappy old machines that you probably wouldn't want to run this on anyway? There's only one atomic operation on a 64bit value and it is just for instrumentation. So by adding --disable-instrumentation to the configure arguments libtorrent builds just fine on macppc. I did not try i386 but it should be the same. latest rtorrent builds and runs here on macppc with this diff, ok for me.
Re: [tobi...@tmux.org: mark net/rtorrent as broken on powerpc]
On Fri, Jul 31, 2015 at 06:51:19PM +0200, Martin Pieuchot wrote: On 31/07/15(Fri) 15:31, Stuart Henderson wrote: On 2015/07/31 15:53, Tobias Ulmer wrote: Is David around? Any objections should be voiced in the next few hours, before I commit this. It's actually libtorrent not rtorrent that should be marked broken. Would it be worth building on i386 with compiler flags to fix that, at the expense of not running on crappy old machines that you probably wouldn't want to run this on anyway? There's only one atomic operation on a 64bit value and it is just for instrumentation. So by adding --disable-instrumentation to the configure arguments libtorrent builds just fine on macppc. I did not try i386 but it should be the same. Thanks martin for bringing some common sense into this atomic creep :)
