Re: [update] sysutils/telegraf to 1.22.0
Am 28.03.22 um 20:56 schrieb Omar Polo:
> Martin Reindl wrote:
>> Am 26.03.22 um 20:59 schrieb Lucas Raab:
>>> On Sat, Mar 26, 2022 at 08:32:11PM +0100, Martin Reindl wrote:
Am 26.03.22 um 18:41 schrieb Lucas Raab:
> Hello,
>
> Here's an update for telegraf. This fixes a snmp collection issue
> that was identified in 1.21.x. This is my first attempt at updating
> a Go-based port so hopefully I didn't botch the job :) Tested so
> far on amd64 only. Other testers out there want to give this a
> whirl?
>
> Changelog: https://github.com/influxdata/telegraf/releases/tag/v1.22.0
>
> Thanks,
> Lucas
v1.22.0 switched gopsutil to v3 which breaks arm64
(which was just fixed in v1.21.4)
If people prefer to have snmp fixed I can take this forward, but then
there won't be a telegraf package for arm64 in 7.1.
-m
>>>
>>> Ah, that's unfortunate. I think not updating makes the most sense in
>>> that case
>>
>> https://github.com/shirou/gopsutil/pull/1244 is not yet in a new
>> release, so it will take some more days before the cpu module (which
>> breaks arm64) is actually usable and some more weeks or months before it
>> makes it into telegraf.
>
> oops, sorry about that, i didn't think about the consequences.
>
> My original PR used cgo and C.long (hence the "once and for all") but
> upstream rejects any usage of cgo...
>
> There are two things I can do to solve this mess:
>
> - start using Go' uintptr, assuming it has the same size as C' long on
>all platforms
>
> - add the appropriate cpu_openbsd_${cpu}.go files with the cpuTimes
>declaration.
>
> Apologize for breaking telegraf!
No problem. Fix is already merged. Now waiting for the
end-of-march-release to poke an update in telegraf.
-m
Re: [update] sysutils/telegraf to 1.22.0
Le Mon, Mar 28, 2022 at 10:12:06PM +0200, Martin Reindl a écrit : > On Mon, Mar 28, 2022 at 07:19:54PM +0200, Landry Breuil wrote: > > Le Sun, Mar 27, 2022 at 04:48:54PM +0200, Martin Reindl a écrit : > > > Am 27.03.22 um 15:34 schrieb Lucas Raab: > > > > On Sun, Mar 27, 2022 at 11:09:32AM +0200, Martin Reindl wrote: > > > >> Am 26.03.22 um 20:59 schrieb Lucas Raab: > > > >>> On Sat, Mar 26, 2022 at 08:32:11PM +0100, Martin Reindl wrote: > > > Thank You Lucas, > > > > > > this PR comes with a 2000+ lines diff touching 19 files. Not exactly slim. > > > > > > What do people think, snmptranslate and snmptable support in 1.22.0 or > > > arm64 for 7.1? > > > > i know i use telegraf 1.20.3 on 7.0 with snmp in various places, dunno > > if that uses snmptranslate/snmptable (yes, in some places i use string > > oids such as 'OPENBSD-PF-MIB::pfCntShort.0' etc) but i'd like to have > > telegraf/snmp working in 7.1. as for arm64 i have no opinion.. > > > > my 2c :) > > So I reckon it is sensible to have 7.1 ship with telegraf-v1.22.0. > We can do arm64 for 7.2. > > OK for Lucas' diff? I've tested that in 3 places, including one which uses snmp (but with numeric oids) and apparently everything seems fine here. ok Landry
Re: [update] sysutils/telegraf to 1.22.0
Martin Reindl wrote:
> Am 26.03.22 um 20:59 schrieb Lucas Raab:
> > On Sat, Mar 26, 2022 at 08:32:11PM +0100, Martin Reindl wrote:
> >>
> >> Am 26.03.22 um 18:41 schrieb Lucas Raab:
> >>> Hello,
> >>>
> >>> Here's an update for telegraf. This fixes a snmp collection issue
> >>> that was identified in 1.21.x. This is my first attempt at updating
> >>> a Go-based port so hopefully I didn't botch the job :) Tested so
> >>> far on amd64 only. Other testers out there want to give this a
> >>> whirl?
> >>>
> >>> Changelog: https://github.com/influxdata/telegraf/releases/tag/v1.22.0
> >>>
> >>> Thanks,
> >>> Lucas
> >>
> >>
> >> v1.22.0 switched gopsutil to v3 which breaks arm64
> >> (which was just fixed in v1.21.4)
> >>
> >> If people prefer to have snmp fixed I can take this forward, but then
> >> there won't be a telegraf package for arm64 in 7.1.
> >>
> >> -m
> >
> > Ah, that's unfortunate. I think not updating makes the most sense in
> > that case
>
> https://github.com/shirou/gopsutil/pull/1244 is not yet in a new
> release, so it will take some more days before the cpu module (which
> breaks arm64) is actually usable and some more weeks or months before it
> makes it into telegraf.
oops, sorry about that, i didn't think about the consequences.
My original PR used cgo and C.long (hence the "once and for all") but
upstream rejects any usage of cgo...
There are two things I can do to solve this mess:
- start using Go' uintptr, assuming it has the same size as C' long on
all platforms
- add the appropriate cpu_openbsd_${cpu}.go files with the cpuTimes
declaration.
Apologize for breaking telegraf!
> If someone beats me into disabling the gopsutil cpu module in the guts
> of telegraf I will happily check this for the 7.1 release.
Re: [update] sysutils/telegraf to 1.22.0
Le Sun, Mar 27, 2022 at 04:48:54PM +0200, Martin Reindl a écrit : > Am 27.03.22 um 15:34 schrieb Lucas Raab: > > On Sun, Mar 27, 2022 at 11:09:32AM +0200, Martin Reindl wrote: > >> Am 26.03.22 um 20:59 schrieb Lucas Raab: > >>> On Sat, Mar 26, 2022 at 08:32:11PM +0100, Martin Reindl wrote: > Thank You Lucas, > > this PR comes with a 2000+ lines diff touching 19 files. Not exactly slim. > > What do people think, snmptranslate and snmptable support in 1.22.0 or > arm64 for 7.1? i know i use telegraf 1.20.3 on 7.0 with snmp in various places, dunno if that uses snmptranslate/snmptable (yes, in some places i use string oids such as 'OPENBSD-PF-MIB::pfCntShort.0' etc) but i'd like to have telegraf/snmp working in 7.1. as for arm64 i have no opinion.. my 2c :) Landry
Re: [update] sysutils/telegraf to 1.22.0
Am 27.03.22 um 15:34 schrieb Lucas Raab: > On Sun, Mar 27, 2022 at 11:09:32AM +0200, Martin Reindl wrote: >> Am 26.03.22 um 20:59 schrieb Lucas Raab: >>> On Sat, Mar 26, 2022 at 08:32:11PM +0100, Martin Reindl wrote: Am 26.03.22 um 18:41 schrieb Lucas Raab: > Hello, > > Here's an update for telegraf. This fixes a snmp collection issue > that was identified in 1.21.x. This is my first attempt at updating > a Go-based port so hopefully I didn't botch the job :) Tested so > far on amd64 only. Other testers out there want to give this a > whirl? > > Changelog: https://github.com/influxdata/telegraf/releases/tag/v1.22.0 > > Thanks, > Lucas v1.22.0 switched gopsutil to v3 which breaks arm64 (which was just fixed in v1.21.4) If people prefer to have snmp fixed I can take this forward, but then there won't be a telegraf package for arm64 in 7.1. -m >>> >>> Ah, that's unfortunate. I think not updating makes the most sense in >>> that case >> >> Lucas, >> >> it might be easier to pull the fix for snmp into our 1.21.4 port than >> getting rid of gopsutil/cpu. Can you please point me to the relevant PR >> in telegraf? >> >> -m > > Hello Martin, > > The PR is: https://github.com/influxdata/telegraf/pull/10802 > > Lucas Thank You Lucas, this PR comes with a 2000+ lines diff touching 19 files. Not exactly slim. What do people think, snmptranslate and snmptable support in 1.22.0 or arm64 for 7.1? -m
Re: [update] sysutils/telegraf to 1.22.0
On Sun, Mar 27, 2022 at 11:09:32AM +0200, Martin Reindl wrote: > Am 26.03.22 um 20:59 schrieb Lucas Raab: > > On Sat, Mar 26, 2022 at 08:32:11PM +0100, Martin Reindl wrote: > >> > >> Am 26.03.22 um 18:41 schrieb Lucas Raab: > >>> Hello, > >>> > >>> Here's an update for telegraf. This fixes a snmp collection issue > >>> that was identified in 1.21.x. This is my first attempt at updating > >>> a Go-based port so hopefully I didn't botch the job :) Tested so > >>> far on amd64 only. Other testers out there want to give this a > >>> whirl? > >>> > >>> Changelog: https://github.com/influxdata/telegraf/releases/tag/v1.22.0 > >>> > >>> Thanks, > >>> Lucas > >> > >> > >> v1.22.0 switched gopsutil to v3 which breaks arm64 > >> (which was just fixed in v1.21.4) > >> > >> If people prefer to have snmp fixed I can take this forward, but then > >> there won't be a telegraf package for arm64 in 7.1. > >> > >> -m > > > > Ah, that's unfortunate. I think not updating makes the most sense in > > that case > > Lucas, > > it might be easier to pull the fix for snmp into our 1.21.4 port than > getting rid of gopsutil/cpu. Can you please point me to the relevant PR > in telegraf? > > -m Hello Martin, The PR is: https://github.com/influxdata/telegraf/pull/10802 Lucas
Re: [update] sysutils/telegraf to 1.22.0
Am 26.03.22 um 20:59 schrieb Lucas Raab: > On Sat, Mar 26, 2022 at 08:32:11PM +0100, Martin Reindl wrote: >> >> Am 26.03.22 um 18:41 schrieb Lucas Raab: >>> Hello, >>> >>> Here's an update for telegraf. This fixes a snmp collection issue >>> that was identified in 1.21.x. This is my first attempt at updating >>> a Go-based port so hopefully I didn't botch the job :) Tested so >>> far on amd64 only. Other testers out there want to give this a >>> whirl? >>> >>> Changelog: https://github.com/influxdata/telegraf/releases/tag/v1.22.0 >>> >>> Thanks, >>> Lucas >> >> >> v1.22.0 switched gopsutil to v3 which breaks arm64 >> (which was just fixed in v1.21.4) >> >> If people prefer to have snmp fixed I can take this forward, but then >> there won't be a telegraf package for arm64 in 7.1. >> >> -m > > Ah, that's unfortunate. I think not updating makes the most sense in > that case Lucas, it might be easier to pull the fix for snmp into our 1.21.4 port than getting rid of gopsutil/cpu. Can you please point me to the relevant PR in telegraf? -m
Re: [update] sysutils/telegraf to 1.22.0
Am 26.03.22 um 20:59 schrieb Lucas Raab: > On Sat, Mar 26, 2022 at 08:32:11PM +0100, Martin Reindl wrote: >> >> Am 26.03.22 um 18:41 schrieb Lucas Raab: >>> Hello, >>> >>> Here's an update for telegraf. This fixes a snmp collection issue >>> that was identified in 1.21.x. This is my first attempt at updating >>> a Go-based port so hopefully I didn't botch the job :) Tested so >>> far on amd64 only. Other testers out there want to give this a >>> whirl? >>> >>> Changelog: https://github.com/influxdata/telegraf/releases/tag/v1.22.0 >>> >>> Thanks, >>> Lucas >> >> >> v1.22.0 switched gopsutil to v3 which breaks arm64 >> (which was just fixed in v1.21.4) >> >> If people prefer to have snmp fixed I can take this forward, but then >> there won't be a telegraf package for arm64 in 7.1. >> >> -m > > Ah, that's unfortunate. I think not updating makes the most sense in > that case https://github.com/shirou/gopsutil/pull/1244 is not yet in a new release, so it will take some more days before the cpu module (which breaks arm64) is actually usable and some more weeks or months before it makes it into telegraf. If someone beats me into disabling the gopsutil cpu module in the guts of telegraf I will happily check this for the 7.1 release.
Re: [update] sysutils/telegraf to 1.22.0
On Sat, Mar 26, 2022 at 08:32:11PM +0100, Martin Reindl wrote: > > Am 26.03.22 um 18:41 schrieb Lucas Raab: > > Hello, > > > > Here's an update for telegraf. This fixes a snmp collection issue > > that was identified in 1.21.x. This is my first attempt at updating > > a Go-based port so hopefully I didn't botch the job :) Tested so > > far on amd64 only. Other testers out there want to give this a > > whirl? > > > > Changelog: https://github.com/influxdata/telegraf/releases/tag/v1.22.0 > > > > Thanks, > > Lucas > > > v1.22.0 switched gopsutil to v3 which breaks arm64 > (which was just fixed in v1.21.4) > > If people prefer to have snmp fixed I can take this forward, but then > there won't be a telegraf package for arm64 in 7.1. > > -m Ah, that's unfortunate. I think not updating makes the most sense in that case
Re: [update] sysutils/telegraf to 1.22.0
Am 26.03.22 um 18:41 schrieb Lucas Raab: > Hello, > > Here's an update for telegraf. This fixes a snmp collection issue > that was identified in 1.21.x. This is my first attempt at updating > a Go-based port so hopefully I didn't botch the job :) Tested so > far on amd64 only. Other testers out there want to give this a > whirl? > > Changelog: https://github.com/influxdata/telegraf/releases/tag/v1.22.0 > > Thanks, > Lucas v1.22.0 switched gopsutil to v3 which breaks arm64 (which was just fixed in v1.21.4) If people prefer to have snmp fixed I can take this forward, but then there won't be a telegraf package for arm64 in 7.1. -m
