Re: 回复: [NEW] www/p5-Plack-Request-WithEncoding
On Tue, Mar 31, 2020 at 04:10:16PM -0400, Chris Bennett wrote: > Question, > > The new version uses Module-Build-Tiny now instead of Module-Build. > > Should I remove modbuild from CONFIGURE_STYLE? > Looks like I should, just wanted to be certain. I believe you can use: CONFIGURE_STYLE = modbuild tiny l8rZ, -- andrew - http://afresh1.com Software doesn't do what you want it to do, it does what you tell it do. -- Stefan G. Weichinger.
Re: 回复: [NEW] www/p5-Plack-Request-WithEncoding
On Tue, Mar 31, 2020 at 04:10:16PM -0400, Chris Bennett wrote: > Question, > > The new version uses Module-Build-Tiny now instead of Module-Build. > > Should I remove modbuild from CONFIGURE_STYLE? > Looks like I should, just wanted to be certain. > > Thanks > -- > Chris Bennett > > Nope, won't build with Module-Build. But Module-Build-Tiny's claim to fame is that it replaces gigantic Module-Build. This seems odd to me, as it means pulling in more dependencies to use fewer dependencies. I don't like that. So I'm going to go learn some stuff. I'll send a new diff later after I figure this out. I don't see getting all these new ports in before ports lock anyhow. I need to go study the code that's making the code. Be back when I'm less dumb. :-] -- Chris Bennett
Re: 回复: [NEW] www/p5-Plack-Request-WithEncoding
Question, The new version uses Module-Build-Tiny now instead of Module-Build. Should I remove modbuild from CONFIGURE_STYLE? Looks like I should, just wanted to be certain. Thanks -- Chris Bennett
Re: 回复: [NEW] www/p5-Plack-Request-WithEncoding
On Thu, Mar 26, 2020 at 10:28:10AM -0700, Andrew Hewus Fresh wrote: > > > > > > I like it a lot, I think you should submit it upstream. > > > > > > Still OK afresh1@, especially with the replaced DESCR > > > > > > > I submitted it upstream. > > Oh, also, cool! Thanks! > Upstream accepted changes. I will submit new version shortly. -- Chris Bennett
Re: 回复: [NEW] www/p5-Plack-Request-WithEncoding
On Wed, Mar 25, 2020 at 12:26:23AM -0400, Chris Bennett wrote: > On Sat, Feb 15, 2020 at 07:04:27PM -0800, Andrew Hewus Fresh wrote: > > On Mon, Feb 03, 2020 at 02:41:45PM -0500, Chris Bennett wrote: > > > On Sun, Jan 26, 2020 at 02:41:24PM -0800, Andrew Hewus Fresh wrote: > > > > On Mon, Jan 20, 2020 at 02:03:34PM -0500, Chris Bennett wrote: > > > > > On Sun, Jan 19, 2020 at 12:57:44PM +, wen heping wrote: > > > > > > 1 BUILD_DEPENDS line is not need, since there is CONFIGURE_STYLE = > > > > > > modbuild > > > > > > 2 p5-Plack should removed from TEST_DEPENDS since it is RUN_DEPENDS > > > > > > 3 Better replace pkg/DESCR with the module's DESCRIPTION > > > > > > > > > > > > Cheers ! > > > > > > wen > > > > > > > > > > Attached is with the above suggestions, except that I left out the > > > > > last > > > > > line in the module's DESCRIPTION with the reference to look at link > > > > > to a > > > > > section of the DESCRIPTION in particular. > > > > > > > > > > I appreciate the help. Porting has changed (very much for the better) > > > > > since I last did ports. > > > > > > > > There are extra tabs in the RUN_DEPENDS continuation, probably from > > > > portgen (and I think I fixed that bug), although only a small style nit. > > > > > > > > After reading the DESCR, I'm fairly sure the original author is not a > > > > native English speaker. Perhaps something more like: > > > > > > > > Plack::Request::WithEncoding is a subclass of Plack::Request that > > > > supports encoded requests. It overrides many Plack::Request > > > > attributes to return decoded values. > > > > > > > > In any case, with a fixed DESCR OK afresh1@ > > > > > > OK, I just used your DESCR above. I also took out the tabs in the > > > RUN_DEPENDS and used multiple spaces instead. The tabs were my fault. > > > I attached a new copy with both those changes. > > > > > > OK afresh1@ > > > > > > Better DESCR? > > Plack::Request::WithEncoding is a subclass of Plack::Request that > supports encoded requests. It overrides many Plack::Request > attributes to return decoded values. > This feature allows a single application to seamlessly handle a wide > variety of different language code sets. > Applications that must be able to handle many different translations > at once will find this extension able to quickly solve that problem. > > > Perhaps this is a better description that points out why and when > someone would find this extension useful? > Otherwise, it doesn't really call out to anyone's attention who is > needing to use many languages at once. I like it a lot, I think you should submit it upstream. Still OK afresh1@, especially with the replaced DESCR > > Thanks > -- > Chris Bennett > > -- andrew - http://afresh1.com The power The nightmares The strange medication
Re: 回复: [NEW] www/p5-Plack-Request-WithEncoding
On Sat, Feb 15, 2020 at 07:04:27PM -0800, Andrew Hewus Fresh wrote: > On Mon, Feb 03, 2020 at 02:41:45PM -0500, Chris Bennett wrote: > > On Sun, Jan 26, 2020 at 02:41:24PM -0800, Andrew Hewus Fresh wrote: > > > On Mon, Jan 20, 2020 at 02:03:34PM -0500, Chris Bennett wrote: > > > > On Sun, Jan 19, 2020 at 12:57:44PM +, wen heping wrote: > > > > > 1 BUILD_DEPENDS line is not need, since there is CONFIGURE_STYLE = > > > > >modbuild > > > > > 2 p5-Plack should removed from TEST_DEPENDS since it is RUN_DEPENDS > > > > > 3 Better replace pkg/DESCR with the module's DESCRIPTION > > > > > > > > > > Cheers ! > > > > > wen > > > > > > > > Attached is with the above suggestions, except that I left out the last > > > > line in the module's DESCRIPTION with the reference to look at link to a > > > > section of the DESCRIPTION in particular. > > > > > > > > I appreciate the help. Porting has changed (very much for the better) > > > > since I last did ports. > > > > > > There are extra tabs in the RUN_DEPENDS continuation, probably from > > > portgen (and I think I fixed that bug), although only a small style nit. > > > > > > After reading the DESCR, I'm fairly sure the original author is not a > > > native English speaker. Perhaps something more like: > > > > > > Plack::Request::WithEncoding is a subclass of Plack::Request that > > > supports encoded requests. It overrides many Plack::Request > > > attributes to return decoded values. > > > > > > In any case, with a fixed DESCR OK afresh1@ > > > > OK, I just used your DESCR above. I also took out the tabs in the > > RUN_DEPENDS and used multiple spaces instead. The tabs were my fault. > > I attached a new copy with both those changes. > > > OK afresh1@ > > Better DESCR? Plack::Request::WithEncoding is a subclass of Plack::Request that supports encoded requests. It overrides many Plack::Request attributes to return decoded values. This feature allows a single application to seamlessly handle a wide variety of different language code sets. Applications that must be able to handle many different translations at once will find this extension able to quickly solve that problem. Perhaps this is a better description that points out why and when someone would find this extension useful? Otherwise, it doesn't really call out to anyone's attention who is needing to use many languages at once. Thanks -- Chris Bennett
Re: 回复: [NEW] www/p5-Plack-Request-WithEncoding
On Mon, Feb 03, 2020 at 02:41:45PM -0500, Chris Bennett wrote: > On Sun, Jan 26, 2020 at 02:41:24PM -0800, Andrew Hewus Fresh wrote: > > On Mon, Jan 20, 2020 at 02:03:34PM -0500, Chris Bennett wrote: > > > On Sun, Jan 19, 2020 at 12:57:44PM +, wen heping wrote: > > > > 1 BUILD_DEPENDS line is not need, since there is CONFIGURE_STYLE = > > > > modbuild > > > > 2 p5-Plack should removed from TEST_DEPENDS since it is RUN_DEPENDS > > > > 3 Better replace pkg/DESCR with the module's DESCRIPTION > > > > > > > > Cheers ! > > > > wen > > > > > > Attached is with the above suggestions, except that I left out the last > > > line in the module's DESCRIPTION with the reference to look at link to a > > > section of the DESCRIPTION in particular. > > > > > > I appreciate the help. Porting has changed (very much for the better) > > > since I last did ports. > > > > There are extra tabs in the RUN_DEPENDS continuation, probably from > > portgen (and I think I fixed that bug), although only a small style nit. > > > > After reading the DESCR, I'm fairly sure the original author is not a > > native English speaker. Perhaps something more like: > > > > Plack::Request::WithEncoding is a subclass of Plack::Request that > > supports encoded requests. It overrides many Plack::Request > > attributes to return decoded values. > > > > In any case, with a fixed DESCR OK afresh1@ > > OK, I just used your DESCR above. I also took out the tabs in the > RUN_DEPENDS and used multiple spaces instead. The tabs were my fault. > I attached a new copy with both those changes. OK afresh1@ -- andrew - http://afresh1.com At the source of every error which is blamed on the computer, you will find at least two human errors, including the error of blaming it on the computer.
Re: 回复: [NEW] www/p5-Plack-Request-WithEncoding
On Sun, Jan 26, 2020 at 02:41:24PM -0800, Andrew Hewus Fresh wrote: > On Mon, Jan 20, 2020 at 02:03:34PM -0500, Chris Bennett wrote: > > On Sun, Jan 19, 2020 at 12:57:44PM +, wen heping wrote: > > > 1 BUILD_DEPENDS line is not need, since there is CONFIGURE_STYLE = > > > modbuild > > > 2 p5-Plack should removed from TEST_DEPENDS since it is RUN_DEPENDS > > > 3 Better replace pkg/DESCR with the module's DESCRIPTION > > > > > > Cheers ! > > > wen > > > > Attached is with the above suggestions, except that I left out the last > > line in the module's DESCRIPTION with the reference to look at link to a > > section of the DESCRIPTION in particular. > > > > I appreciate the help. Porting has changed (very much for the better) > > since I last did ports. > > There are extra tabs in the RUN_DEPENDS continuation, probably from > portgen (and I think I fixed that bug), although only a small style nit. > > After reading the DESCR, I'm fairly sure the original author is not a > native English speaker. Perhaps something more like: > > Plack::Request::WithEncoding is a subclass of Plack::Request that > supports encoded requests. It overrides many Plack::Request > attributes to return decoded values. > > In any case, with a fixed DESCR OK afresh1@ OK, I just used your DESCR above. I also took out the tabs in the RUN_DEPENDS and used multiple spaces instead. The tabs were my fault. I attached a new copy with both those changes. Thanks everyone! -- Chris Bennett p5-Plack-Request-WithEncoding.tar.gz Description: GNU Zip compressed data
Re: 回复: [NEW] www/p5-Plack-Request-WithEncoding
On Mon, Jan 20, 2020 at 02:03:34PM -0500, Chris Bennett wrote: > On Sun, Jan 19, 2020 at 12:57:44PM +, wen heping wrote: > > 1 BUILD_DEPENDS line is not need, since there is CONFIGURE_STYLE = > > modbuild > > 2 p5-Plack should removed from TEST_DEPENDS since it is RUN_DEPENDS > > 3 Better replace pkg/DESCR with the module's DESCRIPTION > > > > Cheers ! > > wen > > Attached is with the above suggestions, except that I left out the last > line in the module's DESCRIPTION with the reference to look at link to a > section of the DESCRIPTION in particular. > > I appreciate the help. Porting has changed (very much for the better) > since I last did ports. There are extra tabs in the RUN_DEPENDS continuation, probably from portgen (and I think I fixed that bug), although only a small style nit. After reading the DESCR, I'm fairly sure the original author is not a native English speaker. Perhaps something more like: Plack::Request::WithEncoding is a subclass of Plack::Request that supports encoded requests. It overrides many Plack::Request attributes to return decoded values. In any case, with a fixed DESCR OK afresh1@
Re: 回复: [NEW] www/p5-Plack-Request-WithEncoding
On Sun, Jan 19, 2020 at 12:57:44PM +, wen heping wrote: > 1 BUILD_DEPENDS line is not need, since there is CONFIGURE_STYLE = > modbuild > 2 p5-Plack should removed from TEST_DEPENDS since it is RUN_DEPENDS > 3 Better replace pkg/DESCR with the module's DESCRIPTION > > Cheers ! > wen Attached is with the above suggestions, except that I left out the last line in the module's DESCRIPTION with the reference to look at link to a section of the DESCRIPTION in particular. I appreciate the help. Porting has changed (very much for the better) since I last did ports. -- Chris Bennett p5-Plack-Request-WithEncoding.tar.gz Description: GNU Zip compressed data
回复: [NEW] www/p5-Plack-Request-WithEncoding
1 BUILD_DEPENDS line is not need, since there is CONFIGURE_STYLE = modbuild 2 p5-Plack should removed from TEST_DEPENDS since it is RUN_DEPENDS 3 Better replace pkg/DESCR with the module's DESCRIPTION Cheers ! wen 发件人: owner-po...@openbsd.org 代表 Chris Bennett 发送时间: 2020年1月19日 14:28 收件人: ports@openbsd.org 主题: [NEW] www/p5-Plack-Request-WithEncoding An extension to Plack::Request Any comments? Thanks! -- Chris Bennett
