Re: 回复: 回复: [Update] www/p5-HTML-FormFu

2020-02-03 Thread Charlene Wendling 
On Mon, 3 Feb 2020 11:12:13 +
wen heping wrote:

> ping ...
> 
> 发件人: owner-po...@openbsd.org  代表 wen
> heping  发送时间: 2019年12月24日 10:50
> 收件人: Andrew Hewus Fresh 
> 抄送: ports@openbsd.org 
> 主题: 回复: [Update] www/p5-HTML-FormFu
> 
> ping ...
> 
> 发件人: Andrew Hewus Fresh 
> 发送时间: 2019年8月26日 7:53
> 收件人: wen heping 
> 抄送: ports@openbsd.org 
> 主题: Re: [Update] www/p5-HTML-FormFu
> 
> On Wed, Jul 31, 2019 at 12:16:59PM +, wen heping wrote:
> > Hi, ports@:
> >
> >Here is a patch for www/p5-HTML-FormFu:
> >i) Update to 2.07
> >ii) Add devel/p5-MooseX-Aliases and
> > devel/p5-MooseX-Attribute-Chained(new) to RUN_DEPENDS.
> >iii) Add devel/p5-Test-RequiresInternet to TEST_DEPENDS
> >
> >It build well and passed all tests on amd64-head system. But it
> > require new port devel/p5-MooseX-Attribute-Chained, which I
> > submitted the patch just now,  imported into portstree first.
> >
> >One port depends on it: www/p5-Catalyst-Controller-HTML-FormFu,
> > it build well and passed all tests after update to 2.04, which I
> > submitted patch just now.
> >
> > Comments? OK?
> > wen
> 
> OK afresh1@
> 
> 
> --
> andrew - http://afresh1.com
> 
> Full-time system administration is a delicate balance
> between proactiveness and laziness.
>   --  jhorwitz from use.perl.org

I've found out that:

- devel/p5-File-ShareDir-Install is needed as BUILD_DEPENDS
- devel/p5-Task-Weaken is a RUN_DEPENDS not a BUILD_DEPENDS
- converters/p5-JSON-MaybeXS was a missing RUN_DEPENDS
- some TEST_DEPENDS were missing
- it uses ExtUtils::MakeMaker, so Module::Install should be zapped

The below diff contains these changes, tests passes (with the
p5-HTML-Scrubber update to 0.19 in the chroot):

Index: Makefile
===
RCS file: /cvs/ports/www/p5-HTML-FormFu/Makefile,v
retrieving revision 1.10
diff -u -p -u -p -r1.10 Makefile
--- Makefile12 Jul 2019 20:50:53 -  1.10
+++ Makefile3 Feb 2020 12:22:22 -
@@ -4,16 +4,16 @@ COMMENT = HTML form creation, rendering 
 
 MODULES =  cpan
 PKG_ARCH = *
-DISTNAME = HTML-FormFu-0.07003
+DISTNAME = HTML-FormFu-2.07
 CATEGORIES =   www textproc
-REVISION = 0
 
 # Perl
 PERMIT_PACKAGE =   Yes
 
-BUILD_DEPENDS =devel/p5-Task-Weaken
+BUILD_DEPENDS =devel/p5-File-ShareDir-Install>=0.06
 
-RUN_DEPENDS =  devel/p5-Class-Accessor-Chained \
+RUN_DEPENDS =  converters/p5-JSON-MaybeXS \
+   devel/p5-Class-Accessor-Chained \
devel/p5-Clone \
devel/p5-Config-Any>=0.23 \
devel/p5-Data-Visitor \
@@ -26,8 +26,11 @@ RUN_DEPENDS =devel/p5-Class-Accessor-C
devel/p5-Hash-Flatten \
devel/p5-List-MoreUtils \
devel/p5-MRO-Compat \
+   devel/p5-MooseX-Aliases \
+   devel/p5-MooseX-Attribute-Chained \
devel/p5-Path-Class \
devel/p5-Readonly \
+   devel/p5-Task-Weaken \
devel/p5-YAML-XS \
graphics/p5-Captcha-reCAPTCHA \
mail/p5-Email-Valid \
@@ -40,8 +43,10 @@ RUN_DEPENDS =devel/p5-Class-Accessor-C
www/p5-HTML-TokeParser-Simple \
www/p5-libwww
 
-TEST_DEPENDS = devel/p5-Test-NoWarnings
-
-CONFIGURE_STYLE =  modinst
+TEST_DEPENDS = devel/p5-Test-Memory-Cycle \
+   devel/p5-Test-RequiresInternet \
+   textproc/p5-Regexp-Assemble \
+   www/p5-CGI \
+   www/p5-CGI-Simple
 
 .include 
Index: distinfo
===
RCS file: /cvs/ports/www/p5-HTML-FormFu/distinfo,v
retrieving revision 1.3
diff -u -p -u -p -r1.3 distinfo
--- distinfo18 Jan 2015 03:15:44 -  1.3
+++ distinfo3 Feb 2020 12:22:22 -
@@ -1,2 +1,2 @@
-SHA256 (HTML-FormFu-0.07003.tar.gz) = 
i7WfYfjiSO42tExZED3FZAgdJEixuLzmiz4aK1jodbw=
-SIZE (HTML-FormFu-0.07003.tar.gz) = 296639
+SHA256 (HTML-FormFu-2.07.tar.gz) = Ty8Bf3qHVPu26RIGyI7RPHVqFOO+oXgYjDuXdGNm6zI=
+SIZE (HTML-FormFu-2.07.tar.gz) = 342125
Index: pkg/PLIST
===
RCS file: /cvs/ports/www/p5-HTML-FormFu/pkg/PLIST,v
retrieving revision 1.2
diff -u -p -u -p -r1.2 PLIST
--- pkg/PLIST   7 Apr 2012 19:50:59 -   1.2
+++ pkg/PLIST   3 Feb 2020 12:22:22 -
@@ -24,6 +24,7 @@ ${P5SITE}/HTML/FormFu/Constraint/File/Ma
 ${P5SITE}/HTML/FormFu/Constraint/File/MinSize.pm
 ${P5SITE}/HTML/FormFu/Constraint/File/Size.pm
 ${P5SITE}/HTML/FormFu/Constraint/Integer.pm
+${P5SITE}/HTML/FormFu/Constraint/JSON.pm

回复: 回复: [Update] www/p5-HTML-FormFu

2020-02-03 Thread wen heping 
ping ...

发件人: owner-po...@openbsd.org  代表 wen heping 

发送时间: 2019年12月24日 10:50
收件人: Andrew Hewus Fresh 
抄送: ports@openbsd.org 
主题: 回复: [Update] www/p5-HTML-FormFu

ping ...

发件人: Andrew Hewus Fresh 
发送时间: 2019年8月26日 7:53
收件人: wen heping 
抄送: ports@openbsd.org 
主题: Re: [Update] www/p5-HTML-FormFu

On Wed, Jul 31, 2019 at 12:16:59PM +, wen heping wrote:
> Hi, ports@:
>
>Here is a patch for www/p5-HTML-FormFu:
>i) Update to 2.07
>ii) Add devel/p5-MooseX-Aliases and devel/p5-MooseX-Attribute-Chained(new)
> to RUN_DEPENDS.
>iii) Add devel/p5-Test-RequiresInternet to TEST_DEPENDS
>
>It build well and passed all tests on amd64-head system. But it require 
> new port
> devel/p5-MooseX-Attribute-Chained, which I submitted the patch just now,  
> imported
> into portstree first.
>
>One port depends on it: www/p5-Catalyst-Controller-HTML-FormFu, it build 
> well
> and passed all tests after update to 2.04, which I submitted patch just now.
>
> Comments? OK?
> wen

OK afresh1@

> Index: Makefile
> ===
> RCS file: /cvs/ports/www/p5-HTML-FormFu/Makefile,v
> retrieving revision 1.10
> diff -u -p -r1.10 Makefile
> --- Makefile  12 Jul 2019 20:50:53 -  1.10
> +++ Makefile  31 Jul 2019 12:08:30 -
> @@ -4,9 +4,8 @@ COMMENT = HTML form creation, rendering
>
>  MODULES =cpan
>  PKG_ARCH =   *
> -DISTNAME =   HTML-FormFu-0.07003
> +DISTNAME =   HTML-FormFu-2.07
>  CATEGORIES = www textproc
> -REVISION =   0
>
>  # Perl
>  PERMIT_PACKAGE = Yes
> @@ -26,6 +25,8 @@ RUN_DEPENDS =   devel/p5-Class-Accessor-C
>devel/p5-Hash-Flatten \
>devel/p5-List-MoreUtils \
>devel/p5-MRO-Compat \
> + devel/p5-MooseX-Aliases \
> + devel/p5-MooseX-Attribute-Chained \
>devel/p5-Path-Class \
>devel/p5-Readonly \
>devel/p5-YAML-XS \
> @@ -40,7 +41,8 @@ RUN_DEPENDS =   devel/p5-Class-Accessor-C
>www/p5-HTML-TokeParser-Simple \
>www/p5-libwww
>
> -TEST_DEPENDS =   devel/p5-Test-NoWarnings
> +TEST_DEPENDS =   devel/p5-Test-NoWarnings \
> + devel/p5-Test-RequiresInternet
>
>  CONFIGURE_STYLE =modinst
>
> Index: distinfo
> ===
> RCS file: /cvs/ports/www/p5-HTML-FormFu/distinfo,v
> retrieving revision 1.3
> diff -u -p -r1.3 distinfo
> --- distinfo  18 Jan 2015 03:15:44 -  1.3
> +++ distinfo  31 Jul 2019 12:08:30 -
> @@ -1,2 +1,2 @@
> -SHA256 (HTML-FormFu-0.07003.tar.gz) = 
> i7WfYfjiSO42tExZED3FZAgdJEixuLzmiz4aK1jodbw=
> -SIZE (HTML-FormFu-0.07003.tar.gz) = 296639
> +SHA256 (HTML-FormFu-2.07.tar.gz) = 
> Ty8Bf3qHVPu26RIGyI7RPHVqFOO+oXgYjDuXdGNm6zI=
> +SIZE (HTML-FormFu-2.07.tar.gz) = 342125
> Index: pkg/PLIST
> ===
> RCS file: /cvs/ports/www/p5-HTML-FormFu/pkg/PLIST,v
> retrieving revision 1.2
> diff -u -p -r1.2 PLIST
> --- pkg/PLIST 7 Apr 2012 19:50:59 -   1.2
> +++ pkg/PLIST 31 Jul 2019 12:08:30 -
> @@ -24,6 +24,7 @@ ${P5SITE}/HTML/FormFu/Constraint/File/Ma
>  ${P5SITE}/HTML/FormFu/Constraint/File/MinSize.pm
>  ${P5SITE}/HTML/FormFu/Constraint/File/Size.pm
>  ${P5SITE}/HTML/FormFu/Constraint/Integer.pm
> +${P5SITE}/HTML/FormFu/Constraint/JSON.pm
>  ${P5SITE}/HTML/FormFu/Constraint/Length.pm
>  ${P5SITE}/HTML/FormFu/Constraint/MaxLength.pm
>  ${P5SITE}/HTML/FormFu/Constraint/MaxRange.pm
> @@ -40,8 +41,6 @@ ${P5SITE}/HTML/FormFu/Constraint/Require
>  ${P5SITE}/HTML/FormFu/Constraint/Set.pm
>  ${P5SITE}/HTML/FormFu/Constraint/SingleValue.pm
>  ${P5SITE}/HTML/FormFu/Constraint/Word.pm
> -${P5SITE}/HTML/FormFu/Constraint/_others.pm
> -${P5SITE}/HTML/FormFu/Constraint/reCAPTCHA.pm
>  ${P5SITE}/HTML/FormFu/Deflator/
>  ${P5SITE}/HTML/FormFu/Deflator.pm
>  ${P5SITE}/HTML/FormFu/Deflator/Callback.pm
> @@ -62,6 +61,7 @@ ${P5SITE}/HTML/FormFu/Element/ComboBox.p
>  ${P5SITE}/HTML/FormFu/Element/ContentButton.pm
>  ${P5SITE}/HTML/FormFu/Element/Date.pm
>  ${P5SITE}/HTML/FormFu/Element/DateTime.pm
> +${P5SITE}/HTML/FormFu/Element/Email.pm
>  ${P5SITE}/HTML/FormFu/Element/Fieldset.pm
>  ${P5SITE}/HTML/FormFu/Element/File.pm
>  ${P5SITE}/HTML/FormFu/Element/Hidden.pm
> @@ -81,14 +81,7 @@ ${P5SITE}/HTML/FormFu/Element/Src.pm
>  ${P5SITE}/HTML/FormFu/Element/Submit.pm
>  ${P5SITE}/HTML/FormFu/Element/Text.pm
>  ${P5SITE}/HTML/FormFu/Element/Textarea.pm
> -${P5SITE}/HTML/FormFu/Element/_Field.pm
> -${P5SITE}/HTML/FormFu/Element/_Group.pm
> -${P5SITE}/HTML/FormFu/Element/_Input.pm
> -${P5SITE}/HTML/FormFu/Element/_MultiElement.pm
> -${P5SITE}/HTML/FormFu/Element/_MultiSelect.pm
> -${P5SITE}/HTML/FormFu/Element/_MultiText.pm
>