Re: Awesome package - missing dep

2021-09-06 Thread Theo Buehler
On Mon, Sep 06, 2021 at 09:53:59PM +0200, Stefan Hagen wrote:
> Stefan Hagen wrote:
> > Nik Reist wrote:
> > > While trying to set awesome as my wm, .xsession-errors shows a
> > > required namespace is not found. It is missing pango as a dependency
> > > and installing it allows awesome to work properly.
> > 
> > Thanks for reporting. Indeed awesome needs pango, but not directoy.
> > 
> > Awesome is using lua-lgi, which provides gobject bindings. It can call 
> > gobject based libraries like gtk, webkit, gstreamer, pango...
> > Lua-lgi itself only depends on devel/gobject-introspection.
> > 
> > I think it doesn't make sense to add dependencies to lua-lgi, just
> > because it can call those libraries. Therefore I propose to add pango
> > as run-dependency to awesome.
> > 
> > OK?
> 
> Again, with revision bump.

Committed. Thanks Nik for the report and Stefan for the fix



Re: Awesome package - missing dep

2021-09-06 Thread Antoine Jacoutot
On Mon, Sep 06, 2021 at 09:53:59PM +0200, Stefan Hagen wrote:
> Stefan Hagen wrote:
> > Nik Reist wrote:
> > > While trying to set awesome as my wm, .xsession-errors shows a
> > > required namespace is not found. It is missing pango as a dependency
> > > and installing it allows awesome to work properly.
> > 
> > Thanks for reporting. Indeed awesome needs pango, but not directoy.
> > 
> > Awesome is using lua-lgi, which provides gobject bindings. It can call 
> > gobject based libraries like gtk, webkit, gstreamer, pango...
> > Lua-lgi itself only depends on devel/gobject-introspection.
> > 
> > I think it doesn't make sense to add dependencies to lua-lgi, just
> > because it can call those libraries. Therefore I propose to add pango
> > as run-dependency to awesome.

That's the way to do it, ok aja


> > 
> > OK?
> 
> Again, with revision bump.
> 
> Index: x11/awesome/Makefile
> ===
> RCS file: /cvs/ports/x11/awesome/Makefile,v
> retrieving revision 1.114
> diff -u -p -u -p -r1.114 Makefile
> --- x11/awesome/Makefile  9 Jun 2021 19:50:10 -   1.114
> +++ x11/awesome/Makefile  6 Sep 2021 19:51:53 -
> @@ -5,7 +5,7 @@ COMMENT=  highly configurable framework 
>  V=   4.3
>  DISTNAME=awesome-${V}
>  CATEGORIES=  x11
> -REVISION=2
> +REVISION=3
>  
>  HOMEPAGE=https://awesomewm.org/
>  
> @@ -42,7 +42,8 @@ BUILD_DEPENDS=  devel/pango \
>  
>  MODLUA_RUN_DEPENDS=  devel/lua-lgi
>  
> -RUN_DEPENDS= misc/rlwrap \
> +RUN_DEPENDS= devel/pango \
> + misc/rlwrap \
>   shells/bash
>  
>  CONFIGURE_ARGS=  -DCOMPRESS_MANPAGES=OFF \
> 

-- 
Antoine



Re: Awesome package - missing dep

2021-09-06 Thread Stefan Hagen
Stefan Hagen wrote:
> Nik Reist wrote:
> > While trying to set awesome as my wm, .xsession-errors shows a
> > required namespace is not found. It is missing pango as a dependency
> > and installing it allows awesome to work properly.
> 
> Thanks for reporting. Indeed awesome needs pango, but not directoy.
> 
> Awesome is using lua-lgi, which provides gobject bindings. It can call 
> gobject based libraries like gtk, webkit, gstreamer, pango...
> Lua-lgi itself only depends on devel/gobject-introspection.
> 
> I think it doesn't make sense to add dependencies to lua-lgi, just
> because it can call those libraries. Therefore I propose to add pango
> as run-dependency to awesome.
> 
> OK?

Again, with revision bump.

Index: x11/awesome/Makefile
===
RCS file: /cvs/ports/x11/awesome/Makefile,v
retrieving revision 1.114
diff -u -p -u -p -r1.114 Makefile
--- x11/awesome/Makefile9 Jun 2021 19:50:10 -   1.114
+++ x11/awesome/Makefile6 Sep 2021 19:51:53 -
@@ -5,7 +5,7 @@ COMMENT=highly configurable framework 
 V= 4.3
 DISTNAME=  awesome-${V}
 CATEGORIES=x11
-REVISION=  2
+REVISION=  3
 
 HOMEPAGE=  https://awesomewm.org/
 
@@ -42,7 +42,8 @@ BUILD_DEPENDS=devel/pango \
 
 MODLUA_RUN_DEPENDS=devel/lua-lgi
 
-RUN_DEPENDS=   misc/rlwrap \
+RUN_DEPENDS=   devel/pango \
+   misc/rlwrap \
shells/bash
 
 CONFIGURE_ARGS=-DCOMPRESS_MANPAGES=OFF \



Re: Awesome package - missing dep

2021-09-06 Thread Stefan Hagen
Nik Reist wrote:
> While trying to set awesome as my wm, .xsession-errors shows a
> required namespace is not found. It is missing pango as a dependency
> and installing it allows awesome to work properly.

Thanks for reporting. Indeed awesome needs pango, but not directoy.

Awesome is using lua-lgi, which provides gobject bindings. It can call 
gobject based libraries like gtk, webkit, gstreamer, pango...
Lua-lgi itself only depends on devel/gobject-introspection.

I think it doesn't make sense to add dependencies to lua-lgi, just
because it can call those libraries. Therefore I propose to add pango
as run-dependency to awesome.

OK?

Index: x11/awesome/Makefile
===
RCS file: /cvs/ports/x11/awesome/Makefile,v
retrieving revision 1.114
diff -u -p -u -p -r1.114 Makefile
--- x11/awesome/Makefile9 Jun 2021 19:50:10 -   1.114
+++ x11/awesome/Makefile6 Sep 2021 19:04:23 -
@@ -42,7 +42,8 @@ BUILD_DEPENDS=devel/pango \
 
 MODLUA_RUN_DEPENDS=devel/lua-lgi
 
-RUN_DEPENDS=   misc/rlwrap \
+RUN_DEPENDS=   devel/pango \
+   misc/rlwrap \
shells/bash
 
 CONFIGURE_ARGS=-DCOMPRESS_MANPAGES=OFF \



Awesome package - missing dep

2021-09-06 Thread Nik Reist
Greetings,

While trying to set awesome as my wm, .xsession-errors shows a required 
namespace is not found. It is missing pango as a dependency and installing it 
allows awesome to work properly.

Thanks,



Nik Reist