Re: Explicitly disable OpenMP, categories archivers-converters
On 11/12/17 14:39, Landry Breuil wrote: On Sun, Nov 12, 2017 at 10:13:52PM +0300, Kirill Bychkov wrote: On Sun, November 12, 2017 19:26, Brian Callahan wrote: Hi ports -- In preparation for importing devel/openmp, I have (at sthen@'s suggestion) been doing a careful review of the ports tree to figure out which ports will try to pull in OpenMP if it exists on the system. I'm nowhere near done, but I have looked at everything in the categories archivers through converters, and only two ports as far as I can tell will try to pull in OpenMP (according to configure output and build logs). I'm choosing to explicitly disable OpenMP for all these ports, as that makes the most sense to me and will produce the least surprises. Once devel/openmp is imported and people want to enable openmp on other ports, that to me is a separate discussion for later. Feedback/OK? ~Brian Hi! Probably you could hide openmp from pickng up by default like devel/libinotify does? Just install it in non-standart directory. And then link ports which will benefit explicitly. Except that in that case, it's a PITA to then explicitely link with it. For libnotify, it's flags all around and rpath and whatnot. Landry I think I agree with landry. Besides, it's only a one-time process. Yes, it takes a but of time, but better to get it working like any other library I think. ~Brian
Re: Explicitly disable OpenMP, categories archivers-converters
On Sun, Nov 12, 2017 at 10:13:52PM +0300, Kirill Bychkov wrote: > On Sun, November 12, 2017 19:26, Brian Callahan wrote: > > Hi ports -- > > > > In preparation for importing devel/openmp, I have (at sthen@'s > > suggestion) been doing a careful review of the ports tree to figure out > > which ports will try to pull in OpenMP if it exists on the system. > > > > I'm nowhere near done, but I have looked at everything in the categories > > archivers through converters, and only two ports as far as I can tell > > will try to pull in OpenMP (according to configure output and build logs). > > > > I'm choosing to explicitly disable OpenMP for all these ports, as that > > makes the most sense to me and will produce the least surprises. Once > > devel/openmp is imported and people want to enable openmp on other > > ports, that to me is a separate discussion for later. > > > > Feedback/OK? > > > > ~Brian > > > > > Hi! > Probably you could hide openmp from pickng up by default like devel/libinotify > does? Just install it in non-standart directory. And then link ports which > will > benefit explicitly. Except that in that case, it's a PITA to then explicitely link with it. For libnotify, it's flags all around and rpath and whatnot. Landry
Re: Explicitly disable OpenMP, categories archivers-converters
On Sun, November 12, 2017 19:26, Brian Callahan wrote: > Hi ports -- > > In preparation for importing devel/openmp, I have (at sthen@'s > suggestion) been doing a careful review of the ports tree to figure out > which ports will try to pull in OpenMP if it exists on the system. > > I'm nowhere near done, but I have looked at everything in the categories > archivers through converters, and only two ports as far as I can tell > will try to pull in OpenMP (according to configure output and build logs). > > I'm choosing to explicitly disable OpenMP for all these ports, as that > makes the most sense to me and will produce the least surprises. Once > devel/openmp is imported and people want to enable openmp on other > ports, that to me is a separate discussion for later. > > Feedback/OK? > > ~Brian > > Hi! Probably you could hide openmp from pickng up by default like devel/libinotify does? Just install it in non-standart directory. And then link ports which will benefit explicitly.
Re: Explicitly disable OpenMP, categories archivers-converters
Brian Callahan [2017-11-12, 11:26:01]: > Hi ports -- > > In preparation for importing devel/openmp, I have (at sthen@'s suggestion) > been doing a careful review of the ports tree to figure out which ports will > try to pull in OpenMP if it exists on the system. > > I'm nowhere near done, but I have looked at everything in the categories > archivers through converters, and only two ports as far as I can tell will > try to pull in OpenMP (according to configure output and build logs). > > I'm choosing to explicitly disable OpenMP for all these ports, as that makes > the most sense to me and will produce the least surprises. Once devel/openmp > is imported and people want to enable openmp on other ports, that to me is a > separate discussion for later. > > Feedback/OK? That approach makes sense to me.
Explicitly disable OpenMP, categories archivers-converters
Hi ports --
In preparation for importing devel/openmp, I have (at sthen@'s
suggestion) been doing a careful review of the ports tree to figure out
which ports will try to pull in OpenMP if it exists on the system.
I'm nowhere near done, but I have looked at everything in the categories
archivers through converters, and only two ports as far as I can tell
will try to pull in OpenMP (according to configure output and build logs).
I'm choosing to explicitly disable OpenMP for all these ports, as that
makes the most sense to me and will produce the least surprises. Once
devel/openmp is imported and people want to enable openmp on other
ports, that to me is a separate discussion for later.
Feedback/OK?
~Brian
Index: libsoxr/Makefile
===
RCS file: /cvs/ports/audio/libsoxr/Makefile,v
retrieving revision 1.5
diff -u -p -u -p -r1.5 Makefile
--- libsoxr/Makefile 16 Nov 2015 14:38:09 - 1.5
+++ libsoxr/Makefile 10 Nov 2017 16:00:50 -
@@ -4,6 +4,7 @@ COMMENT= fast and high quality sample-ra
DISTNAME= soxr-0.1.2-Source
PKGNAME= lib${DISTNAME:S/-Source//}
+REVISION= 0
EXTRACT_SUFX= .tar.xz
SHARED_LIBS= soxr 1.2 soxr-lsr 3.4
@@ -20,5 +21,7 @@ WANTLIB += m
MASTER_SITES= ${MASTER_SITE_SOURCEFORGE:=soxr/}
MODULES= devel/cmake
+
+CONFIGURE_ARGS = -DWITH_OPENMP=OFF
.include
Index: soundtouch/Makefile
===
RCS file: /cvs/ports/audio/soundtouch/Makefile,v
retrieving revision 1.22
diff -u -p -u -p -r1.22 Makefile
--- soundtouch/Makefile 26 Jul 2017 22:45:16 - 1.22
+++ soundtouch/Makefile 10 Nov 2017 16:00:51 -
@@ -5,7 +5,7 @@ COMMENT= tempo/pitch audio processing li
DISTNAME= soundtouch-1.9.2
SHARED_LIBS += SoundTouch 3.0 # .0.0
CATEGORIES= audio devel
-REVISION = 2
+REVISION = 3
HOMEPAGE= http://www.surina.net/soundtouch/
@@ -26,7 +26,8 @@ AUTOCONF_VERSION=2.61
AUTOMAKE_VERSION=1.9
CONFIGURE_STYLE=gnu
-CONFIGURE_ARGS= --disable-x86-optimizations
+CONFIGURE_ARGS= --disable-x86-optimizations \
+ --disable-openmp
MAKE_FLAGS= AUTOCONF_VERSION=${AUTOCONF_VERSION} \
AUTOMAKE_VERSION=${AUTOMAKE_VERSION} \
