Re: Extend README for miniupnpd with NAT-PMP

[aisha]

Hi,
  Thanks for the feedback.
I've attached the patch with the requested grammar changes and REVISION bump.

Best,
Aisha

diff --git a/net/miniupnp/miniupnpd/Makefile b/net/miniupnp/miniupnpd/Makefile
index 59883318dcd..bb32611fa44 100755
--- a/net/miniupnp/miniupnpd/Makefile
+++ b/net/miniupnp/miniupnpd/Makefile
@@ -3,7 +3,7 @@
 COMMENT=   UPnP IGD daemon
 
 DISTNAME=  miniupnpd-2.1
-REVISION=  1
+REVISION=  2
 
 WANTLIB += c crypto kvm ssl
 
diff --git a/net/miniupnp/miniupnpd/pkg/README 
b/net/miniupnp/miniupnpd/pkg/README
index d499602bdde..aa94f663fd4 100644
--- a/net/miniupnp/miniupnpd/pkg/README
+++ b/net/miniupnp/miniupnpd/pkg/README
@@ -9,7 +9,12 @@ needs to be generated for the gateway and "uuid=" set 
accordingly in
 ${SYSCONFDIR}/miniupnpd.conf. To do so, either uuid(1) from the uuid
 package or uuidgen(1) from the e2fsprogs package can be used.
 
-Then the following pf(4) anchor needs to be added to pf.conf(5):
+Many BitTorrent programs use NAT-PMP to request a forwarded port, which
+needs to be enabled in the config file. NAT-PMP listens on port 5351,
+which should be allowed on the internal interfaces, i.e., in pf.conf(5):
+pass in on $internal_interface proto udp to self port 5351
+
+Then the following pf(4) anchor needs to be added:
 anchor "miniupnpd"
 
 At last, multicast needs to be allowed on the internal interface of the

Re: Extend README for miniupnpd with NAT-PMP

[Stuart Henderson]

On 2021/09/14 21:57, aisha wrote:
> Hi,
>   I've added a few extra lines for the miniupnpd port for an easier
> experience with setting up port forwarding. It took me quite a while
> to figure out this small thing, so I personally think it would be
> useful for newer users like myself.
> 
> Cheers,
> Aisha
> 
> 
> diff --git a/net/miniupnp/miniupnpd/pkg/README 
> b/net/miniupnp/miniupnpd/pkg/README
> index d499602bdde..94725f0340e 100644
> --- a/net/miniupnp/miniupnpd/pkg/README
> +++ b/net/miniupnp/miniupnpd/pkg/README
> @@ -9,6 +9,11 @@ needs to be generated for the gateway and "uuid=" set 
> accordingly in
>  ${SYSCONFDIR}/miniupnpd.conf. To do so, either uuid(1) from the uuid
>  package or uuidgen(1) from the e2fsprogs package can be used.
>  
> +Many torrent programs use NAT-PMP to request for a forwarded port, which

torrent -> BitTorrent
request for a forwarded port -> request a forwarded port

> +needs to be enabled in the config file. NAT-PMP listens on port 5351,
> +which should be allowed on the internal interfaces:
> +pass in on $internal_interface proto udp to  port 5351

can use "self" instead of  here.

> +
>  Then the following pf(4) anchor needs to be added to pf.conf(5):
>  anchor "miniupnpd"

Also needs a REVISION bump.

Extend README for miniupnpd with NAT-PMP

[aisha]

Hi,
  I've added a few extra lines for the miniupnpd port for an easier
experience with setting up port forwarding. It took me quite a while
to figure out this small thing, so I personally think it would be
useful for newer users like myself.

Cheers,
Aisha


diff --git a/net/miniupnp/miniupnpd/pkg/README 
b/net/miniupnp/miniupnpd/pkg/README
index d499602bdde..94725f0340e 100644
--- a/net/miniupnp/miniupnpd/pkg/README
+++ b/net/miniupnp/miniupnpd/pkg/README
@@ -9,6 +9,11 @@ needs to be generated for the gateway and "uuid=" set 
accordingly in
 ${SYSCONFDIR}/miniupnpd.conf. To do so, either uuid(1) from the uuid
 package or uuidgen(1) from the e2fsprogs package can be used.
 
+Many torrent programs use NAT-PMP to request for a forwarded port, which
+needs to be enabled in the config file. NAT-PMP listens on port 5351,
+which should be allowed on the internal interfaces:
+pass in on $internal_interface proto udp to  port 5351
+
 Then the following pf(4) anchor needs to be added to pf.conf(5):
 anchor "miniupnpd"