Re: FIX_EXTRACT_PERMISSIONS and XS depends for devel/p5-Class-Load

2020-04-10 Thread Marc Espie
On Thu, Apr 09, 2020 at 08:47:04PM -0700, Andrew Hewus Fresh wrote:
> On Thu, Apr 09, 2020 at 08:39:55PM -0700, Andrew Hewus Fresh wrote:
> > On Thu, Apr 09, 2020 at 08:31:41PM -0700, Andrew Hewus Fresh wrote:
> > > Does a FIX_EXTRACT_PERMISSIONS need a REVISION bump?
> > > 
> > > Otherwise, OK?
> > 
> > 
> > Looking at this, I guess, I prefer this option so things just get
> > faster.  Comments?  OK?
> 
> Sigh, I see that's a circular dependency, so nevermind that part.  Just
> the FIX_EXTRACT_PERMISSIONS.

Well, it wouldn't need a REVISION, considering it won't change the package
itself, unless it used to have restricted files, which would be fairly
hard to achieve without @mode annotations in the PLIST :)



Re: FIX_EXTRACT_PERMISSIONS and XS depends for devel/p5-Class-Load

2020-04-09 Thread Andrew Hewus Fresh
On Thu, Apr 09, 2020 at 08:39:55PM -0700, Andrew Hewus Fresh wrote:
> On Thu, Apr 09, 2020 at 08:31:41PM -0700, Andrew Hewus Fresh wrote:
> > Does a FIX_EXTRACT_PERMISSIONS need a REVISION bump?
> > 
> > Otherwise, OK?
> 
> 
> Looking at this, I guess, I prefer this option so things just get
> faster.  Comments?  OK?

Sigh, I see that's a circular dependency, so nevermind that part.  Just
the FIX_EXTRACT_PERMISSIONS.

> 
> 
> 
> Index: Makefile
> ===
> RCS file: /cvs/ports/devel/p5-Class-Load/Makefile,v
> retrieving revision 1.9
> diff -u -p -r1.9 Makefile
> --- Makefile  12 Feb 2020 14:46:03 -  1.9
> +++ Makefile  10 Apr 2020 03:38:32 -
> @@ -6,6 +6,8 @@ MODULES = cpan
>  PKG_ARCH =   *
>  DISTNAME =   Class-Load-0.25
>  CATEGORIES = devel
> +REVISION =   0
> +FIX_EXTRACT_PERMISSIONS =Yes
>  
>  # same as perl
>  PERMIT_PACKAGE = Yes
> @@ -15,6 +17,9 @@ RUN_DEPENDS =   devel/p5-Data-OptList \
>   devel/p5-Module-Runtime \
>   devel/p5-Package-Stash>=0.32 \
>   devel/p5-Try-Tiny
> +
> +# Make things faster
> +RUN_DEPENDS +=   devel/p5-Class-Load-XS
>  
>  TEST_DEPENDS =   devel/p5-Test-Fatal \
>   devel/p5-Test-Requires \
> 

-- 
andrew - http://afresh1.com

"Programming today is a race between software engineers striving to
build bigger and better idiot-proof programs, and the Universe
trying to produce bigger and better idiots. So far, the Universe is
winning." -- Rich Cook



FIX_EXTRACT_PERMISSIONS and XS depends for devel/p5-Class-Load

2020-04-09 Thread Andrew Hewus Fresh
On Thu, Apr 09, 2020 at 08:31:41PM -0700, Andrew Hewus Fresh wrote:
> Does a FIX_EXTRACT_PERMISSIONS need a REVISION bump?
> 
> Otherwise, OK?


Looking at this, I guess, I prefer this option so things just get
faster.  Comments?  OK?



Index: Makefile
===
RCS file: /cvs/ports/devel/p5-Class-Load/Makefile,v
retrieving revision 1.9
diff -u -p -r1.9 Makefile
--- Makefile12 Feb 2020 14:46:03 -  1.9
+++ Makefile10 Apr 2020 03:38:32 -
@@ -6,6 +6,8 @@ MODULES =   cpan
 PKG_ARCH = *
 DISTNAME = Class-Load-0.25
 CATEGORIES =   devel
+REVISION = 0
+FIX_EXTRACT_PERMISSIONS =  Yes
 
 # same as perl
 PERMIT_PACKAGE =   Yes
@@ -15,6 +17,9 @@ RUN_DEPENDS = devel/p5-Data-OptList \
devel/p5-Module-Runtime \
devel/p5-Package-Stash>=0.32 \
devel/p5-Try-Tiny
+
+# Make things faster
+RUN_DEPENDS += devel/p5-Class-Load-XS
 
 TEST_DEPENDS = devel/p5-Test-Fatal \
devel/p5-Test-Requires \