Re: NEW: gogrepo, a downloader for games from GOG.com
On Fri, Apr 10, 2020 at 03:11:36AM -0600, Thomas Frohwein wrote:
> On Fri, Apr 10, 2020 at 10:45:26AM +0200, Antoine Jacoutot wrote:
> [...]
> > > seconded, it looks like a leaf port to me, so i dont really think it
> > > needs the py2 flavor, juste default to FLAVOR=python3 like other ports.
> >
> > I think you want to do this instead:
> > MODPY_VERSION=${MODPY_DEFAULT_VERSION_3}
>
> I agree, this simplifies things a lot.
>
> New tarball attached that is python3 only with MODPY_DEFAULT_VERSION_3.
> Launch script now without the MODPY prefix, PLIST and do-install updated
> accordingly.
>
> Tested quickly again with '$ gogrepo login' and still works.
>
> ok?
ok solene@
Re: NEW: gogrepo, a downloader for games from GOG.com
On Fri, Apr 10, 2020 at 10:45:26AM +0200, Antoine Jacoutot wrote:
[...]
> > seconded, it looks like a leaf port to me, so i dont really think it
> > needs the py2 flavor, juste default to FLAVOR=python3 like other ports.
>
> I think you want to do this instead:
> MODPY_VERSION=${MODPY_DEFAULT_VERSION_3}
I agree, this simplifies things a lot.
New tarball attached that is python3 only with MODPY_DEFAULT_VERSION_3.
Launch script now without the MODPY prefix, PLIST and do-install updated
accordingly.
Tested quickly again with '$ gogrepo login' and still works.
ok?
gogrepo-py3-only.tgz
Description: Binary data
Re: NEW: gogrepo, a downloader for games from GOG.com
On Fri, Apr 10, 2020 at 09:26:37AM +0200, Landry Breuil wrote:
> On Thu, Apr 09, 2020 at 08:43:05PM -0400, George Koehler wrote:
> > On Wed, 8 Apr 2020 12:16:38 -0600
> > Thomas Frohwein wrote:
> >
> > > New port for downloading GOG.com games via the command line. Useful
> > > especially for a potential future game library management system...
> >
> > py3-gogrepo works for me. I logged into my GOG, downloaded a game,
> > and verified it. (My other games were "missing" during verify.)
> >
> > I want someone who knows python to look at this port. I only tried
> > the python3 FLAVOR. If you can drop flavors and always use python3
> > (like devel/mercurial), then you might rename the command from
> > "py3-gogrepo" to just "gogrepo".
>
> seconded, it looks like a leaf port to me, so i dont really think it
> needs the py2 flavor, juste default to FLAVOR=python3 like other ports.
I think you want to do this instead:
MODPY_VERSION=${MODPY_DEFAULT_VERSION_3}
--
Antoine
Re: NEW: gogrepo, a downloader for games from GOG.com
On Thu, Apr 09, 2020 at 08:43:05PM -0400, George Koehler wrote: > On Wed, 8 Apr 2020 12:16:38 -0600 > Thomas Frohwein wrote: > > > New port for downloading GOG.com games via the command line. Useful > > especially for a potential future game library management system... > > py3-gogrepo works for me. I logged into my GOG, downloaded a game, > and verified it. (My other games were "missing" during verify.) > > I want someone who knows python to look at this port. I only tried > the python3 FLAVOR. If you can drop flavors and always use python3 > (like devel/mercurial), then you might rename the command from > "py3-gogrepo" to just "gogrepo". seconded, it looks like a leaf port to me, so i dont really think it needs the py2 flavor, juste default to FLAVOR=python3 like other ports. Landry
Re: NEW: gogrepo, a downloader for games from GOG.com
On Wed, 8 Apr 2020 12:16:38 -0600 Thomas Frohwein wrote: > New port for downloading GOG.com games via the command line. Useful > especially for a potential future game library management system... py3-gogrepo works for me. I logged into my GOG, downloaded a game, and verified it. (My other games were "missing" during verify.) I want someone who knows python to look at this port. I only tried the python3 FLAVOR. If you can drop flavors and always use python3 (like devel/mercurial), then you might rename the command from "py3-gogrepo" to just "gogrepo". --George
NEW: gogrepo, a downloader for games from GOG.com
Hi, New port for downloading GOG.com games via the command line. Useful especially for a potential future game library management system... Works, tested both py- and py3-. Passes make-port-lib-depends-check and portcheck. I don't have much experience with python ports yet. I used net/py-dpkt as a starting point. A few more points about the port: - there are no release published, but the gogrepo.py calls the version 0.3a. That's why I chose 0.3apl20190727 for MODPY_EGG_VERSION. I am not 100% sure if the "a" will work well with our versioning, but since games/cataclysm-dda uses "0.D" in DISTNAME, this seemed ok. Please correct me if this assumption is wrong. - uses a launch script that calls gogrepo.py - examples for init, download etc here [1] comments, ok's? [1] https://github.com/eddie3/gogrepo gogrepo.tgz Description: Binary data
