Re: New devel/py-crayons (new requirement to update devel/legit)

2020-02-03 Thread clematis 
On Sun, Jan 26, 2020 at 11:08:42PM +0100, Klemens Nanni wrote:
> On Fri, Jan 10, 2020 at 05:49:33PM +0100, clematis wrote:
> > Taking recent feedback into account here's a new tarball including those
> > additional changes: 
> Can you clarify what "recent feedback" that was?
> 
Hello,
Well, I am kind of learning something new with every submission, the
MODPY_DEFAULT_VERSION_3 was new to me and as you've spoted I
guess that was a good example on how to break things up. 
Another change I was refering was to finally have setup
PORTS_PRIVSEP=yes.

> Above diff actually breaks your legit update because the flavor used in
> its dependency list no longer exists.

It does. I understand this now. 

> You probably only tested your already existing installation after
> repackaging py-crayons, but you cannot have successfully tested the
> legit update itself with this.

Correct. :-/ 

> On the submission itself:  Personally, I'm fine with importing new
> python ports as Python 3 only, but that makes for an ugly situation
> where python ports become a wild mix of flavored and Python X.Y only as
> nicely demonstrated above.

:o) Yes... true. It did also felt like that was ok for an import but I
didn't see the rest coming. Now switching all DEPENDS felt like a ton of
updates so I don't know if we want to go that route.

> I don't know how we want to handle this situation, but it would be
> better to find consensus and work toward one solution.

Agreed. I will probably spin-off a dedicated email thread to see if one
solution could be agreed.



PS: devel/legit thread: https://marc.info/?l=openbsd-ports=157866485720815=2

Thanks,
-- 
clematis (0x7e96fd2400fe7b59)

Re: New devel/py-crayons (new requirement to update devel/legit)

2020-01-26 Thread Klemens Nanni 
On Fri, Jan 10, 2020 at 05:49:33PM +0100, clematis wrote:
> Taking recent feedback into account here's a new tarball including those
> additional changes: 
Can you clarify what "recent feedback" that was?

> 
> +MAINTAINER
> +MODPY_VERSION =  ${MODPY_DEFAULT_VERSION_3}
> -FLAVORS =python3
> -FLAVOR ?=
> +# Tests to come in future version
> +NO_TEST= Yes

> Sill run OK with devel/legit 1.2.0
Above diff actually breaks your legit update because the flavor used in
its dependency list no longer exists.

You probably only tested your already existing installation after
repackaging py-crayons, but you cannot have successfully tested the
legit update itself with this.


On the submission itself:  Personally, I'm fine with importing new
python ports as Python 3 only, but that makes for an ugly situation
where python ports become a wild mix of flavored and Python X.Y only as
nicely demonstrated above.

I don't know how we want to handle this situation, but it would be
better to find consensus and work toward one solution.

Re: New devel/py-crayons (new requirement to update devel/legit)

2020-01-11 Thread clematis 
On Fri, Jan 10, 2020 at 05:49:33PM +0100, clematis wrote:
> On Tue, Jan 07, 2020 at 11:18:25PM +0100, clematis wrote:
> > Hi,
> > This python module gives you colored strings for terminal usage.
> > https://github.com/MasterOdin/crayons
> > 
> > It is a new requirement to update devel/legit to 1.2.0 which I will
> > submit later. 
> > 
> > both flavors build, package, install, deinstall and run OK on amd 64
> > (tested using devel/legit 1.2.0)
> 
> Taking recent feedback into account here's a new tarball including those
> additional changes: 
> 
> +MAINTAINER
> +MODPY_VERSION =  ${MODPY_DEFAULT_VERSION_3}
> -FLAVORS =python3
> -FLAVOR ?=
> +# Tests to come in future version
> +NO_TEST= Yes

Oops, forgot rule #27... do not set NO_TEST if a port has an empty
regression test infrastructure. Don't think running the readme Example
is good enough, so I've just removed this NO_TEST from the Makefile.

New tarball attached.

> Sill run OK with devel/legit 1.2.0
> 
> Comments? OK?

-- 
clematis (0x7e96fd2400fe7b59)


devel_py-crayons-0.3.0.tar.gz
Description: application/tar-gz

Re: New devel/py-crayons (new requirement to update devel/legit)

2020-01-10 Thread clematis 
On Tue, Jan 07, 2020 at 11:18:25PM +0100, clematis wrote:
> Hi,
> This python module gives you colored strings for terminal usage.
> https://github.com/MasterOdin/crayons
> 
> It is a new requirement to update devel/legit to 1.2.0 which I will
> submit later. 
> 
> both flavors build, package, install, deinstall and run OK on amd 64
> (tested using devel/legit 1.2.0)

Taking recent feedback into account here's a new tarball including those
additional changes: 

+MAINTAINER
+MODPY_VERSION =${MODPY_DEFAULT_VERSION_3}
-FLAVORS =  python3
-FLAVOR ?=
+# Tests to come in future version
+NO_TEST=   Yes

Sill run OK with devel/legit 1.2.0

Comments? OK?
-- 
clematis (0x7e96fd2400fe7b59)


devel_py-crayons-0.3.0.tar.gz
Description: application/tar-gz

New devel/py-crayons (new requirement to update devel/legit)

2020-01-07 Thread clematis 
Hi,
This python module gives you colored strings for terminal usage.
https://github.com/MasterOdin/crayons

It is a new requirement to update devel/legit to 1.2.0 which I will
submit later. 

both flavors build, package, install, deinstall and run OK on amd 64
(tested using devel/legit 1.2.0)

Comments? OK?
-- 
clematis (0x7e96fd2400fe7b59)


devel_py-crayons.tar.gz
Description: application/tar-gz